kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2026-01-06 22:21:42 +00:00
Code Issues Projects Releases Wiki Activity

Various code fixes.

Browse Source
This commit is contained in:
James Cole
2022-11-04 05:11:05 +01:00
parent 8d8f81c27d
commit f16b679049
48 changed files with 226 additions and 246 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Services/Internal/Support/CreditRecalculateService.php
View File

@@ -68,7 +68,7 @@ class CreditRecalculateService
// work based on account.
$this->processAccount();
}
if (empty($this->work)) {
if (0 === count($this->work)) {
Log::debug('No work accounts, do not do CreditRecalculationService');
return;
@@ -84,7 +84,7 @@ class CreditRecalculateService
{
/** @var TransactionJournal $journal */
foreach ($this->group->transactionJournals as $journal) {
if (empty($this->work)) {
if (0 === count($this->work)) {
try {
$this->findByJournal($journal);
} catch (FireflyException $e) {

4
app/Services/Internal/Support/RecurringTransactionTrait.php
View File

@@ -339,7 +339,7 @@ trait RecurringTransactionTrait
*/
protected function updateTags(RecurrenceTransaction $transaction, array $tags): void
{
if (!empty($tags)) {
if (0 !== count($tags)) {
/** @var RecurrenceMeta|null $entry */
$entry = $transaction->recurrenceTransactionMeta()->where('name', 'tags')->first();
if (null === $entry) {
@@ -348,7 +348,7 @@ trait RecurringTransactionTrait
$entry->value = json_encode($tags);
$entry->save();
}
if (empty($tags)) {
if (0 === count($tags)) {
// delete if present
$transaction->recurrenceTransactionMeta()->where('name', 'tags')->delete();
}