From f2efb69b76eda886c50b6e7bd255f5567238922b Mon Sep 17 00:00:00 2001 From: James Cole Date: Wed, 20 May 2026 20:30:30 +0200 Subject: [PATCH] Fix broken if statement --- app/TransactionRules/Engine/SearchRuleEngine.php | 5 +++-- 1 file changed, 3 insertions(+), 2 deletions(-) diff --git a/app/TransactionRules/Engine/SearchRuleEngine.php b/app/TransactionRules/Engine/SearchRuleEngine.php index 5d9f5f4789..7985baea0b 100644 --- a/app/TransactionRules/Engine/SearchRuleEngine.php +++ b/app/TransactionRules/Engine/SearchRuleEngine.php @@ -543,12 +543,13 @@ class SearchRuleEngine implements RuleEngineInterface } // pick up from the action if it actually acted or not: - if (true === $ruleAction->stop_processing && $result) { + if (true === $ruleAction->stop_processing && true === $result) { Log::debug(sprintf('Rule action "%s" reports changes AND asks to break, so break!', $ruleAction->action_type)); return true; } - if (true === $ruleAction->stop_processing && false === $result) { + // reset is false at this point. + if (true === $ruleAction->stop_processing) { Log::debug(sprintf('Rule action "%s" reports NO changes AND asks to break, but we wont break!', $ruleAction->action_type)); }