kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-02 11:04:53 +00:00
Code Issues Projects Releases Wiki Activity

Catch and verify various errors

Browse Source
This commit is contained in:
James Cole
2023-01-21 12:21:06 +01:00
parent c269913510
commit f9daf7751a
12 changed files with 33 additions and 27 deletions
Download Patch File Download Diff File Expand all files Collapse all files

12
app/Api/V1/Controllers/Controller.php
View File

@@ -99,18 +99,18 @@ abstract class Controller extends BaseController
foreach ($dates as $field) {
try {
$date = request()->query->get($field);
} catch(BadRequestException $e) {
} catch (BadRequestException $e) {
Log::error(sprintf('Request field "%s" contains a non-scalar value. Value set to NULL.', $field));
Log::error($e->getMessage());
$value = null;
}
$obj = null;
$obj = null;
if (null !== $date) {
try {
$obj = Carbon::parse($date);
} catch (InvalidDateException|InvalidFormatException $e) {
// don't care
app('log')->warning(sprintf('Ignored invalid date "%s" in API controller parameter check: %s', $date, $e->getMessage()));
app('log')->warning(sprintf('Ignored invalid date "%s" in API controller parameter check: %s', substr($date, 0, 20), $e->getMessage()));
}
}
$bag->set($field, $obj);
@@ -121,7 +121,7 @@ abstract class Controller extends BaseController
foreach ($integers as $integer) {
try {
$value = request()->query->get($integer);
} catch(BadRequestException $e) {
} catch (BadRequestException $e) {
Log::error(sprintf('Request field "%s" contains a non-scalar value. Value set to NULL.', $integer));
Log::error($e->getMessage());
$value = null;
@@ -144,8 +144,8 @@ abstract class Controller extends BaseController
{
$sortParameters = [];
try {
$param = (string)request()->query->get('sort');
} catch(BadRequestException $e) {
$param = (string)request()->query->get('sort');
} catch (BadRequestException $e) {
Log::error('Request field "sort" contains a non-scalar value. Value set to NULL.');
Log::error($e->getMessage());
$param = '';