From 0ebc79457e3d0a07c2e9af2410a72936a4e46aa2 Mon Sep 17 00:00:00 2001 From: Steve Underwood Date: Wed, 30 Apr 2014 22:51:59 +0800 Subject: [PATCH] Another couple of Coverity related cleanups --- libs/spandsp/src/schedule.c | 4 +++- libs/spandsp/src/t4_rx.c | 5 ++++- 2 files changed, 7 insertions(+), 2 deletions(-) diff --git a/libs/spandsp/src/schedule.c b/libs/spandsp/src/schedule.c index 6e38e6bd94..93916dea1d 100644 --- a/libs/spandsp/src/schedule.c +++ b/libs/spandsp/src/schedule.c @@ -156,9 +156,11 @@ SPAN_DECLARE(int) span_schedule_release(span_sched_state_t *s) SPAN_DECLARE(int) span_schedule_free(span_sched_state_t *s) { - span_schedule_release(s); if (s) + { + span_schedule_release(s); span_free(s); + } return 0; } /*- End of function --------------------------------------------------------*/ diff --git a/libs/spandsp/src/t4_rx.c b/libs/spandsp/src/t4_rx.c index f14521b5f0..7a39dfd144 100644 --- a/libs/spandsp/src/t4_rx.c +++ b/libs/spandsp/src/t4_rx.c @@ -733,7 +733,10 @@ static int close_tiff_output_file(t4_rx_state_t *s) /* Try not to leave a file behind, if we didn't receive any pages to put in it. */ if (s->current_page == 0) - remove(s->tiff.file); + { + if (remove(s->tiff.file) < 0) + span_log(&s->logging, SPAN_LOG_WARNING, "%s: Failed to remove file.\n", s->tiff.file); + } span_free((char *) s->tiff.file); } s->tiff.file = NULL;