Removed an autological-pointer-compare from src/switch_utils.c.
Building with Clang 3.5 gave the following warning: error: comparison of array 'iface_out.sin6_addr.__in6_u.__u6_addr8' equal to a null pointer is always false [-Werror,-Wtautological-pointer-compare] This is a problem because as it is written the check will never be true. A pointer to a structure within a structure will never be null. The intention was either to null check the pointer or to check if the IP address itself was not zero. From context in the code this appeared to be a pointer null check so I removed it.
This commit is contained in:
parent
89f7196a6e
commit
24e5c13283
|
@ -1560,10 +1560,6 @@ SWITCH_DECLARE(switch_status_t) switch_find_local_ip(char *buf, int len, int *ma
|
|||
goto doh;
|
||||
}
|
||||
|
||||
if (iface_out.sin6_addr.s6_addr == 0) {
|
||||
goto doh;
|
||||
}
|
||||
|
||||
inet_ntop(AF_INET6, (const void *) &iface_out.sin6_addr, buf, len - 1);
|
||||
status = SWITCH_STATUS_SUCCESS;
|
||||
}
|
||||
|
|
Loading…
Reference in New Issue