From 2ae67a4756fc1f43cee4f6e404e9a84bbe5c9a90 Mon Sep 17 00:00:00 2001
From: Michael Jerris <mike@jerris.com>
Date: Mon, 26 Apr 2010 06:04:45 -0400
Subject: [PATCH] mod_sofia: add 'allow-empty-password' param (default true)
---
src/mod/endpoints/mod_sofia/sofia_reg.c | 18 ++++++++++++++++--
1 file changed, 16 insertions(+), 2 deletions(-)
diff --git a/src/mod/endpoints/mod_sofia/sofia_reg.c b/src/mod/endpoints/mod_sofia/sofia_reg.c
index 676998c106..d9c60aa5a6 100644
--- a/src/mod/endpoints/mod_sofia/sofia_reg.c
+++ b/src/mod/endpoints/mod_sofia/sofia_reg.c
@@ -1688,6 +1688,7 @@ auth_res_t sofia_reg_parse_auth(sofia_profile_t *profile,
const char *passwd = NULL;
const char *a1_hash = NULL;
const char *mwi_account = NULL;
+ switch_bool_t allow_empty_password = SWITCH_TRUE;
const char *call_id = NULL;
char *sql;
char *number_alias = NULL;
@@ -1924,7 +1925,9 @@ auth_res_t sofia_reg_parse_auth(sofia_profile_t *profile,
if (!strcasecmp(var, "mwi-account")) {
mwi_account = val;
}
-
+ if (!strcasecmp(var, "allow-empty-password")) {
+ allow_empty_password = switch_true(val);
+ }
if (!strcasecmp(var, "user-agent-filter")) {
user_agent_filter = val;
}
@@ -1958,7 +1961,9 @@ auth_res_t sofia_reg_parse_auth(sofia_profile_t *profile,
if (!strcasecmp(var, "mwi-account")) {
mwi_account = val;
}
-
+ if (!strcasecmp(var, "allow-empty-password")) {
+ allow_empty_password = switch_true(val);
+ }
if (!strcasecmp(var, "user-agent-filter")) {
user_agent_filter = val;
}
@@ -1992,6 +1997,9 @@ auth_res_t sofia_reg_parse_auth(sofia_profile_t *profile,
if (!strcasecmp(var, "mwi-account")) {
mwi_account = val;
}
+ if (!strcasecmp(var, "allow-empty-password")) {
+ allow_empty_password = switch_true(val);
+ }
if (!strcasecmp(var, "user-agent-filter")) {
user_agent_filter = val;
}
@@ -2058,6 +2066,12 @@ auth_res_t sofia_reg_parse_auth(sofia_profile_t *profile,
}
}
+ if (!allow_empty_password && zstr(passwd) && zstr(a1_hash)) {
+ switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_WARNING, "Empty password denied for user %s@%s\n", username, domain_name);
+ ret = AUTH_FORBIDDEN;
+ goto end;
+ }
+
if (zstr(passwd) && zstr(a1_hash)) {
ret = AUTH_OK;
goto skip_auth;