From 47d87e37b6e55697766d1a9eedd6cb07d144a605 Mon Sep 17 00:00:00 2001 From: Andrey Volk Date: Fri, 31 Jan 2025 17:48:28 +0300 Subject: [PATCH] [libesl] Coverity 1024285 Dereference before null check --- libs/esl/src/esl.c | 14 ++++++-------- 1 file changed, 6 insertions(+), 8 deletions(-) diff --git a/libs/esl/src/esl.c b/libs/esl/src/esl.c index 893a068e8c..9304bc5749 100644 --- a/libs/esl/src/esl.c +++ b/libs/esl/src/esl.c @@ -1299,14 +1299,12 @@ ESL_DECLARE(esl_status_t) esl_recv_event(esl_handle_t *handle, int check_q, esl_ *e++ = '\0'; while(*e == '\n' || *e == '\r') e++; - if (hval) { - esl_url_decode(hval); - esl_log(ESL_LOG_DEBUG, "RECV HEADER [%s] = [%s]\n", hname, hval); - if (!strncmp(hval, "ARRAY::", 7)) { - esl_event_add_array(revent, hname, hval); - } else { - esl_event_add_header_string(revent, ESL_STACK_BOTTOM, hname, hval); - } + esl_url_decode(hval); + esl_log(ESL_LOG_DEBUG, "RECV HEADER [%s] = [%s]\n", hname, hval); + if (!strncmp(hval, "ARRAY::", 7)) { + esl_event_add_array(revent, hname, hval); + } else { + esl_event_add_header_string(revent, ESL_STACK_BOTTOM, hname, hval); } p = e;