kenmirrors/freeswitch
1
0
Fork 0
mirror of https://github.com/signalwire/freeswitch.git synced 2025-08-13 09:36:46 +00:00
Code Issues Projects Releases Wiki Activity

Wed May 13 10:50:41 CDT 2009 Pekka Pessi <first.last@nokia.com>

Browse Source 
* msg: fixed possible leak in msg_params_d() with more than 16 params
  Ignore-this: a45ef326def7b1bcd14de4850f3c24ab
  
  Coverity issue.


git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13336 d0543943-73ff-0310-b7d9-9358b9ac24b2
This commit is contained in:
Michael Jerris
2009-05-15 16:05:15 +00:00
parent 6f7641f94a
commit 4c3b2bc4b5
3 changed files with 32 additions and 7 deletions
Download Patch File Download Diff File Expand all files Collapse all files

16
libs/sofia-sip/libsofia-sip-ua/msg/msg_parser_util.c
View File

@@ -415,12 +415,14 @@ issize_t msg_avlist_d(su_home_t *home,
if (n == N) {
/* Reallocate params */
char **nparams = su_alloc(home,
(N = MSG_PARAMS_NUM(N + 1)) * sizeof(*params));
char const **nparams = su_realloc(home, params != stack ? params : NULL,
(N = MSG_PARAMS_NUM(N + 1)) * sizeof(*params));
if (!nparams) {
goto error;
}
params = memcpy(nparams, params, n * sizeof(*params));
if (params == stack)
memcpy(nparams, stack, n * sizeof(*params));
params = nparams;
}
params[n++] = p;
@@ -441,12 +443,14 @@ issize_t msg_avlist_d(su_home_t *home,
}
else if (n == N) {
/* Reallocate params */
char **nparams = su_alloc(home,
(N = MSG_PARAMS_NUM(N + 1)) * sizeof(*params));
char const **nparams = su_realloc(home, params != stack ? params : NULL,
(N = MSG_PARAMS_NUM(N + 1)) * sizeof(*params));
if (!nparams) {
goto error;
}
params = memcpy(nparams, params, n * sizeof(*params));
if (params == stack)
memcpy(nparams, stack, n * sizeof(*params));
params = nparams;
}
params[n] = NULL;