kenmirrors
/
freeswitch
mirror of https://github.com/signalwire/freeswitch.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #2543 from signalwire/risky 

[Core] rtp_common_write: Coverity 1227609 Calling risky function
This commit is contained in:
Andrey Volk 2024-07-30 00:09:24 +03:00 committed by GitHub
parent be3c0b3ef6 b38d879413
commit 4eefe8279b
No known key found for this signature in database
GPG Key ID: B5690EEEBB952194
1 changed files with 2 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

4
src/switch_rtp.c
View File

@ -8267,11 +8267,11 @@ static int rtp_common_write(switch_rtp_t *rtp_session,
if (switch_rtp_test_flag(rtp_session, SWITCH_RTP_FLAG_VIDEO)) { if (switch_rtp_test_flag(rtp_session, SWITCH_RTP_FLAG_VIDEO)) {
int external = (flags && *flags & SFF_EXTERNAL); int external = (flags && *flags & SFF_EXTERNAL);
/* Normalize the timestamps to our own base by generating a made up starting point then adding the measured deltas to that base /* Normalize the timestamps to our own base by generating a made up starting point then adding the measured deltas to that base
so if the timestamps and ssrc of the source change, it will not break the other end's jitter bufffer / decoder etc *cough* CHROME *cough* so if the timestamps and ssrc of the source change, it will not break the other end's jitter buffer / decoder etc *cough* CHROME *cough*
*/ */
if (!rtp_session->ts_norm.ts) { if (!rtp_session->ts_norm.ts) {
rtp_session->ts_norm.ts = (uint32_t) rand() % 1000000 + 1; rtp_session->ts_norm.ts = (uint32_t) switch_rand() % 1000000 + 1;
} }
if (!rtp_session->ts_norm.last_ssrc || send_msg->header.ssrc != rtp_session->ts_norm.last_ssrc || rtp_session->ts_norm.last_external != external) { if (!rtp_session->ts_norm.last_ssrc || send_msg->header.ssrc != rtp_session->ts_norm.last_ssrc || rtp_session->ts_norm.last_external != external) {