kenmirrors
/
freeswitch
mirror of https://github.com/signalwire/freeswitch.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

[mod_sofia] sofia_handle_sip_i_invite() leaks xml and event objects on acl_token, sofia_reg_handle_sip_r_challenge() leaks xml object when a user does not have params.

This commit is contained in:
Andrey Volk 2019-10-07 22:37:33 +04:00
parent 5fd6299267
commit 8442218df1
2 changed files with 8 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

7
src/mod/endpoints/mod_sofia/sofia.c
View File

@ -10537,6 +10537,10 @@ void sofia_handle_sip_i_invite(switch_core_session_t *session, nua_t *nua, sofia
switch_channel_set_variable_printf(channel, "sip_invite_stamp", "%" SWITCH_TIME_T_FMT, sip_invite_time); switch_channel_set_variable_printf(channel, "sip_invite_stamp", "%" SWITCH_TIME_T_FMT, sip_invite_time);
if (*acl_token) { if (*acl_token) {
if (x_user) {
switch_xml_free(x_user);
x_user = NULL;
}
switch_channel_set_variable(channel, "acl_token", acl_token); switch_channel_set_variable(channel, "acl_token", acl_token);
if (sofia_locate_user(acl_token, session, sip, &x_user) == SWITCH_STATUS_SUCCESS) { if (sofia_locate_user(acl_token, session, sip, &x_user) == SWITCH_STATUS_SUCCESS) {
switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "Authenticating user %s\n", acl_token); switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_DEBUG, "Authenticating user %s\n", acl_token);
@ -10544,6 +10548,9 @@ void sofia_handle_sip_i_invite(switch_core_session_t *session, nua_t *nua, sofia
switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_WARNING, "Error Authenticating user %s\n", acl_token); switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_WARNING, "Error Authenticating user %s\n", acl_token);
if (sofia_test_pflag(profile, PFLAG_AUTH_REQUIRE_USER)) { if (sofia_test_pflag(profile, PFLAG_AUTH_REQUIRE_USER)) {
nua_respond(nh, SIP_480_TEMPORARILY_UNAVAILABLE, TAG_END()); nua_respond(nh, SIP_480_TEMPORARILY_UNAVAILABLE, TAG_END());
if (v_event) {
switch_event_destroy(&v_event);
}
goto fail; goto fail;
} }
} }

3
src/mod/endpoints/mod_sofia/sofia_reg.c
View File

@ -2624,9 +2624,8 @@ void sofia_reg_handle_sip_r_challenge(int status,
sip_auth_password = dup_pass; sip_auth_password = dup_pass;
} }
} }
switch_xml_free(x_user);
} }
switch_xml_free(x_user);
} }
switch_event_destroy(&locate_params); switch_event_destroy(&locate_params);