From c0a5c54bc10c7ebdb65f5aafc8d60dbad6477944 Mon Sep 17 00:00:00 2001 From: Joao Mesquita Date: Thu, 20 Aug 2015 18:33:39 -0300 Subject: [PATCH] FS-8003 #resolve Use audioInDevices instead of audioDevices to match verto plugin. FS-8003 Also make modifications so that refreshing device actually calls APIs on the verto library instead of just reparsing it's output. --- .../verto_communicator/js/verto-service.js | 121 +++++++++--------- 1 file changed, 57 insertions(+), 64 deletions(-) diff --git a/html5/verto/verto_communicator/js/verto-service.js b/html5/verto/verto_communicator/js/verto-service.js index c126b4e517..04a43d2e06 100644 --- a/html5/verto/verto_communicator/js/verto-service.js +++ b/html5/verto/verto_communicator/js/verto-service.js @@ -234,85 +234,78 @@ vertoService.service('verto', ['$rootScope', '$cookieStore', '$location', refreshDevices: function(callback) { console.debug('Attempting to refresh the devices.'); + function refreshDevicesCallback() { + data.videoDevices = [{ + id: 'none', + label: 'No camera' + }]; + data.shareDevices = [{ + id: 'screen', + label: 'Screen' + }]; + data.audioDevices = []; + data.selectedVideo = 'none'; + data.selectedShare = 'screen'; + data.selectedAudio = null; - data.videoDevices = [{ - id: 'none', - label: 'No camera' - }]; - data.shareDevices = [{ - id: 'screen', - label: 'Screen' - }]; - data.audioDevices = []; + for (var i in jQuery.verto.videoDevices) { + var device = jQuery.verto.videoDevices[i]; + if (!device.label) { + data.videoDevices.push({ + id: 'Camera ' + i, + label: 'Camera ' + i + }); + } else { + data.videoDevices.push({ + id: device.id, + label: device.label || device.id + }); + } - data.selectedVideo = 'none'; - data.selectedShare = 'screen'; - data.selectedAudio = null; + // Selecting the first source. + if (i == 0) { + data.selectedVideo = device.id; + } - for (var i in jQuery.verto.videoDevices) { - var device = jQuery.verto.videoDevices[i]; - if (!device.label) { - data.videoDevices.push({ - id: 'Camera ' + i, - label: 'Camera ' + i - }); - } else { - data.videoDevices.push({ + if (!device.label) { + data.shareDevices.push({ + id: 'Share Device ' + i, + label: 'Share Device ' + i + }); + continue; + } + + data.shareDevices.push({ id: device.id, label: device.label || device.id }); } - // Selecting the first source. - if (i == 0) { - data.selectedVideo = device.id; - } + for (var i in jQuery.verto.audioInDevices) { + var device = jQuery.verto.audioInDevices[i]; + // Selecting the first source. + if (i == 0) { + data.selectedAudio = device.id; + } - if (!device.label) { - data.shareDevices.push({ - id: 'Share Device ' + i, - label: 'Share Device ' + i - }); - continue; - } - - data.shareDevices.push({ - id: device.id, - label: device.label || device.id - }); - } - - for (var i in jQuery.verto.audioDevices) { - var device = jQuery.verto.audioDevices[i]; - // Selecting the first source. - if (i == 0) { - data.selectedAudio = device.id; - } - - if (!device.label) { + if (!device.label) { + data.audioDevices.push({ + id: 'Microphone ' + i, + label: 'Microphone ' + i + }); + continue; + } data.audioDevices.push({ - id: 'Microphone ' + i, - label: 'Microphone ' + i + id: device.id, + label: device.label || device.id }); - continue; } - data.audioDevices.push({ - id: device.id, - label: device.label || device.id - }); - } + console.debug('Devices were refreshed.'); + }; - console.debug('Devices were refreshed.'); + jQuery.verto.refreshDevices(refreshDevicesCallback); - if (angular.isFunction(callback)) { - var devices = { - audio: data.audioDevices, - video: data.videoDevices, - share: data.shareDevices - }; - callback(data.instance, devices); - } }, /**