[apr-util] Fix issues reported by scan-build.

This commit is contained in:
Andrey Volk 2020-02-14 18:39:15 +04:00
parent 5378eae101
commit a7cdf35b60
3 changed files with 6 additions and 4 deletions

View File

@ -180,7 +180,9 @@ static TSort *tsort(TSort *pData,int nItems)
break; break;
} }
} }
pTail->pNext=NULL; /* unfudge the tail */ if (pTail) {
pTail->pNext = NULL; /* unfudge the tail */
}
return pHead; return pHead;
} }

View File

@ -222,7 +222,7 @@ APU_DECLARE(apr_status_t) apr_queue_trypush(apr_queue_t *queue, void *data)
} }
if (apr_queue_full(queue)) { if (apr_queue_full(queue)) {
rv = apr_thread_mutex_unlock(queue->one_big_mutex); apr_thread_mutex_unlock(queue->one_big_mutex);
return APR_EAGAIN; return APR_EAGAIN;
} }
@ -397,7 +397,7 @@ APU_DECLARE(apr_status_t) apr_queue_trypop(apr_queue_t *queue, void **data)
} }
if (apr_queue_empty(queue)) { if (apr_queue_empty(queue)) {
rv = apr_thread_mutex_unlock(queue->one_big_mutex); apr_thread_mutex_unlock(queue->one_big_mutex);
return APR_EAGAIN; return APR_EAGAIN;
} }

View File

@ -82,7 +82,7 @@ static int find_prefix(apr_xml_parser *parser, const char *prefix)
** prefix. ** prefix.
*/ */
for (; elem; elem = elem->parent) { for (; elem; elem = elem->parent) {
apr_xml_ns_scope *ns_scope = elem->ns_scope; apr_xml_ns_scope *ns_scope;
for (ns_scope = elem->ns_scope; ns_scope; ns_scope = ns_scope->next) { for (ns_scope = elem->ns_scope; ns_scope; ns_scope = ns_scope->next) {
if (strcmp(prefix, ns_scope->prefix) == 0) { if (strcmp(prefix, ns_scope->prefix) == 0) {