kenmirrors/freeswitch
1
0
Fork 0
mirror of https://github.com/signalwire/freeswitch.git synced 2025-03-14 04:54:49 +00:00
Code Issues Projects Releases Wiki Activity

freetdm: disallow completely core variables for freetdm outbound variables

Browse Source
This commit is contained in:
Moises Silva 2011-02-11 10:55:11 -05:00
parent d8b11ce63b
commit acd6333e33
1 changed files with 1 additions and 11 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

12
libs/freetdm/mod_freetdm/mod_freetdm.c
View File

@ -1055,28 +1055,18 @@ switch_io_routines_t freetdm_io_routines = {
static const char* channel_get_variable(switch_core_session_t *session, switch_event_t *var_event, const char *variable_name) static const char* channel_get_variable(switch_core_session_t *session, switch_event_t *var_event, const char *variable_name)
{ {
const char *variable = NULL; const char *variable = NULL;
if (var_event) { if (var_event) {
if ((variable = switch_event_get_header(var_event, variable_name))) { if ((variable = switch_event_get_header(var_event, variable_name))) {
return variable; return variable;
} }
} }
if (session) { if (session) {
switch_channel_t *channel = switch_core_session_get_channel(session); switch_channel_t *channel = switch_core_session_get_channel(session);
if ((variable = switch_channel_get_variable(channel, variable_name))) { if ((variable = switch_channel_get_variable(channel, variable_name))) {
return variable; return variable;
} }
} }
// This is unsafe, I don't see anywhere in the whole code where this is called with NULL session anyway.
// There is a new switch_core_get_variable_dup that will strdup it for you and then you must free it.
// That messes up the abstraction completely so I am just commenting it out for you.....
/*
if ((variable = switch_core_get_variable(variable_name))) {
return variable;
}
*/
return NULL; return NULL;
} }