From 083e6ae80f67e0c8545f07d91481f6c4c0c992e8 Mon Sep 17 00:00:00 2001 From: Aron Podrigal Date: Wed, 15 Jan 2025 14:03:07 -0600 Subject: [PATCH] [mod_curl] Fix off-by-one error in argument limit checks. refs: #2727 --- src/mod/applications/mod_curl/mod_curl.c | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff --git a/src/mod/applications/mod_curl/mod_curl.c b/src/mod/applications/mod_curl/mod_curl.c index 82b38d42a9..cae06bdb30 100644 --- a/src/mod/applications/mod_curl/mod_curl.c +++ b/src/mod/applications/mod_curl/mod_curl.c @@ -898,7 +898,7 @@ SWITCH_STANDARD_APP(curl_app_function) if ((argc = switch_separate_string(mydata, ' ', argv, (sizeof(argv) / sizeof(argv[0]))))) { if (argc == 0) { switch_goto_status(SWITCH_STATUS_SUCCESS, usage); - } else if (argc >= MOD_CURL_MAX_ARGS) { + } else if (argc > MOD_CURL_MAX_ARGS) { switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_ERROR, "Max args exceeded: %d\n", MOD_CURL_MAX_ARGS); switch_goto_status(SWITCH_STATUS_FALSE, done); } @@ -1021,7 +1021,7 @@ SWITCH_STANDARD_API(curl_function) if ((argc = switch_separate_string(mydata, ' ', argv, (sizeof(argv) / sizeof(argv[0]))))) { if (argc < 1) { switch_goto_status(SWITCH_STATUS_SUCCESS, usage); - } else if (argc >= MOD_CURL_MAX_ARGS) { + } else if (argc > MOD_CURL_MAX_ARGS) { switch_log_printf(SWITCH_CHANNEL_SESSION_LOG(session), SWITCH_LOG_ERROR, "Max args exceeded: %d\n", MOD_CURL_MAX_ARGS); switch_goto_status(SWITCH_STATUS_FALSE, done); }