kenmirrors
/
freeswitch
mirror of https://github.com/signalwire/freeswitch.git
1
0
Fork 0
Code Issues Projects Releases Wiki Activity

Merge pull request #2045 from signalwire/coverity_13042023_mod_rayo 

[mod_rayo] Coverity CID 1395579 (Resource leak)
This commit is contained in:
Andrey Volk 2023-04-17 19:46:01 +03:00 committed by GitHub
parent 106e8b38f0 075724845e
commit e2544341bd
No known key found for this signature in database
GPG Key ID: 4AEE18F83AFDEB23
1 changed files with 7 additions and 2 deletions
Show Stats Download Patch File Download Diff File Expand all files Collapse all files

9
src/mod/event_handlers/mod_rayo/mod_rayo.c
View File

@ -4765,7 +4765,7 @@ static void send_console_command(struct rayo_client *client, const char *to, con
iks *command = NULL; iks *command = NULL;
iksparser *p = iks_dom_new(&command); iksparser *p = iks_dom_new(&command);
if (iks_parse(p, command_str, 0, 1) == IKS_OK && command) { if (p && iks_parse(p, command_str, 0, 1) == IKS_OK && command) {
char *str; char *str;
iks *iq = NULL; iks *iq = NULL;
@ -4784,9 +4784,11 @@ static void send_console_command(struct rayo_client *client, const char *to, con
if (!iks_find_attrib(iq, "type")) { if (!iks_find_attrib(iq, "type")) {
iks_insert_attrib(iq, "type", "set"); iks_insert_attrib(iq, "type", "set");
} }
if (!iks_find_attrib(iq, "id")) { if (!iks_find_attrib(iq, "id")) {
iks_insert_attrib_printf(iq, "id", "console-%i", RAYO_SEQ_NEXT(client)); iks_insert_attrib_printf(iq, "id", "console-%i", RAYO_SEQ_NEXT(client));
} }
iks_insert_attrib(iq, "from", RAYO_JID(client)); iks_insert_attrib(iq, "from", RAYO_JID(client));
/* send command */ /* send command */
@ -4794,10 +4796,13 @@ static void send_console_command(struct rayo_client *client, const char *to, con
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_CONSOLE, "\nSEND: to %s, %s\n", to, str); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_CONSOLE, "\nSEND: to %s, %s\n", to, str);
rayo_client_command_recv(client, iq); rayo_client_command_recv(client, iq);
iks_delete(command); iks_delete(command);
iks_parser_delete(p);
} else { } else {
switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_CONSOLE, "bad request xml\n"); switch_log_printf(SWITCH_CHANNEL_LOG, SWITCH_LOG_CONSOLE, "bad request xml\n");
if (p) {
iks_parser_delete(p);
}
} }
iks_parser_delete(p);
} }
/** /**