Commit Graph

21949 Commits

Author SHA1 Message Date
Jakub Karolczyk 930341ba86 [core,mod_av,unit-tests] Make transition to core packetizer 2023-07-10 12:58:19 +00:00
Jakub Karolczyk c9fb586c34 [mod_verto] Fix function declarations without a prototype 2023-07-08 06:29:23 -05:00
Jakub Karolczyk ab211c542a
Merge pull request #2140 from signalwire/fix_vars_not_used
[core,miniupnpc,modules] Fix not used variables
2023-07-05 13:18:15 +01:00
Andrey Volk bd5bea5b2c
Merge pull request #2141 from signalwire/remove_verbatim
[mod_sofia] Remove non-implemented verbose feature
2023-07-04 17:04:37 +03:00
Jakub Karolczyk 2afad15f48 [mod_sofia] Remove non-implemented verbose feature 2023-07-04 10:37:48 +01:00
Jakub Karolczyk 5656972bfe [core,miniupnpc,modules] Fix not used variables 2023-07-04 10:18:16 +01:00
Jakub Karolczyk a160eced99 [core,libyuv,modules] Fix function declarations without a prototype 2023-07-04 09:56:40 +01:00
David Villasmil b355bf21e6
[mod_conference] Add flag to destroy the conference only when all mandatory members disconnect. And set endconf to end the conference when any member with the flag disconnects (#2079)
* feature/mod_conference_mandatory_member_flag: Add flag to destroy the conference only when all mandatory members disconnect. And set endconf to end the conference when any member with the flag disconnects
2023-06-28 19:39:22 +03:00
Andrey Volk 25afda9be0 [mod_opus] Fix Windows build regression made by previous commit 2023-06-23 21:25:16 +03:00
Julien Chavanton 67840823c1
[core, mod_opus] more elastic jitterbuffer with Opus codec (#2069) 2023-06-23 16:45:31 +03:00
Andrey Volk f64314ff48 [mod_sofia] Map SWITCH_CAUSE_REJECT_ALL cause to 603 2023-06-22 22:39:51 +03:00
Giacomo Vacca 9c63f03b45 [Core] Add new cause REJECT_ALL 2023-06-22 22:39:46 +03:00
Dragos Oancea 7bc999309c [mod_opus] fix remote codec rate to match. 2023-06-15 16:29:43 +03:00
Dragos Oancea 5e914efc8c [core, mod_opus] bring more fmtp params to core (offer/answer). 2023-06-15 16:26:17 +03:00
Dragos Oancea f90aeade4f [core] Opus RTP timestamp: adding an exception on RTP session creation.
https://www.rfc-editor.org/rfc/rfc7587.html
"The RTP timestamp is incremented with a 48000 Hz
   clock rate for all modes of Opus and all sampling rates.  The unit
   for the timestamp is samples per single (mono) channel"

Follow up: 50f57f85732b0d5a58a39f3fca7b654f894b0c9d, ccbef9e0c7 .
2023-06-15 16:25:46 +03:00
Dragos Oancea 5065c0b118 [mod_opus] fix samples_per_packet for 8khz, 16khz, 24khz. 2023-06-15 16:22:52 +03:00
Dragos Oancea a458d704ab [mod_opus] show uuid in logs. 2023-06-14 16:01:27 +03:00
Dragos Oancea 24452ff104 [mod_opus] fix configuration glitches (switch_true() instead of atoi()). 2023-06-14 15:57:54 +03:00
Dragos Oancea 9b20b324f5
[mod_sofia] Coverity fixes
[mod_sofia] coverity CID 1024253 (Dereference before null check)
[mod_sofia] coverity CID 1024254 (Dereference before null check)
[mod_sofia] coverity CID 1257620 (Logically dead code)
[mod_sofia] coverity CID 1024750 (Dereference null return value)
2023-06-12 18:17:12 +03:00
Andrey Volk b4e43214f7 [Core] Fix possible deadlock in switch_core_media_set_codec() 2023-06-12 17:47:02 +03:00
Dragos Oancea 86875d2381
[mod_verto] Coverity fixes
[mod_verto] coverity CID 1468439 (Dereference after null check)
[mod_verto] coverity CID 1294451 (Dereference before null check)
[mod_verto] coverity CID 1468443 (Logically dead code)
2023-06-12 17:25:37 +03:00
Andrey Volk 9eda0c41eb
Merge pull request #2104 from dragos-oancea/cov-mod_portaudio
[mod_portaudio] coverity CID 1024263 (Dereference before null check)
2023-06-12 17:03:16 +03:00
Andrey Volk 7a47ed19c7
Merge pull request #2106 from dragos-oancea/cov-mod_spandsp
[mod_spandsp] Coverity CID 1024263 (Dereference before null check)
2023-06-12 16:58:09 +03:00
Jakub Karolczyk b0a52eb1fe [core] Add switch_core_media_get_engine() and switch_core_media_get_codec() functions 2023-06-09 18:25:25 +00:00
Andrey Volk d7a4ab7dce [mod_spandsp] Coverity CID 1024263 (Dereference before null check) 2023-06-09 12:18:19 +03:00
Dragos Oancea ef275aec8a [mod_portaudio] coverity CID 1024263 (Dereference before null check) 2023-06-09 12:15:11 +03:00
Andrey Volk 35823b650a [mod_verto] Include libks/ks.h instead of ks.h 2023-05-30 22:45:54 +03:00
Henrique a4af2ea7de
[mod_png] Fix unexpected png video blocked read 2023-05-24 02:14:22 +03:00
ping a3a4244f21
[mod_sofia] fix sofia_glue_get_extra_headers memory leak 2023-05-17 00:29:13 +08:00
Andrey Volk f377a0ff57
Revert "[Core, mod_curl, mod_httapi, mod_http_cache] Compatible with libcurl>=7.87.0" (#2070)
This reverts commit 0398238489.
2023-05-01 20:38:51 +03:00
Clarence 0398238489
[Core, mod_curl, mod_httapi, mod_http_cache] Compatible with libcurl>=7.87.0
* [core] fix deprecated with libcurl>=7.56.0

* [mod_httpapi] fix deprecated with libcurl>=7.56.0

* [mod_curl] fix deprecated with libcurl>=7.56.0

* [mod_http_cache] fix deprecated with libcurl>=7.12.1
2023-04-27 23:43:32 +03:00
Dragos Oancea b5cb26dc47
[Core] Coverity fixes
* [core] coverity CID 1024482 (Dereference after null check)

* [core] coverity CID 1468368 (Logically dead code)

* [core] coverity CID 1468459 (Logically dead code)

* [core] coverity CID 1232742 (Dereference before null check)
2023-04-18 19:30:22 +03:00
Andrey Volk dbd37bdc51
Merge pull request #2052 from dragos-oancea/mod_dptools-cov3
[mod_dptools] coverity CID 1468646 (Unsigned compared against 0)
2023-04-18 13:25:13 +03:00
Dragos Oancea 5597fe3098 [mod_avmd] coverity CID 1395555 (Dereference before null check) 2023-04-18 12:58:16 +03:00
Dragos Oancea e1d966ed0a [mod_dptools] coverity CID 1468646 (Unsigned compared against 0) 2023-04-18 12:55:42 +03:00
Andrey Volk 77a5fa3b0d
Merge pull request #2055 from dragos-oancea/mod_sofia-cov3
[mod_sofia] coverity CID 1468496 (Unchecked return value)
2023-04-17 23:29:03 +03:00
Jakub Karolczyk 6eefc674fe
[mod_avmd] Coverity fixes
* [mod_avmd] Coverity CID 1395501 (Dereference null return value)

* [mod_avmd] Coverity CID 1395478 (Resource leak)
2023-04-17 21:49:42 +03:00
Andrey Volk cb3373872a
Merge pull request #2053 from dragos-oancea/mod_erlang_event-cov3
[mod_erlang_event] coverity CID 1500239 (Uninitialized scalar variable)
2023-04-17 21:22:43 +03:00
Andrey Volk 991c7be001
Merge pull request #2051 from dragos-oancea/mod_opusfile-cov3
[mod_opusfile] coverity CID 1468424 (Missing break in switch)
2023-04-17 20:15:53 +03:00
Andrey Volk 2debb076ed
Merge pull request #2042 from signalwire/coverity_13042023_mod_v8
[mod_v8] Coverity CID 1468570 (Resource leak)
2023-04-17 19:50:04 +03:00
Andrey Volk e2544341bd
Merge pull request #2045 from signalwire/coverity_13042023_mod_rayo
[mod_rayo] Coverity CID 1395579 (Resource leak)
2023-04-17 19:46:01 +03:00
Jakub Karolczyk 075724845e [mod_rayo] Coverity CID 1395579 (Resource leak) 2023-04-17 15:33:47 +01:00
Andrey Volk 106e8b38f0
Merge pull request #2044 from signalwire/coverity_13042023_mod_radius_cdr
[mod_radius_cdr] Coverity CID 1395529 (Resource leak)
2023-04-17 16:59:24 +03:00
Dragos Oancea aab9839678 [mod_sofia] coverity CID 1468496 (Unchecked return value) 2023-04-17 14:55:13 +03:00
Dragos Oancea 01e960cd90 [mod_erlang_event] coverity CID 1500239 (Uninitialized scalar variable) 2023-04-17 14:51:45 +03:00
Dragos Oancea 98c0482844 [mod_opusfile] coverity CID 1468424 (Missing break in switch) 2023-04-17 14:47:39 +03:00
Jakub Karolczyk 0c2edc4f56 [mod_radius_cdr] Coverity CID 1395529 (Resource leak) 2023-04-17 12:01:14 +01:00
Jakub Karolczyk bc00add254
[mod_kazoo] Coverity fixes (#2043)
* [mod_kazoo] Coverity CID 1395503 (Resource leak)

* [mod_kazoo] Coverity CID 1468146 (Resource leak)

* [mod_kazoo] Coverity CID 1468483 (Resource leak)
2023-04-17 13:53:26 +03:00
Andrey Volk 371d3c6164
Merge pull request #2041 from signalwire/coverity_13042023_mod_java
[mod_java] Coverity CID 1320752 (Resource leak)
2023-04-17 13:50:03 +03:00
Jakub Karolczyk 0b05623cef [mod_translate] Coverity CID 1301006 (Resource leak) 2023-04-16 14:22:09 +01:00
Jakub Karolczyk 85a109617f [mod_java] Coverity CID 1320752 (Resource leak) 2023-04-14 17:41:33 +01:00
Jakub Karolczyk 70c144309c [mod_v8] Coverity CID 1468570 (Resource leak) 2023-04-14 17:40:48 +01:00
Andrey Volk 7f3a833466 [mod_commands] Fix leaking session readlock in uuid_capture_text 2023-04-14 14:48:41 +03:00
Jakub Karolczyk eec1fd737c [mod_signalwire] Make this module working with libks and signalwire-c in versions 2.0
* [mod_signalwire] Fix load credentials data from json

* [mod_signalwire] Fix parsing of configuration response
2023-04-13 16:24:35 +03:00
Andrey Volk 4d3b0a5778 [mod_opus] Fix buf scope in switch_opus_decode(). 2023-04-10 15:10:17 +03:00
Andrey Volk be3a73af62
Merge pull request #2032 from signalwire/coverity_06042023_mod_xml_rpc
[mod_xml_rpc] Coverity CID 1294469 (Resource leak)
2023-04-07 09:30:07 +03:00
Jakub Karolczyk 9994c51499 [mod_xml_rpc] Coverity CID 1294469 (Resource leak) 2023-04-06 22:31:50 +01:00
Andrey Volk 919647a035
Merge pull request #2033 from signalwire/coverity_06042023_mod_xml_scgi
[mod_xml_scgi] Coverity CID 1468595 (Resource leak)
2023-04-07 00:21:16 +03:00
Andrey Volk daeaceb27c
Merge pull request #2031 from signalwire/coverity_06042023_mod_xml_curl
[mod_xml_curl] Coverity CID 1468413 (Resource leak)
2023-04-07 00:19:41 +03:00
Andrey Volk ce5194a523
Merge pull request #2030 from signalwire/coverity_06042023_mod_verto
[mod_verto] Coverity CID 1320754 (Resource leak)
2023-04-07 00:16:41 +03:00
Andrey Volk d4faa1ddd2
Merge pull request #2029 from signalwire/coverity_06042023_mod_java
[mod_java] Coverity CID 1320753 (Resource leak)
2023-04-07 00:14:52 +03:00
Andrey Volk 87dea6c503
Merge pull request #2028 from signalwire/coverity_06042023_mod_imagick
[mod_imagick] Coverity CID 1500258 (Resource leak)
2023-04-07 00:13:17 +03:00
Andrey Volk 0091a90ea8
Merge pull request #2027 from signalwire/coverity_06042023_mod_event_multicast
[mod_event_multicast] Coverity CID 1468504 (Resource leak)
2023-04-07 00:11:41 +03:00
Andrey Volk f5bd2c653d
Merge pull request #2026 from signalwire/coverity_06042023_mod_dialplan_asterisk
[mod_dialplan_asterisk] Coverity CID 1214207 (Resource leak)
2023-04-07 00:07:19 +03:00
Andrey Volk 814348c739
Merge pull request #2025 from signalwire/coverity_06042023_mod_av
[mod_av] Coverity CID 1500320 (Resource leak)
2023-04-07 00:05:40 +03:00
Jakub Karolczyk 11b9c1d104 [mod_event_multicast] Coverity CID 1468504 (Resource leak) 2023-04-06 18:36:34 +01:00
Jakub Karolczyk a8f6625d12 [mod_amqp] Coverity CID 1468426 (Resource leak) 2023-04-06 18:31:40 +01:00
Jakub Karolczyk 5388319dd3 [mod_xml_curl] Coverity CID 1468413 (Resource leak) 2023-04-06 18:27:42 +01:00
Jakub Karolczyk 875a1b04ff [mod_av] Coverity CID 1500320 (Resource leak) 2023-04-06 18:25:56 +01:00
Jakub Karolczyk 99e26d3448 [mod_dialplan_asterisk] Coverity CID 1214207 (Resource leak) 2023-04-06 18:25:11 +01:00
Jakub Karolczyk a9e81ae0b8 [mod_verto] Coverity CID 1320754 (Resource leak) 2023-04-06 18:24:26 +01:00
Jakub Karolczyk 0e9954467f [mod_imagick] Coverity CID 1500258 (Resource leak) 2023-04-06 18:23:33 +01:00
Jakub Karolczyk b02fbc702d [mod_java] Coverity CID 1320753 (Resource leak) 2023-04-06 18:21:40 +01:00
Jakub Karolczyk 80d5790274 [mod_xml_scgi] Coverity CID 1468595 (Resource leak) 2023-04-06 18:20:07 +01:00
Dragos Oancea 73ea37c5ab
[Core] Coverity fixes
* [core] coverity CID 1320751 (Dereference before null check)

* [core] coverity CID 1294546 (Unchecked return value)

* [core] coverity CID 1227661 (Logically dead code)

* [core] coverity CID 1227656 (Logically dead code)

* [core] coverity CID 1060948 (Explicit null dereferenced)

* [core] coverity CID 1346465 (Unchecked return value)

* [core] coverity CID 1364953 (Logically dead code)

* [core] coverity CID 1468210 (Dereference before null check)

* [core] coverity CID 1468546 (Dereference before null check)

* [core] coverity CID 1468342 (Dereference before null check)
2023-04-05 18:54:11 +03:00
Jakub Karolczyk 49c1c35982
[core] Coverity fixes
* [core] Coverity CID 1468218 (Resource leak)

* [core] Coverity CID 1468214 (Resource leak)

* [core] Coverity CID 1294472 (Resource leak)

* [core] Coverity CID 1294470 (Resource leak)

* [core] Coverity CID 1500361 (Resource leak)

* [core] Coverity CID 1500308 (Resource leak)

* [core] Coverity CID 1500278 (Resource leak)

---------

Co-authored-by: Andrey Volk <andywolk@gmail.com>
2023-04-01 00:07:59 +03:00
Andrey Volk 55313696db [Core] Remove unused count variable from switch_core_session_execute_exten() 2023-03-31 22:48:11 +03:00
Andrey Volk 9940623bce [Core] Fix switch_core_sqldb_destroy() function declaration. 2023-03-31 20:47:56 +03:00
Jakub Karolczyk 9494148b10
[mod_sofia] Coverity fixes
* [mod_sofia] Coverity CID 1468634 (Resource leak)

* [mod_sofia] Coverity CID 1294467 (Resource leak)

---------

Co-authored-by: Andrey Volk <andywolk@gmail.com>
2023-03-30 22:00:40 +03:00
Jakub Karolczyk 65b24c65db [mod_pgsql] Coverity CID 1468401 (Resource leak) 2023-03-29 23:26:35 +01:00
Andrey Volk f5f7f76cd4
Merge pull request #2006 from dragos-oancea/mod_amr-cov
[mod_amr] coverity CID 1395603 (Unsigned compared against 0)
2023-03-29 19:19:47 +03:00
Dragos Oancea 3d547647b2
[mod_verto] Coverity fixes
* [mod_verto] coverity CID (Logically dead code)

* [mod_verto] coverity CID 1468609 (Logically dead code)
2023-03-29 19:14:54 +03:00
Andrey Volk 16884775b9
Merge pull request #2005 from dragos-oancea/mod_opus-cov
[mod_opus] coverity CID 1320733 (Result is not floating-point)
2023-03-29 19:12:19 +03:00
Dragos Oancea 48b8b0c4d7
[Core] Coverity fixes
* [core] coverity CID 1395504 (Logically dead code)

* [core] coverity CID 1395581 (Dereference before null check)

* [core] coverity CID 1346451 (Improper use of negative value)

* [core] coverity CID 1395497 (Dereference before null check)

* [core] coverity CID 1468458 (Dereference before null check)
2023-03-29 19:08:18 +03:00
Andrey Volk 8e5dc5a087 [mod_opusfile] Fix missing rdlock unlock in switch_opusfile_open() 2023-03-29 19:05:18 +03:00
Dragos Oancea 3c1824a685 [mod_amr] coverity CID 1395603 (Unsigned compared against 0) 2023-03-29 17:20:04 +03:00
Dragos Oancea 3c4695ea31 [mod_opus] coverity CID 1320733 (Result is not floating-point) 2023-03-29 17:18:57 +03:00
Tomasz Ostrowski afc8d78a18
[mod_enum] Fix use-after-free if creating resolver from file failed 2023-03-28 17:36:01 +03:00
Andrey Volk 6c97e3b0f4 [Core] Fix missing mutex unlock in switch_ivr_dmachine_ping() 2023-03-28 17:10:25 +03:00
Andrey Volk 02c25a24a4
Merge pull request #1765 from greenbea/patch-14
[mod_say_en] change epoch to 64 bit int
2023-03-28 17:06:58 +03:00
Andrey Volk ef9268ec0c
Merge pull request #1900 from jyelloz/master
[mod_ladspa] Added activate/deactivate support.
2023-03-28 17:00:28 +03:00
Henrique bb2fa44071
[mod_conference] handle personal canvas with vmuted member 2023-03-28 16:53:16 +03:00
yois615 6d65f8e08c
[mod_callcenter] Fix stale agents and UUID broadcasts
* [call_center] Stop uuid_broadcast on answer

* [mod_callcenter] Fix stale members in database

When a channel is originated to an agent but the
member fails to bridge to that agent, the database is
not updated with the member status and a stale entry
of 'Answered' persists until mod_callcenter is restarted.

Additionally, cc_agent_found is set before the bridge,
therefore ending the while loop on the member channel.
If there is a problem with the agent bridge, the call is
terminated prematurely.

In this commit, we:

* Move the SQL update of the member
to the 'Answered' state to the agent thread instead of
the member's thread, so that correct data is populated.

* Reset the members state accordingly to Abandoned or
Waiting if the channels fail to bridge.

* Use cc_agent_bridged to end the member loop,
so that a member is put back on queue if the agent
channel fails to bridge.
2023-03-28 14:53:16 +03:00
yois615 965e88a6b0
[core, mod_cidlookup] Free memory allocated via strdup
In mod_cidlookup and several other modules, config parameters
are read from external XML files using the SWITCH_CONFIG_ITEM_STRING_STRDUP
method.  These items do not have string_options, and are not freed
with switch_xml_config_cleanup.  We therefore need to call switch_safe_free
for config without string_options.  We also add switch_xml_config_cleanup
to mod_cidlookup.  There are other modules that may be affected but this
commit makes no attempt at fixing those.

Fixes #1752
2023-03-28 01:47:23 +03:00
Andrey Volk f680a29405
Merge pull request #1413 from yois615/master
[mod_sofia] Randomize OPTIONS Ping interval
2023-03-28 01:43:35 +03:00
Tomasz Ostrowski 8e604e8a94
[mod_event_multicast] Few fixes
* [mod_event_multicast] Fix crash / invalid pointer dereference

* [mod_event_multicast] Check current number of addresses before zeroing memory on init

* [mod_event_multicast] Fix condition checking number of addresses on init

* [mod_event_multicast] Fix addresses zeroing on init

* [mod_event_multicast] Reorder memset and assert after malloc
2023-03-27 20:23:07 +03:00
Andrey Volk 2c36dcdd50
Merge pull request #1843 from greenbea/patch-17
[mod_commands] Fix and improve coalesce function
2023-03-27 20:03:40 +03:00
Andrey Volk 49eb8a77ee
Merge pull request #1996 from greenbea/amqp_subclass_support
[mod_amqp] Event subclass support
2023-03-27 19:55:46 +03:00
Дилян Палаузов 99ca7436d8
[mod_commands] add completions for fsctl api_expansion and sync_clock_when_idle 2023-03-27 19:50:51 +03:00
Andrey Volk be1b1c8085
Merge pull request #1976 from greenbea/patch-19
[core] switch_ivr_originate set originate endpoint used
2023-03-27 19:41:32 +03:00