Michael Jerris
db1a2de186
don't null check what we know won't be null
2014-05-01 19:00:24 -04:00
Michael Jerris
2e3558c43e
don't need to double check for null
2014-05-01 18:50:26 -04:00
Michael Jerris
582fa1a664
fix typo
2014-05-01 18:22:57 -04:00
Travis Cross
cd650f6055
Use system ldns library
...
This library is used only by mod_enum and is available on most
platforms. The version in our tree has many code quality problems
that are generating noise when doing static analysis. Suffice it to
say we want rid of it as our responsibility.
FS-353
2014-05-01 22:01:59 +00:00
Travis Cross
c1f884cd33
Remove old ldns patch from FS-3110
2014-05-01 22:01:59 +00:00
Raymond Chandler
33460064ac
CID: 1210739
2014-05-01 17:34:54 -04:00
Raymond Chandler
a4e0929ef0
CID: 1210596
2014-05-01 17:28:54 -04:00
Raymond Chandler
17f79bc2c3
CID: 1210770
2014-05-01 16:36:58 -04:00
Anthony Minessale
7f18b80e60
FS-6503 --resolve remove unused code
2014-05-02 01:28:12 +05:00
Brian West
c462ed6ae1
FS-6499 --resolve
2014-05-01 15:21:57 -05:00
Brian West
d06b137abd
FS-6498 --resolve
2014-05-01 15:20:28 -05:00
Michael Jerris
64f1098b8c
remove dead assignment
2014-05-01 14:17:06 -04:00
Michael Jerris
b0fd845786
remove dead assignment
2014-05-01 14:04:56 -04:00
Raymond Chandler
e4d807108c
CID: 1210646
2014-04-30 18:47:02 -04:00
Raymond Chandler
3abcee7142
unused
2014-04-30 18:36:44 -04:00
Michael Jerris
6add88b43f
check return value for es_say_general_count
2014-04-30 16:43:35 -04:00
Michael Jerris
23b3e172d5
don't leak file handle if fd = 0
2014-04-30 15:56:36 -04:00
Michael Jerris
6f16e0d3da
don't leak if first realloc fails but second one succeeds
2014-04-30 15:53:26 -04:00
Michael Jerris
068ad205b7
split this into 2 functions so its clear if this function allocates or not
2014-04-30 15:48:23 -04:00
Michael Jerris
942215637a
make sure receive buffer is always null terminated
2014-04-30 13:49:58 -04:00
Michael Jerris
ac9741b579
don't leak xml string in dl_logger
2014-04-30 13:44:59 -04:00
Michael Jerris
0b8d2c5d65
add better bounds checking in dtmf_accepting array to avoid buffer overrun in mod_voicemail_ivr
2014-04-30 13:31:06 -04:00
Michael Jerris
a9a852477a
fix read beyond buffer length error
2014-04-30 13:25:29 -04:00
Chris Rienzo
c36e63026c
mod_http_cache: CID 1025858: Thread deadlock (ORDER_REVERSAL)
2014-04-30 10:08:00 -04:00
Michael Jerris
e98045841e
gracefully handle allocation failure
2014-04-30 08:55:39 -04:00
Michael Jerris
2e8572acb5
we always have the session in the dialplan function
2014-04-30 08:51:52 -04:00
Michael Jerris
b3bfa563ae
we always have the caller profile at this point, if for some reason we don't just instead of crashing
2014-04-30 08:50:29 -04:00
Michael Jerris
7508481597
we always have the seesion in the app function
2014-04-30 08:46:11 -04:00
Michael Jerris
9bf98d0dd3
remove useless checks of array == 0
2014-04-30 08:43:57 -04:00
William King
af32ca00e3
Correction to commit 0ba59aa6c2d252886eb4889c5d37fe114e07b4f4 using the correct variable in tel uri param parsing for mod_sofia
2014-04-29 15:23:24 -07:00
Michael Jerris
529099f15c
silence incorrect warnings about null pointer derference and remove unused code
2014-04-29 14:34:49 -04:00
Michael Jerris
4828ecd7fd
remove unused variable
2014-04-28 15:00:22 -04:00
Michael Jerris
95d4d0031c
don't set variable we don't use, and fix off by 1 buffer overflow in 1 case
2014-04-28 14:46:05 -04:00
Michael Jerris
dbaf49926c
remove unnecessary null check, we would have crashed already if that strdup failed
2014-04-28 14:38:38 -04:00
Brian West
5c07c3eb03
don't use memory after free when using naptr with mod_enum with multiple routes
2014-04-28 13:03:09 -05:00
Michael Jerris
a83fde3543
block of code in here twice was writing over expanded, causing it to potentially leak
2014-04-28 13:41:48 -04:00
Anthony Minessale
cc06d9181b
FS-4779 FS-6467 the behaviour from 4479 is now masked behind the param 3pcc-reinvite-bridged-on-ack FS-6467 please test master
2014-04-28 22:10:14 +05:00
Michael Jerris
1affd78204
we only call this with values, and it would crash if you passed it null anyways, just assert to make it 100% clear
2014-04-26 15:41:34 -04:00
Michael Jerris
abd7882d18
contact->m_url is an array, don't check array for zero as its useless
2014-04-26 15:35:27 -04:00
Michael Jerris
96c6abbe69
Fix buffer overrun that could have been exploited with a crafted skinny packet designed to exploit this mistake in bounds checking.
2014-04-26 15:29:01 -04:00
Georgiewskiy Yuriy
2e45fc0619
fix memory leaks, tanks to Sharath from packetizer forum.
2014-04-26 04:49:35 +04:00
Brian West
1aa2fc7548
FS-3332 --resolve
2014-04-25 15:53:21 -05:00
William King
0ba59aa6c2
Expanding on 052638186b2784c4142089008adf4289d40c80bc to support boolean tel url params in mod_sofia
2014-04-25 13:49:59 -07:00
William King
f27fe7ed08
BNPH-6470 follow up to commit 68d863a179c90d2524f8e761dedb3aebd09c3e75 removing the original line that performed the curl request to avoid a double request in mod_xml_curl
2014-04-25 12:11:09 -07:00
Brian West
68d863a179
FS-6470
2014-04-25 11:50:06 -05:00
Brian West
7e15c938e2
FS-6482 --resolve
2014-04-24 14:05:18 -05:00
William King
bcc2aa9899
Fixing memory leak that would occur when reloading mod_xml_curl
2014-04-24 09:13:00 -07:00
Anthony Minessale
4def48b881
revert
2014-04-24 20:58:23 +05:00
Anthony Minessale
2e0cd74e07
FS-6477 --resolve
2014-04-22 23:51:44 +05:00
Anthony Minessale
61e22e8b50
FS-6476 --resolve
2014-04-22 23:25:41 +05:00
