Natanael Copa
317f4b1442
Fix building with musl libc
...
POSIX says poll.h and signal.h should not be prefixed with sys/ (ie
poll.h instead of sys/poll.h)
limits.h also defines a TZNAME_MAX so we change name of the define for
spandsp.
2014-05-02 11:20:36 -04:00
Travis Cross
fc40e4ab79
Avoid leaking data_buf in mod_conference
...
When we couldn't acquire the rwlock on the conference we were leaking
a buffer we just allocated. On a 48k/10ms conference we would leak
960 bytes per attempt.
2014-05-02 03:48:10 +00:00
Michael Jerris
db1a2de186
don't null check what we know won't be null
2014-05-01 19:00:24 -04:00
Michael Jerris
2e3558c43e
don't need to double check for null
2014-05-01 18:50:26 -04:00
Michael Jerris
582fa1a664
fix typo
2014-05-01 18:22:57 -04:00
Travis Cross
cd650f6055
Use system ldns library
...
This library is used only by mod_enum and is available on most
platforms. The version in our tree has many code quality problems
that are generating noise when doing static analysis. Suffice it to
say we want rid of it as our responsibility.
FS-353
2014-05-01 22:01:59 +00:00
Travis Cross
c1f884cd33
Remove old ldns patch from FS-3110
2014-05-01 22:01:59 +00:00
Raymond Chandler
33460064ac
CID: 1210739
2014-05-01 17:34:54 -04:00
Raymond Chandler
a4e0929ef0
CID: 1210596
2014-05-01 17:28:54 -04:00
Raymond Chandler
17f79bc2c3
CID: 1210770
2014-05-01 16:36:58 -04:00
Anthony Minessale
7f18b80e60
FS-6503 --resolve remove unused code
2014-05-02 01:28:12 +05:00
Brian West
c462ed6ae1
FS-6499 --resolve
2014-05-01 15:21:57 -05:00
Brian West
d06b137abd
FS-6498 --resolve
2014-05-01 15:20:28 -05:00
Michael Jerris
64f1098b8c
remove dead assignment
2014-05-01 14:17:06 -04:00
Michael Jerris
b0fd845786
remove dead assignment
2014-05-01 14:04:56 -04:00
Michael Jerris
d4ba268f29
remove dead assignment
2014-05-01 13:52:12 -04:00
Travis Cross
4ec5e5af47
Refactor if blocks
...
Since the first branch doesn't need to do anything, we invert it and
pull a sub-branch out a level into the main conditional.
2014-04-30 23:23:06 +00:00
Travis Cross
ae3cf0a1a9
Remove dead assignment
...
...now this code needs refactoring.
2014-04-30 23:22:13 +00:00
Travis Cross
2ae823fb9f
Drop dead assignments
...
We goto done at the end of these blocks.
2014-04-30 23:03:06 +00:00
Raymond Chandler
e4d807108c
CID: 1210646
2014-04-30 18:47:02 -04:00
Travis Cross
fd4364cd43
Drop dead assignment
2014-04-30 22:43:33 +00:00
Travis Cross
946db55b34
Drop dead assignments
2014-04-30 22:42:08 +00:00
Raymond Chandler
3abcee7142
unused
2014-04-30 18:36:44 -04:00
Travis Cross
f38ccbfb51
Remove dead assignment, but why...
...
This assignment isn't doing anything, so it safe to remove it, but
there remains the question of whether there could have been some
actually necessary intention behind this line.
2014-04-30 22:33:24 +00:00
Travis Cross
0f6e364e61
Drop dead assignment
2014-04-30 22:33:24 +00:00
Travis Cross
b9b5b0d827
Avoid dead assignment of return value of execv
...
execv(3) only returns on error, and will always return -1 in that
case.
2014-04-30 22:33:24 +00:00
William King
5f3e98beb4
Fix a use after free in a 'theoretical' case in switch_cache_db_persistant_execute_trans_full where the pre_trans_execute statement fails, but SQLSetAutoCommitAttr succeeds
2014-04-30 14:37:17 -07:00
Michael Jerris
6add88b43f
check return value for es_say_general_count
2014-04-30 16:43:35 -04:00
Michael Jerris
ef18915ca5
make sure old_pid_buffer is null terminated
2014-04-30 16:36:14 -04:00
Michael Jerris
23b3e172d5
don't leak file handle if fd = 0
2014-04-30 15:56:36 -04:00
Michael Jerris
6f16e0d3da
don't leak if first realloc fails but second one succeeds
2014-04-30 15:53:26 -04:00
Michael Jerris
068ad205b7
split this into 2 functions so its clear if this function allocates or not
2014-04-30 15:48:23 -04:00
Michael Jerris
942215637a
make sure receive buffer is always null terminated
2014-04-30 13:49:58 -04:00
Michael Jerris
ac9741b579
don't leak xml string in dl_logger
2014-04-30 13:44:59 -04:00
Michael Jerris
0b8d2c5d65
add better bounds checking in dtmf_accepting array to avoid buffer overrun in mod_voicemail_ivr
2014-04-30 13:31:06 -04:00
Michael Jerris
a9a852477a
fix read beyond buffer length error
2014-04-30 13:25:29 -04:00
Michael Jerris
e57484af9b
FS-6497: --resolve fix for loop initial declaration not allowed
2014-04-30 12:16:02 -04:00
Chris Rienzo
c36e63026c
mod_http_cache: CID 1025858: Thread deadlock (ORDER_REVERSAL)
2014-04-30 10:08:00 -04:00
Michael Jerris
e98045841e
gracefully handle allocation failure
2014-04-30 08:55:39 -04:00
Michael Jerris
2e8572acb5
we always have the session in the dialplan function
2014-04-30 08:51:52 -04:00
Michael Jerris
b3bfa563ae
we always have the caller profile at this point, if for some reason we don't just instead of crashing
2014-04-30 08:50:29 -04:00
Michael Jerris
7508481597
we always have the seesion in the app function
2014-04-30 08:46:11 -04:00
Michael Jerris
9bf98d0dd3
remove useless checks of array == 0
2014-04-30 08:43:57 -04:00
William King
af32ca00e3
Correction to commit 0ba59aa6c2d252886eb4889c5d37fe114e07b4f4 using the correct variable in tel uri param parsing for mod_sofia
2014-04-29 15:23:24 -07:00
Michael Jerris
529099f15c
silence incorrect warnings about null pointer derference and remove unused code
2014-04-29 14:34:49 -04:00
Anthony Minessale
d0de8c0bc6
add heartbeat_use_scheduler variable to force the heartbeat to use the scheduler rather than the media stream and also make it auto-chage between modes when going in and out of the media path
2014-04-29 04:20:51 +05:00
Michael Jerris
6e41898517
this should never happen, but just in case, this will at least calm coverity
2014-04-28 16:30:19 -04:00
Michael Jerris
7e2499355a
handle null 'status' passed to 'switch_channel_perform_presence' more gracefully
2014-04-28 16:21:45 -04:00
Michael Jerris
a5f680810d
only enable passthru_ptime_mismatch when set to a true value, not when it is set to any value
2014-04-28 16:17:56 -04:00
Michael Jerris
d9b5bfaa7f
only enable passthru_ptime_mismatch when set to a true value, not when it is set to any value
2014-04-28 16:12:10 -04:00
