Commit Graph

1168 Commits

Author SHA1 Message Date
Andrey Volk 1ff5a6593c [Core] switch_rtp.c: Coverity 1500271, 1500287: Out-of-bounds access (OVERRUN) 2024-07-30 02:31:10 +03:00
Andrey Volk b43ae84564 [Core] switch_rtp_create: Coverity 1227620 Calling risky function 2024-07-30 00:16:15 +03:00
Andrey Volk b38d879413 [Core] rtp_common_write: Coverity 1227609 Calling risky function 2024-07-29 17:02:42 +03:00
Andrey Volk 93072c9503 [core] check_rtcp_and_ice() - stringop-overflow: Fix build on Debian Bookworm. 2024-07-25 21:46:40 +03:00
Jakub Karolczyk 6ea8c96c3d [Core] Reject DTLS packets coming from a source different than the current ICE negotiated path. 2023-12-21 22:56:32 +00:00
Jakub Karolczyk 48608177d7 [core] Fix missing 192 key lengths 2023-12-13 00:27:59 +03:00
Jakub Karolczyk 104c0b3fec [core] Fix flopping routes on ICE negotiation 2023-10-12 12:15:46 +00:00
Andrey Volk c4115537e0
[Core] Coverity: Use of 32-bit time_t
* [Core] Coverity: 1500270 Use of 32-bit time_t

* [Core] Coverity: 1500229 Use of 32-bit time_t

* [Core] Coverity: 1500235 Use of 32-bit time_t

* [Core] Coverity: 1500244 Use of 32-bit time_t

* [Core] Coverity: 1500250 Use of 32-bit time_t

* [Core] Coverity: 1500245 Use of 32-bit time_t

* [Core] Coverity: 1500255 Use of 32-bit time_t

* [Core] Coverity: 1500370 Use of 32-bit time_t

* Cleanup
2023-10-04 18:24:16 +03:00
Matteo ffadaffdd8
[core] Use auto DH params with openssl3
Co-authored-by: Matteo Brancaleoni <matteo.brancaleoni@voismart.it>
2023-08-11 14:33:40 +03:00
jpfox156 00818e7b25
[Core] OpenSSL 3 support 2023-07-24 21:56:46 +03:00
Andrey Volk 0f445e1ddd
[core, mod_opus] more elastic jitterbuffer with Opus codec
* [core, mod_opus] more elastic jitterbuffer with Opus codec

* [Core] JB: Fix crash on null channel

* [Core] JB: Fix target_seq race in check_jb_size()

* Code cleanup

---------

Co-authored-by: Julien Chavanton <jchavanton@gmail.com>
2023-07-21 20:03:00 +03:00
Jakub Karolczyk 55f2dc4759
[core] Coverity fixes
* [core] Coverity CID 1024233 (Dereference before null check)

* [core] Coverity CID 1024239 (Dereference before null check)

* [core] Coverity CID 1024242 (Dereference before null check)

* [core] Coverity CID 1024243 (Dereference before null check)

* [core] Coverity CID 1024453 (Dereference before null check)

* [core] Coverity CID 1024554 (Logically dead code)

* [core] Coverity CID 1024868 (unchecked return value from library)

* [core] Coverity CID 1024869 (unchecked return value from library)

* [core] Coverity CID 1468281 (Dereference before null check)

* [core] Coverity CID 1024238 (Dereference before null check)

* [core] Coverity CID 1468621 (Copy into fixed size buffer)

* [core] Coverity CID 1024871 (Unchecked return value)
2023-07-21 13:49:40 +03:00
Andrey Volk 34f1d974f5 Revert "[core, mod_opus] more elastic jitterbuffer with Opus codec (#2069)"
This reverts commit 67840823c1.
2023-07-12 18:18:17 +03:00
Jakub Karolczyk ab211c542a
Merge pull request #2140 from signalwire/fix_vars_not_used
[core,miniupnpc,modules] Fix not used variables
2023-07-05 13:18:15 +01:00
Jakub Karolczyk 5656972bfe [core,miniupnpc,modules] Fix not used variables 2023-07-04 10:18:16 +01:00
Jakub Karolczyk a160eced99 [core,libyuv,modules] Fix function declarations without a prototype 2023-07-04 09:56:40 +01:00
Julien Chavanton 67840823c1
[core, mod_opus] more elastic jitterbuffer with Opus codec (#2069) 2023-06-23 16:45:31 +03:00
Dragos Oancea b5cb26dc47
[Core] Coverity fixes
* [core] coverity CID 1024482 (Dereference after null check)

* [core] coverity CID 1468368 (Logically dead code)

* [core] coverity CID 1468459 (Logically dead code)

* [core] coverity CID 1232742 (Dereference before null check)
2023-04-18 19:30:22 +03:00
Dragos Oancea 73ea37c5ab
[Core] Coverity fixes
* [core] coverity CID 1320751 (Dereference before null check)

* [core] coverity CID 1294546 (Unchecked return value)

* [core] coverity CID 1227661 (Logically dead code)

* [core] coverity CID 1227656 (Logically dead code)

* [core] coverity CID 1060948 (Explicit null dereferenced)

* [core] coverity CID 1346465 (Unchecked return value)

* [core] coverity CID 1364953 (Logically dead code)

* [core] coverity CID 1468210 (Dereference before null check)

* [core] coverity CID 1468546 (Dereference before null check)

* [core] coverity CID 1468342 (Dereference before null check)
2023-04-05 18:54:11 +03:00
Dragos Oancea 48b8b0c4d7
[Core] Coverity fixes
* [core] coverity CID 1395504 (Logically dead code)

* [core] coverity CID 1395581 (Dereference before null check)

* [core] coverity CID 1346451 (Improper use of negative value)

* [core] coverity CID 1395497 (Dereference before null check)

* [core] coverity CID 1468458 (Dereference before null check)
2023-03-29 19:08:18 +03:00
Tomasz Ostrowski 01d3b3c0e3
[Core] ICE: fix wrong buffer size being passed and unitialized buffer 2023-03-23 21:15:41 +03:00
Dragos Oancea 8e59603d98 [core][mod_sofia] remove ZRTP (deemed obsolete).
[unit-tests][build-system][docs] remove references to ZRTP.
2022-10-28 20:19:42 +03:00
Chris Rienzo 85d25e269b [core] use fspr prefixed symbols instead of apr 2022-08-29 20:17:10 +03:00
Andrey Volk 56b6e954cf [Core] Fix dead nested assignments 2022-08-09 23:29:31 +03:00
Dragos Oancea beffab1d68 [core] RTP: a media timeout fix + add pcap based-unit tests. 2022-06-29 18:20:27 +03:00
Dragos Oancea 7fb158ae6a [core] RTP: remove unfulfillable conditions involving timer. add missing LF to DEBUG log line. 2022-02-21 22:53:02 +03:00
Dragos Oancea ae272359f4 [core] Handling RTCP MUX resulting in gaps
(fix proposed by Leon de Rooij)
2022-02-21 15:18:45 +02:00
Dragos Oancea 68039d344d [core] fix build SWITCH_BYTE_ORDER == __BIG_ENDIAN 2021-10-26 08:42:58 +00:00
Anthony Minessale 8c351a4667 [core, mod_verto] double udp buffer for audio, add verto command for video refresh 2021-10-23 22:01:00 +03:00
Dragos Oancea 013894ac33 [core] RTP: remove redundant condition when checking payload type of incoming packets. 2021-10-23 22:00:57 +03:00
Dragos Oancea ce9905cdf4 [core] don't hangup call on SRTP errors (new default behaviour) 2021-10-23 22:00:55 +03:00
Anthony Minessale 6040f3bf48 [Core] Fix ICE and media delay. 2021-10-23 22:00:52 +03:00
Andrey Volk a065460e5f [Core] Fix possible deadlock of an rtp_session in handle_ice() 2021-10-23 22:00:51 +03:00
Anthony Minessale a33062c9d8 [mod_verto] verto re-invites part 1 2021-10-23 22:00:19 +03:00
Anthony Minessale dc4bef79ec [core]speed up call setup 2021-10-23 22:00:18 +03:00
Dragos Oancea b2a8f9ce9f [core] change estimator CUSUM design params for loss to reduce oscillations. rename var. 2021-10-23 22:00:09 +03:00
Dragos Oancea af095ebb68 [core] scan-build: Dereference of null pointer (loaded from variable 'flags') 2021-10-19 20:35:09 +03:00
Ryan Mitchell 607f5db140 [core] add SEND_RTCP_MESSAGE:
toggle send rtcp events off fire_rtcp_events.
eval most common path first when checking flags.
2021-10-01 13:46:34 +00:00
Noah Mehl d24280c700 [core] Add SEND_RTCP_MESSAGE
We utilize: https://github.com/sipcapture/hepipe.js to monitor RTCP for our calls. As such, it's super helpful to get the sent RTCP data along with the received RTCP data. The new: SEND_RTCP_MESSAGE basically mirrors the existing RECV_RTCP_MESSAGE.
2021-10-01 13:46:34 +00:00
Dragos Oancea bb7bf86bb9 [core] print SRTP lib version at init. 2021-09-27 16:42:37 +03:00
Andrey Volk 9376db0aae [Core] Fix FreeSWITCH crashes caused by race conditions when working with Secure RTP. 2021-07-26 10:05:09 +03:00
Norm Brandinger 0877bd5770
[Core] switch_rtp: fix switch_rtp_set_max_missed_packets logging
Warning message about missed packets is misleading.
Message indicates greater (>) however, the conditional is greater than or equals (>=).
The message prints the value of rtp_sesstion->missed_count twice instead of printing the value of rtp_session->max_missed_packets.
2021-04-16 17:24:51 +03:00
Dragos Oancea 7fc5d9a7c3 [core] RTP: handle flush for incoming stream with DTX or packet loss. 2021-04-15 16:37:08 +03:00
Andrey Volk 0cab42bfb6 [Core] Hangup call instead of crashing system on SSL_CTX_new failure. Improve logging. 2021-03-22 18:52:04 +03:00
Dragos Oancea 2e65ca908d [core] rtp: fix #ifdef DEBUG_TS_ROLLOVER (#357) 2021-03-22 18:50:12 +03:00
Alexander Traud 48c4db71c2 [core] Allow other (D)TLS Curves/Groups beside P-256
Five years ago, commit 8e1b2ea enabled ECDHE for the DTLS server by hard-coding P-256. Released before that, OpenSSL 1.0.2, allows auto selection of the curve (P-256, P-384, and P-512). OpenSSL 1.1.x has this enabled on default, which adds groups/curves like X25519 and X448 automatically. This change here allows DTLS clients with a demand for Security Level 4 (192 bit) and 5 (256 bit) connecting to the DTLS server.
2021-03-19 01:00:56 +03:00
Andrey Volk 23321373ed [Core] Fix double close of a socket in switch_rtp 2021-03-16 22:15:33 +03:00
Seven Du 409b21b3e6 [core] debug socket sendto 2020-12-16 22:59:43 +08:00
Andrey Volk 1c0e7070bc [Core] Fix leak of BIO_METHOD *dtls_bio_filter_methods in switch_rtp_add_dtls() 2020-07-09 21:51:06 +04:00
Andrew Cassidy 3130a51182 [Core] Add AEAD_AES_128_GCM and AEAD_AES_256_GCM ciphers support. 2020-06-22 16:26:22 +04:00