12254 Commits

Author SHA1 Message Date
Seven Du
ead290870a fix compiler warning for implicit convertion 2014-06-01 08:09:49 +08:00
Travis Cross
79a888de2c Revert addition of PERL_GCC_PEDANTIC to CFLAGS
Brian and I decided to handle this by just stripping -ansi -pedantic
from the mod_perl build instead.

Revert "Since we can't tell if the system perl was built with
pedantic, we have a problem because we default debug enabled which
uses AX_CFLAGS_WARN_ALL_ANSI, For the GNU CC compiler it will be
-Wall (and -ansi -pedantic) The result is added to the shellvar being
CFLAGS by default.  Which then gets included for building mod_perl,
Either way I think this is the correct corse of action to overcome
these new builds of mod_perl."

This reverts commit cb94340e268466d19f41961f3b435897994ec1fa.
2014-05-30 15:40:46 +00:00
Travis Cross
750e2bae36 Build mod_perl without pedantic flags even when debugging
This means we don't have to set PERL_GCC_PEDANTIC which removes
assertions that are helpful for debugging.
2014-05-30 15:37:14 +00:00
Brian West
cb94340e26 Since we can't tell if the system perl was built with pedantic, we have a problem because we default debug enabled which uses AX_CFLAGS_WARN_ALL_ANSI, For the GNU CC compiler it will be -Wall (and -ansi -pedantic) The result is added to the shellvar being CFLAGS by default. Which then gets included for building mod_perl, Either way I think this is the correct corse of action to overcome these new builds of mod_perl. 2014-05-29 21:13:07 -05:00
Michael Jerris
6092524f17 CID:1174726 Dereference before null check, CID:1214199 Dereference null return value; refactor channel_outgoing_channel to have failure conditions first to reduce indenting level 2014-05-29 21:59:26 +00:00
Travis Cross
b53a6c2b2e Remove unused assignment
If we don't find it, we create a new one, and if we do find it, we
don't use it.
2014-05-29 16:01:09 +00:00
William King
2b0c9a1482 FS-6560 --resolve 2014-05-29 08:37:21 -07:00
Travis Cross
609982cf2f Remove redundant check for null
We're asserting now, and we would have already blown up from
dereferencing earlier.
2014-05-29 14:25:49 +00:00
Travis Cross
6663692ff7 Assert on implied failure to malloc
switch_event_expand_headers should only return null on a malloc
failure, so we might as well just assert here.
2014-05-29 14:24:48 +00:00
Travis Cross
e66d24622a Fix potential dereference of null pointer
The node could conceivably disappear before we grab the globals mutex
and we'd get back a null pointer.
2014-05-29 14:11:33 +00:00
Travis Cross
17137d089d Add missing parenthesis pair
This would have briefly prevented setting outbound_per_cycle from the
mod_fifo config file.
2014-05-29 13:21:22 +00:00
Travis Cross
84fe7b0794 Remove tautological condition check
We already decided to goto end if node is null, so it cannot be null
here.
2014-05-29 13:15:44 +00:00
Travis Cross
bf59d57dab Add missing parenthesis pair
This would have briefly caused the importance value in the fifo config
file to be ignored.
2014-05-29 13:10:23 +00:00
Travis Cross
a976badec7 Document the length limit of fifo_outbound_uuid
Ask me sometime how I was "reminded" of this.
2014-05-28 17:04:46 +00:00
Anthony Minessale
5138f4d5a7 add new stub module mod_rtc dummy signaling-free media engine endpoint 2014-05-28 07:31:24 +05:00
Travis Cross
00b25baa42 mod_fifo: Explain session message unbridge constant 2014-05-28 01:32:11 +00:00
Travis Cross
144fea57b2 mod_fifo: Add missing has_outbound to docstring 2014-05-28 01:32:11 +00:00
Travis Cross
42e9615900 mod_fifo: Add missing tab completions 2014-05-28 01:32:10 +00:00
Travis Cross
06805452d8 mod_fifo: Cleanup documentation formatting 2014-05-28 01:32:10 +00:00
Travis Cross
431d7d97c7 mod_fifo: Document effect of fifo strategy and importance 2014-05-28 01:32:10 +00:00
Travis Cross
96012ffb3a mod_fifo: Document the enterprise strategy 2014-05-28 01:32:10 +00:00
Travis Cross
e2596b3f30 mod_fifo: Document the ringall strategy 2014-05-28 01:32:09 +00:00
Travis Cross
1b5a1c1e1d mod_fifo: Document find_consumers() 2014-05-28 01:32:09 +00:00
Travis Cross
0c25c3deb9 mod_fifo: Document node_thread_run() 2014-05-28 01:32:09 +00:00
Travis Cross
80ccaf3450 mod_fifo: Remove duplicate check in ringall strategy
We already checked the number of usable rows, and nothing has changed.
2014-05-28 01:32:08 +00:00
Travis Cross
343aee2dd8 mod_fifo: Comment manual call tracking session handler 2014-05-28 01:32:08 +00:00
Travis Cross
48acd9fe66 mod_fifo: Note source of unexplained constant 2014-05-28 01:32:08 +00:00
Travis Cross
a24b0b739f mod_fifo: Avoid getting time twice
We were simply discarding unused the first time we retrieved here.
2014-05-28 01:32:07 +00:00
Travis Cross
64144d73a3 mod_fifo: Refactor to avoid a memory allocation 2014-05-28 01:32:07 +00:00
Travis Cross
011882c8dd mod_fifo: Cleanup line spacing 2014-05-28 01:32:07 +00:00
Travis Cross
a5f982fd1c mod_fifo: Replace duplicate code with node_caller_count() 2014-05-28 01:32:06 +00:00
Travis Cross
597a5c1208 mod_fifo: Remove empty declaration 2014-05-28 01:32:06 +00:00
Travis Cross
edecd151a5 mod_fifo: Document the read_frame_callbacks 2014-05-28 01:32:06 +00:00
Travis Cross
42ebfbfc59 mod_fifo: Document the fifo_queue_t structure 2014-05-28 01:32:06 +00:00
Travis Cross
5f4ed9c123 mod_fifo: Document fifo_chime_data::list 2014-05-28 01:32:05 +00:00
Travis Cross
2c7c15261d mod_fifo: Document caller DTMF handler 2014-05-28 01:32:05 +00:00
Travis Cross
3e6199eace mod_fifo: Remove reimplementation of strchr() 2014-05-28 01:32:05 +00:00
Travis Cross
27b3ddcc9f mod_fifo: Document the consumer DTMF callback 2014-05-28 01:32:04 +00:00
Travis Cross
7920630c8f mod_fifo: Refactor DTMF exit key matching 2014-05-28 01:32:04 +00:00
Travis Cross
c34ad2c0ec mod_fifo: Avoid getting a var when we won't use it 2014-05-28 01:32:04 +00:00
Travis Cross
077579b131 mod_fifo: Document fifo_queue_popfly() 2014-05-28 01:32:03 +00:00
Travis Cross
b914c2374d mod_fifo: Document fifo_queue_pop_nameval() 2014-05-28 01:32:03 +00:00
Travis Cross
1eaf4b50ca mod_fifo: Document remove parameter of fifo_queue_pop() 2014-05-28 01:32:03 +00:00
Travis Cross
e241477860 mod_fifo: Tighten up some whitespace 2014-05-28 01:32:03 +00:00
Travis Cross
e677da5870 mod_fifo: Refactor in create_node() 2014-05-28 01:32:02 +00:00
Travis Cross
628b6c19ab mod_fifo: Remove dead code
We were making a copy of the fifo name and stripping any domain name,
but then not using the value.
2014-05-28 01:32:02 +00:00
Travis Cross
6105e9783c mod_fifo: Refactor load_config()
Reduce number of local variables where possible; consolidate lines.
2014-05-28 01:32:02 +00:00
Travis Cross
353c3b19fa mod_fifo: Document fifo_node::outbound_name 2014-05-28 01:32:01 +00:00
Travis Cross
17070e9dac mod_fifo: Improve strategy thread function names 2014-05-28 01:32:01 +00:00
Travis Cross
1f7589d6fa mod_fifo: Refactor 2014-05-28 01:32:01 +00:00