94 Commits

Author SHA1 Message Date
Andrey Volk
068f4c8524 [sofia-sip] Fix multiple issues reported by scan-build. 2020-02-13 21:11:18 +04:00
Dragos Oancea
f72d755487 [sofia-sip] scan-build: Value stored to 'invite_timeout' is never read - nua_invite_client_request() 2020-02-12 17:57:40 +00:00
Mike Jerris
4e930fb089 FS-11452: [sofia-sip] handle 200/183 w/ sdp receivied out of order quickly 2019-02-18 17:06:53 -05:00
Anthony Minessale
87a4670d16 FS-6890 #comment please test 2014-11-12 13:09:39 -06:00
Anthony Minessale
46e74e5853 revert 831832c2c62aaec9039bfc5e2d081b960d5856f4 2014-11-05 09:26:44 -06:00
Anthony Minessale
831832c2c6 FS-6890 #please test 2014-11-04 18:31:44 -06:00
Michael Jerris
cfd8d28bc8 silence clang unused function warnings and get rid of some unused functions 2014-05-01 09:03:19 -04:00
Anthony Minessale
bce51017fb FS-6462 --resolve
I found a problem here but it may not completely match your expectations.
I reviewed the RFC 4028 and checked against the code and I discovered we should not be putting a Min-SE in any response at all besides a 422:

section 5:

   The Min-SE header field MUST NOT be used in responses except for
   those with a 422 response code.  It indicates the minimum value of
   the session interval that the server is willing to accept.

I corrected this problem and implemented the 422 response so if you request a value lower than the minimum specified for the profile.
If the value is equal or higher to the minimum, it will be reflected in the Session-Expires header in the response and no Min-SE will be present.
2014-04-17 04:26:43 +05:00
Michael Jerris
340b697e1b FS-6341: --resolve add 3pcc invite w/o sdp support for 100rel/PRACK 2014-03-17 12:27:42 -04:00
Anthony Minessale
bbe1fe1a31 FS-6005 --resolve 2013-11-27 10:20:35 -06:00
Anthony Minessale
e8f3e42f8b FS-4779 try this patch 2012-11-08 09:52:20 -06:00
Anthony Minessale
63e2044a7e modify sofia debug code to print file, line numbers and function name 2012-10-26 14:15:14 -05:00
Anthony Minessale
bb69310259 FS-4079 FS-4540 please update to this version 2012-08-15 22:51:41 -05:00
Anthony Minessale
b553d62fbd add sip_require_timer=true variable to enable require timer on session refresh that breaks finicky endpoints 2012-04-26 10:35:02 -05:00
Michael Jerris
7d3816dbea silence set but not used 2012-04-25 15:19:47 -04:00
Michael Jerris
ba4280e61f try to add a tag to disable timer autorequire NUTAG_TIMER_AUTOREQUIRE(0) 2012-04-25 15:15:32 -04:00
Anthony Minessale
58c3c3a049 comment out optional Require header from re-invites for the sake of interop with testy t.38 terminals 2011-11-22 18:22:57 -06:00
Anthony Minessale
a19352aa23 FS-3688 revert 2011-11-18 17:01:03 -06:00
Anthony Minessale
2fae5dfadd FS-3688 please do clean build and test make current or the equiv 2011-11-17 11:44:10 -06:00
Anthony Minessale
d68605f5ae FS-3394 --resolve edge case in the 3rd party sofia sip stack library when dealing with a malformed contact and missing ack. Will push upstream to sofia devs 2011-07-06 15:11:26 -05:00
Marc Olivier Chouinard
626a99f994 sofia-lib: More Fix for -Wunused-but-set-variable required compiler. (Might need to be ported back to sofia) 2011-04-23 20:33:19 -04:00
Anthony Minessale
c1acebdb42 patch incomplete multipart parsing code 2010-06-01 17:13:32 -05:00
Michael Jerris
a7f4892887 sofia-sip: extend timeout for session expires on short timeouts to be 90% of timeout instead of 1/3 to handle devices that do not refresh in time such as polycom (SFSIP-212) 2010-05-31 09:50:44 -04:00
Anthony Minessale
aaa822ba79 SFSIP-197
git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@16534 d0543943-73ff-0310-b7d9-9358b9ac24b2
2010-01-28 20:35:17 +00:00
Anthony Minessale
516db24b75 SFSIP-180 report hack in sofia lib to pekka for better answer
git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@15190 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-10-21 23:01:37 +00:00
Anthony Minessale
4d9f7de25b FSCORE-471 and any other update related bugs
git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@15186 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-10-21 18:48:28 +00:00
Michael Jerris
aefcb7d0a0 Tue Jul 7 19:00:00 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: made INFO a general-purpose method


git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@14186 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-07-10 00:48:06 +00:00
Michael Jerris
ebccde01bd Thu Jun 25 12:25:56 CDT 2009 Pekka Pessi <first.last@nokia.com>
* check_session.c: check correct non-support for 100rel

Thu Jun 25 12:26:46 CDT 2009  Pekka Pessi <first.last@nokia.com>
  * nua_session.c: if 100rel is not supported by nua, do not Require it in response
  
Thu Jun 25 12:33:45 CDT 2009  Pekka Pessi <first.last@nokia.com>
  * check_session.c: cleaned test for SFSIP-125

  Fixes SFSIP-125



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13960 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-06-25 18:46:14 +00:00
Michael Jerris
61c23ee5d1 Wed May 13 13:39:29 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_stack_ack(), nua_invite_client_ack(): cleaned code
  Ignore-this: 9edf1594e20f27f4e2effb43c83858ea
    
  Fixed clean-up after ACK.
  
  Coverity issue.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13353 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-05-15 16:18:10 +00:00
Michael Jerris
71f7c7ff11 Wed May 13 12:04:15 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_update_server_report(): fix bugs checking pending INVITEs in fake precondition handling
  Ignore-this: dc67f6287bf48aa8e2a39e2ece96821
  
  Coverity issue.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13343 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-05-15 16:10:38 +00:00
Michael Jerris
a0b8810d89 Tue May 12 13:07:45 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: check dialog usage before using it in nua_update_server_respond()
  Ignore-this: 543e8d6d999a5a4d54600f1dbdfb1444
  
  Coverity issue 7312.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13328 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-05-15 15:57:37 +00:00
Michael Jerris
27c334d8e0 Tue May 12 13:00:40 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: removed dead code from process_prack()
  Ignore-this: 325e40cbba4e6933aa1681d6862533f
  
  Coverity issue.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13326 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-05-15 15:53:31 +00:00
Michael Jerris
584ae7db64 Tue May 12 11:57:49 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: doublecheck invite client transaction
  Ignore-this: 4236b668c99e6e0d72a7889ce6cdf671
  
  Coverity issue.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13325 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-05-15 15:52:14 +00:00
Michael Jerris
672e48f8c8 Tue May 12 11:52:32 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: always clean and remove INVITE client request in nua_invite_client_ack()
  Ignore-this: bdace77be7b43629b591f5adf7315341
  
  Coverity issue.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13324 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-05-15 15:50:43 +00:00
Michael Jerris
0e45cc850f Tue May 12 11:05:19 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua: NUTAG_AUTOACK(0) is now obeyed always when media is disabled
  Ignore-this: c5960a8330904eae5a1428158e4498c7
  
  If media is enabled, stack autoacks 2XX responses to re-INVITEs unless
  NUTAG_AUTOACK(0) is set on handle.
  
  Also documenting NUTAG_AUTOACK() behaviour with re-INVITEs.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13320 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-05-15 15:45:39 +00:00
Michael Jerris
0d3db88c5b Tue May 12 12:08:13 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: include Session-Expires to session refresh requests
  
  Thanks for Linus Surguy for reporting the problem.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13318 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-05-15 15:43:28 +00:00
Anthony Minessale
a1bca1e12e make info work out of dialog
git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13087 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-04-20 19:00:03 +00:00
Michael Jerris
59478dd599 Thu Apr 16 12:04:08 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_client, nua_session: avoid restarting in-progress transactions
  
  This is supposed to fix bugs #SFSIP-135 and #SFSIP-137. Thanks for Tamas
  Jalsovszky and kawarod for reporting the problem.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13062 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-04-16 17:18:56 +00:00
Michael Jerris
5278050e61 Wed Apr 8 16:37:43 CDT 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: do not restart CANCEL requests
  Ignore-this: 2c9d51bbafca2256630a0ea73982abea
  
  Fixes FreesWitch bug SFSIP-134, reported by vile, initial patch by Mike
  Jerris.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@13061 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-04-16 15:00:42 +00:00
Michael Jerris
b5ea56318d Thu Feb 26 15:39:37 CST 2009 Pekka Pessi <first.last@nokia.com>
* nua/check_simple.c: removed extra debug logging, fixed 6.3.4 name



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@12376 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-03-03 17:20:24 +00:00
Michael Jerris
6376b4b705 Tue Feb 10 07:03:27 CST 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: fixed race condition with ACK
  Ignore-this: 37d3e74b169e8a154b9734dbade74d84
  
  Response message got destroyed after sending ACK if stack was run in
  multithreaded mode.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@11872 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-02-11 17:38:16 +00:00
Michael Jerris
73b6ee94a3 Thu Jan 29 12:32:12 CST 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: do not add Min-SE header if not needed



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@11863 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-02-11 17:22:54 +00:00
Michael Jerris
5baf8d20b6 Fri Jan 16 07:42:29 CST 2009 Pekka Pessi <first.last@nokia.com>
* nua: fixed problems with route set handling
  
  RFC 3261 allows the route set changes while dialog is in early state.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@11834 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-02-11 17:07:09 +00:00
Michael Jerris
fa2fe6a216 Tue Jan 13 14:59:50 CST 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: send answer in ACK if offer was sent in 200 OK to re-INVITE
  
  Thanks for Liu Yang for reporting the problem.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@11813 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-02-11 16:55:11 +00:00
Michael Jerris
31367efd3b Thu Jan 8 14:52:37 CST 2009 Pekka Pessi <first.last@nokia.com>
* nua: using <sofia-sip/su_string.h> functions



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@11800 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-02-11 16:49:25 +00:00
Michael Jerris
906fbd4ecf Fri Jan 9 10:33:14 CST 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: when negotiating session refresher, default to UAC



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@11783 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-02-11 16:23:10 +00:00
Michael Jerris
c2f5696a8a Mon Jan 5 06:31:12 CST 2009 Pekka Pessi <first.last@nokia.com>
* nua_session.c: default to initiate session refreshes
  
  Use local refresher unless remote end explicitly indicates that it takes
  care of refreshing the session. Bug reported and initial patch by Timo
  Bruhn.



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@11771 d0543943-73ff-0310-b7d9-9358b9ac24b2
2009-02-11 16:12:35 +00:00
Michael Jerris
e5c185a842 fixed whitespace
git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@10833 d0543943-73ff-0310-b7d9-9358b9ac24b2
2008-12-16 21:23:37 +00:00
Michael Jerris
10c6c9dbb8 Thu Nov 27 06:09:44 CST 2008 Pekka Pessi <first.last@nokia.com>
* nua_session.c: use signed ss_sdp_version (soa_get_user_version() returns int)



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@10832 d0543943-73ff-0310-b7d9-9358b9ac24b2
2008-12-16 21:22:43 +00:00
Michael Jerris
7f70d131ff Fri Nov 21 08:12:28 CST 2008 Pekka Pessi <first.last@nokia.com>
* nua_session.c: call soa_activate() only when nh->nh_soa is valid



git-svn-id: http://svn.freeswitch.org/svn/freeswitch/trunk@10830 d0543943-73ff-0310-b7d9-9358b9ac24b2
2008-12-16 21:21:04 +00:00