15987 Commits

Author SHA1 Message Date
Chris Rienzo
84eb4a0404 mod_rayo: re-added Makefile for iks helpers unit tests 2014-05-08 11:16:02 -04:00
Chris Rienzo
d7d4625866 mod_rayo: re-added Makefile for srgs unit tests 2014-05-08 11:14:20 -04:00
Chris Rienzo
752f7956f9 mod_rayo: fix compiler error to nlsml.c from attempted coverity fix 2014-05-08 11:10:42 -04:00
Michael Jerris
02f6269cf1 check for say errors in say_money functions 2014-05-07 13:18:21 -04:00
Anthony Minessale
2459e710f7 FS-6337 prevent over-frequent jb resets in bad conditions 2014-05-07 22:12:18 +05:00
William King
ee6f3da9ff CID: 1211948 fix memory leak of decoded iks message in function parse_plain_auth_message in mod_rayo 2014-05-07 00:44:54 -07:00
William King
2a50bbba68 CID: 1211950 fix memory leak of iksparser in function nlsml_parse in mod_rayo 2014-05-07 00:37:32 -07:00
William King
ad327dffc8 CID: 1211946 fixing uninitialized pointer read in mod_translate 2014-05-07 00:22:56 -07:00
Anthony Minessale
4a543b29a2 FS-6506 --resolve Technically when you are not using groups you do not add a <users> tag inside <domain> you just put several <user> tags in <domain> This patch will consume an extraneous <users> tag and move on making it work either way. 2014-05-07 00:06:02 +05:00
Michael Jerris
d6fe10979d remove opezap from tree, it has been replaced by freetdm 2014-05-06 11:05:54 -04:00
Michael Jerris
3ff3f327ee FS-6484: guess at fixing seg from mod_managed, this function should never be called without a channel, but if it does, throw an error instead 2014-05-05 19:19:03 -04:00
Anthony Minessale
0a2ba8869a sofia is treating all notify sending as if they were natted rather than when nat is detected. This causes issues on some polycoms that use strange ports in their contact for getting notifies that do not match the port the calls come from 2014-05-06 04:10:19 +05:00
Steve Underwood
38abcf7e2c The APIs for spandsp FAX have changes, removing one of the parameters passed in
the callbacks.
2014-05-04 17:22:28 +08:00
Michael Jerris
9db6d5ba9c different distros have diff pkg names 2014-05-02 18:35:37 -04:00
Michael MCGuinness
974cebd389 SIP-686 changed mod_say (en) to speak full dates when asked to speak a date in the future (rather than only weekday and time). 2014-05-02 14:48:09 -05:00
Anthony Minessale
607247397c FS-6413 update presence_epoch to lock to midnite 2014-05-02 23:49:46 +05:00
Natanael Copa
317f4b1442 Fix building with musl libc
POSIX says poll.h and signal.h should not be prefixed with sys/ (ie
poll.h instead of sys/poll.h)

limits.h also defines a TZNAME_MAX so we change name of the define for
spandsp.
2014-05-02 11:20:36 -04:00
Travis Cross
fc40e4ab79 Avoid leaking data_buf in mod_conference
When we couldn't acquire the rwlock on the conference we were leaking
a buffer we just allocated.  On a 48k/10ms conference we would leak
960 bytes per attempt.
2014-05-02 03:48:10 +00:00
Michael Jerris
db1a2de186 don't null check what we know won't be null 2014-05-01 19:00:24 -04:00
Michael Jerris
2e3558c43e don't need to double check for null 2014-05-01 18:50:26 -04:00
Michael Jerris
582fa1a664 fix typo 2014-05-01 18:22:57 -04:00
Travis Cross
cd650f6055 Use system ldns library
This library is used only by mod_enum and is available on most
platforms.  The version in our tree has many code quality problems
that are generating noise when doing static analysis.  Suffice it to
say we want rid of it as our responsibility.

FS-353
2014-05-01 22:01:59 +00:00
Travis Cross
c1f884cd33 Remove old ldns patch from FS-3110 2014-05-01 22:01:59 +00:00
Raymond Chandler
33460064ac CID: 1210739 2014-05-01 17:34:54 -04:00
Raymond Chandler
a4e0929ef0 CID: 1210596 2014-05-01 17:28:54 -04:00
Raymond Chandler
17f79bc2c3 CID: 1210770 2014-05-01 16:36:58 -04:00
Anthony Minessale
7f18b80e60 FS-6503 --resolve remove unused code 2014-05-02 01:28:12 +05:00
Brian West
c462ed6ae1 FS-6499 --resolve 2014-05-01 15:21:57 -05:00
Brian West
d06b137abd FS-6498 --resolve 2014-05-01 15:20:28 -05:00
Michael Jerris
64f1098b8c remove dead assignment 2014-05-01 14:17:06 -04:00
Michael Jerris
b0fd845786 remove dead assignment 2014-05-01 14:04:56 -04:00
Michael Jerris
d4ba268f29 remove dead assignment 2014-05-01 13:52:12 -04:00
Travis Cross
4ec5e5af47 Refactor if blocks
Since the first branch doesn't need to do anything, we invert it and
pull a sub-branch out a level into the main conditional.
2014-04-30 23:23:06 +00:00
Travis Cross
ae3cf0a1a9 Remove dead assignment
...now this code needs refactoring.
2014-04-30 23:22:13 +00:00
Travis Cross
2ae823fb9f Drop dead assignments
We goto done at the end of these blocks.
2014-04-30 23:03:06 +00:00
Raymond Chandler
e4d807108c CID: 1210646 2014-04-30 18:47:02 -04:00
Travis Cross
fd4364cd43 Drop dead assignment 2014-04-30 22:43:33 +00:00
Travis Cross
946db55b34 Drop dead assignments 2014-04-30 22:42:08 +00:00
Raymond Chandler
3abcee7142 unused 2014-04-30 18:36:44 -04:00
Travis Cross
f38ccbfb51 Remove dead assignment, but why...
This assignment isn't doing anything, so it safe to remove it, but
there remains the question of whether there could have been some
actually necessary intention behind this line.
2014-04-30 22:33:24 +00:00
Travis Cross
0f6e364e61 Drop dead assignment 2014-04-30 22:33:24 +00:00
Travis Cross
b9b5b0d827 Avoid dead assignment of return value of execv
execv(3) only returns on error, and will always return -1 in that
case.
2014-04-30 22:33:24 +00:00
William King
5f3e98beb4 Fix a use after free in a 'theoretical' case in switch_cache_db_persistant_execute_trans_full where the pre_trans_execute statement fails, but SQLSetAutoCommitAttr succeeds 2014-04-30 14:37:17 -07:00
Michael Jerris
6add88b43f check return value for es_say_general_count 2014-04-30 16:43:35 -04:00
Michael Jerris
ef18915ca5 make sure old_pid_buffer is null terminated 2014-04-30 16:36:14 -04:00
Michael Jerris
23b3e172d5 don't leak file handle if fd = 0 2014-04-30 15:56:36 -04:00
Michael Jerris
6f16e0d3da don't leak if first realloc fails but second one succeeds 2014-04-30 15:53:26 -04:00
Michael Jerris
068ad205b7 split this into 2 functions so its clear if this function allocates or not 2014-04-30 15:48:23 -04:00
Michael Jerris
942215637a make sure receive buffer is always null terminated 2014-04-30 13:49:58 -04:00
Michael Jerris
ac9741b579 don't leak xml string in dl_logger 2014-04-30 13:44:59 -04:00