3847 Commits

Author SHA1 Message Date
Travis Cross
0cc7bc8db6 Add missing CURLOPT_NOSIGNAL options
To work correctly in a multi-threaded environment, curl needs to be
used with CURLOPT_NOSIGNAL set to 1.  If it's left at zero, the
default, then curl will use signals to deal with timeouts which will
often result in a crash.

ref: http://curl.haxx.se/libcurl/c/libcurl-tutorial.html#Multi-threading
ref: http://curl.haxx.se/libcurl/c/CURLOPT_NOSIGNAL.html
ref: http://stackoverflow.com/questions/9191668/error-longjmp-causes-uninitialized-stack-frame
ref: https://bugzilla.redhat.com/show_bug.cgi?id=539809
ref: https://bugs.debian.org/cgi-bin/bugreport.cgi?bug=570436
2014-09-23 00:04:21 +00:00
Seven Du
f78007766b don't reset when video floor is locked
when video floor is locked by a member, changing audio floor on del_member
will cause the video floor lock cleared unexpectedly, this commit fixes that.
2014-09-16 19:15:12 +08:00
Travis Cross
622e0e1a6f Check for null hash on increment of mod_hash limit
When we specifically release all limits on a channel we destroy the
hash table stored in the "limit_hash" private channel data but we
don't destroy the private data as it will be reclaimed as part of the
session.  If limit increment is called after the limit release we can
reuse that channel private, but we need to check whether the hash
table is null first.  Fortunately this makes the code look better
anyway.

FS-6775 #resolve
FS-6783 #resolve
2014-09-11 17:47:57 +00:00
Anthony Minessale
ce5d21106e FS-6761 #resolve 2014-09-11 03:29:07 +05:00
Moises Silva
89e8e14a9f Improvements to mod_bert
* Honor the timer name variable

* Added mod_bert::in_sync event when the stream is in sync
2014-09-09 04:07:13 -04:00
Moises Silva
25c6276fea Added cng counter to the bert test app 2014-09-09 04:07:13 -04:00
Moises Silva
557a4a8580 Treat CNG as a silent frame in mod_bert 2014-09-09 04:07:12 -04:00
Moises Silva
58e47748ca Only use a timer if bert_timer_name is specified, otherwise time based on input 2014-09-09 04:07:12 -04:00
Moises Silva
cf2fd15211 Add BERT events for timeout and out of sync in mod_bert 2014-09-09 04:07:12 -04:00
Moises Silva
3248e06b91 Add timer to mod_bert to avoid relying on remote RTP for timing 2014-09-09 04:07:12 -04:00
Moises Silva
ef694513df Improvements to mod_bert
* Added BERT stats channel variables

* Check if the channel is going down when out of sync to avoid flagging it
  as out of sync, if the channel is going down it is expected to have some errors
2014-09-09 04:07:12 -04:00
Moises Silva
a84ce1dd3c Improvements to mod_bert
* Improve bert input debug
* Check for SFF_CNG and ignore those frames
2014-09-09 04:07:11 -04:00
Moises Silva
d3b214a672 Improvements to mod_bert
* Use digital milliwatt as the test sequence pattern
* Add debug IO files (enabled using bert_debug_io_file variable)
2014-09-09 04:07:11 -04:00
Moises Silva
a60876b165 Use a triangle wave in mod_bert 2014-09-09 04:07:11 -04:00
Moises Silva
66a9e12aa8 Improvements to mod_bert
* Calculate sampling error rate over a time window

* Create the following variables to control bert testing behavior:
  bert_timeout_ms - Milliseconds to wait for bert sync before timing out
  bert_window_ms - Window of time to calculate sampling error rate percentage
  bert_max_err - Max percentage of error tolerated before going out of sync
  bert_hangup_on_error - Hangup when error occurs (Timeout or going out of sync)
2014-09-09 04:07:11 -04:00
Moises Silva
fa3a1a0bdd Added mod_bert module 2014-09-09 04:07:02 -04:00
Andrew Cassidy
6753ccf65d Missed one of the variable changes! 2014-09-08 19:18:43 +01:00
Brian West
bb8e4bd1bb FS-6803 #resolve 2014-09-08 11:25:52 -05:00
Travis Cross
57bd4eb9bd Add valet_park ... auto out ... to syntax string
FS-5992 #resolve
2014-09-04 20:40:53 +00:00
Michael Jerris
56e4afb209 FS-6595: Enable pause_play and file_seek for conference member fnode #resolve 2014-09-04 15:56:15 -04:00
Travis Cross
7d11e19983 Check for null hash or private while holding lock
What if the hash were destroyed by one thread holding the lock while
another thread was waiting for the lock?  The waiting thread would
have already checked that the hash was non-null and would proceed on
that assumption after acquiring the lock.

With this commit we check only after acquiring the lock.

ref: FS-6783
ref: FS-6775
2014-09-03 19:45:45 +00:00
Travis Cross
82a28e76e4 Re-fix memory leak
After consideration, this still looks correct.

Thanks-to: Anthony Minessale <anthm@freeswitch.org>

ref: FS-6783
ref: FS-6775
2014-09-03 19:44:43 +00:00
Travis Cross
8c0a1d17e2 Reintroduce memory leak in mod_hash to avoid crash
ref: commit 3e24b3e2c2b28cc672943e75b009377d33f1b01b
ref: FS-6783
ref: FS-6775
2014-09-03 18:16:11 +00:00
Giovanni Maruzzelli
5c15e85ce4 mod_spandsp: added SWITCH_CURRENT_APPLICATION_RESPONSE_VARIABLE on application errors 2014-09-03 15:52:50 +02:00
Travis Cross
acb439ca03 Avoid leaking memory while iterating hash tables
`switch_core_hash_first` allocates an iterator on each call that is
never freed except when the hash table is empty.

By using `switch_core_hash_first_iter` we allocate only one iterator,
and that iterator is freed after the last item is processed.
2014-08-30 03:49:51 +00:00
Travis Cross
df559e0aac Add back goodness refactored out 2014-08-30 01:32:57 +00:00
Travis Cross
9481d9843c Fix comment spelling 2014-08-30 01:19:09 +00:00
Travis Cross
6f2eac6876 Fix comment spelling 2014-08-30 00:52:16 +00:00
Travis Cross
63f16425bd Refactor mod_hash limit_release_hash a bit 2014-08-29 21:44:04 +00:00
Brian West
3e24b3e2c2 FS-6775 #resolve 2014-08-29 09:55:00 -05:00
Travis Cross
dc88617c99 Lower log level of limit increases and releases
In some configurations where many limits are used, the limit increases
and releases were generating a lot of noise and making it harder to
see when limits were exceeded, which was at the same log level.
2014-08-28 01:40:36 +00:00
Anthony Minessale
0f1494ae06 Improve conference recording 2014-08-26 09:52:55 -05:00
Travis Cross
b2f59dd200 Add warning when using HTTPS with mod_curl
mod_curl currently does not verify the authenticity of the peer's
certificate, and does not verify whether the common name on the
certificate matches the server.  This makes mod_curl initiated TLS
connections completely insecure.  We should fix this, but until we do,
we'll warn people that it's not doing what they may think it is.

ref: http://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYPEER.html
ref: http://curl.haxx.se/libcurl/c/CURLOPT_SSL_VERIFYHOST.html
2014-08-21 22:24:04 +00:00
Travis Cross
f2ca3c5211 Decode params to curl_sendfile
`curl_sendfile` generates a multipart message with Content-Type:
multipart/form-data with no separate Content-Type headers in the parts
for each non-file argument.  These parts therefore default to
text/plain.  However, prior to this commit, we were putting the URL
encoded POST data into these parts, which is not correct.  We should
be putting raw text into the parts.

With this commit, we urldecode each argument key and value before
composing the multipart message.

See:

  http://www.w3.org/TR/html401/interact/forms.html#h-17.13.4.2
2014-08-20 10:37:24 +00:00
Brian West
8ebfca9e3d Merge pull request #24 in FS/freeswitch from ~STANGOR/freeswitch:master to master
* commit '4d0b875d4e7b2ee1fc8f30591b5c98c61080fae5':
  fix mod_fifo presence https://jira.freeswitch.org/browse/FS-6732
2014-08-14 14:02:27 -05:00
Mike Jerris
5eb01b519e Merge pull request #25 in FS/freeswitch from ~STEVEAYRE/freeswitch:master to master
* commit '05ef18948d3870c4afcd82ce32e164e4a152a8e1':
  add uptime api to mod_commands
2014-08-13 13:37:17 -05:00
Stan Gor
4d0b875d4e Merging in latest from upstream (FS/freeswitch:refs/heads/master)
* commit 'b60df39b96b05b6c3cf220d5049ea5fc20dfa6e1':
  mod_http_cache: fix configuration so that carriage returns or other whitespace is OK around S3 keys
  mod_http_cache: fixed S3 URL parser to allow mybucketsubdomain.com.s3.amazonaws.com
2014-08-12 22:08:44 -05:00
Chris Rienzo
b60df39b96 mod_http_cache: fix configuration so that carriage returns or other whitespace is OK around S3 keys 2014-08-12 16:28:42 -04:00
Chris Rienzo
3b45ef90ae mod_http_cache: fixed S3 URL parser to allow mybucketsubdomain.com.s3.amazonaws.com 2014-08-12 16:07:56 -04:00
Steven Ayre
05ef18948d add uptime api to mod_commands 2014-08-12 14:06:15 +01:00
stangor
c966dc865a fix mod_fifo presence
https://jira.freeswitch.org/browse/FS-6732
2014-08-11 14:08:10 -07:00
Brian West
aeced06c6c Merge pull request #23 in FS/freeswitch from ~DDRAGIC/freeswitch:fix_mod_blacklist to master
* commit 'fe2a6e8acae2e8104c9480361b1561ee3f120bf1':
  FS-6620 mod_blacklist fix not deleting entries from list
2014-08-11 14:54:42 -05:00
Travis Cross
8414c498cf Fix line endings per .gitattributes 2014-08-08 15:24:42 +00:00
Anthony Minessale
52ed525b97 fix channel count in embedded file formats 2014-08-06 00:25:04 +05:00
Dušan Dragić
fe2a6e8aca FS-6620 mod_blacklist fix not deleting entries from list 2014-08-03 11:51:46 +02:00
Anthony Minessale
fb274514df add switch_separate_file_params function so when using relative paths with bracketed params the full path can be constructed with the params in tact 2014-08-01 22:57:40 +05:00
Travis Cross
5a7144c44a Add DELETE request support to mod_curl 2014-07-31 04:07:36 +00:00
Anthony Minessale
004c5ab2b0 fix some issues with duplicate chat events and some cleanup 2014-07-24 22:58:12 +05:00
Brian West
d9eafdf0cb FS-6681: fix dup of audio/wav and add audio/x-wav 2014-07-24 08:30:44 -05:00
Anthony Minessale
7596689865 add chat to demo 2014-07-24 10:13:39 +05:00