William King
|
9ace496fe3
|
full_contact must be freed by sofia. There isn't a chance of this having blown anything up, but Coverity is right that this should be initialized with NULL to be safe against future refactors.
|
2013-05-18 19:13:18 -07:00 |
|
William King
|
d27a95a50e
|
Possible leak if someone were to try and add extra headers to a channel that had either an inbound info on that session or the session were to be deflected. I don't see a way that these extra headers could be added outside of a C module subscribing to the session states, but just to make sure I'm adding these so that just like other extra header locations it's cleaned up.
|
2013-05-18 17:00:41 -07:00 |
|
William King
|
f718a0572f
|
Alice meet rabit hole. There is a leak here on every invite that comes back from a status 180 when the other side is not FS, but you have presence enabled. Thanks to Coverity scan for location this condition. This 'might' not have been leaking if sofia was automatically freeing this when the sofia object was destroyed, but all other locations where sip_header_as_string where called they were all followed by a su_free, so I assume not.
|
2013-05-18 16:35:03 -07:00 |
|
William King
|
f519ad195a
|
If the mod_sofia global presense hash is null, then make sure to free the matches variable before going to done.
|
2013-05-18 16:05:40 -07:00 |
|
Anthony Minessale
|
ea881b191f
|
media/srtp refactoring pass
|
2013-05-17 15:39:30 -05:00 |
|
William King
|
8d7aa3ff65
|
FS-5441: --resolve
|
2013-05-17 12:39:17 -07:00 |
|
William King
|
58e205ccdb
|
how...?
|
2013-05-17 11:36:31 -07:00 |
|
William King
|
cfeb6aaf54
|
Since there isn't neutral ground, on the rtmp state callback we actually have to force the write lock of the session, but we only need a try lock on removing the session from the rsession->session_hash. This removes a deadlock caused when we had to enforce with locks that the rsession couldn't be destroyed if the FS session was in the middle of a hangup.
|
2013-05-17 11:36:30 -07:00 |
|
William King
|
f24d1cde3d
|
Seems the session wasn't coming to the hangup in a locked state.
|
2013-05-17 11:36:30 -07:00 |
|
William King
|
36f198e883
|
Seems having a read lock still prevents a write lock to be taken, even if the thread that is trying to get the write lock currently has the read lock.
|
2013-05-17 11:36:29 -07:00 |
|
William King
|
9b0212ab59
|
Include the write lock since we're changing the tech_pvt
|
2013-05-17 11:36:29 -07:00 |
|
Anthony Minessale
|
97faaab42c
|
FS-5430 --resolve
|
2013-05-15 09:27:18 -05:00 |
|
Anthony Minessale
|
1eae2a1941
|
FS-5410 --resolve
|
2013-05-13 13:15:33 -05:00 |
|
Raymond Chandler
|
bba4540fe5
|
add context
|
2013-05-10 16:31:12 -04:00 |
|
Anthony Minessale
|
cb7a6bd34b
|
FS-5085 the last change helped weed out the real bug which is this commit
|
2013-05-10 10:45:28 -05:00 |
|
Anthony Minessale
|
bb6b02f2d6
|
FS-5403 --resolve
|
2013-05-10 09:59:02 -05:00 |
|
Anthony Minessale
|
16690e491d
|
FS-5399 --resolve
|
2013-05-09 14:05:09 -05:00 |
|
Giovanni Maruzzelli
|
0330520eba
|
test 2, please ignore
|
2013-05-09 17:00:54 +00:00 |
|
root
|
0fe65187cd
|
test, please ignore
|
2013-05-09 16:59:39 +00:00 |
|
William King
|
9fa4bed8e3
|
FS-5395: False alarm on a reported valgrind memory leak. The io_private is alloc'd from a memory pool which valgrind sucks at tracking. No need to free this, because it'll get cleared when the memory pool on the rsession is destroyed.
|
2013-05-08 18:45:24 -07:00 |
|
William King
|
b3117e8f88
|
FS-5395: --resolve Resolve another mod_rtmp crash where oh specific hangup scenarios there would be a free of variable that wasn't ever malloced
|
2013-05-08 16:54:05 -07:00 |
|
Anthony Minessale
|
0a68bee88e
|
FS-5085 I discovered that the bowout is happening from both legs at once, we only need to check this condition on the A side of the loopback bridge
|
2013-05-08 13:17:07 -05:00 |
|
Brian West
|
7c0dc4c25d
|
Undo previous change
|
2013-05-08 14:40:10 -05:00 |
|
William King
|
0d5888de2f
|
Revert "fixed stuck mod_rtmp session when the call is killed from fs side, such as using uuid_kill"
This reverts commit d8edc031faa41d4e570aad1e347a0ed6c0d6c1d8.
Conflicts:
src/mod/endpoints/mod_rtmp/mod_rtmp.c
|
2013-05-07 16:04:54 -07:00 |
|
Anthony Minessale
|
01a748869d
|
regression parsing rtp-timeout-sec from the profile
|
2013-05-07 08:50:02 -05:00 |
|
Anthony Minessale
|
ff05e5f2c7
|
FS-5383 --resolve
|
2013-05-07 08:31:23 -05:00 |
|
Anthony Minessale
|
283e5f5f6a
|
FS-5365 --resolve
|
2013-05-03 13:14:01 -05:00 |
|
Anthony Minessale
|
adb68d6bca
|
FS-5085 adding this patch but still wondering what causes this issue
|
2013-05-03 12:30:35 -05:00 |
|
Anthony Minessale
|
44840fc97a
|
fix regression in sofia profile param for t38-passthru
|
2013-05-02 22:36:39 -05:00 |
|
William King
|
7ce7cbda57
|
FS-4332: --resolve
|
2013-05-03 00:01:24 -05:00 |
|
William King
|
17781cba1c
|
FS-5240: --resolve Please test
|
2013-05-02 23:57:50 -05:00 |
|
Anthony Minessale
|
9ef0323499
|
FS-5355 --resolve
|
2013-04-29 10:09:14 -05:00 |
|
Anthony Minessale
|
c4e7c302f9
|
FS-5351 --resolve
|
2013-04-27 08:19:18 -05:00 |
|
Seven Du
|
5b9318c109
|
FS-4990 change uuid_debug_audio to uuid_debug_media and add video params
|
2013-04-27 06:47:06 +08:00 |
|
Anthony Minessale
|
7a42ec06df
|
RTP stats were not being logged. There is no JIRA on this sigh
|
2013-04-26 09:31:28 -05:00 |
|
Brian West
|
88a13a7580
|
FS-5316 --resolve
|
2013-04-25 13:48:02 -05:00 |
|
Brian West
|
d5ec949142
|
Add application layer keepalive options to sofia and expose config options
|
2013-04-25 13:34:07 -05:00 |
|
Anthony Minessale
|
eeeb4fa445
|
FS-5340 --resolve
|
2013-04-24 16:35:58 -05:00 |
|
William King
|
66d1755b06
|
If the rsession is null, then don't try to unlock it, since that'll just result in a segfault.
|
2013-04-23 17:52:33 -07:00 |
|
William King
|
5c87754e42
|
fixed rtmp active calls count
|
2013-04-23 17:52:33 -07:00 |
|
William King
|
1dd86108fb
|
added rsession check before comparing its state. commented out active sessions loop
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
f7cb641d17
|
Updating the contributor tags
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
6f89e2537e
|
Moving all rtmp specific logging to use the rtmp uuid rather than the session uuid.
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
fa6d465711
|
Another variable name standardization
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
e379a596b2
|
Should resolve the last of the rsession -> session and session -> rsession on_destroy race condition issues
Conflicts:
src/mod/endpoints/mod_rtmp/mod_rtmp.c
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
fec463fdfe
|
White space cleanup and variable naming standardization
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
ad3a5a3572
|
Standardizing on rsession to reference rtmp_session_t
Conflicts:
src/mod/endpoints/mod_rtmp/mod_rtmp.c
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
7e1aad02b2
|
Resolve the segfault where the channel is destroyed while it is still receiving audio
Conflicts:
src/mod/endpoints/mod_rtmp/rtmp.c
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
a687274308
|
Cleaning up and standardizing variable name to rsession if the session referenced is an rtmp_session_t
|
2013-04-23 17:52:32 -07:00 |
|
William King
|
f81d17c1e2
|
added debugging to print ip and port of rtmp connection as well as tie the rtmp session and fs session together
|
2013-04-23 17:52:31 -07:00 |
|