Commit Graph

26764 Commits

Author SHA1 Message Date
Michael Jerris dbaf49926c remove unnecessary null check, we would have crashed already if that strdup failed 2014-04-28 14:38:38 -04:00
Brian West 5c07c3eb03 don't use memory after free when using naptr with mod_enum with multiple routes 2014-04-28 13:03:09 -05:00
Michael Jerris a83fde3543 block of code in here twice was writing over expanded, causing it to potentially leak 2014-04-28 13:41:48 -04:00
Michael Jerris 59734d8e15 add bounds check to keep rtcp packets with > 5 report blocks from creating a buffer overrun 2014-04-28 13:32:01 -04:00
Anthony Minessale cc06d9181b FS-4779 FS-6467 the behaviour from 4479 is now masked behind the param 3pcc-reinvite-bridged-on-ack FS-6467 please test master 2014-04-28 22:10:14 +05:00
Michael Jerris e3b4e6b227 fix deref before null check 2014-04-28 13:01:12 -04:00
Michael Jerris 1174413115 remove unused variable 2014-04-28 12:41:04 -04:00
Anthony Minessale c51b55a46e FS-6491 --resolve
This seems to be a paradox when running a perl script from a session then executing perl again on the same session from a different thread.
I fixed it by converting any execution of perl in the execute_on_* family of operators to only run background mode which is to store the command in the session stack to be executed only by the session thread instead of on the spot by the outide thread.  changing the execute_on_answer to perl::/path/to/script.pl would also eliminate the crash in code that has not been updated with this patch.

This is just a limitation of embedded perl we have to live with.
2014-04-28 21:19:48 +05:00
William King 0d8f954e09 fixing commit a710841123 in switch_config
Previous commit actually broke the functionality since it was now returning if cfg->path[0] was not null.
Also since cfg->path can never be null, this check can be simplified to only check the first index.
2014-04-28 08:46:48 -07:00
Michael Jerris 60bc7dae9f check return value of switch_vasprintf 2014-04-28 09:54:20 -04:00
Michael Jerris 553dd9bdcf fix assigned but never used issue and code cleanup for readability 2014-04-28 09:47:30 -04:00
Michael Jerris 1affd78204 we only call this with values, and it would crash if you passed it null anyways, just assert to make it 100% clear 2014-04-26 15:41:34 -04:00
Michael Jerris abd7882d18 contact->m_url is an array, don't check array for zero as its useless 2014-04-26 15:35:27 -04:00
Michael Jerris 96c6abbe69 Fix buffer overrun that could have been exploited with a crafted skinny packet designed to exploit this mistake in bounds checking. 2014-04-26 15:29:01 -04:00
Georgiewskiy Yuriy 2e45fc0619 fix memory leaks, tanks to Sharath from packetizer forum. 2014-04-26 04:49:35 +04:00
Brian West 1aa2fc7548 FS-3332 --resolve 2014-04-25 15:53:21 -05:00
William King 0ba59aa6c2 Expanding on 052638186b to support boolean tel url params in mod_sofia 2014-04-25 13:49:59 -07:00
William King f27fe7ed08 BNPH-6470 follow up to commit 68d863a179 removing the original line that performed the curl request to avoid a double request in mod_xml_curl 2014-04-25 12:11:09 -07:00
Brian West 68d863a179 FS-6470 2014-04-25 11:50:06 -05:00
Brian West 7e15c938e2 FS-6482 --resolve 2014-04-24 14:05:18 -05:00
Anthony Minessale d171e156d7 fix issues with heartbeat in bypass media mode 2014-04-24 23:21:15 +05:00
William King bcc2aa9899 Fixing memory leak that would occur when reloading mod_xml_curl 2014-04-24 09:13:00 -07:00
Anthony Minessale 4def48b881 revert 2014-04-24 20:58:23 +05:00
Anthony Minessale 2e0cd74e07 FS-6477 --resolve 2014-04-22 23:51:44 +05:00
Anthony Minessale 61e22e8b50 FS-6476 --resolve 2014-04-22 23:25:41 +05:00
Chris Rienzo 25c9b6196b mod_rayo: preserve old caller ID behavior if display name is not given 2014-04-22 13:30:15 -04:00
Chris Rienzo 1eab82ba2d mod_rayo: relax recent caller ID restrictions a bit 2014-04-22 08:50:50 -04:00
Michael Jerris ba6b9c5a11 ESL-91: --resolve bigger buffer for args 2014-04-21 13:33:47 -04:00
Travis Cross 175c9eebca Remove extraneous abort(3) when sending chat
This appears to have been accidentally added in commit
79ebcb104b which sought to provide a
mechanism for disabling Sofia's chat interface.  The abort(3) here
achieved that a bit too well.
2014-04-19 19:26:27 +00:00
Anthony Minessale 79ebcb104b add enable-chat sofia profile param which defaults to true when not present, set to false to turn off the chat interface in sofia 2014-04-19 12:29:10 -05:00
Travis Cross f408dae2af Drop pinned memcached file download from debian 2014-04-19 06:29:24 +00:00
Travis Cross 59fd9b90d0 Correct display of last write timestamp
On start DTMF packets we were showing the last write timestamp as a
signed value when it's an unsigned value, which could result in it
appearing incongruous with later packets where the value was displayed
correctly.
2014-04-19 01:48:49 +00:00
Brian West 6e8729a159 OPENZAP-222 --resolve 2014-04-18 15:18:41 -05:00
Brian West 265de3d314 FS-6082 --resolve 2014-04-18 15:17:23 -05:00
Brian West bf093e9dc1 Dispatch will call you on register, and call you back if you hangup on next register 2014-04-17 20:35:57 -05:00
Brian West 8ce6198bf9 fix bug in dispatch 2014-04-17 20:19:39 -05:00
Brian West 190c241c81 FS-6452 mod_spy doesn't react on events without variable_domain_name 2014-04-17 20:12:27 -05:00
Anthony Minessale 18df083c69 don't send heartbeat until the first timeout has elapsed rather than instantly 2014-04-18 00:06:24 +05:00
Seven Du 37ee4299fb fix compiler warning 2014-04-17 14:58:18 +08:00
Anthony Minessale cbd20d8a05 update 2014-04-17 04:33:02 +05:00
Anthony Minessale bce51017fb FS-6462 --resolve
I found a problem here but it may not completely match your expectations.
I reviewed the RFC 4028 and checked against the code and I discovered we should not be putting a Min-SE in any response at all besides a 422:

section 5:

   The Min-SE header field MUST NOT be used in responses except for
   those with a 422 response code.  It indicates the minimum value of
   the session interval that the server is willing to accept.

I corrected this problem and implemented the 422 response so if you request a value lower than the minimum specified for the profile.
If the value is equal or higher to the minimum, it will be reflected in the Session-Expires header in the response and no Min-SE will be present.
2014-04-17 04:26:43 +05:00
Anthony Minessale 2bc2811050 FS-5997 regression from commit 70accd9f27 this caused some attended transfers to calls with multiple targets to get the abondoned channels to be stuck on write lock 2014-04-17 02:41:40 +05:00
William King 748b7dea3c Get rid of a small memory leak when the configs are reloaded in mod_enum 2014-04-16 09:27:34 -07:00
Anthony Minessale a4a792488b add generic keepalive system and implement it in sofia to send MESSAGE or INFO packets in-dialog at specified interval.
Adds app: enable_keepalive 0|<seconds>
This app can be run in the dialplan or with execute_on_* type variables for B-legs.

Adds sofia param: keepalive-method  : defaults to MESSAGE can also be "INFO"
This param sets which SIP method to use.
2014-04-16 06:10:25 +05:00
Chris Rienzo ae69c5a7b0 FS-6407 --resolve mod_rayo: support SIP URI caller ID w/ display name 2014-04-15 14:27:49 -04:00
Raymond Chandler 052638186b add parsing of user params on invite 2014-04-15 12:48:07 -04:00
Anthony Minessale b99ef3af01 add SWITCH_MESSAGE_HEARTBEAT_EVENT indication to execute on a session when session heartbeat fires 2014-04-15 21:22:36 +05:00
Nathan Neulinger 96523a9bef mod_skinny: fix leak 2014-04-14 15:04:06 -05:00
Nathan Neulinger 93a84cf130 FS-6460 --resolve fix leaked RTP ports that cause mod_skinny to fail after N calls 2014-04-14 13:23:05 -05:00
Chris Rienzo e8078d8aef mod_rayo: clean up module hashes on shutdown 2014-04-14 12:01:31 -04:00