The clamp(v,a,b) function wraps v around the interval [a,b).
However prior to this commit, `clamp` was ignoring the third argument
and using the second argument again in its place. This resulted in a
division by zero. Hence `clamp` didn't work at all.
Even if the arguments were treated correctly, `clamp` incorrectly
multiplied rather than added whenever v < a. This would have produced
bogus results. (Thanks to Shona McNeill for pointing this out.)
Note that as implemented, `clamp` is undefined for b >= a.
These errors are present in the last upstream C version, v2.7.
They've been corrected in the C++ version that upstream now maintains
instead.
Thanks-to: Shona McNeill <prufrax@googlemail.com>
FS-7070 #resolve
The following values can be read from the event:
sync_lost_percent - Error percentage within the analysis window
sync_lost_count - How many times sync has been lost
cng_count - Counter of confort noise packets
err_samples - Number of samples that did not match the sequence
* commit 'f63f8686bc8da391b3c46b24e10571215c8b377f':
FS-7049 - Documentation for state optional paramenter in callcenter_config queue list and count
fix FS-7049 - Count and list agents based on their state
Previously the `timeout` option to the curl API command set only
`CURLOPT_CONNECTTIMEOUT` -- the maximum amount of time that curl will
wait to connect to the server. If the server accepted the connection
but then never replied, curl would wait essentially forever. There
was no way to set `CURLOPT_TIMEOUT` -- the maximum amount of time the
entire request operation is allowed to take.
With this change, the `timeout` option sets `CURLOPT_TIMEOUT`. We've
earlier added a `connect-timeout` option to set
`CURLOPT_CONNECTTIMEOUT`.
This is a change to existing behavior. However, it's likely that this
is what people expected it to do all along. The curl application
call, for example, accepts both `curl_connect_timeout` and
`curl_timeout` channel variables, with the latter setting
`CURLOPT_TIMEOUT`.
If people really were relying on this odd behavior, we'll rename the
option with the new behavior to something else and come up with a
transition plan.
This patch does the following:
* only starts MOH if no other file (sync or async) is currently playing
* adds a variable "conference_permanent_wait_mod_moh" that controls the
behavior of how the enter and exit sounds interact with the MOH when
wait_mod is set. When the variable is set, the MOH keeps playing and
the enter and exit sounds are mixed with the MOH. When the variable
is unset, then any playing MOH is first stopped, then the enter or
exit sound is played and the MOH is started again.
This functionality is useful in case the enter and exit sounds are
used to announce the name of the caller, who is joining or leaving a
conference.
FS-5159 #resolve
If the member do an attended transfer this loop stops and
the agent is set to Available state again, when in fact he still
busy with other channel.
This was happening, for example, when a member calls support queue, then
the support operator do an attended transfer to sales queue, while the sales
operator is talking the member that was transferred, the sales queue will
send calls to the operator, which is not expected.
This patch allows conference flags to be set dynamically from the
dial plan by either passing them to the conference application in
the +flags{ } string or by setting the "conference_flags" dial plan
variable.
The +flags{ } string is currently used to set *user* flags only.
This patch changes this by allowing the +flags{ } string to contain
conference related flags as well (for example wait_mod). It shouldn't
be a problem to pass both types of flags via +flags{ } as long as
the user and conference flag names are kept unique.
FS-5099 #resolve
when video floor is locked by a member, changing audio floor on del_member
will cause the video floor lock cleared unexpectedly, this commit fixes that.
