Compare commits

...

3 Commits

Author SHA1 Message Date
Ahron Greenberg (agree)
b159ff922b
Merge 759cd5ea35c5f6a788ec121e7926eaa468574279 into 5cb74797fe996b706be1dc29d1096c7baefdfbfb 2025-01-17 16:41:26 +00:00
Aron Podrigal
5cb74797fe
[mod_pgsql] err is now set correctly (dbh:last_error())
New function, `void pgsql_handle_set_error_if_not_set(switch_pgsql_handle_t *handle, char **err)` has been added to mod_pgsql module. This function is now called at several points where an error occurred but *err was not yet set.
2025-01-17 18:51:45 +03:00
agree
759cd5ea35
[core] Fix bug on originate_delay_start delays more than once
When `switch_ivr_originate` is called with endpoints as the user endpoint that also calls `switch_ivr_originate`, freeswitch will wait for the `originate_delay_start` duration every time `switch_ivr_originate` is called.
2023-09-23 23:51:38 -04:00
2 changed files with 30 additions and 1 deletions

View File

@ -106,6 +106,22 @@ char * pgsql_handle_get_error(switch_pgsql_handle_t *handle)
return err_str; return err_str;
} }
void pgsql_handle_set_error_if_not_set(switch_pgsql_handle_t *handle, char **err)
{
char *err_str;
if (err && !(*err)) {
err_str = pgsql_handle_get_error(handle);
if (zstr(err_str)) {
switch_safe_free(err_str);
err_str = strdup((char *)"SQL ERROR!");
}
*err = err_str;
}
}
static int db_is_up(switch_pgsql_handle_t *handle) static int db_is_up(switch_pgsql_handle_t *handle)
{ {
int ret = 0; int ret = 0;
@ -553,8 +569,15 @@ switch_status_t pgsql_handle_exec_detailed(const char *file, const char *func, i
goto error; goto error;
} }
return pgsql_finish_results(handle); if (pgsql_finish_results(handle) != SWITCH_STATUS_SUCCESS) {
goto error;
}
return SWITCH_STATUS_SUCCESS;
error: error:
pgsql_handle_set_error_if_not_set(handle, err);
return SWITCH_STATUS_FALSE; return SWITCH_STATUS_FALSE;
} }
@ -630,6 +653,7 @@ done:
pgsql_free_result(&result); pgsql_free_result(&result);
if (pgsql_finish_results(handle) != SWITCH_STATUS_SUCCESS) { if (pgsql_finish_results(handle) != SWITCH_STATUS_SUCCESS) {
pgsql_handle_set_error_if_not_set(handle, err);
sstatus = SWITCH_STATUS_FALSE; sstatus = SWITCH_STATUS_FALSE;
} }
@ -638,6 +662,7 @@ done:
error: error:
pgsql_free_result(&result); pgsql_free_result(&result);
pgsql_handle_set_error_if_not_set(handle, err);
return SWITCH_STATUS_FALSE; return SWITCH_STATUS_FALSE;
} }
@ -1050,6 +1075,8 @@ switch_status_t pgsql_handle_callback_exec_detailed(const char *file, const char
return SWITCH_STATUS_SUCCESS; return SWITCH_STATUS_SUCCESS;
error: error:
pgsql_handle_set_error_if_not_set(handle, err);
return SWITCH_STATUS_FALSE; return SWITCH_STATUS_FALSE;
} }

View File

@ -2334,6 +2334,8 @@ SWITCH_DECLARE(switch_status_t) switch_ivr_originate(switch_core_session_t *sess
tmp--; tmp--;
} }
} }
switch_event_del_header(var_event, "originate_delay_start");
} }
if (oglobals.session) { if (oglobals.session) {