kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2026-06-11 05:01:47 +00:00
Code Issues Packages Projects Releases Wiki Activity

channelstorage_cpp: Fix fallback return value in channelstorage callback

Browse Source 
callback returned the last iterated channel when no match existed, causing invalid channel references and potential double frees. Updated to correctly return NULL when there is no match.

Resolves: #1609
This commit is contained in:
phoneben
2025-11-26 14:00:21 +02:00
committed by Asterisk Development Team
parent 1fea182543
commit 182531cfdd
1 changed files with 2 additions and 3 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
main/channelstorage_cpp_map_name_id.cc
View File

@@ -172,9 +172,8 @@ static struct ast_channel *callback(struct ast_channelstorage_instance *driver,
rdlock(driver);
}
for (it = getdb(driver).begin(); it != getdb(driver).end(); it++) {
chan = it->second;
if (cb_fn(chan, arg, data, ao2_flags) == (CMP_MATCH | CMP_STOP)) {
ao2_bump(chan);
if (cb_fn(it->second, arg, data, ao2_flags) == (CMP_MATCH | CMP_STOP)) {
chan = ao2_bump(it->second);
break;
}
}