kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2026-05-17 20:42:50 +00:00
Code Issues Packages Projects Releases Wiki Activity

res_stir_shaken: fix memory free crash when Asterisk is built with malloc_debug

Browse Source 
crypto_utils uses ast_asprintf to allocate the search string when checking the
certificate subject, but was not using ast_free to free it. This caused a crash
when Asterisk was built with malloc_debug

Resolves: #1921
This commit is contained in:
Mike Bradeen
2026-05-06 16:33:43 -06:00
parent ef48f4cf7d
commit 7ea1aaf8e1
1 changed files with 7 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

9
res/res_stir_shaken/crypto_utils.c
View File

@@ -917,9 +917,15 @@ time_t crypto_asn_time_as_time_t(ASN1_TIME *at)
char *crypto_get_cert_subject(X509 *cert, const char *short_name)
{
size_t len = 0;
/* buffer is allocated via open_memstream, which is outside of Asterisk's
memory management. It therefore must be freed via ast_std_free to
remain independent of MALLOC_DEBUG */
RAII_VAR(char *, buffer, NULL, ast_std_free);
/* search is allocated via ast_asprintf, which is within Asterisk's
memory management. It therefore must be freed via ast_free or will
cause a crash when used with MALLOC_DEBUG */
RAII_VAR(char *, search, NULL, ast_free);
char *search_buff = NULL;
char *search = NULL;
size_t search_len = 0;
char *rtn = NULL;
char *line = NULL;
@@ -971,7 +977,6 @@ char *crypto_get_cert_subject(X509 *cert, const char *short_name)
}
}
ast_std_free(search);
return rtn;
}