kenmirrors/asterisk
1
0
Fork 0
mirror of https://github.com/asterisk/asterisk.git synced 2025-09-05 12:16:00 +00:00
Code Issues Packages Projects Releases Wiki Activity

The other day when I went through making changes as a result of the ao2_link()

Browse Source 
change, I added some code to set pointers to NULL after they were unreferenced.
This pointed out that in this place, the object was unreferenced before the
code was done using it.  So, move the unref down a little bit.
(crash reported by jmls on IRC)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@90470 65c4cc65-6c06-0410-ace0-fbb531ad65f3
This commit is contained in:
Russell Bryant
2007-12-02 18:18:52 +00:00
parent 763b1ccecc
commit d208d0fc37
1 changed files with 3 additions and 2 deletions
Download Patch File Download Diff File Expand all files Collapse all files

5
apps/app_queue.c
View File

@@ -3038,8 +3038,6 @@ static int add_to_queue(const char *queuename, const char *interface, const char
if ((new_member = create_queue_member(interface, membername, penalty, paused))) {
new_member->dynamic = 1;
ao2_link(q->members, new_member);
ao2_ref(new_member, -1);
new_member = NULL;
q->membercount++;
manager_event(EVENT_FLAG_AGENT, "QueueMemberAdded",
"Queue: %s\r\n"
@@ -3056,6 +3054,9 @@ static int add_to_queue(const char *queuename, const char *interface, const char
new_member->penalty, new_member->calls, (int) new_member->lastcall,
new_member->status, new_member->paused);
ao2_ref(new_member, -1);
new_member = NULL;
if (dump)
dump_queue_members(q);