Commit Graph

11076 Commits

Author SHA1 Message Date
Russell Bryant
0072ea9933 Fix a place where a chan_iax2 pvt struct was accessed without the lock held.
This issue was reported to me via email by Dmitry Mishchenko.  Thanks!


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69069 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 16:29:12 +00:00
Russell Bryant
5aea57eed1 Fix a memory leak pointed out by prashant_jois in #asterisk-bugs. PQclear() was
not called on the result structure after doing a PQexec().  Also, fix up some
formatting in passing.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69016 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:40:17 +00:00
Joshua Colp
200248f687 Change the full frame dropping log message to debug to avoid future bug reports.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69014 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:36:29 +00:00
Joshua Colp
9d7dae818f Schedule the sending of a PING packet a second later than previously so that it does not collide with the LAGRQ.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69012 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:26:38 +00:00
Russell Bryant
3fb6ac7fb7 In ast_channel_make_compatible(), just return if the channels' read and write
formats already match up.  There are code paths that call this function on a
pair of channels multiple times.  This made calls fail that were using g729
in some cases.  The reason is that codec_g729a will unregister itself from the
list of available translators will all licenses are in use.  So, the first
time the function got called, the right translation path was allocated.
However, the second time it got called, the code would not find a translation
path to/from g729 and make the call fail, even if the channel actually already
had a g729 translation path allocated.

(SPD-32)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@69010 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 19:13:41 +00:00
Joshua Colp
8c01036a9f Merged revisions 68921 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68921 | file | 2007-06-12 10:18:57 -0400 (Tue, 12 Jun 2007) | 2 lines

Bring RTP back to Asterisk at the end of a native bridge no matter what.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68922 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 14:23:11 +00:00
Jason Parker
0f45225441 Solaris 10 sometimes (?) needs this include in order to have NULL defined.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68814 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 21:20:15 +00:00
Tilghman Lesher
53700fd145 Issue 9947 - fn2 was unused / incorrectly used
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68781 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 20:45:53 +00:00
Christian Richter
48f8dc5340 Merged revisions 68732 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68732 | crichter | 2007-06-11 18:49:00 +0200 (Mo, 11 Jun 2007) | 1 line

added check for NULL Pointer when calling misdn_new. Asterisk does not allow us to create channels anymore when stop gracefully is used :). also modified the restart_indicator to 0
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68733 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 16:57:59 +00:00
Joshua Colp
080acbfd16 Merged revisions 68682 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68682 | file | 2007-06-11 10:29:58 -0400 (Mon, 11 Jun 2007) | 2 lines

Improve deadlock handling of the channel list. (issue #8376 reported by one47)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68683 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 14:33:12 +00:00
Christian Richter
7d491a7c24 Merged revisions 68631 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68631 | crichter | 2007-06-11 11:18:01 +0200 (Mo, 11 Jun 2007) | 1 line

fixed problem that the dummybc chanels had no lock, checking for the lock now. Also fixed the channel restart stuff, we can now specify and restart particular channels too.
........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68644 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 10:29:18 +00:00
Tilghman Lesher
5ed9d5d64b "dialplan save" produced garbage in the config file
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68595 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 04:21:30 +00:00
Russell Bryant
337738d6d6 Merged revisions 68526 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68526 | russell | 2007-06-08 17:22:36 -0500 (Fri, 08 Jun 2007) | 4 lines

Don't automatically hang up after running Dictate so that callers can exit
cleanly using '#'
(closes issue #9577, patch from Thomas Andrews)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68527 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 22:23:22 +00:00
Kevin P. Fleming
f4b7a2c9cb actually remember the type/subclass of full frames that are in process
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68450 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 15:52:47 +00:00
Joshua Colp
058f617af9 Merged revisions 68397 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68397 | file | 2007-06-07 20:15:33 -0400 (Thu, 07 Jun 2007) | 2 lines

Don't call ast_waitstream_full when the control file descriptor and audio file descriptor are not set, simply call ast_waitstream! (issue #8530 reported by rickead2000)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 00:17:04 +00:00
Joshua Colp
14bde42bb6 Merged revisions 68368 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68368 | file | 2007-06-07 19:59:04 -0400 (Thu, 07 Jun 2007) | 2 lines

Do a DNS lookup immediately upon calling the dnsmgr function, don't wait until a refresh happens. (issue #9097 reported by plack)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68370 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 00:02:34 +00:00
Russell Bryant
08a7d6a06b Merged revisions 68351 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68351 | russell | 2007-06-07 18:13:33 -0500 (Thu, 07 Jun 2007) | 3 lines

Fix a problem where saying a character wouldn't properly break out when the caller pressed '#'
(issue #8113, reported by patbaker82, patch from jamesgolovich (hey, long time no see!) and patbaker82)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68354 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:14:45 +00:00
Jason Parker
30d9a8a20b Fix incorrect French syntax of "old messages".
Request for feedback was sent to asterisk-dev mailing list, with little response.

Issue 9118, patch by junky.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68326 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:00:01 +00:00
Kevin P. Fleming
e816700d6e some improvements to the IAX2 full frame dropping logic recently added:
- use inaddrcmp(), since we have it
- output the type of frame and subclass being dropped, and the type/subclass that is already being processed (which caused the drop)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68313 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 22:14:35 +00:00
Russell Bryant
e7cb53e8b2 Fix loading persistent queue members when using realtime configuration for queues.
Also, remove an unneeded leading slash for the astdb family.
(issue #9911, patch by atis)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 21:16:07 +00:00
Jason Parker
51f1d28d2d Fix an issue with newer phones which require packets be padded out to the correct length.
Issue 9887, patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68249 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:25:18 +00:00
Jason Parker
1d704b2857 Merged revisions 68204 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68204 | qwell | 2007-06-07 15:02:50 -0500 (Thu, 07 Jun 2007) | 4 lines

Don't try to save voicemail greetings unless the user presses '1' to accept/save.

Issue 9904, patch by me.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68211 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:06:00 +00:00
Mark Michelson
878e480ff8 Submitting a fix for Issue 8016. Added a check to make sure that greetings get stored properly.
(Issue 8016, reported by edhorton, patched by alamantia with modification by me. Thanks to Jason Parker
for the advice on this).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:47:42 +00:00
Olle Johansson
2d491b0eae Disable chan_features by default in menuselect
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68196 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:46:10 +00:00
Russell Bryant
452167fa3c Include stdarg.h for build issues on Solaris
(issue #9381)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 19:30:30 +00:00
Joshua Colp
ac65d7f143 Fix logic when doing a name based channel search for a structure when you want to start from a specific point in the channel list. (issue #9324 reported by slavon)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68157 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 18:39:52 +00:00
Joshua Colp
f07dfca43a Merged revisions 68070 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r68070 | file | 2007-06-07 10:19:40 -0400 (Thu, 07 Jun 2007) | 2 lines

Allow the 'g' option to work if used with the 'S' option. (issue #9888 reported by gasparz)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68071 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 14:21:59 +00:00
Olle Johansson
64b3683dbe Adding a few Todo's to res_jabber so we don't forget.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68030 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 10:00:17 +00:00
Olle Johansson
b857aed39e Ok, we found out that this is not about if you have any *active* clients using TLS, but
if you have initialized TLS at all during the lifetime of the module. So if you reload
to disable TLS, it won't help.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68028 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:55:13 +00:00
Olle Johansson
dd7f6f8e21 If you have a jabber client that uses TLS, refuse unload. Bad fix, but will prevent
crashes while we are trying to find a workaround.

Iksemel development seems to have stalled and we might have to stop using the 
TCP/TLS connections in that library and use our own, which would scale better
from a poll/select perspective I guess. It would also make it easier to migrate
to OpenSSL and stop Asterisk from depending on both OpenSSL and GnuTLS.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@68027 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:42:26 +00:00
Olle Johansson
ff2943dd59 Issue #9738 - Make sure we can unload res_jabber. Patch by phsultan - thanks!
Due to a bug in the iksemel library, this will not work if you are using GTLS
in the connection. That's being investigated. If you figure out a way to handle
that without us having to patch iksemel, let us know in the bug report. Thanks.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67993 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 09:00:44 +00:00
Joshua Colp
b58a48d672 Merged revisions 67938 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67938 | file | 2007-06-06 20:09:13 -0400 (Wed, 06 Jun 2007) | 2 lines

Only notify the devicestate system of a peer state change when the peer is built from the config file. (issue #9900 reported by arkadia)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67941 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 00:10:48 +00:00
Joshua Colp
928e69408e Properly handle cases where a stream can't be written to. (issue #9757 reported by junky)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67924 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 23:38:15 +00:00
Russell Bryant
b310d22e7c Disable reload functionality in res_snmp. It is not possible to initialize the
snmp library more than once without completely unloading the module and loading
it again.
(issue #9571, reported by hristo, additional helpful debug information from festr,
 patch from me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67872 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 22:08:02 +00:00
Russell Bryant
6595debbc5 Fix a crash when doing call pickups with SIP phones. The code unlocked the
channel when it should not have.
(issue #9652, reported by corruptor, fixed by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 21:14:46 +00:00
Mark Michelson
e8900612be Fix for Issue 9810. There was a segfault under a specific set of circumstances:
1. VoiceMailMain was configured in the dialplan with an extension as its argument
2. A message was left for this mailbox
3. Tried to call VoiceMailMain but hung up before entering password.

This was fixed by checking that a pointer was non-null prior to trying to dereference it.
(Issue 9810, reported by xmarksthespot, patched by Corydon76 with modifications by me).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 19:26:55 +00:00
Russell Bryant
e7dd69eea8 Merged revisions 67715 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67715 | russell | 2007-06-06 11:40:51 -0500 (Wed, 06 Jun 2007) | 5 lines

We have some bug reports showing crashes due to a double free of a channel.
Add a sanity check to ast_channel_free() to make sure we don't go on trying
to free a channel that wasn't found in the channel list.
(issue #8850, and others...)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67716 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 16:55:59 +00:00
Joshua Colp
1f6872a45e Merged revisions 67649 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67649 | file | 2007-06-06 09:28:34 -0400 (Wed, 06 Jun 2007) | 2 lines

Reinvite the RTP back to the Asterisk machine when the timeout happens. (issue #9888 reported by gasparz)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67650 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:30:25 +00:00
Joshua Colp
7fb76769a8 Fix plc_samples warning when registering a translator. (issue #9897 reported by xylome)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:18:39 +00:00
Joshua Colp
a4ebf8b608 Include macroexten while searching for a channel to pick up in case they are in a macro. (issue #9491 reported by jamesb63)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67626 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:16:34 +00:00
Joshua Colp
ed7775bc53 Make the new "agi debug off" CLI command work. (issue #9890 reported by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67597 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 12:34:06 +00:00
Joshua Colp
26268d3a9a Merged revisions 67593 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r67593 | file | 2007-06-06 08:18:36 -0400 (Wed, 06 Jun 2007) | 2 lines

Revert channel name splitting fix for Zap. The moral of the story is don't use - in your user/peer names. (issue #9668 reported by stevedavies)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67594 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 12:20:27 +00:00
Russell Bryant
1a3e65a793 Fix some crashes related to the use of the "meetme" CLI command. The code for
this command was not locking the conference list at all.
(issue #9351, reported by and patch submitted by Junk-Y, committed patch
 is different and by me)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67558 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 23:01:44 +00:00
Steve Murphy
dc63d79143 this fixes bug 9883, wherein macros were not allowing the includes construct. fixed and tested, looks OK. Now includes can serve as an adjunct to catch.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 21:30:18 +00:00
Russell Bryant
fe9a3bef4e This bug has been hanging over my head ever since I wrote this SLA code.
Every time I tried to go debug it by adding some debug output, the behavior
would change.  It turns out I wasn't crazy.  I had the following piece of code:

   if (remove)
      AST_LIST_REMOVE_CURRENT(...);

Well, AST_LIST_REMOVE_CURRENT was not wrapped in braces, so my conditional
statement didn't do much good at all.  It always ran at least all of the
macro minus the first statement, so I was seeing list entries magically
disappear when they weren't supposed to.

After many hours of debugging, I have come to this extremely irritating fix. :)

(issues #9581, #9497)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67492 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 20:53:28 +00:00
Russell Bryant
83744c244a Suppress a bunch of debug output unless option_debug is on
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 19:48:02 +00:00
Mark Michelson
0a49a913ed Fix for bug number 9786, wherein voicemails saved to IMAP storage using extensions other than gsm were
unable to be played over the phone. (Issue 9786, reporter: xmarksthespot, Patched by xmarksthe spot with revisions by me,
reviewed by Russell Bryant).



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67424 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 18:32:50 +00:00
Jason Parker
4a7ae2ebde Correctly update date/time on devices throughout the life of the device, instead of just at registration.
Issue 9152, yet another patch by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67421 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 18:18:24 +00:00
Steve Murphy
b698ff265b Added code to automatically add a default case to switches that don't have one. In some cases, rather than fall thru, it results in a goto with -1 result, which terminates the extension; a sort of dialplan seqfault, sort of. This was required to fix bug reported in 9881
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67420 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 18:17:28 +00:00
Russell Bryant
9dd7be2f58 Handle a failure in malloc() in ast_safe_string_alloc()
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@67372 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 17:07:30 +00:00