Commit Graph

11273 Commits

Author SHA1 Message Date
Russell Bryant
0a1a04137e (closes issue #10209)
Reported by: juggie
Patches:
      10209-trunk-2.patch uploaded by juggie
Tested by: juggie, blitzrage

In ast_pbx_run(), mark a channel as hung up after an application returned -1, 
or when it runs out of extensions to execute.  This is so that code can detect
that this channel has been hung up for things like making sure DeadAGI is used
on actual dead channels, and is beneficial for other things, like making sure
someone doesn't try to start spying on a channel that is about to go away.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75403 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-17 20:01:12 +00:00
Russell Bryant
6f40b0d2b4 Remove a duplicated newline character in AGI debug output.
(closes issue #10207, patch by seanbright)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75401 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-17 19:45:07 +00:00
Kevin P. Fleming
d0cb9b141d Merged revisions 75304 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75304 | kpfleming | 2007-07-16 15:46:58 -0500 (Mon, 16 Jul 2007) | 3 lines

provide proper copyright/license attribution for this structure that was copied from a BSD-licensed header file long, long ago...


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75306 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-16 20:53:24 +00:00
Kevin P. Fleming
725f93c497 another fix that is not needed here (finishing up 75251)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75258 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-16 18:33:50 +00:00
Mark Michelson
402820c9e3 Restoring functionality from 1.2 wherein Retrydial will not exit if there is no announce file specified.
This change makes it so that if there is no announce file specified, the application will continue until finished (or caller hangs up).
If a bogus announce file is specified, then a warning message will be printed saying that the file could not be found, but execution will
still continue. 

(closes issue #10186, reported by jon, patched by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75253 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-16 18:16:15 +00:00
Kevin P. Fleming
2efa8da290 block change that is not relevant here
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75252 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-16 18:12:31 +00:00
Russell Bryant
aa44ffb5c3 Merged revisions 75107 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75107 | russell | 2007-07-13 15:35:22 -0500 (Fri, 13 Jul 2007) | 3 lines

Fix a couple potential minor memory leaks.  load_moh_classes() could return
without destroying the loaded configuration.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75108 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-13 20:36:16 +00:00
Mark Michelson
90da4da6ad Merged revisions 75066 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75066 | mmichelson | 2007-07-13 15:10:39 -0500 (Fri, 13 Jul 2007) | 5 lines

Fixed an issue where chanspy flags were uninitialized if no options were passed.
What triggered this investigation was an IRC chat where some people's quiet flags were
set while others' weren't even though none of them had specified the q option.


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75078 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-13 20:15:30 +00:00
Russell Bryant
e7afb1e237 Merged revisions 75059 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75059 | russell | 2007-07-13 15:07:21 -0500 (Fri, 13 Jul 2007) | 6 lines

Ensure that adding a user to the list of users of a specific music on hold
class is not done at the same time as any of the other operations on this list
to prevent list corruption.  Using the global moh_data lock for this is not
ideal, but it is what is used to protect these lists everywhere else in the
module, and I am only changing what is necessary to fix the bug.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75067 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-13 20:10:40 +00:00
Russell Bryant
3e138057df Merged revisions 75052 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r75052 | russell | 2007-07-13 14:10:00 -0500 (Fri, 13 Jul 2007) | 12 lines

(closes issue #9660)
Reported by: mmacvicar
Patches submitted by: bbryant, russell
Tested by: mmacvicar, marco, arcivanov, jmhunter, explidous

When using a TDM400P (and probably other analog cards) there was a chance that
you could hang up and pick the phone back up where it has been long enough to
be not considered a flash hook, but too soon such that the device reports that
it is busy and the person on the phone will only hear silence.  This patch
makes chan_zap more tolerant of this and gives the device a couple of seconds 
to succeed so the person on the phone happily gets their dialtone.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@75053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-13 19:11:26 +00:00
Mark Michelson
613059e270 Change to my previous fix regarding agent logoff soft. Now uses deferlogoff instead of loginstart
since loginstart is used after logoff. Thanks to makoto for pointing this out and suggesting the fix.

(closes issue #10178, reported and patched by makoto, with modification by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74998 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-12 23:00:32 +00:00
Steve Murphy
2aab6c341f This patch resolves 10143; thanks to irroot for the patch; looked acceptable. Let the community decide if it messes things up
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74955 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-12 20:42:08 +00:00
Joshua Colp
7152afccd5 Whoops... didn't want this to be returned to 0 each iteration.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74922 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-12 19:17:59 +00:00
Joshua Colp
26acd893d3 When waiting for a digit ensure that a begin frame was received with it, not just an end frame. (issue #10084 reported by rushowr)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74888 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-12 17:16:28 +00:00
Jason Parker
f642f7fc86 It helps if I actually add this stuff for the 7921 too - otherwise it won't actually do much of anything.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74866 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-12 16:53:35 +00:00
Jason Parker
d6ff30694e Add device ID for 7921 wireless skinny phone
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74864 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-12 16:48:49 +00:00
Jason Parker
abf5430584 Fix dialing in skinny that was broken in some cases.
Issue 10136, fix provided by DEA.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74839 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-12 16:16:59 +00:00
Joshua Colp
54b08bfe83 Merged revisions 74814 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74814 | file | 2007-07-12 12:51:24 -0300 (Thu, 12 Jul 2007) | 2 lines

Only print out a warning for situations where it is actually helpful. (issue #10187 reported by denke)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74815 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-12 15:53:55 +00:00
Russell Bryant
1eb3dd6381 Merged revisions 74766 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74766 | russell | 2007-07-11 17:53:26 -0500 (Wed, 11 Jul 2007) | 5 lines

The function make_trunk() can fail and return -1 instead of a valid new call
number.  Fix the uses of this function to handle this instead of treating it
as the new call number.  This would cause a deadlock and memory corruption.
(possible cause of issue #9614 and others, patch by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74767 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-11 22:57:07 +00:00
Mark Michelson
b827d5a183 Merged revisions 74719 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74719 | mmichelson | 2007-07-11 16:12:30 -0500 (Wed, 11 Jul 2007) | 5 lines

The cli command "agent logoff Agent/x soft" did not work...at all. Now it does.

(closes issue #10178, reported and patched by makoto, with slight modification for 1.4 and trunk by me)


........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74722 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-11 21:14:09 +00:00
Russell Bryant
8b7295be2d Merged revisions 74656 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74656 | russell | 2007-07-11 13:33:23 -0500 (Wed, 11 Jul 2007) | 4 lines

Make sure that the ESCAPE immediately follows the condition that uses LIKE.
This fixes realtime extensions with ODBC.
(closes issue #10175, reported by stuarth, patch by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74657 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-11 18:34:51 +00:00
Steve Murphy
7363244381 This fixes 10172, where the entire man8 dir gets removed during an uninstall of asterisk
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74642 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-11 18:18:42 +00:00
Steve Murphy
19041621f6 further reversion of previously applied floating point stuff for expr2
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74628 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-11 18:11:44 +00:00
Joshua Colp
8718f08cbd Blocked revisions 74587 via svnmerge
........
r74587 | file | 2007-07-11 14:15:11 -0300 (Wed, 11 Jul 2007) | 2 lines

Use some Makefile magic to determine if linux/compiler.h is present. (issue #10174 reported by francesco_r)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74590 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-11 17:16:25 +00:00
Joshua Colp
5f37fa26d2 Instead of figuring out kernel versions that have compiler.h and not... let's just use autoconf to check for it's presence. (issue #10174 reported by francesco_r)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74572 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-11 17:03:08 +00:00
Joshua Colp
058a40ff02 Only check if we need to do a SIGMA based tone generation if we have a card. (issue #10179 reported by mikowhy)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74515 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-11 14:09:13 +00:00
Mark Michelson
4ab675ca50 Forwarding a message with IMAP storage was storing the message in the sender's box instead of the forwarded mailbox.
(closes issue #10138, reported and patched by jaroth)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74476 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 23:32:52 +00:00
Jason Parker
05923bb562 Merged revisions 74427 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74427 | qwell | 2007-07-10 14:57:20 -0500 (Tue, 10 Jul 2007) | 6 lines

Fix an issue where it was possible to have a service level of over 100%
Between the time recalc_holdtime and update_queue was called, it was possible that the call could have been hungup.
Move both additions to the same place, so this won't happen.

Issue 10158, initial patch by makoto, modified by me.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 19:58:53 +00:00
Jason Parker
7e0ab0fa62 Don't use #if to check if something is defined - use #ifdef instead.
Pointed out by kpfleming


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74388 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 19:10:36 +00:00
Jason Parker
f3c04c4b7e Merged revisions 74376 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74376 | qwell | 2007-07-10 14:03:45 -0500 (Tue, 10 Jul 2007) | 4 lines

Fix an issue with wrapuptime not working when using AgentLogin.

Issue 10169, patch by makoto, with a minor mod by me to not re-break issue 9618

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74379 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 19:06:24 +00:00
Jason Parker
d4a7eb584f Merged revisions 74373 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74373 | qwell | 2007-07-10 13:37:23 -0500 (Tue, 10 Jul 2007) | 5 lines

Use res_ndestroy on systems that have it.  Otherwise, use res_nclose.
This prevents a memleak on NetBSD - and possibly others.

Issue 10133, patch by me, reported and tested by scw

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74374 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 18:39:30 +00:00
Russell Bryant
3ddbe8e0b6 fix an uninitialized variable
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74323 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 16:00:11 +00:00
Jason Parker
53b44803ee Merged revisions 74316 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74316 | qwell | 2007-07-10 10:37:54 -0500 (Tue, 10 Jul 2007) | 4 lines

Fix a small typo in description in of Voicemail() application.

Issue 10170, patch by casper.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74317 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 15:38:32 +00:00
Russell Bryant
b4865e6eea Merged revisions 74313 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74313 | russell | 2007-07-10 10:30:20 -0500 (Tue, 10 Jul 2007) | 3 lines

Only use ESCAPE when LIKE is used.  
(issue #10075, this part reported by jmls on IRC, patch by me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74314 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 15:31:41 +00:00
Joshua Colp
49584ec434 Merged revisions 74264 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74264 | file | 2007-07-10 11:48:00 -0300 (Tue, 10 Jul 2007) | 2 lines

Ensure the group information category exists before trying to do a string comparison with it. (issue #10171 reported by mlegas)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74265 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 14:50:00 +00:00
Joshua Colp
446f14f0dc Only spit out an inringing warning message when it is applicable. Since call limits are already toast in realtime let's not scare the user if they are using it. (issue #10166 reported by bcnit)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74262 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-10 14:07:13 +00:00
Russell Bryant
1f96da91d4 Update the configure script to check for a required function that is not present
in the 1.2 version of libpri.  This will prevent the configure script from thinking
that it has compatible libpri support for Asterisk 1.4, when it actually does not
because the installed version is from 1.2.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74211 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 21:31:30 +00:00
Russell Bryant
e4142b6218 Blocked revisions 74165 via svnmerge
........
r74165 | russell | 2007-07-09 16:00:17 -0500 (Mon, 09 Jul 2007) | 4 lines

When the specified class isn't found, properly fall back to the channel's music
class or the default.
(issue #10123, reported by blitzrage, patches from juggie, qwell, and me)

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74166 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 21:00:47 +00:00
Russell Bryant
b4960ab566 (closes issue #10123)
Reported by: blitzrage
Patches submitted by: juggie, qwell, me
Tested by: blitzrage

When trying to find a music on hold class to use, try all of the options,
instead of only the first one that is set.  Also, change the MusicOnHold
applications to not hang up on the channel when a class can not be found.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74162 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 20:53:46 +00:00
Jason Parker
bf8172ff95 Merged revisions 74158 via svnmerge from
https://origsvn.digium.com/svn/asterisk/branches/1.2

........
r74158 | qwell | 2007-07-09 15:18:15 -0500 (Mon, 09 Jul 2007) | 8 lines

Several chan_zap options were not working on reload because they were arbitrarily
 disallowed when reloading some/most PRI options (such as signalling) was disallowed.

Options such as polarityonanswerdelay and answeronpolarityswitch can safely be changed on a reload.
This corrects that behavior.

Issue 9186, patch by tzafrir.

........


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74159 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 20:19:28 +00:00
Mark Michelson
5112357ae1 Forgot to get rid of an extraneous debug message.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74122 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 18:38:28 +00:00
Mark Michelson
591f77fe14 The n option for Queue should make the queue exit immediately after failure to reach any members and should not
be dependent on the timeout value passed to Queue

(closes issue #10127, reported by bcnit, repaired by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74120 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 18:32:50 +00:00
Joshua Colp
94cd7026ef Only destroy the scheduler context if it was allocated. (issue #10124 reported by gzero)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74082 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 15:32:43 +00:00
Mark Michelson
441d1bbdf5 Fixed a logic error in leave_voicemail. Pass the mailbox instead of the context to inbox_count when the context is "default."
(closes issue #10135, reported by yannj, repaired by me)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74047 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 14:57:41 +00:00
Joshua Colp
ce4e654f2c Few minor thread synchronization tweaks. (issue #10124 reported by gzero)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74045 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 14:49:05 +00:00
Joshua Colp
475e3be7c0 Use AC_CHECK_HEADER to check for ptlib/openh323 to allow for cross compiling. (issue #9675 reported by zandbelt)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@74043 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 14:34:33 +00:00
Tilghman Lesher
befa215f7b Doxygen formatting fixes; fixes errors while 'make progdocs'. (Closes issue #10104)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73985 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 04:03:20 +00:00
Joshua Colp
a979d44c9c Give Agent channel names priority when doing CDR merging. (issue #10011 reported by krtorio)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73980 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 03:13:19 +00:00
Joshua Colp
1944dea3bd Add a few sanity checks when writing out the dialplan. (issue #10157 reported by dome)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73930 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-09 01:13:57 +00:00
Olle Johansson
7bbda30564 While tracking down a bug, I need some more history. Dumphistory is very useful, indeed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@73849 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-07-08 09:47:31 +00:00