Tilghman Lesher
528dd04ecb
Use ESCAPE clause for the first parameter, not just 2nd-Nth parameters.
...
Reported by: apsaras
Patch by: tilghman
(Closes issue #11353 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89534 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-23 17:05:10 +00:00
Russell Bryant
53c77e38f4
mvanbaak pointed out a spelling error in this sample configuration file. While
...
I was at it, I went ahead and tweaked it a little bit more.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89527 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-22 17:29:41 +00:00
Mark Michelson
ddc5bf5b47
Fix a small error I made in my previous commit
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 19:27:51 +00:00
Mark Michelson
d105c24a57
Changing an inaccurate debug message to be less inaccurate. Under the circumstances, this
...
message would always report that there were 0 members available, even though that may not be true.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89493 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 19:24:22 +00:00
Terry Wilson
9c29d80d70
If a channel gets masqueraded in the middle of a park, don't play the
...
announcement to the masqueraded channel, and dial back to the original
channel on timeout.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-21 18:59:27 +00:00
Kevin P. Fleming
a90e90384c
re-doxygen some comments
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89462 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 19:16:24 +00:00
Kevin P. Fleming
337fb0c37f
bring back compile-option checking when loading modules, only this time use a string-based storage and comparison mechanism because it is easier to support on other platforms
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89461 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 19:12:52 +00:00
Mark Michelson
da4933e657
According to comments in main/pbx.c, it is essential that if we are going to lock
...
the conlock as well as the hints lock, it must be locked in that respective order.
In order to prevent a potential deadlock, we need to lock the conlock prior to
locking the hints lock in ast_hint_state_changed (see the call stack example on
issue #11323 for how this can happen).
(closes issue #11323 , reported by eelcob, suggestion for patch by eelcob, patch by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89457 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 17:50:31 +00:00
Steve Murphy
8a1f941a17
closes issue #11324 ; break statements missing in switch cases.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89450 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 15:22:08 +00:00
Christian Richter
be20960013
added RR patch from iroot #10908 , thanks.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89445 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-20 13:40:55 +00:00
Joshua Colp
34a3095877
Print out the correct filename (features.conf) in the log message when parkpos options are incorrect.
...
(closes issue #11295 )
Reported by: Laureano
Patches:
res_features.c.patch uploaded by Laureano (license 265)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89419 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 15:53:32 +00:00
Joshua Colp
1bd082719f
Clarify documentation a bit, include that a frame has to pass through the core in order for the Local channel optimization to happen.
...
(closes issue #11246 )
Reported by: jon
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89416 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-19 15:24:12 +00:00
Russell Bryant
12d60508f3
Temporarily revert revision 89325, which added md5 magic for keeping track of
...
what build options were used. We agreed that we should remove this before
making a 1.4 release, and then we can put it back in. Then, we can take a
month or so to play around with it to get it how we want it.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89339 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 22:26:44 +00:00
Kevin P. Fleming
22b119d188
To help combat problems where people build external modules (asterisk-addons or others) and then change the build options of the Asterisk build in a way that makes the incompatible without warning, this commit introduces an MD5 signature of the important build-time options and includes that signature into modules when they are built. When the loader loads one of these modules and notices the problem, it will emit a warning to console and refuse to initialize the module, as doing so could cause the system to be unstable or even crash.
...
If you upgrade to this version of Asterisk, you must rebuild *all* of your modules that came from other sources before trying to run this version. If you are using Digium's G.729 binary codec module, you will need v33 or newer.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89325 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 16:47:46 +00:00
Mark Michelson
891b3bab2a
Make realtime queues accessible from the QUEUE_MEMBER_COUNT function.
...
(closes issue #11271 , reported and patched by atis, with small modifications from me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89323 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-16 15:28:22 +00:00
Tilghman Lesher
92d1018c2a
Start Asterisk in Debian at a more reasonable time (since zaptel is at level 20)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89302 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 18:37:38 +00:00
Tilghman Lesher
245abfa1c2
Fix an uninitialized memory read found by valgrind
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89301 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 18:23:14 +00:00
Tilghman Lesher
f39db73930
Yet another memory corruption issue.
...
Reported by: atis
Patch by: tilghman
Fixes issue #10923
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89298 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 18:05:56 +00:00
Russell Bryant
bd5b8a4014
Update the SLAStation application to account for the case where the SLA thread
...
has a call out to the station, but the user has pressed a line button to answer
the call instead of picking up the handset. If they do, the phone sends out a
new INVITE. So, the SLAStation app must check to see if it is picking up a
ringing trunk, and ensure that the other stations stop ringing.
(reported internally, patched by me, tested by mogorman)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89296 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 17:19:28 +00:00
Mark Michelson
1fece3bb67
Undoing previous commit since I realize it was wrong
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89288 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 14:57:28 +00:00
Mark Michelson
88f847869d
Adding a missing mutex unlock.
...
(closes issue 11256, reported and patched by ys)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89286 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 14:54:10 +00:00
Olle Johansson
9d3be20a0d
Don't send re-invites during pending INVITE transactions.
...
Patch by one47 - thanks!
Closes issue #9305
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89281 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 11:26:22 +00:00
Olle Johansson
fc49ddab3a
Improve support for multipart messages. Code by gasparz, changes
...
by me (mostly formatting). Thanks, gasparz!
Closes issue #10947
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89280 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-15 11:15:09 +00:00
Tilghman Lesher
1af09c5f9d
When a recording ends with '#', we are improperly trimming an extra 200ms from the recording.
...
Reported by: sim
Patch by: tilghman
Closes issue #11247
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89275 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 23:23:58 +00:00
Joshua Colp
f3f12761ba
Return the proper value when the srv_callback function executes properly.
...
(closes issue #11240 )
Reported by: jtodd
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89260 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-14 01:15:12 +00:00
Jason Parker
fb0bb38fc4
Fix building on newer systems which require a third arg to open() when using O_CREAT.
...
Issue 11238, reported by puzzled.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89254 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 21:07:08 +00:00
Jason Parker
b0e9d400ff
Revert change from revision 67064.
...
It is documented behavior that if a parking extension already exists while using PARKINGEXTEN,
dialplan execution will continue. If blind transferring to a Park with PARKINGEXTEN, you
must keep this in mind, and handle the failure yourself.
Issue 11237, reported by jon.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89248 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 19:47:45 +00:00
Tilghman Lesher
4332b72082
If we set a value for qualify, we should actually pay attention to it, instead of overriding the value
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89246 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 17:34:11 +00:00
Mark Michelson
dc6e3e9d5d
Reverting commit made in revision 89205 since it is unnecessary.
...
Thanks to Kevin for pointing this out
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89241 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 16:02:02 +00:00
Tilghman Lesher
feed493993
Debugging is running into the 16-lock limit. Increase to avoid.
...
(This define is only effective when debugging is turned on, so there's
no effect for most installations.)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 13:51:53 +00:00
Mark Michelson
4155b5f984
Some sanity checking for MixMonitor. If only 1 argument is given, then the args.options
...
and args.post_process strings are uninitialized and could contain garbage. This change
handles this situation properly by only using arguments that we have parsed.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89205 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-13 00:56:46 +00:00
Jason Parker
05df1092da
Fix a typo pointed out by De_Mon on #asterisk-dev
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89194 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 20:46:52 +00:00
Tilghman Lesher
472eb33648
If two config writes collide, file corruption could result. Use a mkstemp() file, instead.
...
Reported by: paravoid
Patch by: tilghman
Closes issue #10781
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89191 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 20:16:18 +00:00
Tilghman Lesher
1a052e0498
Fix two cases of memory corruption caused by background threads.
...
Reported by: atis
Patch by: tilghman
Fixes issue #10923
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89184 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 17:29:17 +00:00
Christian Richter
c2c1e68238
if we're NT and no number was dialed and overlapdial is set, we wait for the ISDN timeout instead of starting our own timer. added a comment for the misdn.conf.sample for the overlapdial config option.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89173 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 11:26:48 +00:00
Christian Richter
4e52dc67dc
added restart all interfaces Restart_Indicator, to automatically send a RESTART after the L2 of a PTP Port comes up. Also fixed some places where we have send a RELEASE without need for it.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89172 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 11:23:57 +00:00
Christian Richter
472f7a471c
fixed a state/event issue with overlapdial=yes when no extension matched. removed the general sending of a RELEASE_COMPLETE when we receive a RELEASE, this is done by mISDNuser/mISDN. This makes it possible to use asterisk-1.4 with mISDN trunk, but requires users of mISDN/mISDNuser-1.1.X to upgrade to at least mISDNuser-1.1.6 (when using the NT mode at all)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89171 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 11:13:13 +00:00
Christian Richter
ad50f139c4
fixed the support for CW and therefore for the reject_cause option.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89170 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 09:57:23 +00:00
Christian Richter
57ccb76df1
aded ntkeepcalls option, to avoid droÃpping calls when the L2 goes down on a PTP link. There are some pbx which do turn off the L1 for a very short while and restart it immediately. normally T310 should be started and after 10 seconds or so the calls should be dropped, this is a simple fix wihtout this timer.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89169 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-12 09:45:36 +00:00
Jason Parker
76aa7c3767
Properly say the seconds here..
...
Issue 11203, fix described by vma.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89125 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 23:52:35 +00:00
Mark Michelson
3b75ff9010
Rework of the commit I made yesterday to use the already built-in
...
ast_uri_decode function as opposed to my home-rolled one. Also added
comments.
Thanks to oej for pointing me in the right direction
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89119 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 21:00:08 +00:00
Jason Parker
c170f694e7
Avoid warnings on load when using sample configuration files.
...
Issue 11195, patch by eliel.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 18:45:15 +00:00
Mark Michelson
9f5cf47a6f
I made this same adjustment in trunk to fix a bug, and it makes sense to do it in 1.4 as
...
well. If an imapfolder is specified in voicemail.conf, don't ever explicitly connect to
INBOX since it may not exist.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89111 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 16:47:23 +00:00
Kevin P. Fleming
30cb593fd2
fix a glaring bug in the new SRV record handling that would cause incorrect weight sorting
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89105 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 05:26:47 +00:00
Tilghman Lesher
7e81a39a81
Typo
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89103 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 04:55:19 +00:00
Joshua Colp
3aea241b63
Do not add a sip: to the beginning of the To URI unless needed.
...
(closes issue #10756 )
Reported by: goestelecom
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89101 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 02:26:48 +00:00
Joshua Colp
0f1ef85f9a
Improve the devicestate logic for multiple devices. If any are available then the extension is considered available.
...
(closes issue #10164 )
Reported by: nic_bellamy
Patches:
sip-hinting-svn-branch-1.4.patch uploaded by nic (license 299)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89099 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 01:28:56 +00:00
Joshua Colp
53fd91490e
Add support for allowing one outgoing transaction. This means if a response comes back out of order chan_sip will still handle it. I dream of a chan_sip with real transaction support.
...
(closes issue #10946 )
Reported by: flefoll
(closes issue #10915 )
Reported by: ramonpeek
(closes issue #9567 )
Reported by: atca_pres
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89097 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-08 01:11:25 +00:00
Joshua Colp
f1309f2c3f
If callerid is configured in sip.conf use that for checking the presence of an extension in the dialplan.
...
(closes issue #11185 )
Reported by: spditner
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89095 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-07 23:53:25 +00:00
Tilghman Lesher
45c16cc29b
The member refcount must be incremented, to avoid using it after deallocation.
...
A huge thanks go to lvl- for patiently providing the necessary valgrind output
that was necessary to finding this problem of memory corruption.
Reported by: lvl-
Patch by: tilghman
Closes issue #11174
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@89093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-11-07 23:39:37 +00:00