Joshua Colp
7e22d574a7
Send an unhold indication when going off hold. (issue #10036 reported by speedy)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71124 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 16:02:40 +00:00
Jason Parker
01f5e6d56b
Fix a few silly usages of ast_playstream() - it only ever returns 0...
...
Issue 10035
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71065 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 14:52:18 +00:00
Brett Bryant
b9000f54b2
Fixed infinite loop when controlling terminal was lost
...
and return value of input function wasn't checked for
errors. This would cause 100% cpu to be taken up.
(closes issue #9654 , issue #10010 )
Reported by: mnicholson, and eserra
Idea for the patch from mnicholson, patched by me
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@71064 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-22 14:39:34 +00:00
Steve Murphy
c25932a107
This little fix is in response to bug 10016, but may not cure it. The code is wrong, clearly. In a situation where you set the CDR's amaflags, and then ForkCDR, and then set the new CDR's amaflags to some other value, you will see that all CDRs have had their amaflags changed. This is not good. So I fixed it.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70948 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 22:29:50 +00:00
Joshua Colp
e179ccaff2
Don't explode if the gain option is specified without a value. (issue #9274 reported by mfarver)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70898 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 21:37:55 +00:00
Steve Murphy
7a7b6536c7
it was pointed out that the cdr_custom config load could get a lock, and under certain circumstances, would never release it. I also noted that the situation where more than one mapping spec was warned about, but did not ignore further mappings as it had promised. I think I have fixed both situations.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70804 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 19:13:17 +00:00
Christian Richter
d8d4454ae5
we activate the bchannels in TE mode on incoming calls only when we want to connect the call.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70672 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-21 13:11:29 +00:00
Joshua Colp
6357ad5659
Don't overwrite the configured username setting upon a REGISTER. (issue #8565 reported by jsmith)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70551 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 22:20:16 +00:00
Tilghman Lesher
a1cc9b4966
Issue 9997 - Timelimit times out the wrong channel
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70444 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 19:25:54 +00:00
Russell Bryant
cfaead2b9c
Fix a problem where an established call would not be properly disconnected
...
when a PRI disconnect is received depending on which cause code was received.
(issue #9588 , original patch by softins, updated patch from jtexter3, and some
additional feedback from mhardeman)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70396 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 18:45:38 +00:00
Christian Richter
f5f018a209
forgot one place ..
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70342 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 15:42:39 +00:00
Christian Richter
7fc236e53b
fixed a bug that was introduced by copy and paste in the last commit ..bchannels weren't cleaned properly.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70341 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 15:29:09 +00:00
Christian Richter
ede913f976
on receiption of cause:44 we mark the channel as in use and inform the user about the situation, we need to test the RESTART stuff then. Also shuffled the empty_chan_in_stack function after the bchannel cleaning functions, to avoid race conditions.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70311 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-20 14:47:59 +00:00
Steve Murphy
8da289e13c
This fixes 9246, where channel variables are not available in the 'h' exten, on a 'ZOMBIE' channel. The fix is to consolidate the channel variables during a masquerade, and then copy the merged variables back onto the clone, so the zombie has the same vars that the 'original' has.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@70053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 18:07:59 +00:00
Joshua Colp
3d1a5f71c5
Handle the CC field in the RTP header. (issue #9384 reported by DoodleHu)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69992 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 17:00:58 +00:00
Russell Bryant
6e0248318b
Backport fix for crashes related to subscriptions from 1.4 ...
...
Fix a crash that could occur when handing device state changes.
When the state of a device changes, the device state thread tells the extension
state handling code that it changed. Then, the extension state code calls the
callback in chan_sip so that it can update subscriptions to that extension.
A pointer to a sip_pvt structure is passed to this function as the call which
needs a NOTIFY sent. However, there was no locking done to ensure that the pvt
struct didn't disappear during this process.
(issue #9946 , reported by tdonahue, patch by me, patch updated to trunk to use
the sip_pvt lock wrappers by eliel)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69990 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 16:45:37 +00:00
Joshua Colp
07b9fc569f
Update BRIDGEPEER variable if set to the new channel name when a masquerade happens. (issue #9699 reported by dimas)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69986 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 16:21:29 +00:00
Joshua Colp
e21d079484
Perform an extra hangup check just in case. (issue #9589 reported by bcnit)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69894 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 13:54:03 +00:00
Christian Richter
3322095dea
when we send out a SETUP, but get no response, we should cleanup everything after reception of a hangup.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69887 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 13:23:04 +00:00
Joshua Colp
234b7d22fe
Add parked call extension AFTER the parking slot has been announced, otherwise two threads will try to handle the same channel and it will go kaboom. (issue #9191 reported by japple)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69846 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-19 12:57:55 +00:00
Joshua Colp
dc41ce9857
Set the peer name on the dialog to the one configured in sip.conf and NOT the username to be used for authentication attempts. (issue #9967 reported by achauvin)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69765 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 18:13:03 +00:00
Tilghman Lesher
ff8bb42cbc
Issue 9998 - Remove SIG prefix, since it's not supported by ksh
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69743 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-18 17:45:15 +00:00
Jason Parker
9aa74f204a
Fix an issue where the line number in an unterminated comment block error message would show the wrong line number.
...
"Reported" to me on #asterisk (somebody posted an error message, and I happened to catch it)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69469 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 23:21:45 +00:00
Russell Bryant
dc41cf2347
Backport rev 69010 from the 1.4 branch ...
...
In ast_channel_make_compatible(), just return if the channels' read and write
formats already match up. There are code paths that call this function on a
pair of channels multiple times. This made calls fail that were using g729
in some cases. The reason is that codec_g729a will unregister itself from the
list of available translators will all licenses are in use. So, the first
time the function got called, the right translation path was allocated.
However, the second time it got called, the code would not find a translation
path to/from g729 and make the call fail, even if the channel actually already
had a g729 translation path allocated.
(SPD-32)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69347 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 20:56:19 +00:00
Jason Parker
fab1ba87cd
Change a quite broken while loop to a for loop, so "continue;" works as expected instead of eating 99% CPU...
...
Issue 9966, patch by me.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69258 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-14 15:15:53 +00:00
Joshua Colp
0156942fe0
Return group counting to previous behavior where you could only have one group per category. (issue #9711 reported by irroot)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69127 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 18:12:48 +00:00
Christian Richter
ba372aa9a4
restart indicator 0x80 is correct, at least that's what libpri does.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@69053 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-13 09:55:54 +00:00
Joshua Colp
28464199ee
Bring RTP back to Asterisk at the end of a native bridge no matter what.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68921 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 14:18:57 +00:00
Christian Richter
37ded96cfa
if the bridged partner is mISDN too we should not send dtmf tones, they are transmitted inband always
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68887 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 08:35:22 +00:00
Christian Richter
7bb272f942
if we have already some digits, we just stop the tones.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68874 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-12 07:48:52 +00:00
Christian Richter
9809905c76
added check for NULL Pointer when calling misdn_new. Asterisk does not allow us to create channels anymore when stop gracefully is used :). also modified the restart_indicator to 0
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68732 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 16:49:00 +00:00
Joshua Colp
41421be994
Improve deadlock handling of the channel list. (issue #8376 reported by one47)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68682 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 14:29:58 +00:00
Christian Richter
5cc2b1078e
fixed problem that the dummybc chanels had no lock, checking for the lock now. Also fixed the channel restart stuff, we can now specify and restart particular channels too.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68631 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-11 09:18:01 +00:00
Russell Bryant
086aba207e
Don't automatically hang up after running Dictate so that callers can exit
...
cleanly using '#'
(closes issue #9577 , patch from Thomas Andrews)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68526 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 22:22:36 +00:00
Joshua Colp
d8fb68b9cb
Don't call ast_waitstream_full when the control file descriptor and audio file descriptor are not set, simply call ast_waitstream! (issue #8530 reported by rickead2000)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68397 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-08 00:15:33 +00:00
Joshua Colp
49ffa786ff
Do a DNS lookup immediately upon calling the dnsmgr function, don't wait until a refresh happens. (issue #9097 reported by plack)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68368 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:59:04 +00:00
Russell Bryant
c00062ff31
Fix a problem where saying a character wouldn't properly break out when the caller pressed '#'
...
(issue #8113 , reported by patbaker82, patch from jamesgolovich (hey, long time no see!) and patbaker82)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68351 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 23:13:33 +00:00
Jason Parker
a3961d646a
Don't try to save voicemail greetings unless the user presses '1' to accept/save.
...
Issue 9904, patch by me.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68204 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 20:02:50 +00:00
Joshua Colp
9c0627eab0
Allow the 'g' option to work if used with the 'S' option. (issue #9888 reported by gasparz)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@68070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 14:19:40 +00:00
Joshua Colp
084ede4507
Only notify the devicestate system of a peer state change when the peer is built from the config file. (issue #9900 reported by arkadia)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67938 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-07 00:09:13 +00:00
Russell Bryant
3a2e0e1ed9
We have some bug reports showing crashes due to a double free of a channel.
...
Add a sanity check to ast_channel_free() to make sure we don't go on trying
to free a channel that wasn't found in the channel list.
(issue #8850 , and others...)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67715 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 16:40:51 +00:00
Joshua Colp
76fdb9418b
Reinvite the RTP back to the Asterisk machine when the timeout happens. (issue #9888 reported by gasparz)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67649 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 13:28:34 +00:00
Joshua Colp
a05ab92728
Revert channel name splitting fix for Zap. The moral of the story is don't use - in your user/peer names. (issue #9668 reported by stevedavies)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67593 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-06 12:18:36 +00:00
Christian Richter
f002ad09a3
briding is a bool, fixed copy and paste issue.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67307 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 15:42:03 +00:00
Christian Richter
e7590d0aec
simplified the EVENT_SETUP handling in the cb_events function a lot. Commented the different possibilities a bit and made functions of shared code. When the dialed extension does not exist in the extensions.conf we'll jump into the 'i' extension if this does exist, else we disconnect the call with the cause:1 = No Route to Destination.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67306 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 15:39:43 +00:00
Nadi Sarrar
e0f4f4969c
Backport of the overlap_dial functionality from asterisk-1.4's chan_misdn.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67239 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 11:18:45 +00:00
Christian Richter
3cd1c84e8d
added possibility to deactivate bridging per port
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67209 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-05 10:05:45 +00:00
Tilghman Lesher
dd412388a1
According to MATH, 0+1181000386 = 1181000448. Oops.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67161 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 23:41:49 +00:00
Tilghman Lesher
c78acd2896
Add revision Id tags (by request of tzafrir)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@67060 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-06-04 17:10:30 +00:00
Joshua Colp
22fe1b73cc
It is now possible for this path of execution to have the frame pointer be NULL, therefore we need to check for it before trying to access it. (issue #9836 reported by barthpbx)
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.2@66764 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-05-31 16:12:39 +00:00