Commit Graph

13917 Commits

Author SHA1 Message Date
Leif Madsen
9ff28fd6e8 Update IMAP documentation.
Update the IMAP documentation to make it clear that storing voicemails
in the same folder as a large number of emails could potentially cause
significant slow downs when writing or retrieving voicemails.

(closes issue #16704)
Reported by: TimeHider
Tested by: lmadsen, TimeHider

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@250050 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 21:08:09 +00:00
Leif Madsen
19c43ed644 Update documentation to clarify purpose of unanswered option.
(closes issue #16267)
Reported by: elsto
Patches: 
      cdr.conf.sample.patch.txt uploaded by lmadsen (license 10)
Tested by: davidw, elsto

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@250043 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 20:51:35 +00:00
Leif Madsen
c91785154c Update documentation to not imply we support overriding options.
(issue #16855)
Reported by: davidw

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@250041 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 20:45:37 +00:00
Alec L Davis
3d3116e656 revert ability to exit echo app
caused a regression, as only supported VOICE, not VIDEO etc.
Left in small formatting change.

(issue #16880)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 19:36:20 +00:00
Alec L Davis
63e614d896 fixes ability to exit echo app
when called from a ISDN channel, null frames prevent '#' exit.
Now only echo back VOICE and DTMF frames

(issue #16880)
Reported by: alecdavis
Patches: 
      based on echo_exit_1-6-1.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249845 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-02 09:11:56 +00:00
Sean Bright
daf062ece8 Fix crash in app_voicemail related to message counting.
We were passing a 'struct inprocess **' and treating it like a 'struct inprocess *'
causing a segfault.

(closes issue #16921)
Reported by: whardier
Patches:
      20100301_issue16921.patch uploaded by seanbright (license 71)
Tested by: whardier


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249671 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 19:35:01 +00:00
Jeff Peeler
9a4e4eb749 Modify queued frames from local channels to not set the other side to up
In this case, attended transfers were broken due to ast_feature_request_and_dial
detecting the channel being set to up before the answer frame could be read and
therefore failing to mark the channel as ready. This fix is a regression fix for
244785, which should continue to work properly as well.

(closes issue #16816)
Reported by: jamhed
Tested by: jamhed, corruptor


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249536 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-03-01 17:02:03 +00:00
Alec L Davis
271908886f overlap receiving: automatically send CALL PROCEEDING when dialplan starts
Following Q.931 5.2.4
When the user has determined that sufficient call information has been received the 
user shall stop T302 and send CALL PROCEEDING to the network.

Previously timeouts were possible if the dialplan took a long time to issue any
response back to the network.

Verified that our local TELCO also does the same.

(issue #16789)
Reported by: alecdavis
Patches: 
      based on overlap_receiving_trunk.diff.txt uploaded by alecdavis (license 585)
Tested by: alecdavis

(closes issue #16789)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249365 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-27 23:51:28 +00:00
Kevin P. Fleming
62f453c9d7 add a reference to the now-published IAX2 RFC
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249234 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-27 14:07:59 +00:00
Mark Michelson
99e1a0f967 For T.38 reINVITEs treat a 606 the same as a 488.
(closes issue #16792)
Reported by: vrban
Patches:
      t38_606.patch uploaded by vrban (license 756)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@249100 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-26 17:04:29 +00:00
Jeff Peeler
dbdbc92a4a Ensure that monitor recordings are written to the correct location (again)
This is an extension to 248757. As such the dialplan test has been extended:

exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test,b)
exten => 5040, n, dial(sip/5001)
exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2,b)
exten => 5041, n, dial(sip/5001)
exten => 5042, 1, monitor(wav,monitor_test3,b)
exten => 5042, n, dial(sip/5001)
exten => 5043, 1, monitor(wav,tmp/jeff/monitor_test3,m)
exten => 5043, n, changemonitor(monitor_test4)
exten => 5043, n, dial(sip/5001)
exten => 5044, 1, monitor(wav,monitor_test4,m)
exten => 5044, n, changemonitor(tmp/jeff/monitor_test5) ; this looks to fail by design and emits a warning
exten => 5044, n, dial(sip/5001)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248860 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-25 21:22:06 +00:00
Tilghman Lesher
096a41e440 Some platforms clear /var/run at boot, which makes connecting a remote console... difficult.
Previously, we only created the default /var/run/asterisk directory at install
time.  While we could create it in the init script, that would not work for
those who start asterisk manually from the command line.  So the safest thing
to do is to create it as part of the Asterisk boot process.  This also changes
the ownership of the directory, because the pid and ctl files are created after
we setuid/setgid.

(closes issue #16802)
 Reported by: Brian
 Patches: 
       20100224__issue16802.diff.txt uploaded by tilghman (license 14)
 Tested by: tzafrir


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248859 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-25 21:21:05 +00:00
Jeff Peeler
3371a165f5 Ensure that monitor recordings are written to the correct location.
Recordings should be placed in the monitor directory when a non-absolute path
is used.

Exact dialplan used for testing:
exten => 5040, 1, monitor(wav,tmp/jeff/monitor_test,b)
exten => 5040, n, dial(sip/5001)
exten => 5041, 1, monitor(wav,/tmp/jeff/monitor_test2,b)
exten => 5041, n, dial(sip/5001)
exten => 5042, 1, monitor(wav,monitor_test3,b)
exten => 5042, n, dial(sip/5001)

ABE-2101


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248757 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-25 18:06:54 +00:00
Jeff Peeler
e896cc88cf Make deletion of temporary greetings work properly with IMAP_STORAGE
This same patch was merged in 220833, but was skipped in this branch
erroneously.

(closes issue #16170)
Reported by: francesco_r


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248668 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-24 22:58:54 +00:00
Tilghman Lesher
252704411c Remove color code sequences from verbose messages that go to logfiles.
(closes issue #16786)
 Reported by: dodo
 Patches: 
       logger2.patch uploaded by dodo (license 989)
 Tested by: tilghman


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248582 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-24 21:02:18 +00:00
David Vossel
8d9b578022 fixes invite with replaces deadlock
(closes issue #16862)
Reported by: pwalker
Patches:
      replaces_deadlock_1.4 uploaded by dvossel (license 671)
Tested by: pwalker, dvossel



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248396 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-23 16:26:05 +00:00
Olle Johansson
ef93e3343e Don't log to debug unless debug is turned on
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248268 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-22 13:52:34 +00:00
Olle Johansson
b39082c470 Make sure we support RTCP compound messages with zero reports
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248106 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-20 22:25:42 +00:00
Tilghman Lesher
afb69ed7c8 Backport crash fix from trunk to 1.4, whereby 'core show gracefully' could crash Asterisk.
(closes issue #16470)
 Reported by: kjotte


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@248012 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-19 19:11:45 +00:00
Richard Mudgett
7b5a46027f Merged revision 247904 from
https://origsvn.digium.com/svn/asterisk/be/branches/C.2-...

..........
r247904 | rmudgett | 2010-02-19 10:49:44 -0600 (Fri, 19 Feb 2010) | 49 lines

Make chan_misdn DTMF processing consistent with other channel technologies.

The processing of DTMF tones on the receiving side of an ISDN channel is
inconsistent with the way it is handled in other channels, especially
DAHDI analog.  This causes DTMF tones sent from an ISDN phone to be
doubled at the connected party.

We are using the following 2 options of misdn.conf
1) astdtmf=yes
2) senddtmf=yes

Option one is necessary because the asterisk DSP DTMF detection is better
than mISDN's internal DSP.  Not as many false positives.

Option two is necessary to transmit DTMF tones end to end when mISDN
channels are connected to SIP channels with out of band DTMF for example.

The symptom is that DTMF tones sent by an ISDN phone are doubled on the
way through asterisk when two mISDN channels are connected with a Local
channel in between or if it is bridged to an analog channel.

The doubling of DTMF tones is because DTMF is passed inband to asterisk by
the mISDN channel and passed out of band once again after the release of
the DTMF tone.  Passing it inband is wrong.  Neither an analog channel nor
SIP channel passes DTMF inband if configured to inband DTMF.  Analog and
SIP channels filter out the DTMF tones because they use the voice frames
returned by ast_dsp_process.  But chan_misdn passes the unfiltered input
voice frames instead.

To overcome one aspect of the problem, the doubling of DTMF tones when two
mISDN channels are directly bridged, someone made an 'optimization', where
in that case the DTMF tone passed out-of-band to the peer channel is not
translated to an inband tone at the transmit side.  This optimization is
bad because it does not work in general.  For example, analog channels or
mISDN channels when bridged through an intermediary local channel will
generate DTMF tones from out-of-band information.  Also, of course, it
must not be done when there is no inband DTMF available.

This patch fixes the issue.  Now chan_misdn will filter the received
inband DTMF signal the same as other channel types.

Another change included: No need to build an extra translation path
because ast_process_dsp does it if required.

Patches:
	misdn-dtmf.patch

JIRA ABE-2080


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@247910 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-19 17:18:49 +00:00
Matthew Nicholson
815f726220 Copy the calling party's account code to the called party if they don't already have one.
(closes issue #16331)
Reported by: bluefox
Tested by: mnicholson


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@247651 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-18 19:38:09 +00:00
Leif Madsen
e34cdeceaf Add additional link to best practices document per jsmith.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@247508 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-18 16:53:44 +00:00
Leif Madsen
879ee0b9a6 Add best practices documentation.
(issue #16808)
Reported by: lmadsen

(issue #16810)
Reported by: Nick_Lewis
Tested by: lmadsen

Review: https://reviewboard.asterisk.org/r/507/

git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@247502 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-18 16:38:17 +00:00
Russell Bryant
e691e5c6a6 Tweak argument handling for wget in the sounds Makefile.
1) Fix the check to see if we are using wget to not be full of fail.  The
configure script populates this variable with the absolute path to wget if
it is found, so it didn't work.

2) Allow some extra arguments to be passed in for wget.  This is just a simple
change to allow our Bamboo build script to tell wget to be quiet and not fill
up our logs with download status output.


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@247422 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-18 04:19:01 +00:00
Mark Michelson
a01809c2c2 Make sure that when autofill is disabled that callers not in the front of the queue cannot place calls.
(closes issue #16834)
Reported by: kebl0155
Patches:
      app_queue_no_autofill.v1.patch uploaded by kebl0155 (license 356)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@247168 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-17 16:24:17 +00:00
Tilghman Lesher
ace50777f2 Make the menuselect instructions correct by allowing 'make menuselect' to actually solve dependency problems.
(Previously, it would fail out again with the same message about running
'make menuselect', which was NOT at all helpful.)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@246709 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-15 23:42:33 +00:00
David Vossel
ff6dd92e3e lock channel during datastore removal
On channel destruction the channel's datastores are removed and
destroyed.  Since there are public API calls to find and remove
datastores on a channel, a lock should be held whenever datastores are
removed and destroyed.  This resolves a crash caused by a race
condition in app_chanspy.c.

(closes issue #16678)
Reported by: tim_ringenbach
Patches:
      datastore_destroy_race.diff uploaded by tim ringenbach (license 540)
Tested by: dvossel




git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@246545 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-12 23:30:17 +00:00
Jason Parker
403eb70599 Fix some silly formatting, and remove unnecessary option_debug checks
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@246460 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-12 18:52:28 +00:00
David Vossel
47de4d5211 fixes random deadlock in app_queue with use_weight during reload
(closes issue #16677)
Reported by: tim_ringenbach
Patches:
      app_queue_use_weight_deadlock.diff uploaded by tim ringenbach (license 540)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@246115 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-10 17:44:20 +00:00
Tilghman Lesher
793e58a924 Include examples of FILTER usage in extension patterns where a "." may be a risk.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@245944 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-10 13:37:13 +00:00
Olle Johansson
b279512253 Make sure that res_smdi loads regardless of configuration, since chan_dahdi depends on res_smdi
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@245909 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-10 08:24:34 +00:00
David Vossel
5a823cad50 Fixes iaxs and iaxsl size off by one issue.
2^15 = 32768 which is the maximum allowed iax2 callnumber.
Creating the iaxs and iaxsl array of size 32768 means the maximum
callnumber is actually out of bounds.  This causes a nasty crash.

(closes issue #15997)
Reported by: exarv
Patches:
      iax_fix.diff uploaded by dvossel (license 671)



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@245792 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-09 22:55:38 +00:00
Jason Parker
90f2840242 Remove reference of documentation in source directory.
People don't always build Asterisk from source (distro packages, anybody?).


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@245496 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-08 20:39:50 +00:00
Olle Johansson
ed94dddd97 Res_features depends on res_adsi in 1.4
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@245422 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-08 11:57:52 +00:00
Kevin P. Fleming
c540f2eff1 Remove contrib/firmware directory as it is empty
Remove explicit license for IAXy firmware as it is no longer included in the tree



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@245044 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-05 18:32:29 +00:00
Sean Bright
90bf027119 Update main copyright date.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@244926 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-05 17:03:35 +00:00
Jeff Peeler
735485effc Change channel state on local channels for busy,answer,ring.
Previously local channels channel state never changed. This became problematic
when the state of the other side of the local channel was lost, for example
during a masquerade. Changing the state of the local channel allows for the
scenario to be detected when the channel state is set to ringing, but the peer
isn't ringing. The specific problem scenario is described in 164201. Although
this was noted on one of the issues, here is the tested dialplan verified to
work:

exten => 9700,1,Dial(Local/*9700@default&Local/#9700@default)

exten => *9700,1,Set(GLOBAL(TESTCHAN)=${CHANNEL:0:${MATH(${LEN(${CHANNEL})}-1):0:2}}1)
exten => *9700,n,wait(3) ;3 works, 1 did not
exten => *9700,n,Dial(SIP/5001)

exten => #9700,1,Wait(1) ;1 works, 3 did not
exten => #9700,n,ChannelRedirect(${TESTCHAN},parkedcalls,701,1)

(closes issue #14992)
Reported by: davidw


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@244785 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-04 23:20:21 +00:00
Tilghman Lesher
277db8b69d Backup and restore original textfile, for prosthesis (gerund of prepend).
Also, fix menuselect such that changing voicemail build options correctly
causes rebuild.

(closes issue #16415)
 Reported by: tomo1657
 Patches: 
       prepention.patch uploaded by tomo1657 (license 484)
       (with modifications by me to backport to 1.4)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@244242 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-01 23:13:44 +00:00
Tilghman Lesher
bad37b9a69 When a transferer hangs up during an attended transfer BEFORE the transfer is answered, don't stop playing MOH.
(closes issue #16513)
 Reported by: litnimax
 Patches: 
       atxfer_moh_16513.patch uploaded by gknispel proformatique (license 261)
 Tested by: litnimax


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@244151 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-01 18:38:37 +00:00
Tilghman Lesher
72af53a885 Revert previous chan_local fix (r236981) and fix instead by destroying expired frames in the queue.
(closes issue #16525)
 Reported by: kobaz
 Patches: 
       20100126__issue16525.diff.txt uploaded by tilghman (license 14)
       20100129__issue16525__1.6.0.diff.txt uploaded by tilghman (license 14)
 Tested by: kobaz, atis

(closes issue #16581)
 Reported by: ZX81

(closes issue #16681)
 Reported by: alexr1



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@244070 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-02-01 17:46:31 +00:00
Leif Madsen
a5722e173c Oops, correct wrong link (https vs. http) in previous commit.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243863 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-28 18:48:24 +00:00
Leif Madsen
d4b45b2dab Update location of bug tracker in documentation.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243862 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-28 18:46:20 +00:00
Russell Bryant
fe49526a56 Fix a bogus third argument to ast_copy_string().
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243779 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-28 15:03:17 +00:00
Jeff Peeler
e0704019cc Revert 243570, I should have looked at this closer. Will reopen the issue, but
am leaving the review closed as the change was pointless.

(issue #16488)


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243691 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-27 20:35:56 +00:00
Jeff Peeler
d889f4c191 Extend announcement URL used with Queue from 80 chars to PATH_MAX.
(closes issue #16488)
Reported by: syspert
Patches: 
      soundfilelen.pacth-2 uploaded by syspert (license 938)

Review: https://reviewboard.asterisk.org/r/475/


git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243570 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-27 18:47:34 +00:00
Mark Michelson
c3db30de46 Use a safe list traversal while checking for duplicate vars in pbx_builtin_setvar_helper.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243486 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-27 18:06:43 +00:00
David Vossel
fb0cf432f1 fixes bug with channel receiving wrong privileges after call parking
(closes issue #16429)
Reported by: Yasuhiro Konishi
Patches:
      features.c.diff uploaded by Yasuhiro Konishi (license 947)
Tested by: dvossel



git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243390 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-26 23:55:49 +00:00
Jeff Peeler
b024a9452d Remove unnecessary code in ast_read as issue 16058 has been fully solved now.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@243258 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-26 18:19:10 +00:00
Tilghman Lesher
82b871e683 Err, and use the new menuselect define, too.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@242969 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-25 21:50:22 +00:00
Tilghman Lesher
af31dd313c Only rebuild parsers by an option in menuselect
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@242966 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2010-01-25 21:36:33 +00:00