Steve Murphy
b04af32888
Applied the same fixes for ael.flex as was done in 97849 for ast_expr2.fl; overrode the normally generate yyfree func with our own version that checks the pointer for non-null before passing to free(). Also takes care of a little problem with 2.5.33 and the use of the __STDC_VERSION__ macro.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97889 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 21:37:10 +00:00
Steve Murphy
9eeca94298
This is a fix for 2 things: a problem Terry was having in OSX with null pointers, which was my fault, as I probably forgot to run the sed script last time I made mods. So, I moved the fix into the flex input itself. Then, I found when I used flex 2.5.33, that it was using __STDC_VERSION__, and that's not real good; so I added back in a DIFFERENT sed script to fix that little mess. Tested everything, a couple different ways. Hope I did no harm, at the least.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97849 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 20:21:27 +00:00
Jason Parker
00b8f86349
Fix a comment that is no longer true.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97847 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 20:12:37 +00:00
Russell Bryant
142e5dd457
Remove other remnants of pbx_kdeconsole
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97753 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 16:19:47 +00:00
Russell Bryant
742fd8127c
Remove pbx_kdeconsole from the tree. It hasn't worked in ages, and nobody has
...
complained.
(closes issue #11706 , reported by caio1982)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97734 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 16:10:09 +00:00
Joshua Colp
91762636b9
Don't try to copy the category from the group if no category exists.
...
(closes issue #11724 )
Reported by: IgorG
Patches:
group_count.v1.patch uploaded by IgorG (license 20)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97697 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-10 15:07:12 +00:00
Russell Bryant
3378ef39fd
Strip terminal sequences from the verbose messages
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97645 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 23:01:48 +00:00
Russell Bryant
d8004449d5
Make pbx_gtkconsole build ... but doesn't actually load on my system still
...
(related to issue #11706 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97640 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 22:26:33 +00:00
Jason Parker
3b966ed04e
Correctly display a message if a command could not be found.
...
Also fix a comment which may have led to this happening.
Issue 11718, reported by kshumard.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97622 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 20:28:43 +00:00
Jason Parker
5583996b22
Fix some locking and return value funkiness. We really shouldn't be unlocking this lock inside of a function, unless we locked it there too.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97618 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 20:05:45 +00:00
Mark Michelson
2da89b6120
Part 2 of app_queue doxygen improvements. Some smaller functions this time
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97575 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 18:48:15 +00:00
Russell Bryant
eebd74ee97
Fix saying the parking space number to the caller doing the parking ...
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97529 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 18:02:08 +00:00
Kevin P. Fleming
ce81b232e3
report the same message whether Zaptel does not have transcoder support loaded or no transcoders were found
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97491 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 17:21:14 +00:00
Philippe Sultan
863ef8d7d2
Set the caller id within the gtalk_alloc function.
...
As underlined in issue #10437 by Josh, we need to prevent a possible
memory leak. We only set the name part of the caller id, the number
part is not relevant when dealing with JIDs.
Closes issue #11549 .
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97489 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 16:44:24 +00:00
Joshua Colp
7a3ee5a7fc
Don't do conferencing totally in Zaptel if Monitor is running on the channel.
...
(closes issue #11709 )
Reported by: BigJimmy
Patches:
patch-meetmerec uploaded by BigJimmy (license 371)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97450 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 16:11:17 +00:00
Kevin P. Fleming
d235974bd6
pass the right variable to get an error string... oops
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97448 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 15:43:19 +00:00
Kevin P. Fleming
7bfd21933f
add error number output to ioctl failure messages to help with debugging
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97410 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 15:26:23 +00:00
Tilghman Lesher
1f14e0cf39
Allow filename completion on zero-length modules, remove a memory leak, remove
...
a file descriptor leak, and make filename completion thread-safe.
Patched and tested by tilghman.
(Closes issue #11681 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97350 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 00:44:14 +00:00
Mark Michelson
34f994f017
use the \retval doxygen command properly
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97308 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-09 00:17:40 +00:00
Mark Michelson
2a0748b0fe
Part 1 of N of adding doxygen comments to app_queue. I picked some of the most common functions
...
used (which also happen to be some the biggest/ugliest functions too) to document first. I'm pretty
new to doxygen so criticism is welcome.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97304 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 23:49:11 +00:00
Mark Michelson
fdd5c25103
Some coding guidelines-related cleanup
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97206 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 21:24:48 +00:00
Joshua Colp
61ee1872b1
Fix various DTMF issues in chan_mgcp.
...
(closes issue #11443 )
Reported by: eferro
Patches:
dtmf_control_hybrid-inband-mode.patch uploaded by eferro (license 337)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97195 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 20:48:20 +00:00
Tilghman Lesher
3acbb032f8
Increase constants to where we're less likely to hit them while debugging.
...
(Closes issue #11694 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97194 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 20:47:07 +00:00
Mark Michelson
b5ea488a1d
Making some changes designed to not allow for a corrupted mailstream for a vm_state.
...
1. Add locking to the vm_state retrieval functions so that no linked list corruption occurs.
2. Make sure to always grab the persistent vm_state when mailstream access is necessary.
3. Correct an incorrect return value in the init_mailstream function.
(closes issue #11304 , reported by dwhite)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97192 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 20:42:07 +00:00
Joshua Colp
edfb14d0f6
If no group has been provided to the GROUP_COUNT dialplan function then use the first one specific to the channel.
...
(closes issue #11077 )
Reported by: m4him
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97152 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 19:53:52 +00:00
Joshua Colp
be83b74be9
Make app_queue calls work with directed pickup.
...
(closes issue #11700 )
Reported by: jbauer
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97093 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 18:36:40 +00:00
Tilghman Lesher
1b289c2998
Apply multiple crash fixes, found in issue #11386 , but not completely
...
closing that issue.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@97077 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-08 18:02:13 +00:00
Russell Bryant
9aa3d2dd7f
Merged revisions 96931 via svnmerge from
...
https://origsvn.digium.com/svn/asterisk/branches/1.2
........
r96931 | russell | 2008-01-07 14:46:22 -0600 (Mon, 07 Jan 2008) | 2 lines
Change misery.digium.com to pbx.digium.com
........
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96932 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-07 20:47:52 +00:00
Russell Bryant
61a1ce95a5
Don't crash if something happens when setting up an SMDI interface and it gets
...
destroyed before the SMDI port handling thread gets created.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96884 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-07 16:39:23 +00:00
Philippe Sultan
ee7978e96e
Indentation fix, makes the code easier to read
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96815 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-07 14:34:36 +00:00
Philippe Sultan
e531dcb1af
Compute the base64 value over the [authzid]\0authcid\0password string,
...
thus excluding the trailing NULL byte.
This change has already been committed to trunk, see #11644 .
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96797 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-07 14:25:29 +00:00
Russell Bryant
b11422fe8f
Don't pass an empty string as the device name.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96644 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-05 02:09:19 +00:00
Tilghman Lesher
8770045be8
Fix the problem of notification of a device state change to a device with a '-'
...
in the name. Could probably do with a better fix in trunk, but this bug has
been open way too long without a better solution.
Reported by: stevedavies
Patch by: tilghman
(Closes issue #9668 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96575 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-04 23:03:40 +00:00
Jason Parker
6cc0887f56
Properly continue in the dialplan if using PARKINGEXTEN and the slot is full.
...
Issue 11237, patch by me.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96573 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-04 22:55:56 +00:00
Tilghman Lesher
58cc575e52
If you change the bindaddr in sip.conf to a non-bound address and reload, sip goes kablooie.
...
Reported and patched by: one47
(Closes issue #11535 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96525 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-04 19:27:25 +00:00
Russell Bryant
6787783ce5
Make use of the temporary channel pointer while the pvt is unlocked.
...
(closes issue #11675 )
Reported by: flefoll
Patches:
chan_zap.c.patch-store-owner-before-unlock uploaded by flefoll (license 244)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96449 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-04 16:19:22 +00:00
Russell Bryant
6ae86ec183
Don't crash if the iax2 pvt structure has been destroyed before we get to this point
...
(closes issue #11672 , reported by snuffy, patched by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96394 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-03 22:44:22 +00:00
Tilghman Lesher
6d96102150
Missed initialization caused crash.
...
Reported and fixed by: tiziano
(Closes issue #11671 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96318 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-03 21:37:02 +00:00
Christian Richter
2a4a61f914
make sure frame is completely clean, before we send it to asterisk as DTMF. If we don't make it clean, it happens that one way audio occurs..
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96199 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-03 12:12:27 +00:00
Christian Richter
be6e667c1e
when overlapdial was used and no number was dialed, the call was dropped, now we just jump into the s extension, which makes a lot more sense.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96198 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-03 12:08:40 +00:00
Mark Michelson
068e1d8208
We need to reset the membername to NULL on each iteration of this loop, otherwise the result is that
...
multiple members can have the same name, since the variable was not reset on each iteration of the loop.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96102 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-02 23:46:02 +00:00
Russell Bryant
ec8a896935
Convert locks of the contexts list in pbx_config to the appropriate rdlock or wrlock
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96024 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-02 22:14:28 +00:00
Russell Bryant
93748ccb9c
pbx_dundi only needs a rdlock on the contexts list.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96022 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-02 22:04:47 +00:00
Russell Bryant
4ee7457343
app_macro only needs a rdlock on the contexts list.
...
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@96020 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-02 22:00:21 +00:00
Joshua Colp
b5087d7743
Allocate a SIP refer structure when performing a transfer using BYE with Also so that the transfer information is properly stored. (AST-2008-001)
...
(closes issue #11637 )
Reported by: greyvoip
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95946 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-02 20:24:09 +00:00
Mark Michelson
60c6826c1c
A change to improve the accuracy of queue logging in the case where a member does not
...
answer during the specified timeout period. Prior to this change, there was a small chance
that the member name recorded in this case would be blank. Also prior to this change, if using
the ringall strategy, if no one answered the call during the specified timeout, the member name
listed in the queue log would randomly be one of the members that was rung.
(closes issue #11498 , reported and tested by hloubser, patched by me)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95890 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2008-01-02 17:51:22 +00:00
Mark Michelson
8fded490ce
Avoiding a potentially bad locking situation. ast_merge_contexts_and_delete writelocks the conlock, then
...
calls ast_hint_extension, which attempts to readlock the same lock. Recursion with read-write locks is
dangerous, so the inner lock needs to be removed. I did this by copying the "guts" of ast_hint_extension
into ast_merge_contexts_and_delete (sans the extra lock).
(this change is inspired by the locking problems seen in issue #11080 , but I have no idea if this is the
problematic area experienced by the reporters of that issue)
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95577 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-31 23:43:13 +00:00
Tilghman Lesher
3d142f0271
Allow the default "0" to be returned if the STAT fails
...
(Closes issue #11659 )
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95470 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-31 20:27:26 +00:00
Russell Bryant
ce3f27c5d5
Remove duplicate increment of the header count in the add_header() function.
...
(closes issue #11648 )
Reported by: makoto
Patch provided by sergee, committed patch by me, inspired by comments from putnopvut
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95191 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-28 18:24:59 +00:00
Mark Michelson
a7dee30a8d
I found a bug while browsing the queue code and managed to reproduce it in a small setup.
...
If a queue uses the ringall strategy, it was possible through unfortunate coincidence for a single member at a given penalty level to
make app_queue think that all members at that penalty level were unavailable and cause the members at the
next penalty level to be rung. With this patch, we will only move to the next penalty level if ALL the members
at a given penalty level are unreachable.
git-svn-id: https://origsvn.digium.com/svn/asterisk/branches/1.4@95095 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2007-12-28 00:16:15 +00:00