Commit Graph

30513 Commits

Author SHA1 Message Date
Jenkins2 f340e9e24d Merge "codec_gsm: Avoid shifting a negative signed value." 2018-01-09 06:22:30 -06:00
Jenkins2 832f058719 Merge "res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation." 2018-01-09 05:46:34 -06:00
Joshua Colp d407171a33 Merge "BuildSystem: Find ptlib-config on Debian/Ubuntu." 2018-01-09 05:41:24 -06:00
Jenkins2 8e18209cad Merge "res_stasis: Fix app_is_subscribed_bridge_id." 2018-01-08 11:25:45 -06:00
Jenkins2 94e7a7675b Merge "General: Avoid implicit conversion to char when changes value to negative." 2018-01-08 06:51:40 -06:00
Jenkins2 9c746dc55e Merge "bridge_softmix: Removed unused parameter from check_binaural_position_change(.)." 2018-01-08 06:38:13 -06:00
Jenkins2 4b326eb289 Merge "editline: Avoid comparison between pointer and zero character constant." 2018-01-08 06:13:32 -06:00
Jenkins2 341a258b34 Merge "pbx: Prevent execution of NULL pointer." 2018-01-08 05:53:29 -06:00
Corey Farrell 6870ba5f26 res_stasis: Fix app_is_subscribed_bridge_id.
Instead of searching for bridge_id provided in an argument this function
always searched for BRIDGE_ALL first.  Rewrite this function to work
like the similar functions for channel and endpoint functions.

Change-Id: Ib5caca69e11727c5c8a7284a1d00621f40f1e60a
2018-01-07 21:21:13 -05:00
Jenkins2 634d30fb9e Merge "General: Silence modules on (un)load." 2018-01-07 16:46:49 -06:00
Jenkins2 26e5edd043 Merge "chan_ooh323: Limit outgoinglimit to positive values as intended." 2018-01-06 20:56:24 -06:00
Jenkins2 bcc2931d22 Merge "BuildSystem: Avoid obsolete warning with HELP_STRING on autoconf." 2018-01-06 20:31:04 -06:00
Alexander Traud 7e9781c25e General: Silence modules on (un)load.
Some (normally optional) modules created notices, warnings, and even errors
in normal situations like (un)load. This cluttered the command-line interface
(CLI) on start and while stopping gracefully. However, when an user went for
the script './contrib/scripts/install_prereq', those modules get compiled-in
because their prerequisites were met at compile time. Furthermore, because of
ASTERISK_27475, the former talkative module 'res_curl' is built as side-effect.

ASTERISK-27553

Change-Id: I9f105f46d72553994e820679bfde3478a551b281
2018-01-06 20:13:07 -06:00
Alexander Traud f84fcc1fc1 General: Avoid implicit conversion to char when changes value to negative.
clang 5.0 warned about this.

ASTERISK-27557

Change-Id: I7cceaa88e147cbdf81a3a7beec5c1c20210fa41e
2018-01-06 22:12:40 +01:00
Alexander Traud b12c8cffad bridge_softmix: Removed unused parameter from check_binaural_position_change(.).
Found as a result of the function being passed an uninitalized variable by
clang.

ASTERISK-27550

Change-Id: I8af3bd84656b685a956d498459f8db3613f68954
2018-01-06 19:06:00 +01:00
Alexander Traud ad3252ccef editline: Avoid comparison between pointer and zero character constant.
gcc 7.2 warned about this.

ASTERISK-27559

Change-Id: I48960dda9cf0a11b6a9426f775e632363f8caa74
2018-01-06 13:45:28 +01:00
Alexander Traud ef68df9111 codec_gsm: Avoid shifting a negative signed value.
clang 5.0 warned about this.

ASTERISK-27558

Change-Id: Icc452ecb0d86bbeba78dae768cc472ec540699df
2018-01-06 12:01:00 +01:00
Richard Mudgett b20b5758d9 res_pjsip_endpoint_identifier_ip.c: Fix apply identify validation.
The ip_identify_apply() did not validate the configuration for simple
static configuration errors or deal well with address resolution errors.

* Added missing configuration validation checks.
* Fixed address resolution error handling.
* Demoted an error message to a warning since it does not fail applying
the identify object configuration.

Change-Id: I8b519607263fe88e8ce964f526a45359fd362b6e
2018-01-05 18:49:28 -06:00
Alexander Traud af064eaf13 BuildSystem: Find ptlib-config on Debian/Ubuntu.
The current configure script requires that tool when libpt-dev is installed.
libpt-dev was installed by libopenh323-dev, bacause you wanted to go for H.323
based channel drivers.

ASTERISK-25329

Change-Id: I9c6ab78b7246c21536e1d252dcbffe682f63f83d
2018-01-05 21:56:17 +01:00
Alexander Traud f0c8f04c73 chan_ooh323: Limit outgoinglimit to positive values as intended.
ASTERISK-27552

Change-Id: Ifbf9d51e7374ca2e8b27ec568f6770050fc1a854
2018-01-05 08:02:21 -06:00
Alexander Traud 09f339bda5 ooh323cDriver: Fix typo in header guard.
ASTERISK-27551

Change-Id: I39ff66031e3373e895e2bc47b23a5e860ea4e012
2018-01-05 13:19:36 +01:00
Alexander Traud bc1b4f4d43 BuildSystem: Avoid obsolete warning with HELP_STRING on autoconf.
ASTERISK-26046

Change-Id: I48f05698c235f709225b92bec5aa260fb57d69d1
2018-01-05 10:36:49 +01:00
Corey Farrell cfb88f3ac1 pbx: Prevent execution of NULL pointer.
pbx_extension_helper has a check for q->swo.exec == NULL but it doesn't
actually return so we would still run the function.  Fix the return.
Move the 'int res' variable into the only scope which uses it.

Also fix a copy-paste error in ast_pbx_init which could result in a
crash on allocation failure (we exit with a normal error instead).

Change-Id: I0693af921fdc7f56b6a72a21fb816ed08b960a69
2018-01-04 16:50:04 -05:00
Jenkins2 4eccf697e1 Merge "rtp_engine: Add missing unlock." 2018-01-04 15:02:15 -06:00
Joshua Colp 5cab877093 Merge "translators: Don't use ast_module_running_ref." 2018-01-04 14:49:06 -06:00
Jenkins2 a79a8d1526 Merge "res_pjsip_history: Add missing unlock to CLI command." 2018-01-04 14:24:25 -06:00
Jenkins2 f33ed0d247 Merge "aco: Fix NULL dereference in error path." 2018-01-04 14:00:43 -06:00
Jenkins2 8187bde9bf Merge "func_odbc: Add missing unlock's to acf_odbc_read." 2018-01-04 13:53:20 -06:00
Corey Farrell 82cf585fb5 translators: Don't use ast_module_running_ref.
Translators are run during module load before the module is actually
running, so it cannot use ast_module_running_ref.

ASTERISK-20346

Change-Id: Iaa0e75da99c696e38000f1a41e340abbd7a88f56
2018-01-04 12:01:56 -05:00
Corey Farrell da365affbd rtp_engine: Add missing unlock.
Change-Id: I380c31a255e060309f4916da11176e0d00813215
2018-01-04 10:39:59 -05:00
Corey Farrell 73bf5035b8 res_pjsip_history: Add missing unlock to CLI command.
Change-Id: I872060a30543776a176a316309602d924a23eb29
2018-01-04 10:30:48 -05:00
Corey Farrell aaed0b8b3a aco: Fix NULL dereference in error path.
Change-Id: Id505167cf0f9414a3c144fa2c1e181a2cf288694
2018-01-04 10:27:44 -05:00
Joshua Colp 2fac32a37a Merge "loader: Create ast_module_running_ref." 2018-01-04 07:12:43 -06:00
Joshua Colp 25399f74aa Merge "res_pjsip_session: Check if sequence header is missing" 2018-01-04 07:01:04 -06:00
Joshua Colp 307abc4cad Merge "datastore: Add automatic module references." 2018-01-04 06:53:28 -06:00
Corey Farrell e3c9314a2e func_odbc: Add missing unlock's to acf_odbc_read.
Change-Id: I828329ecbd252ae8f27a369a046d2b03102b07c6
2018-01-03 20:31:40 -05:00
Corey Farrell 55f1d69c43 loader: Create ast_module_running_ref.
This function returns NULL if the module in question is not running.  I
did not change ast_module_ref as most callers do not check the result
and they always call ast_module_unref.

Make use of this function when running registered items from:
* app_stack API's
* bridge technologies
* CLI commands
* File formats
* Manager Actions
* RTP engines
* Sorcery Wizards
* Timing Interfaces
* Translators
* AGI Commands
* Fax Technologies

ASTERISK-20346 #close

Change-Id: Ia16fd28e188b2fc0b9d18b8a5d9cacc31df73fcc
2018-01-03 17:23:36 -05:00
Jenkins2 7f4facc5e4 Merge "res_pjsip: Add AMI action 'PJSIPShowAors'" 2018-01-03 15:29:36 -06:00
Kevin Harwell 62f862e2cd res_pjsip_session: Check if sequence header is missing
The pjsip_msg_find_hdr function can return NULL. This patch adds a check
when searching for the sequence header to make sure a NULL pointer is never
de-referenced.

Change-Id: I19af23aeeded65be016be92360e8cb7ffe51fad2
2018-01-03 10:46:25 -06:00
Jenkins2 84d0871380 Merge "core: Use macros to generate ao2_container callbacks where possible." 2018-01-03 07:50:36 -06:00
Jenkins2 9efcaf5eb0 Merge "astobj2: Create case-insensitive variants of container function macros." 2018-01-03 07:32:15 -06:00
Joshua Colp f77ca95418 Merge "aco: Add missing aco_option_type_string for OPT_TIMELEN_T." 2018-01-03 07:09:38 -06:00
Jenkins2 5a1525345e Merge "cdr: submit: fix logic of test for batch mode" 2018-01-03 06:43:47 -06:00
Joshua Colp 72e77539ee Merge "cdr_mysql: Make sure connection charset is always set" 2018-01-02 07:48:24 -06:00
Jenkins2 6480777005 Merge "stasis_channels.c: Misc cleanup." 2018-01-02 07:38:44 -06:00
Tzafrir Cohen 9b5d1454b4 cdr: submit: fix logic of test for batch mode
ASTERISK-27539 #close

Change-Id: I33cdf329d2bb4486dcae975c450f6aae94c515f7
2018-01-02 15:36:04 +02:00
Sungtae Kim ffbf5be116 res_pjsip: Add AMI action 'PJSIPShowAors'
Add an AMI action which provides information on all
configured AORs.

ASTERISK-27537

Change-Id: If8b990a00909e5b6c0f04a3b8dccd9903dc445eb
2018-01-02 12:24:38 +00:00
Corey Farrell f298178583 aco: Add missing aco_option_type_string for OPT_TIMELEN_T.
ASTERISK-27117

Change-Id: I8f6c34bb30830be9f7a40823723eb4dcaaa91c61
2018-01-02 01:26:10 -05:00
Sean Bright 15f8b9b8bf ice: Increase foundation buffer size
Per RFC 5245, the foundation specified with an ICE candidate can be up
to 32 characters but we are only allowing for 31.

ASTERISK-27498 #close
Reported by: Michele Prà

Change-Id: I05ce7a5952721a76a2b4c90366168022558dc7cf
2017-12-31 11:34:41 -05:00
Corey Farrell b32d6d5e2d astobj2: Create case-insensitive variants of container function macros.
* AO2_STRING_FIELD_CASE_HASH_FN
* AO2_STRING_FIELD_CASE_CMP_FN
* AO2_STRING_FIELD_CASE_SORT_FN

Change-Id: I11af8c6a0c43380a42732553f519c667abb842cf
2017-12-30 13:39:24 -05:00