Compare commits

...

16 Commits

Author SHA1 Message Date
Leif Madsen
ded998cf63 Importing release summary for 1.6.0.19 release.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231613 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 21:11:37 +00:00
Leif Madsen
848a82e6da Update ChangeLog for additional SDP regression fix.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231611 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 21:10:13 +00:00
Leif Madsen
20f9aebd29 Remove old or outdated summary files.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231609 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 21:06:13 +00:00
Joshua Colp
9b12e00840 When receiving SDP that matches the version of the last one do not treat it as a fatal error.
(closes issue #16238)
Reported by: seandarcy 


git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231606 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 20:51:12 +00:00
Leif Madsen
1c923c514f Importing release summary for 1.6.0.19 release.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231555 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 18:50:19 +00:00
David Vossel
bd3abe1f7c SDP regression fix
Ensure that SDP parsing does not ignore the last line of the SDP.

(closes issue #16268)
Reported by: sgimeno



git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231533 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 18:19:06 +00:00
David Vossel
3cbfc7cbcf AST-2009-010
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231521 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 17:50:44 +00:00
Leif Madsen
4e2c5513ca Update ChangeLog file to reference closed issue.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231495 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 17:29:02 +00:00
Leif Madsen
b418720c84 Update .version and ChangeLog files.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231473 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 17:24:35 +00:00
Leif Madsen
b9e85920db Create Asterisk 1.6.0.19 from 1.6.0.18
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.19@231444 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-30 17:15:35 +00:00
Leif Madsen
f00843a05c Importing release summary for 1.6.0.18 release.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.18@230431 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-18 18:37:29 +00:00
Leif Madsen
56081362bd Update .version and ChangeLog
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.18@230428 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-18 18:29:39 +00:00
Leif Madsen
4f5f0d53ff Create Asterisk 1.6.0.18 from 1.6.0.18-rc3
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.18@230425 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-18 18:25:19 +00:00
Leif Madsen
102abad138 Use autotagged externals
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.18-rc3@229961 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 16:58:54 +00:00
Leif Madsen
b1f0105c48 Importing files for 1.6.0.18-rc3 release.
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.18-rc3@229960 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 16:58:50 +00:00
Leif Madsen
7e852a9e3a Creating tag for the release of asterisk-1.6.0.18-rc3
git-svn-id: https://origsvn.digium.com/svn/asterisk/tags/1.6.0.18-rc3@229958 65c4cc65-6c06-0410-ace0-fbb531ad65f3
2009-11-13 16:58:05 +00:00
7 changed files with 55296 additions and 13 deletions

1
.lastclean Normal file
View File

@@ -0,0 +1 @@
36

1
.version Normal file
View File

@@ -0,0 +1 @@
1.6.0.19

55069
ChangeLog Normal file

File diff suppressed because it is too large Load Diff

View File

@@ -0,0 +1,79 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN" http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd">
<html xmlns="http://www.w3.org/1999/xhtml">
<head><meta http-equiv="Content-Type" content="text/html; charset=iso-8859-1" /><title>Release Summary - asterisk-1.6.0.19</title></head>
<body>
<h1 align="center"><a name="top">Release Summary</a></h1>
<h3 align="center">asterisk-1.6.0.19</h3>
<h3 align="center">Date: 2009-11-30</h3>
<h3 align="center">&lt;asteriskteam@digium.com&gt;</h3>
<hr/>
<h2 align="center">Table of Contents</h2>
<ol>
<li><a href="#summary">Summary</a></li>
<li><a href="#contributors">Contributors</a></li>
<li><a href="#issues">Closed Issues</a></li>
<li><a href="#commits">Other Changes</a></li>
<li><a href="#diffstat">Diffstat</a></li>
</ol>
<hr/>
<a name="summary"><h2 align="center">Summary</h2></a>
<center><a href="#top">[Back to Top]</a></center><br/><p>This release has been made to address one or more security vulnerabilities that have been identified. A security advisory document has been published for each vulnerability that includes additional information. Users of versions of Asterisk that are affected are strongly encouraged to review the advisories and determine what action they should take to protect their systems from these issues.</p>
<p>Security Advisories: <a href="http://downloads.asterisk.org/pub/security/AST-2009-010.html">AST-2009-010</a></p>
<p>The data in this summary reflects changes that have been made since the previous release, asterisk-1.6.0.18.</p>
<hr/>
<a name="contributors"><h2 align="center">Contributors</h2></a>
<center><a href="#top">[Back to Top]</a></center><br/><p>This table lists the people who have submitted code, those that have tested patches, as well as those that reported issues on the issue tracker that were resolved in this release. For coders, the number is how many of their patches (of any size) were committed into this release. For testers, the number is the number of times their name was listed as assisting with testing a patch. Finally, for reporters, the number is the number of issues that they reported that were closed by commits that went into this release.</p>
<table width="100%" border="0">
<tr>
<td width="33%"><h3>Coders</h3></td>
<td width="33%"><h3>Testers</h3></td>
<td width="33%"><h3>Reporters</h3></td>
</tr>
<tr valign="top">
<td>
6 lmadsen<br/>
2 dvossel<br/>
</td>
<td>
</td>
<td>
1 sgimeno<br/>
</td>
</tr>
</table>
<hr/>
<a name="issues"><h2 align="center">Closed Issues</h2></a>
<center><a href="#top">[Back to Top]</a></center><br/><p>This is a list of all issues from the issue tracker that were closed by changes that went into this release.</p>
<h3>Category: Channels/chan_sip/General</h3><br/>
<a href="https://issues.asterisk.org/view.php?id=16268">#16268</a>: [patch] Last line of SDP is not being parsed<br/>
Revision: <a href="http://svn.digium.com/view/asterisk/tags/1.6.0.19?view=revision&revision=231533">231533</a><br/>
Reporter: sgimeno<br/>
Coders: dvossel<br/>
<br/>
<hr/>
<a name="commits"><h2 align="center">Commits Not Associated with an Issue</h2></a>
<center><a href="#top">[Back to Top]</a></center><br/><p>This is a list of all changes that went into this release that did not directly close an issue from the issue tracker. The commits may have been marked as being related to an issue. If that is the case, the issue numbers are listed here, as well.</p>
<table width="100%" border="1">
<tr><td><b>Revision</b></td><td><b>Author</b></td><td><b>Summary</b></td><td><b>Issues Referenced</b></td></tr><tr><td><a href="http://svn.digium.com/view/asterisk/tags/1.6.0.19?view=revision&revision=231444">231444</a></td><td>lmadsen</td><td>Create Asterisk 1.6.0.19 from 1.6.0.18</td>
<td></td></tr><tr><td><a href="http://svn.digium.com/view/asterisk/tags/1.6.0.19?view=revision&revision=231473">231473</a></td><td>lmadsen</td><td>Update .version and ChangeLog files.</td>
<td></td></tr><tr><td><a href="http://svn.digium.com/view/asterisk/tags/1.6.0.19?view=revision&revision=231495">231495</a></td><td>lmadsen</td><td>Update ChangeLog file to reference closed issue.</td>
<td></td></tr><tr><td><a href="http://svn.digium.com/view/asterisk/tags/1.6.0.19?view=revision&revision=231521">231521</a></td><td>dvossel</td><td>AST-2009-010</td>
<td></td></tr><tr><td><a href="http://svn.digium.com/view/asterisk/tags/1.6.0.19?view=revision&revision=231555">231555</a></td><td>lmadsen</td><td>Importing release summary for 1.6.0.19 release.</td>
<td></td></tr><tr><td><a href="http://svn.digium.com/view/asterisk/tags/1.6.0.19?view=revision&revision=231609">231609</a></td><td>lmadsen</td><td>Remove old or outdated summary files.</td>
<td></td></tr><tr><td><a href="http://svn.digium.com/view/asterisk/tags/1.6.0.19?view=revision&revision=231611">231611</a></td><td>lmadsen</td><td>Update ChangeLog for additional SDP regression fix.</td>
<td></td></tr></table>
<hr/>
<a name="diffstat"><h2 align="center">Diffstat Results</h2></a>
<center><a href="#top">[Back to Top]</a></center><br/><p>This is a summary of the changes to the source code that went into this release that was generated using the diffstat utility.</p>
<pre>
.version | 2
ChangeLog | 8
asterisk-1.6.0.18-summary.html | 1050 ---------------------------------
asterisk-1.6.0.18-summary.txt | 1271 -----------------------------------------
channels/chan_sip.c | 33 -
main/rtp.c | 1
6 files changed, 30 insertions(+), 2335 deletions(-)
</pre><br/>
<hr/>
</body>
</html>

View File

@@ -0,0 +1,125 @@
Release Summary
asterisk-1.6.0.19
Date: 2009-11-30
<asteriskteam@digium.com>
----------------------------------------------------------------------
Table of Contents
1. Summary
2. Contributors
3. Closed Issues
4. Other Changes
5. Diffstat
----------------------------------------------------------------------
Summary
[Back to Top]
This release has been made to address one or more security vulnerabilities
that have been identified. A security advisory document has been published
for each vulnerability that includes additional information. Users of
versions of Asterisk that are affected are strongly encouraged to review
the advisories and determine what action they should take to protect their
systems from these issues.
Security Advisories: AST-2009-010
The data in this summary reflects changes that have been made since the
previous release, asterisk-1.6.0.18.
----------------------------------------------------------------------
Contributors
[Back to Top]
This table lists the people who have submitted code, those that have
tested patches, as well as those that reported issues on the issue tracker
that were resolved in this release. For coders, the number is how many of
their patches (of any size) were committed into this release. For testers,
the number is the number of times their name was listed as assisting with
testing a patch. Finally, for reporters, the number is the number of
issues that they reported that were closed by commits that went into this
release.
Coders Testers Reporters
6 lmadsen 1 sgimeno
2 dvossel
----------------------------------------------------------------------
Closed Issues
[Back to Top]
This is a list of all issues from the issue tracker that were closed by
changes that went into this release.
Category: Channels/chan_sip/General
#16268: [patch] Last line of SDP is not being parsed
Revision: 231533
Reporter: sgimeno
Coders: dvossel
----------------------------------------------------------------------
Commits Not Associated with an Issue
[Back to Top]
This is a list of all changes that went into this release that did not
directly close an issue from the issue tracker. The commits may have been
marked as being related to an issue. If that is the case, the issue
numbers are listed here, as well.
+------------------------------------------------------------------------+
| Revision | Author | Summary | Issues Referenced |
|----------+---------+-------------------------------+-------------------|
| 231444 | lmadsen | Create Asterisk 1.6.0.19 from | |
| | | 1.6.0.18 | |
|----------+---------+-------------------------------+-------------------|
| 231473 | lmadsen | Update .version and ChangeLog | |
| | | files. | |
|----------+---------+-------------------------------+-------------------|
| 231495 | lmadsen | Update ChangeLog file to | |
| | | reference closed issue. | |
|----------+---------+-------------------------------+-------------------|
| 231521 | dvossel | AST-2009-010 | |
|----------+---------+-------------------------------+-------------------|
| 231555 | lmadsen | Importing release summary for | |
| | | 1.6.0.19 release. | |
|----------+---------+-------------------------------+-------------------|
| 231609 | lmadsen | Remove old or outdated | |
| | | summary files. | |
|----------+---------+-------------------------------+-------------------|
| | | Update ChangeLog for | |
| 231611 | lmadsen | additional SDP regression | |
| | | fix. | |
+------------------------------------------------------------------------+
----------------------------------------------------------------------
Diffstat Results
[Back to Top]
This is a summary of the changes to the source code that went into this
release that was generated using the diffstat utility.
.version | 2
ChangeLog | 8
asterisk-1.6.0.18-summary.html | 1050 ---------------------------------
asterisk-1.6.0.18-summary.txt | 1271 -----------------------------------------
channels/chan_sip.c | 33 -
main/rtp.c | 1
6 files changed, 30 insertions(+), 2335 deletions(-)
----------------------------------------------------------------------

View File

@@ -830,7 +830,7 @@ struct sip_request {
int method; /*!< Method of this request */
int lines; /*!< Body Content */
unsigned int sdp_start; /*!< the line number where the SDP begins */
unsigned int sdp_end; /*!< the line number where the SDP ends */
unsigned int sdp_count; /*!< the number of lines of SDP */
char debug; /*!< print extra debugging if non zero */
char has_to_tag; /*!< non-zero if packet has To: tag */
char ignore; /*!< if non-zero This is a re-transmit, ignore it */
@@ -5883,25 +5883,31 @@ static const char *get_sdp_iterate(int *start, struct sip_request *req, const ch
{
int len = strlen(name);
while (*start < req->sdp_end) {
while (*start < (req->sdp_start + req->sdp_count)) {
const char *r = get_body_by_line(req->line[(*start)++], name, len);
if (r[0] != '\0')
return r;
}
/* if the line was not found, ensure that *start points past the SDP */
(*start)++;
return "";
}
/*! \brief Fetches the next valid SDP line between the 'start' line
* and the 'stop' line. Returns the type ('a', 'c', ...) and
* matching line in reference 'start' is updated with the next line number.
* (inclusive) and the 'stop' line (exclusive). Returns the type
* ('a', 'c', ...) and matching line in reference 'start' is updated
* with the next line number.
*/
static char get_sdp_line(int *start, int stop, struct sip_request *req, const char **value)
{
char type = '\0';
const char *line = NULL;
if (stop > req->sdp_end || stop < req->sdp_start) stop = req->sdp_end;
if (stop > (req->sdp_start + req->sdp_count)) {
stop = req->sdp_start + req->sdp_count;
}
while (*start < stop) {
line = req->line[(*start)++];
@@ -6714,7 +6720,7 @@ static int parse_request(struct sip_request *req)
\param req the SIP request to process
\return 1 if SDP found, 0 if not found
Also updates req->sdp_start and req->sdp_end to indicate where the SDP
Also updates req->sdp_start and req->sdp_count to indicate where the SDP
lives in the message body.
*/
static int find_sdp(struct sip_request *req)
@@ -6747,7 +6753,7 @@ static int find_sdp(struct sip_request *req)
/* if the body contains only SDP, this is easy */
if (!strncasecmp(content_type, "application/sdp", 15)) {
req->sdp_start = 0;
req->sdp_end = req->lines;
req->sdp_count = req->lines;
return req->lines ? 1 : 0;
}
@@ -6786,7 +6792,7 @@ static int find_sdp(struct sip_request *req)
for (x = 0; x < (req->lines ); x++) {
if(!strncasecmp(req->line[x], boundary, strlen(boundary))){
if(found_application_sdp && found_end_of_headers){
req->sdp_end = x-1;
req->sdp_count = (x - 1) - req->sdp_start;
return 1;
}
found_application_sdp = FALSE;
@@ -6802,7 +6808,7 @@ static int find_sdp(struct sip_request *req)
}
}
if(found_application_sdp && found_end_of_headers) {
req->sdp_end = x;
req->sdp_count = x - req->sdp_start;
return TRUE;
}
return FALSE;
@@ -6992,8 +6998,11 @@ static int process_sdp(struct sip_pvt *p, struct sip_request *req, int t38action
int processed = FALSE;
switch (type) {
case 'o':
/* If we end up receiving SDP that doesn't actually modify the session we don't want to treat this as a fatal
* error. We just want to ignore the SDP and let the rest of the packet be handled as normal.
*/
if (!process_sdp_o(value, p))
return -1;
return (p->session_modify == FALSE) ? 0 : -1;
break;
case 'c':
if (process_sdp_c(value, &sessionhp)) {
@@ -7442,6 +7451,8 @@ static int process_sdp_o(const char *o, struct sip_pvt *p)
change media session and increment its own version number in answer
SDP in this case. */
p->session_modify = TRUE;
if (ast_strlen_zero(o)) {
ast_log(LOG_WARNING, "SDP syntax error. SDP without an o= line\n");
return FALSE;
@@ -7490,11 +7501,9 @@ static int process_sdp_o(const char *o, struct sip_pvt *p)
(p->sessionversion_remote < 0) ||
(p->sessionversion_remote < rua_version)) {
p->sessionversion_remote = rua_version;
p->session_modify = TRUE;
} else {
if (p->t38.state == T38_LOCAL_REINVITE) {
p->sessionversion_remote = rua_version;
p->session_modify = TRUE;
ast_log(LOG_WARNING, "Call %s responded to our T.38 reinvite without changing SDP version; 'ignoresdpversion' should be set for this peer.\n", p->callid);
} else {
p->session_modify = FALSE;

View File

@@ -1074,7 +1074,6 @@ static struct ast_frame *process_rfc3389(struct ast_rtp *rtp, unsigned char *dat
}
rtp->f.frametype = AST_FRAME_CNG;
rtp->f.subclass = data[0] & 0x7f;
rtp->f.datalen = len - 1;
rtp->f.samples = 0;
rtp->f.delivery.tv_usec = rtp->f.delivery.tv_sec = 0;
f = &rtp->f;