Compare commits

...

15 Commits

Author SHA1 Message Date
George Joseph
968f188ccf ChangeLog: Updated for 11.23.1 2016-09-08 11:28:35 -05:00
George Joseph
a0f3f8dd8d Release summaries: Add summaries for 11.23.1 2016-09-08 11:28:33 -05:00
George Joseph
329694c975 Release summaries: Remove previous versions 2016-09-08 11:28:26 -05:00
George Joseph
f1dc619c72 .version: Update for 11.23.1 2016-09-08 11:28:26 -05:00
George Joseph
8e4b3c15ff .lastclean: Update for 11.23.1 2016-09-08 11:28:26 -05:00
Joshua Colp
1e248e309e chan_sip: Don't allocate new RTP instances on top of old ones.
In some scenarios dialog_initialize_rtp can be called multiple times on
the same dialog.  This can cause RTP instances to be leaked along with
multiple file descriptors for each instance.

This change makes it so the existing RTP instances are destroyed and
not overwritten, stopping the memory leak.

ASTERISK-26272 #close
patches:
  ASTERISK-26272-11.patch submitted by Corey Farrell (license 5909)

Change-Id: I3c1d94dea8594fe0702168cb979b898ae0f5fc5d
2016-09-08 08:58:40 -06:00
Joshua Colp
d95f2fd979 ChangeLog: Updated for 11.23.0 2016-07-21 09:56:56 -05:00
Joshua Colp
9a0768384c Release summaries: Add summaries for 11.23.0 2016-07-21 09:56:49 -05:00
Joshua Colp
ad439c5ffe Release summaries: Remove previous versions 2016-07-21 09:55:45 -05:00
Joshua Colp
70f9a858a6 .version: Update for 11.23.0 2016-07-21 09:55:44 -05:00
Joshua Colp
4a0378f4ce .lastclean: Update for 11.23.0 2016-07-21 09:55:44 -05:00
Mark Michelson
b40583a6e7 ChangeLog: Updated for 11.23.0-rc1 2016-06-23 09:14:32 -05:00
Mark Michelson
638b840510 Release summaries: Add summaries for 11.23.0-rc1 2016-06-23 09:13:35 -05:00
Mark Michelson
6615d6f90e .version: Update for 11.23.0-rc1 2016-06-23 09:12:32 -05:00
Mark Michelson
e97ccd7e0c .lastclean: Update for 11.23.0-rc1 2016-06-23 09:12:31 -05:00
6 changed files with 38304 additions and 22 deletions

1
.lastclean Normal file
View File

@@ -0,0 +1 @@
40

1
.version Normal file
View File

@@ -0,0 +1 @@
11.23.1

38132
ChangeLog Normal file

File diff suppressed because it is too large Load Diff

View File

@@ -0,0 +1,23 @@
<!DOCTYPE html PUBLIC "-//W3C//DTD XHTML 1.0 Transitional//EN"http://www.w3.org/TR/xhtml1/DTD/xhtml1-transitional.dtd"><html xmlns="http://www.w3.org/1999/xhtml"><title>Release Summary - asterisk-11.23.1</title><h1 align="center"><a name="top">Release Summary</a></h1><h3 align="center">asterisk-11.23.1</h3><h3 align="center">Date: 2016-09-08</h3><h3 align="center">&lt;asteriskteam@digium.com&gt;</h3><hr><h2 align="center">Table of Contents</h2><ol>
<li><a href="#summary">Summary</a></li>
<li><a href="#contributors">Contributors</a></li>
<li><a href="#closed_issues">Closed Issues</a></li>
<li><a href="#commits">Other Changes</a></li>
<li><a href="#diffstat">Diffstat</a></li>
</ol><hr><a name="summary"><h2 align="center">Summary</h2></a><center><a href="#top">[Back to Top]</a></center><p>This release has been made to address one or more security vulnerabilities that have been identified. A security advisory document has been published for each vulnerability that includes additional information. Users of versions of Asterisk that are affected are strongly encouraged to review the advisories and determine what action they should take to protect their systems from these issues.</p><p>Security Advisories:</p><ul>
<li><a href="http://downloads.asterisk.org/pub/security/AST-2016-007.html">AST-2016-007</a></li>
</ul><p>The data in this summary reflects changes that have been made since the previous release, asterisk-11.23.0.</p><hr><a name="contributors"><h2 align="center">Contributors</h2></a><center><a href="#top">[Back to Top]</a></center><p>This table lists the people who have submitted code, those that have tested patches, as well as those that reported issues on the issue tracker that were resolved in this release. For coders, the number is how many of their patches (of any size) were committed into this release. For testers, the number is the number of times their name was listed as assisting with testing a patch. Finally, for reporters, the number is the number of issues that they reported that were affected by commits that went into this release.</p><table width="100%" border="0">
<tr><th width="33%">Coders</th><th width="33%">Testers</th><th width="33%">Reporters</th></tr>
<tr valign="top"><td width="33%">3 George Joseph <gjoseph@digium.com><br/>1 Corey Farrell <git@cfware.com><br/></td><td width="33%"><td width="33%">1 Etienne Lessard <elessard@proformatique.com><br/></td></tr>
</table><hr><a name="closed_issues"><h2 align="center">Closed Issues</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all issues from the issue tracker that were closed by changes that went into this release.</p><h3>Bug</h3><h4>Category: Channels/chan_sip/General</h4><a href="https://issues.asterisk.org/jira/browse/ASTERISK-26272">ASTERISK-26272</a>: chan_sip: File descriptors leak (UDP sockets)<br/>Reported by: Etienne Lessard<ul>
<li><a href="https://code.asterisk.org/code/changelog/asterisk?cs=1e248e309ede8c503cf0a834201f29395da67ba3">[1e248e309e]</a> Corey Farrell -- chan_sip: Don't allocate new RTP instances on top of old ones.</li>
</ul><br><hr><a name="commits"><h2 align="center">Commits Not Associated with an Issue</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a list of all changes that went into this release that did not reference a JIRA issue.</p><table width="100%" border="1">
<tr><th>Revision</th><th>Author</th><th>Summary</th></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=329694c97522609ddc8fcd59b52e61d59a6d15ee">329694c975</a></td><td>gtjoseph</td><td>Release summaries: Remove previous versions</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=f1dc619c72f4b979708a0c2c77badb30014da720">f1dc619c72</a></td><td>gtjoseph</td><td>.version: Update for 11.23.1</td></tr>
<tr><td><a href="https://code.asterisk.org/code/changelog/asterisk?cs=8e4b3c15ff5824cc9de186e7d5b3f1498ec51e1c">8e4b3c15ff</a></td><td>gtjoseph</td><td>.lastclean: Update for 11.23.1</td></tr>
</table><hr><a name="diffstat"><h2 align="center">Diffstat Results</h2></a><center><a href="#top">[Back to Top]</a></center><p>This is a summary of the changes to the source code that went into this release that was generated using the diffstat utility.</p><pre>asterisk-11.23.0-summary.html | 134 -------------
asterisk-11.23.0-summary.txt | 428 ------------------------------------------
b/.version | 2
b/channels/chan_sip.c | 34 +++
4 files changed, 35 insertions(+), 563 deletions(-)</pre><br></html>

View File

@@ -0,0 +1,108 @@
Release Summary
asterisk-11.23.1
Date: 2016-09-08
<asteriskteam@digium.com>
----------------------------------------------------------------------
Table of Contents
1. Summary
2. Contributors
3. Closed Issues
4. Other Changes
5. Diffstat
----------------------------------------------------------------------
Summary
[Back to Top]
This release has been made to address one or more security vulnerabilities
that have been identified. A security advisory document has been published
for each vulnerability that includes additional information. Users of
versions of Asterisk that are affected are strongly encouraged to review
the advisories and determine what action they should take to protect their
systems from these issues.
Security Advisories:
* AST-2016-007
The data in this summary reflects changes that have been made since the
previous release, asterisk-11.23.0.
----------------------------------------------------------------------
Contributors
[Back to Top]
This table lists the people who have submitted code, those that have
tested patches, as well as those that reported issues on the issue tracker
that were resolved in this release. For coders, the number is how many of
their patches (of any size) were committed into this release. For testers,
the number is the number of times their name was listed as assisting with
testing a patch. Finally, for reporters, the number is the number of
issues that they reported that were affected by commits that went into
this release.
Coders Testers Reporters
3 George Joseph 1 Etienne Lessard
1 Corey Farrell
----------------------------------------------------------------------
Closed Issues
[Back to Top]
This is a list of all issues from the issue tracker that were closed by
changes that went into this release.
Bug
Category: Channels/chan_sip/General
ASTERISK-26272: chan_sip: File descriptors leak (UDP sockets)
Reported by: Etienne Lessard
* [1e248e309e] Corey Farrell -- chan_sip: Don't allocate new RTP
instances on top of old ones.
----------------------------------------------------------------------
Commits Not Associated with an Issue
[Back to Top]
This is a list of all changes that went into this release that did not
reference a JIRA issue.
+------------------------------------------------------------------------+
| Revision | Author | Summary |
|-------------+-----------+----------------------------------------------|
| 329694c975 | gtjoseph | Release summaries: Remove previous versions |
|-------------+-----------+----------------------------------------------|
| f1dc619c72 | gtjoseph | .version: Update for 11.23.1 |
|-------------+-----------+----------------------------------------------|
| 8e4b3c15ff | gtjoseph | .lastclean: Update for 11.23.1 |
+------------------------------------------------------------------------+
----------------------------------------------------------------------
Diffstat Results
[Back to Top]
This is a summary of the changes to the source code that went into this
release that was generated using the diffstat utility.
asterisk-11.23.0-summary.html | 134 -------------
asterisk-11.23.0-summary.txt | 428 ------------------------------------------
b/.version | 2
b/channels/chan_sip.c | 34 +++
4 files changed, 35 insertions(+), 563 deletions(-)

View File

@@ -5706,6 +5706,38 @@ static void copy_socket_data(struct sip_socket *to_sock, const struct sip_socket
*to_sock = *from_sock;
}
/*! Cleanup the RTP and SRTP portions of a dialog
*
* \note This procedure excludes vsrtp as it is initialized differently.
*/
static void dialog_clean_rtp(struct sip_pvt *p)
{
if (p->rtp) {
ast_rtp_instance_destroy(p->rtp);
p->rtp = NULL;
}
if (p->vrtp) {
ast_rtp_instance_destroy(p->vrtp);
p->vrtp = NULL;
}
if (p->trtp) {
ast_rtp_instance_destroy(p->trtp);
p->trtp = NULL;
}
if (p->srtp) {
sip_srtp_destroy(p->srtp);
p->srtp = NULL;
}
if (p->tsrtp) {
sip_srtp_destroy(p->tsrtp);
p->tsrtp = NULL;
}
}
/*! \brief Initialize DTLS-SRTP support on an RTP instance */
static int dialog_initialize_dtls_srtp(const struct sip_pvt *dialog, struct ast_rtp_instance *rtp, struct sip_srtp **srtp)
{
@@ -5753,6 +5785,9 @@ static int dialog_initialize_rtp(struct sip_pvt *dialog)
return 0;
}
/* Make sure previous RTP instances/FD's do not leak */
dialog_clean_rtp(dialog);
ast_sockaddr_copy(&bindaddr_tmp, &bindaddr);
if (!(dialog->rtp = ast_rtp_instance_new(dialog->engine, sched, &bindaddr_tmp, NULL))) {
return -1;
@@ -6417,18 +6452,10 @@ static void sip_pvt_dtor(void *vdoomed)
ast_free(p->notify);
p->notify = NULL;
}
if (p->rtp) {
ast_rtp_instance_destroy(p->rtp);
p->rtp = NULL;
}
if (p->vrtp) {
ast_rtp_instance_destroy(p->vrtp);
p->vrtp = NULL;
}
if (p->trtp) {
ast_rtp_instance_destroy(p->trtp);
p->trtp = NULL;
}
/* Free RTP and SRTP instances */
dialog_clean_rtp(p);
if (p->udptl) {
ast_udptl_destroy(p->udptl);
p->udptl = NULL;
@@ -6464,21 +6491,11 @@ static void sip_pvt_dtor(void *vdoomed)
destroy_msg_headers(p);
if (p->srtp) {
sip_srtp_destroy(p->srtp);
p->srtp = NULL;
}
if (p->vsrtp) {
sip_srtp_destroy(p->vsrtp);
p->vsrtp = NULL;
}
if (p->tsrtp) {
sip_srtp_destroy(p->tsrtp);
p->tsrtp = NULL;
}
if (p->directmediaacl) {
p->directmediaacl = ast_free_acl_list(p->directmediaacl);
}