kenmirrors/firefly-iii
1
0
Fork 0
mirror of https://github.com/firefly-iii/firefly-iii.git synced 2025-09-04 19:53:44 +00:00
Code Issues Projects Releases Wiki Activity

Switch should have default thing.

Browse Source
This commit is contained in:
James Cole
2020-10-03 17:53:23 +02:00
parent b8e36b0398
commit 61ffc8ada6
7 changed files with 16 additions and 4 deletions
Download Patch File Download Diff File Expand all files Collapse all files

4
app/Api/V1/Requests/ConfigurationRequest.php
View File

@@ -56,6 +56,8 @@ class ConfigurationRequest extends FormRequest
{
$name = $this->route()->parameter('configName');
switch ($name) {
default:
break;
case 'is_demo_site':
case 'single_user_mode':
return ['value' => $this->boolean('value')];
@@ -75,6 +77,8 @@ class ConfigurationRequest extends FormRequest
{
$name = $this->route()->parameter('configName');
switch ($name) {
default:
break;
case 'is_demo_site':
case 'single_user_mode':
return ['value' => ['required', new IsBoolean]];

2
app/Console/Commands/Upgrade/OtherCurrenciesCorrections.php
View File

@@ -128,6 +128,8 @@ class OtherCurrenciesCorrections extends Command
/** @var Transaction $lead */
$lead = null;
switch ($journal->transactionType->type) {
default:
break;
case TransactionType::WITHDRAWAL:
$lead = $journal->transactions()->where('amount', '<', 0)->first();
break;

2
app/Http/Controllers/Chart/AccountController.php
View File

@@ -587,6 +587,8 @@ class AccountController extends Controller
$entries = [];
$current = clone $start;
switch ($step) {
default:
break;
case '1D':
// per day the entire period, balance for every day.
$format = (string) trans('config.month_and_day', [], $locale);

2
app/Http/Controllers/Json/RecurrenceController.php
View File

@@ -103,8 +103,8 @@ class RecurrenceController extends Controller
$repetition->repetition_skip = (int) $request->get('skip');
$repetition->weekend = (int) $request->get('weekend');
$actualEnd = clone $end;
$occurrences = [];
switch ($endsAt) {
default:
case 'forever':
// simply generate up until $end. No change from default behavior.
$occurrences = $this->recurring->getOccurrencesInRange($repetition, $actualStart, $actualEnd);

7
app/Http/Controllers/ReportController.php
View File

@@ -384,12 +384,13 @@ class ReportController extends Controller
}
switch ($reportType) {
case 'category':
$uri = route('reports.report.category', [$accounts, $categories, $start, $end]);
break;
default:
case 'default':
$uri = route('reports.report.default', [$accounts, $start, $end]);
break;
case 'category':
$uri = route('reports.report.category', [$accounts, $categories, $start, $end]);
break;
case 'audit':
$uri = route('reports.report.audit', [$accounts, $start, $end]);
break;

1
app/Support/Search/AccountSearch.php
View File

@@ -73,6 +73,7 @@ class AccountSearch implements GenericSearchInterface
$like = sprintf('%%%s%%', $this->query);
$originalQuery = $this->query;
switch ($this->field) {
default:
case self::SEARCH_ALL:
$query->where(
static function (Builder $q) use ($like) {

2
app/Validation/TransactionValidation.php
View File

@@ -354,6 +354,7 @@ trait TransactionValidation
$sources = array_unique($sources);
$dests = array_unique($dests);
switch ($type) {
default:
case 'withdrawal':
if (count($sources) > 1) {
$validator->errors()->add('transactions.0.source_id', (string)trans('validation.all_accounts_equal'));
@@ -409,6 +410,7 @@ trait TransactionValidation
}
// TODO not the best way to loop this.
switch ($type) {
default:
case 'withdrawal':
if ($this->arrayEqual($comparison['source_id'])) {
// source ID's are equal, return void.