Merge pull request #11874 from firefly-iii/release-1772634907

🤖 Automatically merge the PR into the develop branch.

.ci/phpstan.neon

@@ -5,14 +5,60 @@ parameters:
     - ../routes
     - ../config
     - ../bootstrap/app.php
+    - ../bootstrap/providers.php
   universalObjectCratesClasses:
     - Illuminate\Database\Eloquent\Model
   reportUnmatchedIgnoredErrors: true
   ignoreErrors:
+    # these are actually interesting but not right now:
+    - identifier: notIdentical.alwaysTrue
+    - identifier: method.notFound
+    - identifier: nullsafe.neverNull
+    - identifier: identical.alwaysFalse
+    - identifier: if.condNotBoolean
+    # - identifier: booleanNot.exprNotBoolean
+    - identifier: method.nonObject
+    - identifier: function.impossibleType
+    - identifier: booleanNot.exprNotBoolean
+    - identifier: ternary.condNotBoolean
+    - identifier: booleanNot.alwaysFalse
+    - identifier: booleanAnd.alwaysFalse
+    - identifier: greater.alwaysTrue
+    - identifier: function.alreadyNarrowedType
+    - identifier: booleanNot.alwaysTrue
+    - identifier: property.phpDocType
+    - identifier: nullCoalesce.offset
+    - identifier: nullCoalesce.variable
+    - identifier: larastan.noUnnecessaryCollectionCall
+    - identifier: varTag.differentVariable
+    - identifier: identical.alwaysTrue
+    - identifier: clone.nonObject
+    - identifier: assign.propertyReadOnly
+    - identifier: property.nonObject
+    - identifier: varTag.nativeType
+    - identifier: booleanAnd.leftAlwaysFalse
+    - identifier: property.onlyWritten
+    - identifier: parameter.phpDocType
+    - identifier: property.dynamicName
+    - identifier: property.unusedType
+    - identifier: staticMethod.deprecated
+    - identifier: greater.invalid
+    - identifier: instanceof.alwaysTrue
+    # ignore everything but things that BREAK
+    - identifier: property.deprecated
+    - identifier: method.deprecated
+    - identifier: cast.useless
+    - identifier: parameter.deprecatedClass
+    - identifier: method.deprecatedClass
+    - identifier: argument.type
+    - identifier: return.type
+    - identifier: assign.propertyType
+    - identifier: return.unusedType
+    - identifier: return.phpDocType
     # all errors below I will never fix.
-    - '#expects view-string\|null, string given#'
-    - '#expects view-string, string given#'
-    - "#Parameter \\#[1-2] \\$num[1-2] of function bc[a-z]+ expects numeric-string, [a-z\\-|&]+ given#"
+    # - '#expects view-string\|null, string given#'
+    # - '#expects view-string, string given#'
+    # - "#Parameter \\#[1-2] \\$num[1-2] of function bc[a-z]+ expects numeric-string, [a-z\\-|&]+ given#"
     - identifier: missingType.generics # not interesting enough to fix.
     -
         identifier: larastan.noEnvCallsOutsideOfConfig
@@ -20,11 +66,11 @@ parameters:
     - identifier: missingType.iterableValue # not interesting enough to fix.
     - identifier: varTag.type # needs a custom extension for every repository, not gonna happen.
     - '#Dynamic call to static method Illuminate#'
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::before#' # is custom scope
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::after#' # is custom scope
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::withTrashed#' # is to allow soft delete
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::accountTypeIn#' # is a custom scope
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\BelongsTo::withTrashed#' # is to allow soft delete
+    # - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::before#' # is custom scope
+    # - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::after#' # is custom scope
+    # - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::withTrashed#' # is to allow soft delete
+    # - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::accountTypeIn#' # is a custom scope
+    # - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\BelongsTo::withTrashed#' # is to allow soft delete
 
   # The level 8 is the highest level. original was 5
   # 7 is more than enough, higher just leaves NULL things.

.github/workflows/release.yml

@@ -174,12 +174,22 @@ jobs:
         uses: nhedger/setup-mago@v1
       - name: Run CI
         run: |
+          # install all packages etc.
           rm -rf vendor composer.lock
           composer update --no-scripts --no-plugins -q
+
+          # format code.
+          echo "Will now run Mago Format"
           mago format || true
-          # mago analyze --reporting-format=github || true
           sudo chown -R runner:docker resources/lang
+          echo "Will now run PHPCS"
           .ci/phpcs.sh || true
+
+          # lint and check
+          echo "Will now run Mago Lint"
+          mago lint || true
+          echo "Will now run PHPstan"
+          .ci/phpstan.sh || true
       - name: Calculate variables
         run: |
 

app/Api/V1/Controllers/Autocomplete/AccountController.php

@@ -41,7 +41,7 @@ use Illuminate\Support\Facades\Log;
 /**
  * Class AccountController
  */
-class AccountController extends Controller
+final class AccountController extends Controller
 {
     use AccountFilter;
 

app/Api/V1/Controllers/Autocomplete/BillController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class BillController
  */
-class BillController extends Controller
+final class BillController extends Controller
 {
     private BillRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_SUBSCRIPTIONS];

app/Api/V1/Controllers/Autocomplete/BudgetController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class BudgetController
  */
-class BudgetController extends Controller
+final class BudgetController extends Controller
 {
     private BudgetRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_BUDGETS];

app/Api/V1/Controllers/Autocomplete/CategoryController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class CategoryController
  */
-class CategoryController extends Controller
+final class CategoryController extends Controller
 {
     private CategoryRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];

app/Api/V1/Controllers/Autocomplete/CurrencyController.php

@@ -37,7 +37,7 @@ use Illuminate\Http\Request;
 /**
  * Class CurrencyController
  */
-class CurrencyController extends Controller
+final class CurrencyController extends Controller
 {
     private CurrencyRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];

app/Api/V1/Controllers/Autocomplete/ObjectGroupController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class ObjectGroupController
  */
-class ObjectGroupController extends Controller
+final class ObjectGroupController extends Controller
 {
     private ObjectGroupRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];

app/Api/V1/Controllers/Autocomplete/PiggyBankController.php

@@ -38,7 +38,7 @@ use Illuminate\Http\Request;
 /**
  * Class PiggyBankController
  */
-class PiggyBankController extends Controller
+final class PiggyBankController extends Controller
 {
     private AccountRepositoryInterface $accountRepository;
     private PiggyBankRepositoryInterface $piggyRepository;

app/Api/V1/Controllers/Autocomplete/RecurrenceController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class RecurrenceController
  */
-class RecurrenceController extends Controller
+final class RecurrenceController extends Controller
 {
     private RecurringRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_RECURRING];

app/Api/V1/Controllers/Autocomplete/RuleController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class RuleController
  */
-class RuleController extends Controller
+final class RuleController extends Controller
 {
     private RuleRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_RULES];

app/Api/V1/Controllers/Autocomplete/RuleGroupController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class RuleGroupController
  */
-class RuleGroupController extends Controller
+final class RuleGroupController extends Controller
 {
     private RuleGroupRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_RULES];

app/Api/V1/Controllers/Autocomplete/TagController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class TagController
  */
-class TagController extends Controller
+final class TagController extends Controller
 {
     private TagRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];

app/Api/V1/Controllers/Autocomplete/TransactionController.php

@@ -39,7 +39,7 @@ use Illuminate\Support\Collection;
 /**
  * Class TransactionController
  */
-class TransactionController extends Controller
+final class TransactionController extends Controller
 {
     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];
     private TransactionGroupRepositoryInterface $groupRepository;

app/Api/V1/Controllers/Autocomplete/TransactionTypeController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\Request;
 /**
  * Class TransactionTypeController
  */
-class TransactionTypeController extends Controller
+final class TransactionTypeController extends Controller
 {
     private TransactionTypeRepositoryInterface $repository;
     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];

app/Api/V1/Controllers/Chart/AccountController.php

@@ -44,7 +44,7 @@ use Illuminate\Support\Facades\Log;
 /**
  * Class AccountController
  */
-class AccountController extends Controller
+final class AccountController extends Controller
 {
     use ApiSupport;
     use CleansChartData;

app/Api/V1/Controllers/Chart/BalanceController.php

@@ -40,7 +40,7 @@ use Illuminate\Http\Request;
 /**
  * Class BalanceController
  */
-class BalanceController extends Controller
+final class BalanceController extends Controller
 {
     use CleansChartData;
     use CollectsAccountsFromFilter;

app/Api/V1/Controllers/Chart/BudgetController.php

@@ -47,7 +47,7 @@ use Illuminate\Support\Facades\Log;
 /**
  * Class BudgetController
  */
-class BudgetController extends Controller
+final class BudgetController extends Controller
 {
     use CleansChartData;
     use ValidatesUserGroupTrait;

app/Api/V1/Controllers/Chart/CategoryController.php

@@ -45,7 +45,7 @@ use Illuminate\Support\Facades\Log;
 /**
  * Class BudgetController
  */
-class CategoryController extends Controller
+final class CategoryController extends Controller
 {
     use CleansChartData;
     use ValidatesUserGroupTrait;

app/Api/V1/Controllers/Data/Bulk/TransactionController.php

@@ -42,7 +42,7 @@ use Illuminate\Http\Request;
  * Because this is a security nightmare waiting to happen validation
  * is pretty strict.
  */
-class TransactionController extends Controller
+final class TransactionController extends Controller
 {
     private AccountRepositoryInterface $repository;
 

app/Api/V1/Controllers/Data/DestroyController.php

@@ -54,7 +54,7 @@ use Illuminate\Support\Facades\Log;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private bool $unused;
 

app/Api/V1/Controllers/Data/Export/ExportController.php

@@ -38,7 +38,7 @@ use function Safe\date;
 /**
  * Class ExportController
  */
-class ExportController extends Controller
+final class ExportController extends Controller
 {
     private ExportDataGenerator $exporter;
     protected array $acceptedRoles = [UserRoleEnum::READ_ONLY];

app/Api/V1/Controllers/Data/PurgeController.php

@@ -44,7 +44,7 @@ use Illuminate\Http\Request;
 /**
  * Class PurgeController
  */
-class PurgeController extends Controller
+final class PurgeController extends Controller
 {
     protected array $acceptedRoles = [UserRoleEnum::FULL];
 

app/Api/V1/Controllers/Insight/Expense/AccountController.php

@@ -37,7 +37,7 @@ use Illuminate\Http\JsonResponse;
  * Shows expense information grouped or limited by date.
  * I.e. all expenses grouped by account + currency.
  */
-class AccountController extends Controller
+final class AccountController extends Controller
 {
     use ApiSupport;
 

app/Api/V1/Controllers/Insight/Expense/BillController.php

@@ -36,7 +36,7 @@ use Illuminate\Support\Facades\Log;
 /**
  * Class BillController
  */
-class BillController extends Controller
+final class BillController extends Controller
 {
     private BillRepositoryInterface $repository;
 

app/Api/V1/Controllers/Insight/Expense/BudgetController.php

@@ -36,7 +36,7 @@ use Illuminate\Support\Collection;
 /**
  * Class BudgetController
  */
-class BudgetController extends Controller
+final class BudgetController extends Controller
 {
     private NoBudgetRepositoryInterface $noRepository;
     private OperationsRepositoryInterface $opsRepository;

app/Api/V1/Controllers/Insight/Expense/CategoryController.php

@@ -36,7 +36,7 @@ use Illuminate\Support\Collection;
 /**
  * Class CategoryController
  */
-class CategoryController extends Controller
+final class CategoryController extends Controller
 {
     private NoCategoryRepositoryInterface $noRepository;
     private OperationsRepositoryInterface $opsRepository;

app/Api/V1/Controllers/Insight/Expense/PeriodController.php

@@ -35,7 +35,7 @@ use Illuminate\Support\Facades\Log;
 /**
  * Class PeriodController
  */
-class PeriodController extends Controller
+final class PeriodController extends Controller
 {
     public function total(GenericRequest $request): JsonResponse
     {

app/Api/V1/Controllers/Insight/Expense/TagController.php

@@ -36,7 +36,7 @@ use Illuminate\Support\Facades\Log;
 /**
  * Class TagController
  */
-class TagController extends Controller
+final class TagController extends Controller
 {
     private TagRepositoryInterface $repository;
 

app/Api/V1/Controllers/Insight/Income/AccountController.php

@@ -37,7 +37,7 @@ use Illuminate\Http\JsonResponse;
  * Shows income information grouped or limited by date.
  * I.e. all income grouped by account + currency.
  */
-class AccountController extends Controller
+final class AccountController extends Controller
 {
     use ApiSupport;
 

app/Api/V1/Controllers/Insight/Income/CategoryController.php

@@ -36,7 +36,7 @@ use Illuminate\Support\Collection;
 /**
  * Class CategoryController
  */
-class CategoryController extends Controller
+final class CategoryController extends Controller
 {
     private NoCategoryRepositoryInterface $noRepository;
     private OperationsRepositoryInterface $opsRepository;

app/Api/V1/Controllers/Insight/Income/PeriodController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class PeriodController
  */
-class PeriodController extends Controller
+final class PeriodController extends Controller
 {
     public function total(GenericRequest $request): JsonResponse
     {

app/Api/V1/Controllers/Insight/Income/TagController.php

@@ -36,7 +36,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class TagController
  */
-class TagController extends Controller
+final class TagController extends Controller
 {
     private TagRepositoryInterface $repository;
 

app/Api/V1/Controllers/Insight/Transfer/AccountController.php

@@ -33,7 +33,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class AccountController
  */
-class AccountController extends Controller
+final class AccountController extends Controller
 {
     use ApiSupport;
 

app/Api/V1/Controllers/Insight/Transfer/CategoryController.php

@@ -36,7 +36,7 @@ use Illuminate\Support\Collection;
 /**
  * Class CategoryController
  */
-class CategoryController extends Controller
+final class CategoryController extends Controller
 {
     private NoCategoryRepositoryInterface $noRepository;
     private OperationsRepositoryInterface $opsRepository;

app/Api/V1/Controllers/Insight/Transfer/PeriodController.php

@@ -35,7 +35,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class PeriodController
  */
-class PeriodController extends Controller
+final class PeriodController extends Controller
 {
     public function total(GenericRequest $request): JsonResponse
     {

app/Api/V1/Controllers/Insight/Transfer/TagController.php

@@ -36,7 +36,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class TagController
  */
-class TagController extends Controller
+final class TagController extends Controller
 {
     private TagRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Account/DestroyController.php

@@ -33,7 +33,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     public const string RESOURCE_KEY = 'accounts';
 

app/Api/V1/Controllers/Models/Account/ListController.php

@@ -25,7 +25,7 @@ declare(strict_types=1);
 namespace FireflyIII\Api\V1\Controllers\Models\Account;
 
 use FireflyIII\Api\V1\Controllers\Controller;
-use FireflyIII\Api\V1\Requests\Models\Transaction\ListRequest;
+use FireflyIII\Api\V1\Requests\Generic\PaginationDateRangeRequest;
 use FireflyIII\Api\V1\Requests\PaginationRequest;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Models\Account;
@@ -46,7 +46,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class ListController
  */
-class ListController extends Controller
+final class ListController extends Controller
 {
     use TransactionFilter;
 
@@ -126,7 +126,7 @@ class ListController extends Controller
     /**
      * Show all transaction groups related to the account.
      */
-    public function transactions(ListRequest $request, Account $account): JsonResponse
+    public function transactions(PaginationDateRangeRequest $request, Account $account): JsonResponse
     {
         ['limit' => $limit, 'page'  => $page, 'start' => $start, 'end'   => $end, 'type'  => $type] = $request->attributes->all();
         $types                                                                                      = $this->mapTransactionTypes($type ?? 'default');

app/Api/V1/Controllers/Models/Account/ShowController.php

@@ -41,7 +41,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     use AccountFilter;
 

app/Api/V1/Controllers/Models/Account/StoreController.php

@@ -36,7 +36,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     public const string RESOURCE_KEY = 'accounts';
 

app/Api/V1/Controllers/Models/Account/UpdateController.php

@@ -39,7 +39,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     public const string RESOURCE_KEY = 'accounts';
 

app/Api/V1/Controllers/Models/Attachment/DestroyController.php

@@ -37,7 +37,7 @@ use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private AttachmentRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Attachment/ShowController.php

@@ -44,7 +44,7 @@ use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private AttachmentRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Attachment/StoreController.php

@@ -42,7 +42,7 @@ use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     private AttachmentRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Attachment/UpdateController.php

@@ -39,7 +39,7 @@ use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private AttachmentRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/AvailableBudget/ShowController.php

@@ -40,7 +40,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private AvailableBudgetRepositoryInterface $abRepository;
 

app/Api/V1/Controllers/Models/Bill/DestroyController.php

@@ -33,7 +33,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private BillRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Bill/ListController.php

@@ -44,7 +44,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class ListController
  */
-class ListController extends Controller
+final class ListController extends Controller
 {
     use TransactionFilter;
 

app/Api/V1/Controllers/Models/Bill/ShowController.php

@@ -41,7 +41,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private BillRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Bill/StoreController.php

@@ -38,7 +38,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     use TransactionFilter;
 

app/Api/V1/Controllers/Models/Bill/UpdateController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private BillRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Budget/DestroyController.php

@@ -33,7 +33,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private BudgetRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Budget/ListController.php

@@ -44,7 +44,7 @@ use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
 
 // Class ListController
-class ListController extends Controller
+final class ListController extends Controller
 {
     use TransactionFilter;
 

app/Api/V1/Controllers/Models/Budget/ShowController.php

@@ -40,7 +40,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private BudgetLimitRepositoryInterface $blRepository;
     private BudgetRepositoryInterface $repository;

app/Api/V1/Controllers/Models/Budget/StoreController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     private BudgetRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Budget/UpdateController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private BudgetRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/BudgetLimit/DestroyController.php

@@ -36,7 +36,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private BudgetLimitRepositoryInterface $blRepository;
 

app/Api/V1/Controllers/Models/BudgetLimit/ListController.php

@@ -40,7 +40,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class ListController
  */
-class ListController extends Controller
+final class ListController extends Controller
 {
     use TransactionFilter;
 

app/Api/V1/Controllers/Models/BudgetLimit/ShowController.php

@@ -44,7 +44,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private BudgetLimitRepositoryInterface $blRepository;
     private BudgetRepositoryInterface $repository;

app/Api/V1/Controllers/Models/BudgetLimit/StoreController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     private BudgetLimitRepositoryInterface $blRepository;
 

app/Api/V1/Controllers/Models/BudgetLimit/UpdateController.php

@@ -39,7 +39,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private BudgetLimitRepositoryInterface $blRepository;
 

app/Api/V1/Controllers/Models/Category/DestroyController.php

@@ -33,7 +33,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private CategoryRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Category/ListController.php

@@ -42,7 +42,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class ListController
  */
-class ListController extends Controller
+final class ListController extends Controller
 {
     use TransactionFilter;
 

app/Api/V1/Controllers/Models/Category/ShowController.php

@@ -39,7 +39,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private CategoryRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Category/StoreController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     private CategoryRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Category/UpdateController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private CategoryRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/CurrencyExchangeRate/DestroyController.php

@@ -36,7 +36,7 @@ use FireflyIII\Support\Http\Api\ValidatesUserGroupTrait;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     use ValidatesUserGroupTrait;
 

app/Api/V1/Controllers/Models/CurrencyExchangeRate/IndexController.php

@@ -36,7 +36,7 @@ use Illuminate\Pagination\LengthAwarePaginator;
 /**
  * Class ShowController
  */
-class IndexController extends Controller
+final class IndexController extends Controller
 {
     use ValidatesUserGroupTrait;
 

app/Api/V1/Controllers/Models/CurrencyExchangeRate/ShowController.php

@@ -40,7 +40,7 @@ use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     use ValidatesUserGroupTrait;
 

app/Api/V1/Controllers/Models/CurrencyExchangeRate/StoreController.php

@@ -41,7 +41,7 @@ use Illuminate\Http\Request;
 use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Support\Collection;
 
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     use ValidatesUserGroupTrait;
 

app/Api/V1/Controllers/Models/CurrencyExchangeRate/UpdateController.php

@@ -37,7 +37,7 @@ use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
 use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     use ValidatesUserGroupTrait;
 

app/Api/V1/Controllers/Models/ObjectGroup/DestroyController.php

@@ -34,7 +34,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private ObjectGroupRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/ObjectGroup/ListController.php

@@ -40,7 +40,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class ListController
  */
-class ListController extends Controller
+final class ListController extends Controller
 {
     private ObjectGroupRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/ObjectGroup/ShowController.php

@@ -38,7 +38,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private ObjectGroupRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/ObjectGroup/UpdateController.php

@@ -36,7 +36,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private ObjectGroupRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/PiggyBank/DestroyController.php

@@ -33,7 +33,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private PiggyBankRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/PiggyBank/ListController.php

@@ -41,7 +41,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class ListController
  */
-class ListController extends Controller
+final class ListController extends Controller
 {
     private PiggyBankRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/PiggyBank/ShowController.php

@@ -39,7 +39,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private PiggyBankRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/PiggyBank/StoreController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     private PiggyBankRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/PiggyBank/UpdateController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private PiggyBankRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Recurrence/DestroyController.php

@@ -33,7 +33,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private RecurringRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Recurrence/ListController.php

@@ -40,7 +40,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class ListController
  */
-class ListController extends Controller
+final class ListController extends Controller
 {
     use TransactionFilter;
 

app/Api/V1/Controllers/Models/Recurrence/ShowController.php

@@ -39,7 +39,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private RecurringRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Recurrence/StoreController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     private RecurringRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Recurrence/TriggerController.php

@@ -41,7 +41,7 @@ use Illuminate\Support\Facades\Log;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
 
-class TriggerController extends Controller
+final class TriggerController extends Controller
 {
     private RecurringRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Recurrence/UpdateController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private RecurringRepositoryInterface $repository;
 

app/Api/V1/Controllers/Models/Rule/DestroyController.php

@@ -34,7 +34,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private RuleRepositoryInterface $ruleRepository;
 

app/Api/V1/Controllers/Models/Rule/ExpressionController.php

@@ -31,7 +31,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class ExpressionController
  */
-class ExpressionController extends Controller
+final class ExpressionController extends Controller
 {
     /**
      * This endpoint is documented at:

app/Api/V1/Controllers/Models/Rule/ShowController.php

@@ -38,7 +38,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private RuleRepositoryInterface $ruleRepository;
 

app/Api/V1/Controllers/Models/Rule/StoreController.php

@@ -35,7 +35,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     private RuleRepositoryInterface $ruleRepository;
 

app/Api/V1/Controllers/Models/Rule/TriggerController.php

@@ -42,7 +42,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class TriggerController
  */
-class TriggerController extends Controller
+final class TriggerController extends Controller
 {
     private RuleRepositoryInterface $ruleRepository;
 

app/Api/V1/Controllers/Models/Rule/UpdateController.php

@@ -36,7 +36,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class UpdateController
  */
-class UpdateController extends Controller
+final class UpdateController extends Controller
 {
     private RuleRepositoryInterface $ruleRepository;
 

app/Api/V1/Controllers/Models/RuleGroup/DestroyController.php

@@ -34,7 +34,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private RuleGroupRepositoryInterface $ruleGroupRepository;
 

app/Api/V1/Controllers/Models/RuleGroup/ListController.php

@@ -37,7 +37,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class ListController
  */
-class ListController extends Controller
+final class ListController extends Controller
 {
     private RuleGroupRepositoryInterface $ruleGroupRepository;
 

app/Api/V1/Controllers/Models/RuleGroup/ShowController.php

@@ -38,7 +38,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class ShowController
  */
-class ShowController extends Controller
+final class ShowController extends Controller
 {
     private RuleGroupRepositoryInterface $ruleGroupRepository;
 

app/Api/V1/Controllers/Models/RuleGroup/StoreController.php

@@ -36,7 +36,7 @@ use League\Fractal\Resource\Item;
 /**
  * Class StoreController
  */
-class StoreController extends Controller
+final class StoreController extends Controller
 {
     private AccountRepositoryInterface $accountRepository;
     private RuleGroupRepositoryInterface $ruleGroupRepository;

app/Api/V1/Controllers/Models/RuleGroup/TriggerController.php

@@ -43,7 +43,7 @@ use League\Fractal\Resource\Collection as FractalCollection;
 /**
  * Class TriggerController
  */
-class TriggerController extends Controller
+final class TriggerController extends Controller
 {
     private RuleGroupRepositoryInterface $ruleGroupRepository;
 

app/Api/V1/Controllers/Models/Tag/DestroyController.php

@@ -34,7 +34,7 @@ use Illuminate\Http\JsonResponse;
 /**
  * Class DestroyController
  */
-class DestroyController extends Controller
+final class DestroyController extends Controller
 {
     private TagRepositoryInterface $repository;