Update changelog.

.ci/.env.ci

@@ -60,7 +60,7 @@ APP_LOG_LEVEL=info
 # Use "pgsql" for PostgreSQL
 # Use "mysql" for MySQL and MariaDB.
 # Use "sqlite" for SQLite.
-DB_CONNECTION=sqlite
+DB_CONNECTION=sqlite_test
 
 # MySQL supports SSL. You can configure it here.
 # If you use Docker or similar, you can set these variables from a file by appending them with _FILE
@@ -127,6 +127,7 @@ MAIL_ENCRYPTION=null
 MAILGUN_DOMAIN=
 MAILGUN_SECRET=
 
+
 # If you are on EU region in mailgun, use api.eu.mailgun.net, otherwise use api.mailgun.net
 # If you use Docker or similar, you can set this variable from a file by appending it with _FILE
 MAILGUN_ENDPOINT=api.mailgun.net
@@ -135,6 +136,7 @@ MAILGUN_ENDPOINT=api.mailgun.net
 MANDRILL_SECRET=
 SPARKPOST_SECRET=
 
+
 # Firefly III can send you the following messages
 SEND_REGISTRATION_MAIL=true
 SEND_ERROR_MESSAGE=true
@@ -186,7 +188,7 @@ AUTHENTICATION_GUARD=web
 # Enter a custom URL here that will force a logout (your authentication provider can tell you).
 # Setting this variable only works when AUTHENTICATION_GUARD != web
 #
-CUSTOM_LOGOUT_URL=
+CUSTOM_LOGOUT_URI=
 
 # LDAP connection configuration
 # OpenLDAP, FreeIPA or ActiveDirectory
@@ -221,6 +223,7 @@ ADLDAP_ADMIN_PASSWORD=
 ADLDAP_ACCOUNT_PREFIX=
 ADLDAP_ACCOUNT_SUFFIX=
 
+
 # LDAP authentication settings.
 ADLDAP_PASSWORD_SYNC=false
 ADLDAP_LOGIN_FALLBACK=false
@@ -257,6 +260,12 @@ DISABLE_CSP_HEADER=false
 TRACKER_SITE_ID=
 TRACKER_URL=
 
+#
+# Firefly III can collect telemetry on how you use Firefly III. This is opt-in.
+# In order to allow this, change the following variable to true.
+# To read more about this feature, go to this page: https://docs.firefly-iii.org/support/telemetry
+SEND_TELEMETRY=false
+
 # You can fine tune the start-up of a Docker container by editing these environment variables.
 # Use this at your own risk. Disabling certain checks and features may result in lost of inconsistent data.
 # However if you know what you're doing you can significantly speed up container start times.
@@ -301,6 +310,7 @@ PUSHER_ID=
 DEMO_USERNAME=
 DEMO_PASSWORD=
 USE_ENCRYPTION=false
+IS_HEROKU=false
 FIREFLY_III_LAYOUT=v1
 
 #

.ci/firefly-iii-standard.yml

@@ -1,250 +1,250 @@
 parameters:
-  indentation: spaces
+    indentation: spaces
 
-  file_extensions:
-    - php
+    file_extensions:
+        - php
 
-  exclude_files:
-    - fixtures/*
-    - fixtures*/*
-    - temp/*
-    - tmp/*
+    exclude_files:
+        - fixtures/*
+        - fixtures*/*
+        - temp/*
+        - tmp/*
 
 services:
-  # Checkers bellow aim on 1:1 copy of https://nette.org/en/coding-standard
+    # Checkers bellow aim on 1:1 copy of https://nette.org/en/coding-standard
 
-  # General rules - https://nette.org/en/coding-standard#toc-general-rules
+    # General rules - https://nette.org/en/coding-standard#toc-general-rules
 
-  # use tabs over spaces
-  # PHP_CodeSniffer\Standards\Generic\Sniffs\WhiteSpace\DisallowSpaceIndentSniff: ~
-  # PHP code must use only UTF-8 without BOM
-  PhpCsFixer\Fixer\Basic\EncodingFixer: ~
-  # <?php opening tag
-  PhpCsFixer\Fixer\PhpTag\FullOpeningTagFixer: ~
-  # Ensure there is no code on the same line as the PHP open tag.
-  PhpCsFixer\Fixer\PhpTag\LinebreakAfterOpeningTagFixer: ~
-  # The closing ?> tag must be omitted from files containing only PHP.
-  PhpCsFixer\Fixer\PhpTag\NoClosingTagFixer: ~
-  # There must not be trailing whitespace at the end of lines.
-  PhpCsFixer\Fixer\Whitespace\NoTrailingWhitespaceFixer: ~
-  # ...and at the end of blank lines.
-  PhpCsFixer\Fixer\Whitespace\NoWhitespaceInBlankLineFixer: ~
-  # All files must end with a single blank line.
-  PhpCsFixer\Fixer\Whitespace\SingleBlankLineAtEofFixer: ~
-  # File name should match class name if possible.
-  PhpCsFixer\Fixer\Basic\Psr4Fixer: ~
-  # Enforces using shorthand scalar typehint variants in phpDocs: `int` instead of `integer` and `bool` instead of `boolean`
-  SlevomatCodingStandard\Sniffs\TypeHints\LongTypeHintsSniff: ~
+    # use tabs over spaces
+    # PHP_CodeSniffer\Standards\Generic\Sniffs\WhiteSpace\DisallowSpaceIndentSniff: ~
+    # PHP code must use only UTF-8 without BOM
+    PhpCsFixer\Fixer\Basic\EncodingFixer: ~
+    # <?php opening tag
+    PhpCsFixer\Fixer\PhpTag\FullOpeningTagFixer: ~
+    # Ensure there is no code on the same line as the PHP open tag.
+    PhpCsFixer\Fixer\PhpTag\LinebreakAfterOpeningTagFixer: ~
+    # The closing ?> tag must be omitted from files containing only PHP.
+    PhpCsFixer\Fixer\PhpTag\NoClosingTagFixer: ~
+    # There must not be trailing whitespace at the end of lines.
+    PhpCsFixer\Fixer\Whitespace\NoTrailingWhitespaceFixer: ~
+    # ...and at the end of blank lines.
+    PhpCsFixer\Fixer\Whitespace\NoWhitespaceInBlankLineFixer: ~
+    # All files must end with a single blank line.
+    PhpCsFixer\Fixer\Whitespace\SingleBlankLineAtEofFixer: ~
+    # File name should match class name if possible.
+    PhpCsFixer\Fixer\Basic\Psr4Fixer: ~
+    # Enforces using shorthand scalar typehint variants in phpDocs: `int` instead of `integer` and `bool` instead of `boolean`
+    SlevomatCodingStandard\Sniffs\TypeHints\LongTypeHintsSniff: ~
 
-  # File Header - https://nette.org/en/coding-standard#toc-file-header
+    # File Header - https://nette.org/en/coding-standard#toc-file-header
 
-  # empty line before namespace
-  PhpCsFixer\Fixer\NamespaceNotation\SingleBlankLineBeforeNamespaceFixer: ~
-  # 1 Use statement per line
-  PhpCsFixer\Fixer\Import\SingleImportPerStatementFixer: ~
-  # Use statements are alphabetically ordered
-  PhpCsFixer\Fixer\Import\OrderedImportsFixer: ~
-  # disallow group use declarations use FooLibrary\Bar\Baz\{ ClassA, ClassB, ClassC, ClassD as Fizbo }
-  SlevomatCodingStandard\Sniffs\Namespaces\DisallowGroupUseSniff: ~
-  # Disallows leading backslash in use statement: use \Foo\Bar;
-  SlevomatCodingStandard\Sniffs\Namespaces\UseDoesNotStartWithBackslashSniff: ~
-  # Looks for unused imports from other namespaces.
-  Nette\CodingStandard\Sniffs\Namespaces\UnusedUsesSniff:
-    searchAnnotations: yes
-    ignoredAnnotationNames: [ '@testCase' ]
-    ignoredAnnotations: [ '@internal' ]
+    # empty line before namespace
+    PhpCsFixer\Fixer\NamespaceNotation\SingleBlankLineBeforeNamespaceFixer: ~
+    # 1 Use statement per line
+    PhpCsFixer\Fixer\Import\SingleImportPerStatementFixer: ~
+    # Use statements are alphabetically ordered
+    PhpCsFixer\Fixer\Import\OrderedImportsFixer: ~
+    # disallow group use declarations use FooLibrary\Bar\Baz\{ ClassA, ClassB, ClassC, ClassD as Fizbo }
+    SlevomatCodingStandard\Sniffs\Namespaces\DisallowGroupUseSniff: ~
+    # Disallows leading backslash in use statement: use \Foo\Bar;
+    SlevomatCodingStandard\Sniffs\Namespaces\UseDoesNotStartWithBackslashSniff: ~
+    # Looks for unused imports from other namespaces.
+    Nette\CodingStandard\Sniffs\Namespaces\UnusedUsesSniff:
+        searchAnnotations: yes
+        ignoredAnnotationNames: ['@testCase']
+        ignoredAnnotations: ['@internal']
 
-  # Language Construct (should be placed before some other fixers)
+    # Language Construct (should be placed before some other fixers)
 
-  # Functions should be used with `$strict` param set to `true`
-  PhpCsFixer\Fixer\Strict\StrictParamFixer: ~
-  # replaces is_null(parameter) expression with `null === parameter`.
-  PhpCsFixer\Fixer\LanguageConstruct\IsNullFixer:
-    use_yoda_style: true
-  # Calling `unset` on multiple items should be done in one call.
-  PhpCsFixer\Fixer\LanguageConstruct\CombineConsecutiveUnsetsFixer: ~
-  # Replace all `<>` with `!=`.
-  PhpCsFixer\Fixer\Operator\StandardizeNotEqualsFixer: ~
-  # Include/Require and file path should be divided with a single space. File path should not be placed under brackets.
-  PhpCsFixer\Fixer\ControlStructure\IncludeFixer: ~
-  # Requires short ternary operator ?: when possible
-  SlevomatCodingStandard\Sniffs\ControlStructures\RequireShortTernaryOperatorSniff: ~
+    # Functions should be used with `$strict` param set to `true`
+    PhpCsFixer\Fixer\Strict\StrictParamFixer: ~
+    # replaces is_null(parameter) expression with `null === parameter`.
+    PhpCsFixer\Fixer\LanguageConstruct\IsNullFixer:
+        use_yoda_style: true
+    # Calling `unset` on multiple items should be done in one call.
+    PhpCsFixer\Fixer\LanguageConstruct\CombineConsecutiveUnsetsFixer: ~
+    # Replace all `<>` with `!=`.
+    PhpCsFixer\Fixer\Operator\StandardizeNotEqualsFixer: ~
+    # Include/Require and file path should be divided with a single space. File path should not be placed under brackets.
+    PhpCsFixer\Fixer\ControlStructure\IncludeFixer: ~
+    # Requires short ternary operator ?: when possible
+    SlevomatCodingStandard\Sniffs\ControlStructures\RequireShortTernaryOperatorSniff: ~
 
-  # Arrays - https://nette.org/en/coding-standard#toc-arrays
+    # Arrays - https://nette.org/en/coding-standard#toc-arrays
 
-  # use short array fixes
-  PhpCsFixer\Fixer\ArrayNotation\ArraySyntaxFixer:
-    syntax: short
-  # use trailing command in last array element
-  PhpCsFixer\Fixer\ArrayNotation\TrailingCommaInMultilineArrayFixer: ~
-  # PHP single-line arrays should not have trailing comma.
-  # PhpCsFixer\Fixer\ArrayNotation\NoTrailingCommaInSinglelineArrayFixer: ~
-  # In array declaration, there MUST NOT be a whitespace before each comma.
-  PhpCsFixer\Fixer\ArrayNotation\NoWhitespaceBeforeCommaInArrayFixer: ~
-  # Arrays should be formatted like function/method arguments, without leading or trailing single line space.
-  PhpCsFixer\Fixer\ArrayNotation\TrimArraySpacesFixer: ~
-  # In array declaration, there MUST be a whitespace after each comma.
-  PhpCsFixer\Fixer\ArrayNotation\WhitespaceAfterCommaInArrayFixer: ~
+    # use short array fixes
+    PhpCsFixer\Fixer\ArrayNotation\ArraySyntaxFixer:
+        syntax: short
+    # use trailing command in last array element
+    PhpCsFixer\Fixer\ArrayNotation\TrailingCommaInMultilineArrayFixer: ~
+    # PHP single-line arrays should not have trailing comma.
+    # PhpCsFixer\Fixer\ArrayNotation\NoTrailingCommaInSinglelineArrayFixer: ~
+    # In array declaration, there MUST NOT be a whitespace before each comma.
+    PhpCsFixer\Fixer\ArrayNotation\NoWhitespaceBeforeCommaInArrayFixer: ~
+    # Arrays should be formatted like function/method arguments, without leading or trailing single line space.
+    PhpCsFixer\Fixer\ArrayNotation\TrimArraySpacesFixer: ~
+    # In array declaration, there MUST be a whitespace after each comma.
+    PhpCsFixer\Fixer\ArrayNotation\WhitespaceAfterCommaInArrayFixer: ~
 
-  # Strings
+    # Strings
 
-  # Convert `heredoc` to `nowdoc` where possible.
-  PhpCsFixer\Fixer\StringNotation\HeredocToNowdocFixer: ~
-  # Convert double quotes to single quotes for simple strings.
-  PhpCsFixer\Fixer\StringNotation\SingleQuoteFixer: ~
+    # Convert `heredoc` to `nowdoc` where possible.
+    PhpCsFixer\Fixer\StringNotation\HeredocToNowdocFixer: ~
+    # Convert double quotes to single quotes for simple strings.
+    PhpCsFixer\Fixer\StringNotation\SingleQuoteFixer: ~
 
-  # Keywords and True/False/Null - https://nette.org/en/coding-standard#toc-keywords-and-true-false-null
+    # Keywords and True/False/Null - https://nette.org/en/coding-standard#toc-keywords-and-true-false-null
 
-  # PHP keywords must be in lower case
-  PhpCsFixer\Fixer\Casing\LowercaseKeywordsFixer: ~
-  # The PHP constants `true`, `false`, and `null` MUST be in lower case
-  PhpCsFixer\Fixer\Casing\LowercaseConstantsFixer: ~
+    # PHP keywords must be in lower case
+    PhpCsFixer\Fixer\Casing\LowercaseKeywordsFixer: ~
+    # The PHP constants `true`, `false`, and `null` MUST be in lower case
+    PhpCsFixer\Fixer\Casing\LowercaseConstantsFixer: ~
 
-  # Method and Functions Calls - https://nette.org/en/coding-standard#toc-method-and-function-calls
+    # Method and Functions Calls - https://nette.org/en/coding-standard#toc-method-and-function-calls
 
-  # Function defined by PHP should be called using the correct casing
-  PhpCsFixer\Fixer\Casing\NativeFunctionCasingFixer: ~
-  # In the argument list, there must be one space after each comma, and there must no be a space before each comma
-  PhpCsFixer\Fixer\FunctionNotation\MethodArgumentSpaceFixer: ~
-  # This sniff checks that there are two blank lines between functions declarations and single between signatures.
-  #Nette\CodingStandard\Sniffs\WhiteSpace\FunctionSpacingSniff: ~
+    # Function defined by PHP should be called using the correct casing
+    PhpCsFixer\Fixer\Casing\NativeFunctionCasingFixer: ~
+    # In the argument list, there must be one space after each comma, and there must no be a space before each comma
+    PhpCsFixer\Fixer\FunctionNotation\MethodArgumentSpaceFixer: ~
+    # This sniff checks that there are two blank lines between functions declarations and single between signatures.
+    #Nette\CodingStandard\Sniffs\WhiteSpace\FunctionSpacingSniff: ~
 
-  # Classes - https://nette.org/en/coding-standard#toc-classes
+    # Classes - https://nette.org/en/coding-standard#toc-classes
 
-  # Inside a classy element "self" should be preferred to the class name itself.
-  PhpCsFixer\Fixer\ClassNotation\SelfAccessorFixer: ~
-  # class element order: constants, properties, from public to private
-  PhpCsFixer\Fixer\ClassNotation\OrderedClassElementsFixer:
-    order:
-      - use_trait
-      - constant
-      - constant_public
-      - constant_protected
-      - constant_private
-      - property_public
-      - property_protected
-      - property_private
+    # Inside a classy element "self" should be preferred to the class name itself.
+    PhpCsFixer\Fixer\ClassNotation\SelfAccessorFixer: ~
+    # class element order: constants, properties, from public to private
+    PhpCsFixer\Fixer\ClassNotation\OrderedClassElementsFixer:
+        order:
+            - use_trait
+            - constant
+            - constant_public
+            - constant_protected
+            - constant_private
+            - property_public
+            - property_protected
+            - property_private
 
-  # Constants - https://nette.org/en/coding-standard#toc-constants
+    # Constants - https://nette.org/en/coding-standard#toc-constants
 
-  # constant names are CAPITALIZED (manuall fixing only :()
-  PHP_CodeSniffer\Standards\Generic\Sniffs\NamingConventions\UpperCaseConstantNameSniff: ~
+    # constant names are CAPITALIZED (manuall fixing only :()
+    PHP_CodeSniffer\Standards\Generic\Sniffs\NamingConventions\UpperCaseConstantNameSniff: ~
 
-  # Class Properties - https://nette.org/en/coding-standard#toc-class-properties
+    # Class Properties - https://nette.org/en/coding-standard#toc-class-properties
 
-  # There MUST NOT be more than one property declared per statement.
-  PhpCsFixer\Fixer\ClassNotation\SingleClassElementPerStatementFixer:
-    elements: [ 'property' ]
+    # There MUST NOT be more than one property declared per statement.
+    PhpCsFixer\Fixer\ClassNotation\SingleClassElementPerStatementFixer:
+        elements: ['property']
 
-  # Methods - https://nette.org/en/coding-standard#toc-methods
+    # Methods - https://nette.org/en/coding-standard#toc-methods
 
-  # They must be declared in camelCase.
-  PHP_CodeSniffer\Standards\PSR1\Sniffs\Methods\CamelCapsMethodNameSniff: ~
-  # Checks that there's a single space between a typehint and a parameter name and no whitespace between a nullability symbol and a typehint
-  SlevomatCodingStandard\Sniffs\TypeHints\ParameterTypeHintSpacingSniff: ~
-  # Spaces should be properly placed in a function declaration.
-  PhpCsFixer\Fixer\FunctionNotation\FunctionDeclarationFixer: ~
-  # In function arguments there must not be arguments with default values before non-default ones.
-  PhpCsFixer\Fixer\FunctionNotation\NoUnreachableDefaultArgumentValueFixer: ~
+    # They must be declared in camelCase.
+    PHP_CodeSniffer\Standards\PSR1\Sniffs\Methods\CamelCapsMethodNameSniff: ~
+    # Checks that there's a single space between a typehint and a parameter name and no whitespace between a nullability symbol and a typehint
+    SlevomatCodingStandard\Sniffs\TypeHints\ParameterTypeHintSpacingSniff: ~
+    # Spaces should be properly placed in a function declaration.
+    PhpCsFixer\Fixer\FunctionNotation\FunctionDeclarationFixer: ~
+    # In function arguments there must not be arguments with default values before non-default ones.
+    PhpCsFixer\Fixer\FunctionNotation\NoUnreachableDefaultArgumentValueFixer: ~
 
-  # Constans, Class Properties, Methods
+    # Constans, Class Properties, Methods
 
-  # Constants and Properties should be separated by 1 blank line
-  #PhpCsFixer\Fixer\ClassNotation\ClassAttributesSeparationFixer:
-  #    elements: [const, property]
+    # Constants and Properties should be separated by 1 blank line
+    #PhpCsFixer\Fixer\ClassNotation\ClassAttributesSeparationFixer:
+    #    elements: [const, property]
 
-  # Last property and 1st method should be separated by 2 spaces
-  Nette\CodingStandard\Fixer\ClassNotation\LastPropertyAndFirstMethodSeparationFixer:
-    space_count: 2
+    # Last property and 1st method should be separated by 2 spaces
+    Nette\CodingStandard\Fixer\ClassNotation\LastPropertyAndFirstMethodSeparationFixer:
+        space_count: 2
 
-  # Control Statements - https://nette.org/en/coding-standard#toc-control-statements
+    # Control Statements - https://nette.org/en/coding-standard#toc-control-statements
 
-  # The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
-  PhpCsFixer\Fixer\ControlStructure\ElseifFixer: ~
-  # Remove useless semicolon statements.
-  PhpCsFixer\Fixer\Semicolon\NoEmptyStatementFixer: ~
-  # Remove trailing commas in list() calls.
-  PhpCsFixer\Fixer\ControlStructure\NoTrailingCommaInListCallFixer: ~
-  # Removes unneeded parentheses around control statements.
-  PhpCsFixer\Fixer\ControlStructure\NoUnneededControlParenthesesFixer: ~
-  # A case should be followed by a colon and not a semicolon.
-  PhpCsFixer\Fixer\ControlStructure\SwitchCaseSemicolonToColonFixer: ~
-  # The structure body must be indented once.
-  # The closing brace must be on the next line after the body.
-  # There should not be more than one statement per line.
-  #Nette\CodingStandard\Fixer\Basic\BracesFixer:
-  #    allow_single_line_closure: true
-  # changes if (1 === $cond) to if ($cond === 1)
-  #SlevomatCodingStandard\Sniffs\ControlStructures\DisallowYodaComparisonSniff: ~
-  # finds unreachable catch blocks:
-  SlevomatCodingStandard\Sniffs\Exceptions\DeadCatchSniff: ~
+    # The keyword `elseif` should be used instead of `else if` so that all control keywords look like single words.
+    PhpCsFixer\Fixer\ControlStructure\ElseifFixer: ~
+    # Remove useless semicolon statements.
+    PhpCsFixer\Fixer\Semicolon\NoEmptyStatementFixer: ~
+    # Remove trailing commas in list() calls.
+    PhpCsFixer\Fixer\ControlStructure\NoTrailingCommaInListCallFixer: ~
+    # Removes unneeded parentheses around control statements.
+    PhpCsFixer\Fixer\ControlStructure\NoUnneededControlParenthesesFixer: ~
+    # A case should be followed by a colon and not a semicolon.
+    PhpCsFixer\Fixer\ControlStructure\SwitchCaseSemicolonToColonFixer: ~
+    # The structure body must be indented once.
+    # The closing brace must be on the next line after the body.
+    # There should not be more than one statement per line.
+    #Nette\CodingStandard\Fixer\Basic\BracesFixer:
+    #    allow_single_line_closure: true
+    # changes if (1 === $cond) to if ($cond === 1)
+    #SlevomatCodingStandard\Sniffs\ControlStructures\DisallowYodaComparisonSniff: ~
+    # finds unreachable catch blocks:
+    SlevomatCodingStandard\Sniffs\Exceptions\DeadCatchSniff: ~
 
-  # Casting
+    # Casting
 
-  # A single space or none should be between cast and variable (int) $val
-  PhpCsFixer\Fixer\CastNotation\CastSpacesFixer: ~
-  # Cast should be written in lower case.
-  PhpCsFixer\Fixer\CastNotation\LowercaseCastFixer: ~
-  # Replaces `intval`, `floatval`, `doubleval`, `strval` and `boolval` function calls with according type casting operator
-  PhpCsFixer\Fixer\CastNotation\ModernizeTypesCastingFixer: ~
-  # Short cast `bool` using double exclamation mark should not be used
-  PhpCsFixer\Fixer\CastNotation\NoShortBoolCastFixer: ~
-  # Cast `(boolean)` and `(integer)` should be written as `(bool)` and `(int)`, `(double)` and `(real)` as `(float)`
-  PhpCsFixer\Fixer\CastNotation\ShortScalarCastFixer: ~
+    # A single space or none should be between cast and variable (int) $val
+    PhpCsFixer\Fixer\CastNotation\CastSpacesFixer: ~
+    # Cast should be written in lower case.
+    PhpCsFixer\Fixer\CastNotation\LowercaseCastFixer: ~
+    # Replaces `intval`, `floatval`, `doubleval`, `strval` and `boolval` function calls with according type casting operator
+    PhpCsFixer\Fixer\CastNotation\ModernizeTypesCastingFixer: ~
+    # Short cast `bool` using double exclamation mark should not be used
+    PhpCsFixer\Fixer\CastNotation\NoShortBoolCastFixer: ~
+    # Cast `(boolean)` and `(integer)` should be written as `(bool)` and `(int)`, `(double)` and `(real)` as `(float)`
+    PhpCsFixer\Fixer\CastNotation\ShortScalarCastFixer: ~
 
-  # Language Whitespace
+    # Language Whitespace
 
-  # Binary operators should be surrounded by at least one space. DO NOT USE
-  #PhpCsFixer\Fixer\Operator\BinaryOperatorSpacesFixer: ~
-  # Unary operators should be placed adjacent to their operands.
-  PhpCsFixer\Fixer\Operator\UnaryOperatorSpacesFixer: ~
-  # No space after the opening parenthesis and before the closing parenthesis
-  PhpCsFixer\Fixer\Whitespace\NoSpacesInsideParenthesisFixer: ~
-  # There MUST NOT be spaces around offset braces $a[0]
-  PhpCsFixer\Fixer\Whitespace\NoSpacesAroundOffsetFixer: ~
-  # There should not be space before or after object `T_OBJECT_OPERATOR` `->`.
-  PhpCsFixer\Fixer\Operator\ObjectOperatorWithoutWhitespaceFixer: ~
-  # Standardize spaces around ternary operator.
-  PhpCsFixer\Fixer\Operator\TernaryOperatorSpacesFixer: ~
-  # Concatenation $a . $b should be spaced according configuration
-  PhpCsFixer\Fixer\Operator\ConcatSpaceFixer:
-    spacing: one
-  # Removes extra spaces between colon and case value.
-  PhpCsFixer\Fixer\ControlStructure\SwitchCaseSpaceFixer: ~
+    # Binary operators should be surrounded by at least one space. DO NOT USE
+    #PhpCsFixer\Fixer\Operator\BinaryOperatorSpacesFixer: ~
+    # Unary operators should be placed adjacent to their operands.
+    PhpCsFixer\Fixer\Operator\UnaryOperatorSpacesFixer: ~
+    # No space after the opening parenthesis and before the closing parenthesis
+    PhpCsFixer\Fixer\Whitespace\NoSpacesInsideParenthesisFixer: ~
+    # There MUST NOT be spaces around offset braces $a[0]
+    PhpCsFixer\Fixer\Whitespace\NoSpacesAroundOffsetFixer: ~
+    # There should not be space before or after object `T_OBJECT_OPERATOR` `->`.
+    PhpCsFixer\Fixer\Operator\ObjectOperatorWithoutWhitespaceFixer: ~
+    # Standardize spaces around ternary operator.
+    PhpCsFixer\Fixer\Operator\TernaryOperatorSpacesFixer: ~
+    # Concatenation $a . $b should be spaced according configuration
+    PhpCsFixer\Fixer\Operator\ConcatSpaceFixer:
+        spacing: one
+    # Removes extra spaces between colon and case value.
+    PhpCsFixer\Fixer\ControlStructure\SwitchCaseSpaceFixer: ~
 
-  # Comments
+    # Comments
 
-  # Docblocks should have the same indentation as the documented subject.
-  PhpCsFixer\Fixer\Phpdoc\PhpdocIndentFixer: ~
-  # There should not be any empty comments.
-  PhpCsFixer\Fixer\Comment\NoEmptyCommentFixer: ~
-  # There should not be empty PHPDoc blocks.
-  #PhpCsFixer\Fixer\Phpdoc\NoEmptyPhpdocFixer: ~
-  # Phpdocs should start and end with content, excluding the very first and last line of the docblocks.
-  PhpCsFixer\Fixer\Phpdoc\PhpdocTrimFixer: ~
-  # Single-line comments comments with only one line of actual content should use the `//` syntax.
-  PhpCsFixer\Fixer\Comment\SingleLineCommentStyleFixer:
-    comment_types: [ 'hash' ]
-  # Require comments with single-line content to be written as one-liners
-  SlevomatCodingStandard\Sniffs\Commenting\RequireOneLinePropertyDocCommentSniff: ~
+    # Docblocks should have the same indentation as the documented subject.
+    PhpCsFixer\Fixer\Phpdoc\PhpdocIndentFixer: ~
+    # There should not be any empty comments.
+    PhpCsFixer\Fixer\Comment\NoEmptyCommentFixer: ~
+    # There should not be empty PHPDoc blocks.
+    #PhpCsFixer\Fixer\Phpdoc\NoEmptyPhpdocFixer: ~
+    # Phpdocs should start and end with content, excluding the very first and last line of the docblocks.
+    PhpCsFixer\Fixer\Phpdoc\PhpdocTrimFixer: ~
+    # Single-line comments comments with only one line of actual content should use the `//` syntax.
+    PhpCsFixer\Fixer\Comment\SingleLineCommentStyleFixer:
+        comment_types: ['hash']
+    # Require comments with single-line content to be written as one-liners
+    SlevomatCodingStandard\Sniffs\Commenting\RequireOneLinePropertyDocCommentSniff: ~
 
 
-  # Properties MUST not be explicitly initialized with `null`.
-  #PhpCsFixer\Fixer\ClassNotation\NoNullPropertyInitializationFixer: ~
+    # Properties MUST not be explicitly initialized with `null`.
+    #PhpCsFixer\Fixer\ClassNotation\NoNullPropertyInitializationFixer: ~
 
-  PhpCsFixer\Fixer\ControlStructure\NoBreakCommentFixer:
-    comment_text: 'break omitted'
+    PhpCsFixer\Fixer\ControlStructure\NoBreakCommentFixer:
+        comment_text: 'break omitted'
 
-  # declare(strict_types=1);
-  PhpCsFixer\Fixer\Strict\DeclareStrictTypesFixer: ~
-  # Enforces consistent formatting of return typehints: function foo(): ?int
-  SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSpacingSniff: ~
-  # Use `null` coalescing operator `??` where possible.
-  PhpCsFixer\Fixer\Operator\TernaryToNullCoalescingFixer: ~
+    # declare(strict_types=1);
+    PhpCsFixer\Fixer\Strict\DeclareStrictTypesFixer: ~
+    # Enforces consistent formatting of return typehints: function foo(): ?int
+    SlevomatCodingStandard\Sniffs\TypeHints\ReturnTypeHintSpacingSniff: ~
+    # Use `null` coalescing operator `??` where possible.
+    PhpCsFixer\Fixer\Operator\TernaryToNullCoalescingFixer: ~
 
-  Nette\CodingStandard\Fixer\ClassNotation\ClassAndTraitVisibilityRequiredFixer:
-    elements: [ 'const', 'property', 'method' ]
+    Nette\CodingStandard\Fixer\ClassNotation\ClassAndTraitVisibilityRequiredFixer:
+        elements: ['const', 'property', 'method']
 
-  # short list() syntax []
-  PhpCsFixer\Fixer\ListNotation\ListSyntaxFixer:
-    syntax: short
+    # short list() syntax []
+    PhpCsFixer\Fixer\ListNotation\ListSyntaxFixer:
+        syntax: short

.ci/php-cs-fixer/.gitignore

@@ -1,2 +0,0 @@
-vendor
-.php-cs-fixer.cache

.ci/php-cs-fixer/.php-cs-fixer.php

@@ -1,77 +0,0 @@
-<?php
-/*
- * .php-cs-fixer.php
- * Copyright (c) 2022 james@firefly-iii.org
- *
- * This file is part of Firefly III (https://github.com/firefly-iii).
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-use PhpCsFixer\Runner\Parallel\ParallelConfigFactory;
-
-$current = __DIR__;
-
-$paths = [
-    $current . '/../../app',
-    $current . '/../../config',
-    $current . '/../../database',
-    $current . '/../../routes',
-    $current . '/../../tests',
-    $current . '/../../resources/lang/en_US',
-];
-
-$finder = PhpCsFixer\Finder::create()
-                           ->in($paths);
-
-
-$config = new PhpCsFixer\Config();
-$config->setParallelConfig(ParallelConfigFactory::detect());
-return $config->setRules(
-    [
-        // rule sets
-        '@PHP83Migration'               => true,
-        '@PhpCsFixer'                   => true,
-        '@PhpCsFixer:risky'             => true,
-        '@PSR12'                        => true,
-        '@PSR12:risky'                  => true,
-        'declare_strict_types'          => true,
-        'strict_param'                  => true,
-        'no_unused_imports'             => true,
-        'single_space_around_construct' => true,
-        'statement_indentation'         => true,
-        'void_return'                   => true,
-
-        // disabled rules
-        'native_function_invocation'    => false, // annoying
-        'php_unit_data_provider_name'   => false, // bloody annoying long test names
-        'static_lambda'                 => false, // breaks the Response macro for API's.
-        'phpdoc_summary'                => false, // annoying.
-        'comment_to_phpdoc'             => false, // breaks phpstan lines in combination with PHPStorm.
-        'type_declaration_spaces'       => false,
-        'cast_spaces'                   => false,
-        'phpdoc_to_comment' => false, // do not overrule single line comment style, breaks phpstan.
-
-        // complex rules
-        'array_syntax'                  => ['syntax' => 'short'],
-        'binary_operator_spaces'        => [
-            'default'   => 'at_least_single_space',
-            'operators' => [
-                '=>'  => 'align_single_space_by_scope',
-                '='   => 'align_single_space_minimal_by_scope',
-                '??=' => 'align_single_space_minimal_by_scope',
-            ],
-        ],
-    ])
-              ->setFinder($finder);

.ci/php-cs-fixer/composer.json

@@ -1,5 +0,0 @@
-{
-    "require": {
-        "friendsofphp/php-cs-fixer": "^3.12"
-    }
-}

.ci/phpmd/.gitignore

@@ -1 +0,0 @@
-vendor

.ci/phpmd/composer.json

@@ -1,5 +0,0 @@
-{
-    "require-dev": {
-        "phpmd/phpmd": "^2.13"
-    }
-}

.ci/phpmd/phpmd.xml

@@ -1,94 +0,0 @@
-<?xml version="1.0" encoding="UTF-8"?>
-<!--
-  ~ phpmd.xml
-  ~ Copyright (c) 2023 james@firefly-iii.org
-  ~
-  ~ This file is part of Firefly III (https://github.com/firefly-iii).
-  ~
-  ~ This program is free software: you can redistribute it and/or modify
-  ~ it under the terms of the GNU Affero General Public License as
-  ~ published by the Free Software Foundation, either version 3 of the
-  ~ License, or (at your option) any later version.
-  ~
-  ~ This program is distributed in the hope that it will be useful,
-  ~ but WITHOUT ANY WARRANTY; without even the implied warranty of
-  ~ MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
-  ~ GNU Affero General Public License for more details.
-  ~
-  ~ You should have received a copy of the GNU Affero General Public License
-  ~ along with this program.  If not, see <https://www.gnu.org/licenses/>.
-  -->
-
-<ruleset xmlns:xsi="http://www.w3.org/2001/XMLSchema-instance"
-         name="pcsg-generated-ruleset"
-         xmlns="http://pmd.sf.net/ruleset/1.0.0"
-         xsi:schemaLocation="http://pmd.sf.net/ruleset/1.0.0 http://pmd.sf.net/ruleset_xml_schema.xsd"
-         xsi:noNamespaceSchemaLocation="http://pmd.sf.net/ruleset_xml_schema.xsd">
-    <description>Firefly III ruleset.</description>
-    <!-- Import the entire controversial code rule set -->
-    <rule ref="rulesets/controversial.xml">
-        <exclude name="CamelCasePropertyName"/>
-    </rule>
-
-    <!-- clean code -->
-    <!-- <rule ref="rulesets/codesize.xml" /> -->
-    <rule ref="rulesets/unusedcode.xml"/>
-
-
-    <rule ref="rulesets/design.xml/NumberOfChildren">
-        <properties>
-            <!-- This is now at 32, which excludes the controllers but should prevent more monoliths. -->
-            <property name="minimum" value="32"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/design.xml/CouplingBetweenObjects">
-        <properties>
-            <!-- Leaving this at 28 excuses most current code but it can't get worse than that. -->
-            <property name="maximum" value="28"/>
-        </properties>
-    </rule>
-
-
-    <rule ref="rulesets/naming.xml/ShortMethodName">
-        <properties>
-            <property name="minimum" value="3"/>
-        </properties>
-    </rule>
-
-    <!-- code size -->
-    <rule ref="rulesets/codesize.xml/CyclomaticComplexity">
-        <properties>
-            <!-- Leave at 20. This means methods will be pretty complex before the system starts complaining. -->
-            <property name="reportLevel" value="20"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/codesize.xml/NPathComplexity">
-        <properties>
-            <!-- 2000 results in some pretty complex methods, but it's OK. -->
-            <!-- They should not be much more complex than that though -->
-            <property name="minimum" value="2000"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/codesize.xml/ExcessiveMethodLength">
-        <properties>
-            <!-- 75 seems like a nice number. Shorter isn't always feasible and there are a few exceptions already -->
-            <property name="minimum" value="75"/>
-            <property name="ignore-whitespace" value="true"/>
-        </properties>
-    </rule>
-    <rule ref="rulesets/codesize.xml/ExcessiveParameterList">
-        <properties>
-            <!-- 5 is fine. 6 is excessive, but I have just one of those. At the end of the day, I still need all params. -->
-            <property name="minimum" value="5"/>
-        </properties>
-    </rule>
-
-    <!-- include clean code manually -->
-    <rule ref="rulesets/cleancode.xml/BooleanArgumentFlag"/>
-    <rule ref="rulesets/cleancode.xml/ElseExpression"/>
-    <rule ref="rulesets/cleancode.xml/MissingImport"/>
-    <rule ref="rulesets/cleancode.xml/UndefinedVariable"/>
-    <rule ref="rulesets/cleancode.xml/IfStatementAssignment"/>
-    <rule ref="rulesets/cleancode.xml/DuplicatedArrayKey"/>
-    <rule ref="rulesets/cleancode.xml/ErrorControlOperator"/>
-</ruleset>

.ci/phpstan.neon

@@ -1,38 +1,33 @@
+includes:
+  - ../vendor/nunomaduro/larastan/extension.neon
+  - ../vendor/ergebnis/phpstan-rules/rules.neon
+  - ../vendor/phpstan/phpstan-deprecation-rules/rules.neon
+  - ../vendor/thecodingmachine/phpstan-strict-rules/phpstan-strict-rules.neon
+
 parameters:
-  scanFiles:
-    - ../_ide_helper
+  ignoreErrors:
+    - '#is not allowed to extend#'
+    - '#is neither abstract nor final#'
+    - '#Control structures using switch should not be used\.#'
+    - '#has a nullable return type declaration#'
+    - '#with a nullable type declaration#'
+    - '#with null as default value#'
+    - '#Constructor in [a-zA-Z0-9\\_]+ has parameter \$[a-zA-Z0-9\\_]+ with default value#'
+    -
+        message: '#Function compact\(\) should not be used.#'
+        paths:
+            - ../app/Http/Controllers
+            - ../app/Support/Http/Controllers/RenderPartialViews.php
+            - ../app/Support/Form/FormSupport.php
+            - ../app/Support/Form/CurrencyForm.php
+            - ../app/Support/Form/AccountForm.php
+            - ../app/Support/ExpandedForm.php
+            - ../app/Generator/Report
   paths:
     - ../app
     - ../database
     - ../routes
-    - ../config
     - ../bootstrap/app.php
-  universalObjectCratesClasses:
-    - Illuminate\Database\Eloquent\Model
-  # TODO: slowly remove these parameters and fix the issues found.
-  reportUnmatchedIgnoredErrors: true
-  ignoreErrors:
-  # TODO: slowly remove these exceptions and fix the issues found.
-    - '#Dynamic call to static method#' # all the Laravel ORM things depend on this.
-    - identifier: varTag.nativeType
-    - identifier: varTag.type
-    -
-        identifier: larastan.noEnvCallsOutsideOfConfig
-        path: ../app/Console/Commands/System/CreatesDatabase.php
-    - identifier: missingType.iterableValue # not interesting enough to fix.
-    - identifier: missingType.generics # not interesting enough to fix.
-    - "#Parameter \\#[1-2] \\$num[1-2] of function bc[a-z]+ expects numeric-string, [a-z\\-|&]+ given#"
-    - '#expects view-string, string given#'
-    - '#expects view-string\|null, string given#'
-
-    # phpstan can't handle this so we ignore them.
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::before#'
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::after#'
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::withTrashed#'
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\HasMany::accountTypeIn#'
-    - '#Call to an undefined method Illuminate\\Database\\Eloquent\\Relations\\BelongsTo::withTrashed#'
 
   # The level 8 is the highest level. original was 5
-  # 7 is more than enough, higher just leaves NULL things.
-  level: 7
-
+  level: 3

.ci/phpstan.sh

@@ -23,26 +23,11 @@
 # Install composer packages
 #composer install --no-scripts --no-ansi
 
-SCRIPT_DIR="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
-
 # enable test .env file.
-# cp .ci/.env.ci .env
+cp .ci/.env.ci .env
 
 # Do static code analysis.
-if [[ $GITHUB_ACTIONS = "" ]]
-then
-    ./vendor/bin/phpstan analyse -c .ci/phpstan.neon --error-format=table > phpstan-report.txt
-    EXIT_CODE=$?
-    echo "The PHPstan report can be found in phpstan-report.txt. Exit code is $EXIT_CODE."
-fi
+# ./vendor/bin/phpstan analyse -c .ci/phpstan.neon --no-progress
+./vendor/bin/phpstan analyse -c .ci/phpstan.neon
 
-if [[ $GITHUB_ACTIONS = "true" ]]
-then
-    ./vendor/bin/phpstan analyse -c .ci/phpstan.neon --no-progress --error-format=github
-    EXIT_CODE=$?
-
-    # temporary exit code 0
-    # EXIT_CODE=0
-fi
-
-exit $EXIT_CODE
+exit 0

.ci/phpunit.sh

@@ -1,7 +1,7 @@
 #!/usr/bin/env bash
 
 #
-# phpstan.sh
+# phpunit.sh
 # Copyright (c) 2021 james@firefly-iii.org
 #
 # This file is part of Firefly III (https://github.com/firefly-iii).
@@ -20,21 +20,14 @@
 # along with this program.  If not, see <https://www.gnu.org/licenses/>.
 #
 
-SCRIPT_DIR="$( cd -- "$( dirname -- "${BASH_SOURCE[0]}" )" &> /dev/null && pwd )"
+# enable test .env file.
+cp .ci/.env.ci ../.env
 
-# clean up php code
-cd $SCRIPT_DIR/php-cs-fixer
-composer update --quiet
-rm -f .php-cs-fixer.cache
-PHP_CS_FIXER_IGNORE_ENV=true ./vendor/bin/php-cs-fixer fix \
-    --config $SCRIPT_DIR/php-cs-fixer/.php-cs-fixer.php \
-    --format=txt -v \
-    --allow-risky=yes
+# download test database
+# TODO no longer exists
+wget --quiet https://raw.githubusercontent.com/firefly-iii/test-data/main/test_db.sqlite -o storage/database/test_db.sqlite
 
-EXIT_CODE=$?
+# run phpunit
+./vendor/bin/phpunit --configuration phpunit.coverage.xml
 
-echo "Exit code for CS fixer is $EXIT_CODE."
-
-cd $SCRIPT_DIR/..
-
-exit $EXIT_CODE
+exit 0

.deploy/heroku/.env.heroku

@@ -0,0 +1,327 @@
+# You can leave this on "local". If you change it to production most console commands will ask for extra confirmation.
+# Never set it to "testing".
+APP_ENV=heroku
+
+# Set to true if you want to see debug information in error screens.
+APP_DEBUG=false
+
+# This should be your email address.
+# If you use Docker or similar, you can set this variable from a file by using SITE_OWNER_FILE
+SITE_OWNER=heroku@example.com
+
+# The encryption key for your sessions. Keep this very secure.
+# If you generate a new one all existing attachments must be considered LOST.
+# Change it to a string of exactly 32 chars or use something like `php artisan key:generate` to generate it.
+# If you use Docker or similar, you can set this variable from a file by using APP_KEY_FILE
+APP_KEY=7ahyYVPVsmxjdhsweWCauGeJfwc92NP2
+
+#
+# Firefly III will launch using this language (for new users and unauthenticated visitors)
+# For a list of available languages: https://github.com/firefly-iii/firefly-iii/tree/main/resources/lang
+#
+# If text is still in English, remember that not everything may have been translated.
+DEFAULT_LANGUAGE=en_US
+
+# The locale defines how numbers are formatted.
+# by default this value is the same as whatever the language is.
+DEFAULT_LOCALE=equal
+
+# Change this value to your preferred time zone.
+# Example: Europe/Amsterdam
+# For a list of supported time zones, see https://en.wikipedia.org/wiki/List_of_tz_database_time_zones
+TZ=UTC
+
+# TRUSTED_PROXIES is a useful variable when using Docker and/or a reverse proxy.
+# Set it to ** and reverse proxies work just fine.
+TRUSTED_PROXIES=**
+
+# The log channel defines where your log entries go to.
+# Several other options exist. You can use 'single' for one big fat error log (not recommended).
+# Also available are 'syslog', 'errorlog' and 'stdout' which will log to the system itself.
+# A rotating log option is 'daily', creates 5 files that (surprise) rotate.
+# Default setting 'stack' will log to 'daily' and to 'stdout' at the same time.
+
+# - Docker + versions <= 4.8.1.8 and before: use "stdout"
+# - Docker + versions >  4.8.1.8           : use "docker_out"
+# - Docker + versions >=  5.1.1            : use "stack"
+# - For everything else (als not Docker)   : use 'stack'
+
+LOG_CHANNEL=stdout
+
+# Log level. You can set this from least severe to most severe:
+# debug, info, notice, warning, error, critical, alert, emergency
+# If you set it to debug your logs will grow large, and fast. If you set it to emergency probably
+# nothing will get logged, ever.
+APP_LOG_LEVEL=notice
+
+# Database credentials. Make sure the database exists. I recommend a dedicated user for Firefly III
+# For other database types, please see the FAQ: https://docs.firefly-iii.org/support/faq
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
+# Use "pgsql" for PostgreSQL
+# Use "mysql" for MySQL and MariaDB.
+# Use "sqlite" for SQLite.
+DB_CONNECTION=pgsql
+
+
+# MySQL supports SSL. You can configure it here.
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
+MYSQL_USE_SSL=false
+MYSQL_SSL_VERIFY_SERVER_CERT=true
+# You need to set at least of these options
+MYSQL_SSL_CAPATH=/etc/ssl/certs/
+MYSQL_SSL_CA=
+MYSQL_SSL_CERT=
+MYSQL_SSL_KEY=
+MYSQL_SSL_CIPHER=
+
+# PostgreSQL supports SSL. You can configure it here.
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
+PGSQL_SSL_MODE=prefer
+PGSQL_SSL_ROOT_CERT=null
+PGSQL_SSL_CERT=null
+PGSQL_SSL_KEY=null
+PGSQL_SSL_CRL_FILE=null
+
+# If you're looking for performance improvements, you could install memcached.
+CACHE_DRIVER=file
+SESSION_DRIVER=file
+
+# If you set either of these to 'redis', you might want to update these settings too
+# If you use Docker or similar, you can set REDIS_HOST_FILE, REDIS_PASSWORD_FILE or
+# REDIS_PORT_FILE to set the value from a file instead of from an environment variable
+
+# can be tcp, unix or http
+REDIS_SCHEME=tcp
+
+# use only when using 'unix' for REDIS_SCHEME. Leave empty otherwise.
+REDIS_PATH=
+
+# use only when using 'tcp' or 'http' for REDIS_SCHEME. Leave empty otherwise.
+REDIS_HOST=127.0.0.1
+REDIS_PORT=6379
+
+REDIS_PASSWORD=null
+# always use quotes and make sure redis db "0" and "1" exists. Otherwise change accordingly.
+REDIS_DB="0"
+REDIS_CACHE_DB="1"
+
+# Cookie settings. Should not be necessary to change these.
+# If you use Docker or similar, you can set COOKIE_DOMAIN_FILE to set
+# the value from a file instead of from an environment variable
+COOKIE_PATH="/"
+COOKIE_DOMAIN=
+COOKIE_SECURE=false
+
+# If you want Firefly III to mail you, update these settings
+# For instructions, see: https://docs.firefly-iii.org/advanced-installation/email
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
+MAIL_MAILER=log
+MAIL_HOST=null
+MAIL_PORT=2525
+MAIL_FROM=changeme@example.com
+MAIL_USERNAME=null
+MAIL_PASSWORD=null
+MAIL_ENCRYPTION=null
+
+# Other mail drivers:
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
+MAILGUN_DOMAIN=
+MAILGUN_SECRET=
+
+
+# If you are on EU region in mailgun, use api.eu.mailgun.net, otherwise use api.mailgun.net
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
+MAILGUN_ENDPOINT=api.mailgun.net
+
+# If you use Docker or similar, you can set these variables from a file by appending them with _FILE
+MANDRILL_SECRET=
+SPARKPOST_SECRET=
+
+
+# Firefly III can send you the following messages
+SEND_REGISTRATION_MAIL=true
+SEND_ERROR_MESSAGE=true
+
+# These messages contain (sensitive) transaction information:
+SEND_REPORT_JOURNALS=true
+
+# Set a Mapbox API key here (see mapbox.com) so there might be a map available at various places.
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
+MAPBOX_API_KEY=
+
+# The map will default to this location:
+MAP_DEFAULT_LAT=51.983333
+MAP_DEFAULT_LONG=5.916667
+MAP_DEFAULT_ZOOM=6
+
+# Firefly III currently supports two provider for live Currency Exchange Rates:
+# "fixer", and "ratesapi".
+# RatesApi.IO (see https://ratesapi.io) is a FREE and OPEN SOURCE live currency exchange rates,
+# built compatible with Fixer.IO, based on data published by European Central Bank, and doesn't require API key.
+CER_PROVIDER=ratesapi
+
+# If you have select "fixer" as default currency exchange rates,
+# set a Fixer IO API key here (see https://fixer.io) to enable live currency exchange rates.
+# Please note that this WILL ONLY WORK FOR PAID fixer.io accounts because they severely limited
+# the free API up to the point where you might as well offer nothing.
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
+FIXER_API_KEY=
+
+# Firefly III has two options for user authentication. "eloquent" is the default,
+# and "ldap" for LDAP servers.
+# For full instructions on these settings please visit:
+# https://docs.firefly-iii.org/advanced-installation/authentication
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
+LOGIN_PROVIDER=eloquent
+
+#
+# It's also possible to change the way users are authenticated. You could use Authelia for example.
+# Authentication via the REMOTE_USER header is supported. Change the value below to "remote_user_guard".
+#
+# If you do this please read the documentation for instructions and warnings:
+# https://docs.firefly-iii.org/advanced-installation/authentication
+#
+# This function is available in Firefly III v5.3.0 and higher.
+AUTHENTICATION_GUARD=web
+
+#
+# Likewise, it's impossible to log out users who's authentication is handled by an external system.
+# Enter a custom URL here that will force a logout (your authentication provider can tell you).
+# Setting this variable only works when AUTHENTICATION_GUARD != web
+#
+CUSTOM_LOGOUT_URI=
+
+# LDAP connection configuration
+# OpenLDAP, FreeIPA or ActiveDirectory
+# # If you use Docker or similar, you can set this variable from a file by appending it with _FILE
+ADLDAP_CONNECTION_SCHEME=OpenLDAP
+ADLDAP_AUTO_CONNECT=true
+
+# LDAP connection settings
+# You can set the following variables from a file by appending them with _FILE:
+# ADLDAP_CONTROLLERS, ADLDAP_PORT, ADLDAP_BASEDN
+ADLDAP_CONTROLLERS=
+ADLDAP_PORT=389
+ADLDAP_TIMEOUT=5
+ADLDAP_BASEDN=""
+ADLDAP_FOLLOW_REFFERALS=false
+
+# SSL/TLS settings
+ADLDAP_USE_SSL=false
+ADLDAP_USE_TLS=false
+ADLDAP_SSL_CACERTDIR=
+ADLDAP_SSL_CACERTFILE=
+ADLDAP_SSL_CERTFILE=
+ADLDAP_SSL_KEYFILE=
+ADLDAP_SSL_CIPHER_SUITE=
+ADLDAP_SSL_REQUIRE_CERT=
+
+# You can set the following variables from a file by appending them with _FILE:
+ADLDAP_ADMIN_USERNAME=
+ADLDAP_ADMIN_PASSWORD=
+
+# You can set the following variables from a file by appending them with _FILE:
+ADLDAP_ACCOUNT_PREFIX=
+ADLDAP_ACCOUNT_SUFFIX=
+
+
+# LDAP authentication settings.
+ADLDAP_PASSWORD_SYNC=false
+ADLDAP_LOGIN_FALLBACK=false
+
+ADLDAP_DISCOVER_FIELD=distinguishedname
+ADLDAP_AUTH_FIELD=distinguishedname
+
+# Will allow SSO if your server provides an AUTH_USER field.
+# You can set the following variables from a file by appending them with _FILE:
+WINDOWS_SSO_ENABLED=false
+WINDOWS_SSO_DISCOVER=samaccountname
+WINDOWS_SSO_KEY=AUTH_USER
+
+# field to sync as local username.
+# You can set the following variable from a file by appending it with _FILE:
+ADLDAP_SYNC_FIELD=userprincipalname
+
+# You can disable the X-Frame-Options header if it interferes with tools like
+# Organizr. This is at your own risk. Applications running in frames run the risk
+# of leaking information to their parent frame.
+DISABLE_FRAME_HEADER=false
+
+# You can disable the Content Security Policy header when you're using an ancient browser
+# or any version of Microsoft Edge / Internet Explorer (which amounts to the same thing really)
+# This leaves you with the risk of not being able to stop XSS bugs should they ever surface.
+# This is at your own risk.
+DISABLE_CSP_HEADER=false
+
+# If you wish to track your own behavior over Firefly III, set valid analytics tracker information here.
+# Nobody uses this except for me on the demo site. But hey, feel free to use this if you want to.
+# Do not prepend the TRACKER_URL with http:// or https://
+# The only tracker supported is Matomo.
+# You can set the following variables from a file by appending them with _FILE:
+TRACKER_SITE_ID=
+TRACKER_URL=
+
+#
+# Firefly III can collect telemetry on how you use Firefly III. This is opt-in.
+# In order to allow this, change the following variable to true.
+# To read more about this feature, go to this page: https://docs.firefly-iii.org/support/telemetry
+SEND_TELEMETRY=false
+
+# You can fine tune the start-up of a Docker container by editing these environment variables.
+# Use this at your own risk. Disabling certain checks and features may result in lost of inconsistent data.
+# However if you know what you're doing you can significantly speed up container start times.
+# Set each value to true to enable, or false to disable.
+
+# Check if the SQLite database exists. Can be skipped if you're not using SQLite.
+# Won't significantly speed up things.
+DKR_CHECK_SQLITE=true
+
+# Run database creation and migration commands. Disable this only if you're 100% sure the DB exists
+# and is up to date.
+DKR_RUN_MIGRATION=true
+
+# Run database upgrade commands. Disable this only when you're 100% sure your DB is up-to-date
+# with the latest fixes (outside of migrations!)
+DKR_RUN_UPGRADE=true
+
+# Verify database integrity. Includes all data checks and verifications.
+# Disabling this makes Firefly III assume your DB is intact.
+DKR_RUN_VERIFY=true
+
+# Run database reporting commands. When disabled, Firefly III won't go over your data to report current state.
+# Disabling this should have no impact on data integrity or safety but it won't warn you of possible issues.
+DKR_RUN_REPORT=true
+
+# Generate OAuth2 keys.
+# When disabled, Firefly III won't attempt to generate OAuth2 Passport keys. This won't be an issue, IFF (if and only if)
+# you had previously generated keys already and they're stored in your database for restoration.
+DKR_RUN_PASSPORT_INSTALL=true
+
+# Leave the following configuration vars as is.
+# Unless you like to tinker and know what you're doing.
+APP_NAME=FireflyIII
+ADLDAP_CONNECTION=default
+BROADCAST_DRIVER=log
+QUEUE_DRIVER=sync
+CACHE_PREFIX=firefly
+SEARCH_RESULT_LIMIT=50
+PUSHER_KEY=
+PUSHER_SECRET=
+PUSHER_ID=
+DEMO_USERNAME=
+DEMO_PASSWORD=
+USE_ENCRYPTION=false
+IS_HEROKU=false
+FIREFLY_III_LAYOUT=v1
+
+#
+# If you have trouble configuring your Firefly III installation, DON'T BOTHER setting this variable.
+# It won't work. It doesn't do ANYTHING. Don't believe the lies you read online. I'm not joking.
+# This configuration value WILL NOT HELP.
+#
+# This variable is ONLY used in some of the emails Firefly III sends around. Nowhere else.
+# So when configuring anything WEB related this variable doesn't do anything. Nothing
+#
+# If you're stuck I understand you get desperate but look SOMEWHERE ELSE.
+#
+APP_URL=http://localhost

.deploy/heroku/.locales

@@ -0,0 +1,23 @@
+bg_BG
+cs_CZ
+de_DE
+el_GR
+en_GB
+en_US
+es_ES
+fi_FI
+fr_FR
+hu_HU
+it_IT
+nb_NO
+nl_NL
+pl_PL
+pt_BR
+pt_PT
+ro_RO
+ru_RU
+sk_SK
+sv_SE
+vi_VN
+zh-hans_CN
+zh-hant_CN

.editorconfig

@@ -1,18 +0,0 @@
-root = true
-
-[*]
-charset = utf-8
-end_of_line = lf
-indent_size = 4
-indent_style = space
-insert_final_newline = true
-trim_trailing_whitespace = true
-
-[*.md]
-trim_trailing_whitespace = false
-
-[*.{yml,yaml}]
-indent_size = 2
-
-[docker-compose.yml]
-indent_size = 4

.env.example

@@ -1,21 +1,17 @@
 # You can leave this on "local". If you change it to production most console commands will ask for extra confirmation.
 # Never set it to "testing".
-APP_ENV=production
+APP_ENV=local
 
 # Set to true if you want to see debug information in error screens.
 APP_DEBUG=false
 
 # This should be your email address.
 # If you use Docker or similar, you can set this variable from a file by using SITE_OWNER_FILE
-# The variable is used in some errors shown to users who aren't admin.
 SITE_OWNER=mail@example.com
 
 # The encryption key for your sessions. Keep this very secure.
 # Change it to a string of exactly 32 chars or use something like `php artisan key:generate` to generate it.
 # If you use Docker or similar, you can set this variable from a file by using APP_KEY_FILE
-#
-# Avoid the "#" character in your APP_KEY, it may break things.
-#
 APP_KEY=SomeRandomStringOf32CharsExactly
 
 # Firefly III will launch using this language (for new users and unauthenticated visitors)
@@ -41,8 +37,13 @@ TRUSTED_PROXIES=
 # Several other options exist. You can use 'single' for one big fat error log (not recommended).
 # Also available are 'syslog', 'errorlog' and 'stdout' which will log to the system itself.
 # A rotating log option is 'daily', creates 5 files that (surprise) rotate.
-# A cool option is 'papertrail' for cloud logging
 # Default setting 'stack' will log to 'daily' and to 'stdout' at the same time.
+
+# - Docker + versions <= 4.8.1.8 and before: use "stdout"
+# - Docker + versions >  4.8.1.8           : use "docker_out"
+# - Docker + versions >=  5.1.1            : use "stack"
+# - For everything else (als not Docker)   : use 'stack'
+
 LOG_CHANNEL=stack
 
 # Log level. You can set this from least severe to most severe:
@@ -52,33 +53,12 @@ LOG_CHANNEL=stack
 APP_LOG_LEVEL=notice
 
 # Audit log level.
-# The audit log is used to log notable Firefly III events on a separate channel.
-# These log entries may contain sensitive financial information.
-# The audit log is disabled by default.
-#
-# To enable it, set AUDIT_LOG_LEVEL to "info"
-# To disable it, set AUDIT_LOG_LEVEL to "emergency"
-AUDIT_LOG_LEVEL=emergency
-
-#
-# If you want, you can redirect the audit logs to another channel.
-# Set 'audit_stdout', 'audit_syslog', 'audit_errorlog' to log to the system itself.
-# Use audit_daily to log to a rotating file.
-# Use audit_papertrail to log to papertrail.
-#
-# If you do this, the audit logs may be mixed with normal logs because the settings for these channels
-# are often the same as the settings for the normal logs.
-AUDIT_LOG_CHANNEL=
-
-#
-# Used when logging to papertrail:
-# Also used when audit logs log to papertrail:
-#
-PAPERTRAIL_HOST=
-PAPERTRAIL_PORT=
+# set to "emergency" if you dont want to store audit logs.
+# leave on info otherwise.
+AUDIT_LOG_LEVEL=info
 
 # Database credentials. Make sure the database exists. I recommend a dedicated user for Firefly III
-# For other database types, please see the FAQ: https://docs.firefly-iii.org/references/faq/install/#i-want-to-use-sqlite
+# For other database types, please see the FAQ: https://docs.firefly-iii.org/support/faq
 # If you use Docker or similar, you can set these variables from a file by appending them with _FILE
 # Use "pgsql" for PostgreSQL
 # Use "mysql" for MySQL and MariaDB.
@@ -89,8 +69,6 @@ DB_PORT=3306
 DB_DATABASE=firefly
 DB_USERNAME=firefly
 DB_PASSWORD=secret_firefly_password
-# leave empty or omit when not using a socket connection
-DB_SOCKET=
 
 # MySQL supports SSL. You can configure it here.
 # If you use Docker or similar, you can set these variables from a file by appending them with _FILE
@@ -111,21 +89,15 @@ PGSQL_SSL_CERT=null
 PGSQL_SSL_KEY=null
 PGSQL_SSL_CRL_FILE=null
 
-# For postgresql 15 and up, setting this to public will no longer work as expected, becasuse the
-# 'public' schema is without grants. This can be worked around by having a super user grant those
-# necessary privileges, but in security conscious setups that's not viable.
-# You will need to set this to the schema you want to use.
-PGSQL_SCHEMA=public
-
-# If you're looking for performance improvements, you could install memcached or redis
+# If you're looking for performance improvements, you could install memcached.
 CACHE_DRIVER=file
 SESSION_DRIVER=file
 
-# If you set either of the options above to 'redis', you might want to update these settings too
+# If you set either of these to 'redis', you might want to update these settings too
 # If you use Docker or similar, you can set REDIS_HOST_FILE, REDIS_PASSWORD_FILE or
 # REDIS_PORT_FILE to set the value from a file instead of from an environment variable
 
-# can be tcp or unix. http is not supported
+# can be tcp, unix or http
 REDIS_SCHEME=tcp
 
 # use only when using 'unix' for REDIS_SCHEME. Leave empty otherwise.
@@ -135,10 +107,7 @@ REDIS_PATH=
 REDIS_HOST=127.0.0.1
 REDIS_PORT=6379
 
-# Use only with Redis 6+ with proper ACL set. Leave empty otherwise.
-REDIS_USERNAME=
-REDIS_PASSWORD=
-
+REDIS_PASSWORD=null
 # always use quotes and make sure redis db "0" and "1" exists. Otherwise change accordingly.
 REDIS_DB="0"
 REDIS_CACHE_DB="1"
@@ -146,14 +115,13 @@ REDIS_CACHE_DB="1"
 # Cookie settings. Should not be necessary to change these.
 # If you use Docker or similar, you can set COOKIE_DOMAIN_FILE to set
 # the value from a file instead of from an environment variable
-# Setting samesite to "strict" may give you trouble logging in.
 COOKIE_PATH="/"
 COOKIE_DOMAIN=
 COOKIE_SECURE=false
 COOKIE_SAMESITE=lax
 
-# If you want Firefly III to email you, update these settings
-# For instructions, see: https://docs.firefly-iii.org/how-to/firefly-iii/advanced/notifications/#email
+# If you want Firefly III to mail you, update these settings
+# For instructions, see: https://docs.firefly-iii.org/advanced-installation/email
 # If you use Docker or similar, you can set these variables from a file by appending them with _FILE
 MAIL_MAILER=log
 MAIL_HOST=null
@@ -162,13 +130,13 @@ MAIL_FROM=changeme@example.com
 MAIL_USERNAME=null
 MAIL_PASSWORD=null
 MAIL_ENCRYPTION=null
-MAIL_SENDMAIL_COMMAND=
 
 # Other mail drivers:
 # If you use Docker or similar, you can set these variables from a file by appending them with _FILE
 MAILGUN_DOMAIN=
 MAILGUN_SECRET=
 
+
 # If you are on EU region in mailgun, use api.eu.mailgun.net, otherwise use api.mailgun.net
 # If you use Docker or similar, you can set this variable from a file by appending it with _FILE
 MAILGUN_ENDPOINT=api.mailgun.net
@@ -176,78 +144,126 @@ MAILGUN_ENDPOINT=api.mailgun.net
 # If you use Docker or similar, you can set these variables from a file by appending them with _FILE
 MANDRILL_SECRET=
 SPARKPOST_SECRET=
-MAILERSEND_API_KEY=
 
-# Firefly III can send you the following messages.
+# Firefly III can send you the following messages
+SEND_REGISTRATION_MAIL=true
 SEND_ERROR_MESSAGE=true
+SEND_LOGIN_NEW_IP_WARNING=true
 
 # These messages contain (sensitive) transaction information:
 SEND_REPORT_JOURNALS=true
 
-# Set this value to true if you want to set the location of certain things, like transactions.
-# Since this involves an external service, it's optional and disabled by default.
+# Set a Mapbox API key here (see mapbox.com) so there might be a map available at various places.
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
+# Take note: it is no longer necessary to set this value, and it will be removed in future versions.
+MAPBOX_API_KEY=
+
+#
+# Instead of the mapbox API key, just set this value to true if you want to set the location
+# of certain things, like transactions. Since this involves an external service, it's optional
+# and disabled by default.
+#
 ENABLE_EXTERNAL_MAP=false
 
-#
-# Enable or disable exchange rate conversion. This function isn't used yet by Firefly III
-#
-ENABLE_EXCHANGE_RATES=false
-
-# Set this value to true if you want Firefly III to download currency exchange rates
-# from the internet. These rates are hosted by the creator of Firefly III inside
-# an Azure Storage Container.
-# Not all currencies may be available. Rates may be wrong.
-ENABLE_EXTERNAL_RATES=false
-
 # The map will default to this location:
 MAP_DEFAULT_LAT=51.983333
 MAP_DEFAULT_LONG=5.916667
 MAP_DEFAULT_ZOOM=6
 
+# Firefly III has two options for user authentication. "eloquent" is the default,
+# and "ldap" for LDAP servers.
+# For full instructions on these settings please visit:
+# https://docs.firefly-iii.org/advanced-installation/authentication
+# If you use Docker or similar, you can set this variable from a file by appending it with _FILE
 #
-# Some objects have room for an URL, like transactions and webhooks.
-# By default, the following protocols are allowed:
-# http, https, ftp, ftps, mailto
+# If you enable 'ldap' AND you run Docker, the Docker image will contact packagist.org
+# This is necessary to download the required packages.
 #
-# To change this, set your preferred comma separated set below.
-# Be sure to include http, https and other default ones if you need to.
-#
-VALID_URL_PROTOCOLS=
+LOGIN_PROVIDER=eloquent
 
+# It's also possible to change the way users are authenticated. You could use Authelia for example.
+# Authentication via the REMOTE_USER header is supported. Change the value below to "remote_user_guard".
 #
-# Firefly III authentication settings
+# This will also allow Windows SSO.
 #
-
-#
-# Firefly III supports a few authentication methods:
-# - 'web' (default, uses built in DB)
-# - 'remote_user_guard' for Authelia etc
-# Read more about these settings in the documentation.
-# https://docs.firefly-iii.org/how-to/firefly-iii/advanced/authentication/
-#
-# LDAP is no longer supported :(
+# If you do this please read the documentation for instructions and warnings:
+# https://docs.firefly-iii.org/advanced-installation/authentication
 #
+# This function is available in Firefly III v5.3.0 and higher.
 AUTHENTICATION_GUARD=web
 
+# If the guard is changed, Firefly III uses the 'REMOTE_USER' header as per RFC 3875.
+# You can also use another header, like AUTH_USER when using Windows SSO.
+# Some systems use X-Auth headers. In that case, use HTTP_X_AUTH_USERNAME or HTTP_X_AUTH_EMAIL
+# Depending on your system, REMOTE_USER may need to be changed to HTTP_REMOTE_USER
 #
-# Remote user guard settings
+# If this header is 'unexpectedly empty', check out the documentation.
+# https://docs.firefly-iii.org/advanced-installation/authentication
 #
 AUTHENTICATION_GUARD_HEADER=REMOTE_USER
+
+#
+# Firefly III uses email addresses as user identifiers. When you're using an external authentication guard
+# that doesn't do this, Firefly III is incapable of emailing you. Messages sent to "Bill Gates" always fail.
+#
+# However, if you set this value, Firefly III will store the value from this header as the user's backup
+# email address and use it to communicate. So user "Bill Gates" could still have
+# the email address "bill@microsoft.com".
+#
+# Example value: AUTHENTICATION_GUARD_EMAIL=HTTP_X_AUTH_EMAIL
+#
 AUTHENTICATION_GUARD_EMAIL=
 
-#
-# Firefly III generates a basic keypair for your OAuth tokens.
-# If you want, you can overrule the key with your own (secure) value.
-# It's also possible to set PASSPORT_PUBLIC_KEY_FILE or PASSPORT_PRIVATE_KEY_FILE
-# if you're using Docker secrets or similar solutions for secret management
-#
-PASSPORT_PRIVATE_KEY=
-PASSPORT_PUBLIC_KEY=
 
+# It's impossible to log out users who's authentication is handled by an external system.
+# Enter a custom URL here that will force a logout (your authentication provider can tell you).
+# Setting this variable only works when AUTHENTICATION_GUARD != web
 #
-# Extra authentication settings
-#
-CUSTOM_LOGOUT_URL=
+CUSTOM_LOGOUT_URI=
+
+# LDAP connection configuration
+# OpenLDAP, FreeIPA or ActiveDirectory
+# # If you use Docker or similar, you can set this variable from a file by appending it with _FILE
+ADLDAP_CONNECTION_SCHEME=OpenLDAP
+ADLDAP_AUTO_CONNECT=true
+
+# LDAP connection settings
+# You can set the following variables from a file by appending them with _FILE:
+# ADLDAP_CONTROLLERS, ADLDAP_PORT, ADLDAP_BASEDN
+ADLDAP_CONTROLLERS=
+ADLDAP_PORT=389
+ADLDAP_TIMEOUT=5
+ADLDAP_BASEDN=""
+ADLDAP_FOLLOW_REFFERALS=false
+
+# SSL/TLS settings
+ADLDAP_USE_SSL=false
+ADLDAP_USE_TLS=false
+ADLDAP_SSL_CACERTDIR=
+ADLDAP_SSL_CACERTFILE=
+ADLDAP_SSL_CERTFILE=
+ADLDAP_SSL_KEYFILE=
+ADLDAP_SSL_CIPHER_SUITE=
+ADLDAP_SSL_REQUIRE_CERT=
+
+# You can set the following variables from a file by appending them with _FILE:
+ADLDAP_ADMIN_USERNAME=
+ADLDAP_ADMIN_PASSWORD=
+
+# You can set the following variables from a file by appending them with _FILE:
+ADLDAP_ACCOUNT_PREFIX=
+ADLDAP_ACCOUNT_SUFFIX=
+
+# LDAP authentication settings.
+ADLDAP_PASSWORD_SYNC=false
+ADLDAP_LOGIN_FALLBACK=false
+
+ADLDAP_DISCOVER_FIELD=distinguishedname
+ADLDAP_AUTH_FIELD=distinguishedname
+
+# field to sync as local username.
+# You can set the following variable from a file by appending it with _FILE:
+ADLDAP_SYNC_FIELD=userprincipalname
 
 # You can disable the X-Frame-Options header if it interferes with tools like
 # Organizr. This is at your own risk. Applications running in frames run the risk
@@ -268,41 +284,50 @@ DISABLE_CSP_HEADER=false
 TRACKER_SITE_ID=
 TRACKER_URL=
 
+# Firefly III can collect telemetry on how you use Firefly III. This is opt-in.
+# In order to allow this, change the following variable to true.
+# To read more about this feature, go to this page: https://docs.firefly-iii.org/support/telemetry
+SEND_TELEMETRY=false
+
 #
 # Firefly III supports webhooks. These are security sensitive and must be enabled manually first.
 #
 ALLOW_WEBHOOKS=false
 
-#
-# The static cron job token can be useful when you use Docker and wish to manage cron jobs.
-# 1. Set this token to any 32-character value (this is important!).
-# 2. Use this token in the cron URL instead of a user's command line token that you can find in /profile
-#
-# For more info: https://docs.firefly-iii.org/how-to/firefly-iii/advanced/cron/
-#
-# You can set this variable from a file by appending it with _FILE
-#
-STATIC_CRON_TOKEN=
-
 # You can fine tune the start-up of a Docker container by editing these environment variables.
-# Use this at your own risk. Disabling certain checks and features may result in lots of inconsistent data.
+# Use this at your own risk. Disabling certain checks and features may result in lost of inconsistent data.
 # However if you know what you're doing you can significantly speed up container start times.
 # Set each value to true to enable, or false to disable.
 
-# Set this to true to build all locales supported by Firefly III.
-# This may take quite some time (several minutes) and is generally not recommended.
-# If you wish to change or alter the list of locales, start your Docker container with
-# `docker run -v locale.gen:/etc/locale.gen -e DKR_BUILD_LOCALE=true`
-# and make sure your preferred locales are in your own locale.gen.
-DKR_BUILD_LOCALE=false
-
 # Check if the SQLite database exists. Can be skipped if you're not using SQLite.
 # Won't significantly speed up things.
 DKR_CHECK_SQLITE=true
 
+# Run database creation and migration commands. Disable this only if you're 100% sure the DB exists
+# and is up to date.
+DKR_RUN_MIGRATION=true
+
+# Run database upgrade commands. Disable this only when you're 100% sure your DB is up-to-date
+# with the latest fixes (outside of migrations!)
+DKR_RUN_UPGRADE=true
+
+# Verify database integrity. Includes all data checks and verifications.
+# Disabling this makes Firefly III assume your DB is intact.
+DKR_RUN_VERIFY=true
+
+# Run database reporting commands. When disabled, Firefly III won't go over your data to report current state.
+# Disabling this should have no impact on data integrity or safety but it won't warn you of possible issues.
+DKR_RUN_REPORT=true
+
+# Generate OAuth2 keys.
+# When disabled, Firefly III won't attempt to generate OAuth2 Passport keys. This won't be an issue, IFF (if and only if)
+# you had previously generated keys already and they're stored in your database for restoration.
+DKR_RUN_PASSPORT_INSTALL=true
+
 # Leave the following configuration vars as is.
 # Unless you like to tinker and know what you're doing.
 APP_NAME=FireflyIII
+ADLDAP_CONNECTION=default
 BROADCAST_DRIVER=log
 QUEUE_DRIVER=sync
 CACHE_PREFIX=firefly
@@ -312,27 +337,17 @@ PUSHER_SECRET=
 PUSHER_ID=
 DEMO_USERNAME=
 DEMO_PASSWORD=
-
-#
-# Disable or enable the running balance column data
-# Please disable this. It's a very experimental feature.
-#
-USE_RUNNING_BALANCE=false
-
-#
-# The v2 layout is very experimental. If it breaks you get to keep both parts.
-# Be wary of data loss.
-#
+IS_HEROKU=false
 FIREFLY_III_LAYOUT=v1
 
 #
-# Which Query Parser implementation to use for the search rngine and rules
-# 'new' is experimental, 'legacy' is the classic one
+# If you have trouble configuring your Firefly III installation, DON'T BOTHER setting this variable.
+# It won't work. It doesn't do ANYTHING. Don't believe the lies you read online. I'm not joking.
+# This configuration value WILL NOT HELP.
 #
-QUERY_PARSER_IMPLEMENTATION=legacy
-
+# This variable is ONLY used in some of the emails Firefly III sends around. Nowhere else.
+# So when configuring anything WEB related this variable doesn't do anything. Nothing
 #
-# Please make sure this URL matches the external URL of your Firefly III installation.
-# It is used to validate specific requests and to generate URLs in emails.
+# If you're stuck I understand you get desperate but look SOMEWHERE ELSE.
 #
 APP_URL=http://localhost

.env.testing

@@ -1,26 +0,0 @@
-APP_ENV=testing
-APP_DEBUG=true
-SITE_OWNER=mail@example.com
-APP_KEY=TestTestTestTestTestTestTestTest
-DEFAULT_LANGUAGE=en_US
-DEFAULT_LOCALE=equal
-TZ=Europe/Amsterdam
-LOG_CHANNEL=stdout
-APP_LOG_LEVEL=debug
-AUDIT_LOG_LEVEL=info
-AUDIT_LOG_CHANNEL=audit_stdout
-DB_CONNECTION=sqlite
-CACHE_DRIVER=array
-SESSION_DRIVER=array
-MAIL_MAILER=log
-SEND_ERROR_MESSAGE=true
-ENABLE_EXTERNAL_MAP=false
-ENABLE_EXTERNAL_RATES=true
-AUTHENTICATION_GUARD=web
-ALLOW_WEBHOOKS=true
-APP_NAME=FireflyIII
-BROADCAST_DRIVER=log
-QUEUE_DRIVER=sync
-CACHE_PREFIX=firefly
-FIREFLY_III_LAYOUT=v1
-APP_URL=http://localhost

.gitattributes

@@ -1,11 +1,8 @@
-* text=auto eol=lf
-
-*.blade.php diff=html
-*.css diff=css
-*.html diff=html
-*.md diff=markdown
-*.php diff=php
-
-/.github export-ignore
+* text=auto
+*.css linguist-vendored
+*.scss linguist-vendored
+*.js linguist-vendored
 CHANGELOG.md export-ignore
-.styleci.yml export-ignore
+/tests       export-ignore
+/phpunit.xml export-ignore
+/.ci export-ignore

.github/.mergify.yml

@@ -0,0 +1,7 @@
+pull_request_rules:
+  - name: PR on main is never approved.
+    conditions:
+      - base=main
+    actions:
+      close:
+        message: Please reopen this PR on the `develop` branch. Thank you.

.github/CODEOWNERS

@@ -1,2 +0,0 @@
-# code owners for this Firefly III related repository
-* @JC5 @SDx3

.github/ISSUE_TEMPLATE/Bug_report.md

@@ -0,0 +1,33 @@
+---
+name: Bug report
+about: Create a report to help Firefly III improve
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Bug description**
+I am running Firefly III version x.x.x, and my problem is:
+
+<!-- Replace the version and describe your problem or your issue may be closed. -->
+
+**Steps to reproduce**
+<!-- What do you need to do to trigger this bug? -->
+
+**Extra info**
+<!-- Please add extra info here, such as OS, browser, and the output from the /debug page of your Firefly III installation (click the version at the bottom). 
+
+DO NOT PUT ```BACKTICKS``` AROUND THE OUTPUT OF THE /debug PAGE
+
+-->
+
+
+**Bonus points**
+<!-- Before you submit, verify the following please: -->
+
+- I searched and nobody reported this bug before
+- I have added a stack trace from my log files <!-- (see https://bit.ly/FF3-get-debug-info) -->
+- I have added a screenshot.
+- I was able to replicate it on the demo site https://demo.firefly-iii.org/
+<!-- - I donated money (this is a joke ;)-->

.github/ISSUE_TEMPLATE/Custom.md

@@ -0,0 +1,27 @@
+---
+name: I have a question or a problem
+about: Ask away!
+
+---
+
+I am running Firefly III version x.x.x.
+
+**Description**
+<!-- (if relevant of course) -->
+
+**Extra info**
+<!-- Please add extra info here, such as OS, browser, and the output from the `/debug`-page of your Firefly III installation (click the version at the bottom). 
+
+DO NOT PUT ```BACKTICKS``` AROUND THE OUTPUT OF THE /debug PAGE
+
+--> 
+
+**Bonus points**
+
+<!-- Complete the following checklist for bonus points -->
+
+- I have read the FAQ at https://bit.ly/FF3-FAQ
+- I added a screenshot
+- I added log files <!-- (see https://bit.ly/FF3-get-debug-info) -->
+- I was able to replicate the issue on the demo site.
+<!-- - I donated money (this is a joke :wink:)-->

.github/ISSUE_TEMPLATE/Feature_request.md

@@ -0,0 +1,34 @@
+---
+name: Feature request
+about: Suggest an idea or feature for Firefly III
+title: ''
+labels: ''
+assignees: ''
+
+---
+
+**Description**
+<!--
+Please describe your feature request:
+
+- I would like Firefly III to do ABC.
+- What if you would add feature XYZ?
+- Firefly III doesn't do DEF.
+
+-->
+
+**Solution**
+<!-- Describe what your feature would add to Firefly III. -->
+
+**What are alternatives?**
+<!-- Please describe what alternatives currently exist. -->
+
+**Additional context**
+<!-- Add any other context or screenshots about the feature request here. -->
+
+**Bonus points**
+<!-- Earn bonus points by:
+
+- Make a drawing
+- Donate money (just kidding ;)
+-->

.github/ISSUE_TEMPLATE/bug.yml

@@ -1,57 +0,0 @@
-name: Bug Report
-description: Report a bug in Firefly III (or associated tools)
-body:
-  - type: checkboxes
-    attributes:
-      label: Support guidelines
-      description: Please read the support guidelines before proceeding.
-      options:
-        - label: I've read the [support guidelines](https://github.com/firefly-iii/firefly-iii/blob/main/.github/support.md)
-          required: true
-
-  - type: checkboxes
-    attributes:
-      label: I've found a bug and checked that ...
-      description: Make sure that your request fulfills all of the following requirements. If one requirement cannot be satisfied, explain in detail why.
-      options:
-        - label: ... [the documentation](https://docs.firefly-iii.org/) does not mention anything about my problem
-        - label: ... there are no open or closed issues that are related to my problem
-        - label: ... it's [definitely a Firefly III issue, not me](https://github.com/firefly-iii/firefly-iii/blob/main/.github/its_you_not_me.md)
-
-  - type: textarea
-    attributes:
-      label: Description
-      description: Please provide a brief description of the bug in 1-2 sentences.
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: Debug information
-      description: Please provide the table from the /debug page. Do not add backticks or quotes.
-      placeholder: The output from the /debug page
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: Expected behaviour
-      description: Please describe precisely what you'd expect to happen. Be specific.
-    validations:
-      required: false
-
-  - type: textarea
-    attributes:
-      label: Steps to reproduce
-      description: Please describe the steps to reproduce the bug.
-      placeholder: |
-        1. ...
-        2. ...
-        3. ...
-    validations:
-      required: false
-
-  - type: textarea
-    attributes:
-      label: Additional info
-      description: Please provide any additional information that seem useful.

.github/ISSUE_TEMPLATE/fr.yml

@@ -1,42 +0,0 @@
-name: Feature Request
-description: Request a feature or enhancement in Firefly III (or associated tools)
-body:
-  - type: checkboxes
-    attributes:
-      label: Support guidelines
-      description: Please read the support guidelines before proceeding.
-      options:
-        - label: I've read the [support guidelines](https://github.com/firefly-iii/firefly-iii/blob/main/.github/support.md)
-          required: true
-        - label: My request is not listed as [a very good idea, but unfortunately...](https://docs.firefly-iii.org/explanation/more-information/what-its-not/)
-          required: true
-        - label: I've used [the search](https://github.com/firefly-iii/firefly-iii/issues?q=is%3Aissue) and this has not been requested before.
-          required: true
-
-  - type: textarea
-    attributes:
-      label: Description
-      description: Please describe your feature request
-      placeholder: |
-        - I would like Firefly III to do (thing).
-        - What if you would add feature (feature here)?
-        - Firefly III doesn't do (thing).
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: Solution
-      description: Describe what your feature would add to Firefly III.
-    validations:
-      required: true
-
-  - type: textarea
-    attributes:
-      label: What are alternatives?
-      description: Please describe what alternatives currently exist.
-
-  - type: textarea
-    attributes:
-      label: Additional context
-      description: Add any other context or screenshots about the feature request here.

.github/code_of_conduct.md

@@ -2,10 +2,7 @@
 
 ## Our Pledge
 
-In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making
-participation in our project and our community a harassment-free experience for everyone, regardless of age, body size,
-disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race,
-religion, or sexual identity and orientation.
+In the interest of fostering an open and welcoming environment, we as contributors and maintainers pledge to making participation in our project and our community a harassment-free experience for everyone, regardless of age, body size, disability, ethnicity, gender identity and expression, level of experience, nationality, personal appearance, race, religion, or sexual identity and orientation.
 
 ## Our Standards
 
@@ -27,35 +24,23 @@ Examples of unacceptable behavior by participants include:
 
 ## Our Responsibilities
 
-Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take
-appropriate and fair corrective action in response to any instances of unacceptable behavior.
+Project maintainers are responsible for clarifying the standards of acceptable behavior and are expected to take appropriate and fair corrective action in response to any instances of unacceptable behavior.
 
-Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits,
-issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any
-contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
+Project maintainers have the right and responsibility to remove, edit, or reject comments, commits, code, wiki edits, issues, and other contributions that are not aligned to this Code of Conduct, or to ban temporarily or permanently any contributor for other behaviors that they deem inappropriate, threatening, offensive, or harmful.
 
 ## Scope
 
-This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the
-project or its community. Examples of representing a project or community include using an official project e-mail
-address, posting via an official social media account, or acting as an appointed representative at an online or offline
-event. Representation of a project may be further defined and clarified by project maintainers.
+This Code of Conduct applies both within project spaces and in public spaces when an individual is representing the project or its community. Examples of representing a project or community include using an official project e-mail address, posting via an official social media account, or acting as an appointed representative at an online or offline event. Representation of a project may be further defined and clarified by project maintainers.
 
 ## Enforcement
 
-Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at
-james@firefly-iii.org. The project team will review and investigate all complaints, and will respond in a way that it
-deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the
-reporter of an incident. Further details of specific enforcement policies may be posted separately.
+Instances of abusive, harassing, or otherwise unacceptable behavior may be reported by contacting the project team at james@firefly-iii.org. The project team will review and investigate all complaints, and will respond in a way that it deems appropriate to the circumstances. The project team is obligated to maintain confidentiality with regard to the reporter of an incident. Further details of specific enforcement policies may be posted separately.
 
-Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent
-repercussions as determined by other members of the project's leadership.
+Project maintainers who do not follow or enforce the Code of Conduct in good faith may face temporary or permanent repercussions as determined by other members of the project's leadership.
 
 ## Attribution
 
-This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available
-at [http://contributor-covenant.org/version/1/4][version]
+This Code of Conduct is adapted from the [Contributor Covenant][homepage], version 1.4, available at [http://contributor-covenant.org/version/1/4][version]
 
 [homepage]: http://contributor-covenant.org
-
 [version]: http://contributor-covenant.org/version/1/4/

.github/contributing.md

@@ -1,3 +1,3 @@
-# [Contributing guidelines](https://docs.firefly-iii.org/explanation/support/#contributing-code)
+# [Contributing guidelines](https://docs.firefly-iii.org/other-pages/contributing)
 
-[Contributing guidelines](https://docs.firefly-iii.org/explanation/support/#contributing-code)
+[Contributing guidelines](https://docs.firefly-iii.org/other-pages/contributing)

.github/dependabot.yml

@@ -1,27 +1,26 @@
 version: 2
 updates:
 
-  # Check for updates to GitHub Actions every week
-  - package-ecosystem: "github-actions"
-    directory: "/"
-    labels: []
-    schedule:
-      interval: "weekly"
-
   # composer updates
   - package-ecosystem: "composer"
     directory: "/" # Location of package manifests
     target-branch: develop
-    labels: []
-    versioning-strategy: increase
+    labels: ["bug"]
     schedule:
       interval: "weekly"
 
   # yarn / JS updates
   - package-ecosystem: "npm"
     directory: "/"
-    labels: []
     target-branch: develop
-    versioning-strategy: increase
+    labels: ["bug"]
+    schedule:
+      interval: "weekly"
+
+  # yarn / JS updates for new frontend
+  - package-ecosystem: "npm"
+    directory: "/frontend"
+    target-branch: develop
+    labels: ["bug"]
     schedule:
       interval: "weekly"

.github/funding.yml

@@ -1,6 +1,4 @@
-# Firefly III sponsor options
+# These are supported funding model platforms
 
 github: jc5
 patreon: JC5
-ko_fi: jamesc5
-liberapay: JC5

.github/its_you_not_me.md

@@ -1,20 +0,0 @@
-# It's not you, it's me
-
-Sometimes bugs reported to Firefly III are configuration and system problems on the user's side.
-
-If you run into any of the following problems, there's a good chance it's not a Firefly III issue, but a configuration
-issue.
-
-- ⚠️ Firefly III can't connect to the database when starting or the password is wrong, even though you're sure it's
-  correct.
-- ⚠️ Errors about a missing `APP_KEY` or other encryption/hash problems
-- ⚠️ You can't login due to `419` errors (page expired)
-- ⚠️ Any `500` error when starting Firefly III
-- ⚠️ Any white page when starting Firefly III
-- ⚠️ Time-out when starting Firefly III for the first time
-- ⚠️ Firefly III does not work behind your reverse proxy
-- ⚠️ You can't connect to the Data Importer due to 404's or authentication issues.
-
-If you run into an issue like this, please start a [discussion](https://github.com/firefly-iii/firefly-iii/discussions)
-or chat on [Gitter.im](https://gitter.im/firefly-iii/firefly-iii). There's a good chance it's not a bug but something we
-can fix rather quickly :+1:

.github/label-actions.yml

@@ -1,126 +0,0 @@
-# Configuration for Label Actions - https://github.com/dessant/label-actions
-
-# The `feature` label is added to issues
-fixed:
-  issues:
-    # Post a comment, `{issue-author}` is an optional placeholder
-    comment: |
-      Hi there!
-
-      This is an automatic reply. `Share and enjoy`
-
-      This issue has been marked as fixed. The bug, feature or enhancement will become a part of Firefly III or the data importer in due course. Thanks for reporting!
-
-      A new version will be released in due time. Unfortunately, [I cannot give an estimate](https://docs.firefly-iii.org/references/faq/firefly-iii/general/#when-will-you-release-version-the-next-version), but [the roadmap](https://roadmap.firefly-iii.org/) is available for your reading pleasure.
-
-      Thank you for your contributions.
-feature:
-  issues:
-    # Post a comment, `{issue-author}` is an optional placeholder
-    unlabel: feature
-    comment: |
-      Hi there!
-
-      This is an automatic reply. `Share and enjoy`
-
-      This issue has been marked as a feature request. The requested (new) feature will become a part of Firefly III or the data importer in due course.
-
-      If you come across this issue, please be aware there is NO need to reply with "+1" or "me too" or "I need this too" or whatever. Such comments are not helpful, and do not influence [the roadmap](https://roadmap.firefly-iii.org/). Your comment may be :skull: deleted. You can subscribe to this issue to get updates.
-
-      Thank you for your contributions.
-
-epic:
-  issues:
-    # Post a comment, `{issue-author}` is an optional placeholder
-    comment: |
-      Hi there!
-
-      This is an automatic reply. `Share and enjoy`
-
-      This issue has been marked as an epic. In epics, large amounts of works are collected that will be part of a major new feature. If you have more ideas that could be a part of this epic, feel free to reply.
-
-      *However*, please be aware there is NO need to reply with "+1" or "me too" or "I need this too" or whatever. Such comments are not helpful, and do not influence [the roadmap](https://roadmap.firefly-iii.org/). Your comment may be :skull: deleted.
-
-      If you are merely interested in this epic's progress, you can subscribe to this issue to get updates.
-
-      Thank you for your contributions.
-
-enhancement:
-  unlabel: enhancement
-  issues:
-    # Post a comment, `{issue-author}` is an optional placeholder
-    comment: |
-      Hi there!
-
-      This is an automatic reply. `Share and enjoy`
-
-      This issue has been marked as an enhancement. The requested enhancement to an existing feature will become a part of Firefly III or the data importer in due course.
-
-      If you come across this issue, please be aware there is NO need to reply with "+1" or "me too" or "I need this too" or whatever. Such comments are not helpful, and do not influence [the roadmap](https://roadmap.firefly-iii.org/). Your comment may be :skull: deleted. You can subscribe to this issue to get updates.
-
-      Thank you for your contributions.
-
-triage:
-  issues:
-    # Post a comment, `{issue-author}` is an optional placeholder
-    comment: |
-      Hi there!
-
-      This is an automatic reply. `Share and enjoy`
-
-      This issue has been marked as being in triage. The root cause is not known yet, or the issue needs more investigation. You can help by sharing debug information (from `/debug`) if you also have this issue or when you haven't already done so.
-
-      Thank you for your contributions.
-
-needs-moar-debug:
-  issues:
-    comment: |
-      Hi there!
-
-      This is an automatic reply. `Share and enjoy`
-
-      To learn more about this issue, please make sure you share at least:
-
-      1. The table you can find on the `/debug` page
-      2. Firefly III version
-      2. Docker, self-hosted, or hosted by a third party?
-      3. Operating system and browser
-
-      Thank you for your contributions.
-    unlabel: needs-moar-debug
-
-
-needs-moar-logs:
-  issues:
-    comment: |
-      Hi there!
-
-      This is an automatic reply. `Share and enjoy`
-
-      To learn more about this issue, please share the relevant log files from your Firefly III or data importer installation.
-
-      The relevant instructions can be found in the documentation: [How to debug Firefly III?](https://docs.firefly-iii.org/how-to/general/debug/) Once debug mode is activated per these instructions, you can repeat your action and find the logs, depending on your method of installation. All is explained on the page.
-
-      Please share the relevant log lines in your issue, either inline or as an attachment. If you feel the logs contain sensitive information, you may also send them to [james@firefly-iii.org](mailto:james@firefly-iii.org). Without these logs, it may not be possible to properly investigate this issue.
-
-      Thank you for your contributions.
-    unlabel: needs-moar-logs
-
-v2-layout-issue:
-  issues:
-    comment: |
-      Hi there!
-
-      This is an automatic reply. `Share and enjoy`
-
-      It seems your issue is about the new v2-layout that is currently in development for Firefly III.
-
-      These issues are collected in [a GitHub discussion](https://github.com/firefly-iii/firefly-iii/issues/8361).
-
-      Please note that the v2 layout is still very much in development.
-
-      Thank you for your contributions.
-    close: true
-    close-reason: completed
-    lock: false
-    unlabel: v2-layout-issue

.github/mergify.yml

@@ -1,10 +0,0 @@
----
-pull_request_rules:
-  - name: Close all on main
-    conditions:
-      - base=main
-      - -author~=^dependabot(|-preview)\[bot\]$
-    actions:
-      close:
-        message: Please do not open PR's on the `main` branch, but on the `develop`
-          branch only. Thank you!

.github/pull_request_template.md

@@ -1,25 +1,19 @@
 <!--
-Thank you for submitting new code to Firefly III, or any of the related projects. Please read the following rules carefully.
+Before you create a new PR, please consider:
 
-- Please do not submit solutions for problems that are not already reported in an issue.
-- Unfortunately, Firefly III can't be your learning experience. If you're new to all of this, please open an issue first.
-- Please do not open PRs to "discuss" possible solutions or to "get feedback" on your code. I simply don't have time for that.
-- Pull requests for the MAIN branch will be closed.
-- DO NOT include translated strings in your PR.
-- PRs (or parts thereof) that only fix issues inside code comments will not be accepted.
-
-If it feels necessary to open an issue first, please do so, before you open a PR.
-
-See also: https://docs.firefly-iii.org/explanation/support/#contributing-code
+1) Pull requests for the MAIN branch will be closed.
+2) We cannot accept pull requests to add new currencies.
+3) DO NOT include translations in your PR. Only English US sentences.
 
+Thanks.
 -->
-    
-This PR fixes issue # (if relevant).
+
+Fixes issue # (if relevant)
 
 Changes in this pull request:
 
--
--
--
+- 
+- 
+- 
 
 @JC5

.github/security.md

@@ -1,101 +1,53 @@
 # Security Policy
 
-Firefly III is an application to manage your personal finances. As such, the developer has adopted this security
-disclosure and response policy to ensure that critical issues are responsibly handled.
+Firefly III is an application to manage your personal finances. As such, the developer has adopted this security disclosure and response policy to ensure that critical issues are responsibly handled.
 
 ## Supported Versions
-
-Only the latest Firefly III release is maintained. Applicable fixes, including security fixes, will not backported to
-older release branches. Please refer to [releases.md](https://github.com/firefly-iii/firefly-iii/blob/main/releases.md)
-for details.
+Only the latest Firefly III release is maintained. Applicable fixes, including security fixes, will not backported to older release branches. Please refer to [releases.md](https://github.com/firefly-iii/firefly-iii/blob/main/releases.md) for details.
 
 ## Reporting a Vulnerability - Private Disclosure Process
+Security is of the highest importance and all security vulnerabilities or suspected security vulnerabilities should be reported to Firefly III privately, to minimize attacks against current users of Firefly III before they are fixed. Vulnerabilities will be investigated and patched on the next patch (or minor) release as soon as possible. This information could be kept entirely internal to the project.  
 
-Security is of the highest importance and all security vulnerabilities or suspected security vulnerabilities should be
-reported to Firefly III privately, to minimize attacks against current users of Firefly III before they are fixed.
-Vulnerabilities will be investigated and patched on the next patch (or minor) release as soon as possible. This
-information could be kept entirely internal to the project.
-
-If you know of a publicly disclosed security vulnerability for Firefly III, please **IMMEDIATELY** contact
-james@firefly-iii.org to inform the Firefly III developer. You can use my [GPG key](https://keybase.io/jc5) for extra
-security.
+If you know of a publicly disclosed security vulnerability for Firefly III, please **IMMEDIATELY** contact james@firefly-iii.org to inform the Firefly III developer. You can use my [GPG key](https://keybase.io/jc5) for extra security.
 
 **IMPORTANT: Do not file public issues on GitHub for security vulnerabilities**
 
-To report a vulnerability or a security-related issue, please email the private address james@firefly-iii.org with the
-details of the vulnerability. The email will be received by the developer of Firefly III. Emails will be addressed
-within 3 business days, including a detailed plan to investigate the issue and any potential workarounds to perform in
-the meantime. Do not report non-security-impacting bugs through this channel.
-Use [GitHub issues](https://github.com/firefly-iii/firefly-iii/issues/new/choose) instead.
+To report a vulnerability or a security-related issue, please email the private address james@firefly-iii.org with the details of the vulnerability. The email will be received by the developer of Firefly III. Emails will be addressed within 3 business days, including a detailed plan to investigate the issue and any potential workarounds to perform in the meantime. Do not report non-security-impacting bugs through this channel. Use [GitHub issues](https://github.com/firefly-iii/firefly-iii/issues/new/choose) instead.
 
 ### Proposed Email Content
-
 Provide a descriptive subject line and in the body of the email include the following information:
-
 * Basic identity information, such as your name and your affiliation or company.
-* Detailed steps to reproduce the vulnerability  (POC scripts, screenshots, and compressed packet captures are all
-  helpful to us).
-* Description of the effects of the vulnerability on Firefly III and the related hardware and software configurations,
-  so that the developer can reproduce it.
+* Detailed steps to reproduce the vulnerability  (POC scripts, screenshots, and compressed packet captures are all helpful to us).
+* Description of the effects of the vulnerability on Firefly III and the related hardware and software configurations, so that the developer can reproduce it.
 * How the vulnerability affects Firefly III usage and an estimation of the attack surface, if there is one.
 * List other projects or dependencies that were used in conjunction with Firefly III to produce the vulnerability.
 
 ## When to report a vulnerability
-
 * When you think Firefly III has a potential security vulnerability.
 * When you suspect a potential vulnerability but you are unsure that it impacts Firefly III.
-* When you know of or suspect a potential vulnerability on another project that is used by Firefly III. For example
-  Firefly III has a dependency on Docker, MySQL, etc.
-
+* When you know of or suspect a potential vulnerability on another project that is used by Firefly III. For example Firefly III has a dependency on Docker, MySQL, etc.
+  
 ## Patch, Release, and Disclosure
-
 The Firefly III developer will respond to vulnerability reports as follows:
-
-1. The developer will investigate the vulnerability and determine its effects and criticality.
-2. If the issue is not deemed to be a vulnerability, the developer will follow up with a detailed reason for rejection.
-3. The developer will initiate a conversation with the reporter within 3 business days.
-4. If a vulnerability is acknowledged and the timeline for a fix is determined, the developer will work on a plan to
-   communicate with the appropriate community, including identifying mitigating steps that affected users can take to
-   protect themselves until the fix is rolled out.
-5. The developer will also create a [CVSS](https://www.first.org/cvss/specification-document) using
-   the [CVSS Calculator](https://www.first.org/cvss/calculator/3.0). The developer makes the final call on the
-   calculated CVSS; it is better to move quickly than making the CVSS perfect. Issues may also be reported
-   to [Mitre](https://cve.mitre.org/) using
-   this [scoring calculator](https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator). The CVE will initially be set to
-   private.
-6. The developer will work on fixing the vulnerability and perform internal testing before preparing to roll out the
-   fix.
-7. A public disclosure date is negotiated by the Firefly III developer and the bug submitter. We prefer to fully
-   disclose the bug as soon as possible once a user mitigation or patch is available. It is reasonable to delay
-   disclosure when the bug or the fix is not yet fully understood, the solution is not well-tested, or for distributor
-   coordination. The timeframe for disclosure is from immediate (especially if it’s already publicly known) to a few
-   weeks. For a critical vulnerability with a straightforward mitigation, we expect report date to public disclosure
-   date to be on the order of 14 business days. The Firefly III developer holds the final say when setting a public
-   disclosure date.
-8. Once the fix is confirmed, the developer will patch the vulnerability in the next patch or minor release. Upon
-   release of the patched version of Firefly III, we will follow the **Public Disclosure Process**.
+ 
+1.  The developer will investigate the vulnerability and determine its effects and criticality.
+2.  If the issue is not deemed to be a vulnerability, the developer will follow up with a detailed reason for rejection.
+3.  The developer will initiate a conversation with the reporter within 3 business days.
+4.  If a vulnerability is acknowledged and the timeline for a fix is determined, the developer will work on a plan to communicate with the appropriate community, including identifying mitigating steps that affected users can take to protect themselves until the fix is rolled out.
+5.  The developer will also create a [CVSS](https://www.first.org/cvss/specification-document) using the [CVSS Calculator](https://www.first.org/cvss/calculator/3.0). The developer makes the final call on the calculated CVSS; it is better to move quickly than making the CVSS perfect. Issues may also be reported to [Mitre](https://cve.mitre.org/) using this [scoring calculator](https://nvd.nist.gov/vuln-metrics/cvss/v3-calculator). The CVE will initially be set to private.
+6.  The developer will work on fixing the vulnerability and perform internal testing before preparing to roll out the fix.
+7. A public disclosure date is negotiated by the Firefly III developer and the bug submitter. We prefer to fully disclose the bug as soon as possible once a user mitigation or patch is available. It is reasonable to delay disclosure when the bug or the fix is not yet fully understood, the solution is not well-tested, or for distributor coordination. The timeframe for disclosure is from immediate (especially if it’s already publicly known) to a few weeks. For a critical vulnerability with a straightforward mitigation, we expect report date to public disclosure date to be on the order of 14 business days. The Firefly III developer holds the final say when setting a public disclosure date.
+9.  Once the fix is confirmed, the developer will patch the vulnerability in the next patch or minor release. Upon release of the patched version of Firefly III, we will follow the **Public Disclosure Process**.
 
 ### Public Disclosure Process
+The developer publishes a public [advisory](https://github.com/firefly-iii/firefly-iii/security/advisories) to the Firefly III community via GitHub. In most cases, additional communication via Twitter, reddit and other channels will assist in educating Firefly III users and rolling out the patched release to affected users. 
 
-The developer publishes a public [advisory](https://github.com/firefly-iii/firefly-iii/security/advisories) to the
-Firefly III community via GitHub. In most cases, additional communication via Mastodon, Gitter and other channels will
-assist in educating Firefly III users and rolling out the patched release to affected users.
-
-The developer will also publish any mitigating steps users can take until the fix can be applied to their Firefly III
-instances.
-
+The develop will also publish any mitigating steps users can take until the fix can be applied to their Firefly III instances.
+ 
 ## Confidentiality, integrity and availability
+We consider vulnerabilities leading to the compromise of data confidentiality, elevation of privilege, or integrity to be our highest priority concerns. Availability, in particular in areas relating to DoS and resource exhaustion, is also a serious security concern. The Firefly III developer takes all vulnerabilities, potential vulnerabilities, and suspected vulnerabilities seriously and will investigate them in an urgent and expeditious manner.
 
-We consider vulnerabilities leading to the compromise of data confidentiality, elevation of privilege, or integrity to
-be our highest priority concerns. Availability, in particular in areas relating to DoS and resource exhaustion, is also
-a serious security concern. The Firefly III developer takes all vulnerabilities, potential vulnerabilities, and
-suspected vulnerabilities seriously and will investigate them in an urgent and expeditious manner.
-
-Note that we do not currently consider the default settings for Firefly III to be secure-by-default. It is necessary for
-operators to explicitly configure settings, role based access control, and other resource related features in Firefly
-III to provide a hardened Firefly III environment. We will not act on any security disclosure that relates to a lack of
-safe defaults. Over time, we will work towards improved safe-by-default configuration, taking into account backwards
-compatibility.
+Note that we do not currently consider the default settings for Firefly III to be secure-by-default. It is necessary for operators to explicitly configure settings, role based access control, and other resource related features in Firefly III to provide a hardened Firefly III environment. We will not act on any security disclosure that relates to a lack of safe defaults. Over time, we will work towards improved safe-by-default configuration, taking into account backwards compatibility.
 
 ## Credits
 

.github/stale.yml

@@ -0,0 +1,57 @@
+# Configuration for probot-stale - https://github.com/probot/stale
+
+# Number of days of inactivity before an Issue or Pull Request becomes stale
+daysUntilStale: 7
+
+# Number of days of inactivity before a stale Issue or Pull Request is closed.
+# Set to false to disable. If disabled, issues still need to be closed manually, but will remain marked as stale.
+daysUntilClose: 7
+
+# Issues or Pull Requests with these labels will never be considered stale. Set to `[]` to disable
+# - "[Status] Maybe Later"
+exemptLabels:
+  - enhancement
+  - feature
+  - bug
+  - announcement
+
+# Set to true to ignore issues in a project (defaults to false)
+exemptProjects: false
+
+# Set to true to ignore issues in a milestone (defaults to false)
+exemptMilestones: false
+
+# Label to use when marking as stale
+staleLabel: stale
+
+# Comment to post when marking as stale. Set to `false` to disable
+markComment: >
+  This issue has been automatically marked as stale because it has not had
+  recent activity. It will be closed if no further activity occurs. Thank you
+  for your contributions.
+
+# Comment to post when removing the stale label.
+# unmarkComment: >
+#   Your comment here.
+
+# Comment to post when closing a stale Issue or Pull Request.
+# closeComment: >
+#   Your comment here.
+
+# Limit the number of actions per hour, from 1-30. Default is 30
+limitPerRun: 30
+
+# Limit to only `issues` or `pulls`
+# only: issues
+
+# Optionally, specify configuration settings that are specific to just 'issues' or 'pulls':
+# pulls:
+#   daysUntilStale: 30
+#   markComment: >
+#     This pull request has been automatically marked as stale because it has not had
+#     recent activity. It will be closed if no further activity occurs. Thank you
+#     for your contributions.
+
+# issues:
+#   exemptLabels:
+#     - confirmed

.github/support.md

@@ -1,34 +1,12 @@
-# Support [![Average time to resolve an issue](http://isitmaintained.com/badge/resolution/firefly-iii/firefly-iii.svg)](http://isitmaintained.com/project/firefly-iii/firefly-iii "Average time to resolve an issue")
+# Welcome to Firefly III on Github!
 
 :+1::tada: Thank you for taking the time to contribute something to Firefly III!
 
-## Reporting an issue
+## Bugs
 
-First of all: thank you for reporting a bug instead of ditching the tool altogether. Bugs have a lot of priority!
+First of all: thank you for reporting a bug instead of ditching the tool altogether. If you find a bug, please take the time and see if the [demo site](https://demo.firefly-iii.org/) is also suffering from this bug. Include as many log files and details as you think are necessary. Bugs have a lot of priority! 
 
-1. Open bugs will have open issues, so search for one first.
-2. If your feature request is already there, vote on it with :+1: or :-1: reactions.
-3. Do NOT hijack old issues with the bug you found, open your own issue.
-4. If relevant, take the time and see if the [demo site](https://demo.firefly-iii.org/) is also suffering from your
-   issue.
-5. If relevant, read the [documentation](https://docs.firefly-iii.org/).
+## Installation problems
 
-Please follow these guidelines when opening new issues:
-
-## Writing good issues
-
-- File a single issue for a single problem or feature requests. Feel free to open multiple issues.
-- Collect as many details as you can.
-- Be clear and specific, and state what you're not sure about.
-
-Only then [create a new issue](https://github.com/firefly-iii/firefly-iii/issues/new/choose)!
-
-## Issue closure and abandonment policy
-
-- Issues can be converted into discussions if it's not a bug or feature request.
-- Features that won't be implemented will be labelled "
-  wontfix". [This isn't personal](https://docs.firefly-iii.org/explanation/more-information/what-its-not/).
-- Issues can be closed if they're duplicates of other issues.
-- Issues can be closed if the answer is in the FAQ.
-- Issues will be closed automatically after 14 days.
-- Issues will be locked automatically after 90 days.
+Please take the time to read the [documentation](https://docs.firefly-iii.org/) and make sure you search through closed issues for the problems other people
+ have had. Your problem may be among them! If not, open an issue and I will help where I can.

.github/workflows/cleanup.yml

@@ -1,106 +0,0 @@
-# This workflow prunes old workflow runs for an entire repository.
-
-name: "Chore - Prune old builds"
-
-permissions:
-  actions: write
-
-on:
-  schedule:
-    - cron: '0 1 * * *'
-  workflow_dispatch:
-jobs:
-  prune:
-    runs-on: ubuntu-latest
-    timeout-minutes: 10
-    steps:
-      - name: Prune cancelled/skipped runs
-        uses: actions/github-script@v7
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const cancelled = await github.rest.actions.listWorkflowRunsForRepo({
-              owner: context.repo.owner,
-              per_page: 100,
-              repo: context.repo.repo,
-              status: 'cancelled',
-            });
-
-            const skipped = await github.rest.actions.listWorkflowRunsForRepo({
-              owner: context.repo.owner,
-              per_page: 100,
-              repo: context.repo.repo,
-              status: 'skipped',
-            });
-
-            for (const response of [cancelled, skipped]) {
-              for (const run of response.data.workflow_runs) {
-                console.log(`Run id ${run.id} of '${run.name}' is a cancelled/skipped run. Deleting...`);
-                await github.rest.actions.deleteWorkflowRun({
-                  owner: context.repo.owner,
-                  repo: context.repo.repo,
-                  run_id: run.id
-                });
-              }
-            }
-
-      - name: Prune runs older than 3 days
-        uses: actions/github-script@v7
-        with:
-          github-token: ${{ secrets.GITHUB_TOKEN }}
-          script: |
-            const days_to_expiration = 3;
-            const ms_in_day = 86400000;
-            const now = Date.now();
-            const pages = 5;
-
-            // we don't want to prune old runs from test.yml
-            // because we track the duration of runs over time
-
-            const workflows = [
-              'cleanup.yml',
-              'close-duplicates.yml',
-              'closed-issues.yml',
-              'debug-info-actions.yml',
-              'depsreview.yml',
-              'label-actions.yml',
-              'lock.yml',
-              'release.yml',
-              'sonarcloud.yml',
-              'stale.yml'
-            ]
-
-            let runs_to_delete = [];
-
-            for (const workflow of workflows) {
-              for (let page = 0; page < pages; page += 1) {
-                let response = await github.rest.actions.listWorkflowRuns({
-                  owner: context.repo.owner,
-                  page: page,
-                  per_page: 100,
-                  repo: context.repo.repo,
-                  workflow_id: workflow
-                });
-
-                if (response.data.workflow_runs.length > 0) {
-                  for (const run of response.data.workflow_runs) {
-                    if (now - Date.parse(run.created_at) > ms_in_day * days_to_expiration) {
-                      runs_to_delete.push([run.id, run.name]);
-                    }
-                  }
-                }
-              }
-            }
-
-            for (const run of runs_to_delete) {
-              console.log(`Run id ${run[0]} of '${run[1]}' is older than ${days_to_expiration} days. Deleting...`);
-              try {
-                await github.rest.actions.deleteWorkflowRun({
-                  owner: context.repo.owner,
-                  repo: context.repo.repo,
-                  run_id: run[0]
-                });
-              } catch (error) {
-                // ignore errors
-              }
-            }

.github/workflows/close-duplicates.yml

@@ -1,39 +0,0 @@
-name: "Issues - Command to close duplicate issues"
-
-# the workflow to execute on is comments that are newly created
-on:
-  issue_comment:
-    types: [ created ]
-
-permissions:
-  issues: write
-  checks: read
-
-jobs:
-  close_duplicates:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: github/command@v1.3.0
-        id: command
-        with:
-          allowed_contexts: "issue"
-          command: ".duplicate"
-      - name: reply
-        if: ${{ steps.command.outputs.continue == 'true' }}
-        run: |
-
-          ISSUE_TITLE=$(gh issue view ${{ steps.command.outputs.params }} --json title --jq '.title')
-
-          gh issue comment "$NUMBER" --body "Hi there!
-
-          This is an automatic reply. \`Share and enjoy\`.
-
-          Your issue is probably a duplicate of issue <span>#</span>${{ steps.command.outputs.params }}: [$ISSUE_TITLE](https://github.com/firefly-iii/firefly-iii/issues/${{ steps.command.outputs.params }}). Please refer to issue #${{ steps.command.outputs.params }} for support.
-
-          You can close this issue now. If you believe this is not in fact a duplicate, please reply and let us know. Otherwise, this issue will be automatically closed in a few days time.
-
-          Thank you for your contributions."
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          GH_REPO: ${{ github.repository }}
-          NUMBER: ${{ github.event.issue.number }}

.github/workflows/closed-issues.yml

@@ -1,25 +0,0 @@
----
-name: Issues - Reply to closed issue
-on:
-  issues:
-    types:
-      - closed
-jobs:
-  command_and_close:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: aws-actions/closed-issue-message@v1
-        with:
-          message: |
-            Hi there! This is an automatic reply. `Share and enjoy`
-
-            This issue is now 🔒 closed. Please be aware that closed issues are not monitored by the developer of Firefly III.
-
-            - If the original bug is not actually fixed, please open [a new issue](https://github.com/firefly-iii/firefly-iii/issues/new/choose). Refer to this issue for clarity.
-            - Follow-up questions must be posted in a new [discussion](https://github.com/firefly-iii/firefly-iii/discussions/)
-            - Further replies to this issue may get no response.
-
-            If there is more to discuss, please open [a new issue](https://github.com/firefly-iii/firefly-iii/issues/new/choose) or [discussion](https://github.com/firefly-iii/firefly-iii/discussions/).
-
-            Thank you for your contributions.
-          repo-token: ${{ secrets.GITHUB_TOKEN }}

.github/workflows/debug-info-actions.yml

@@ -1,32 +0,0 @@
-name: 'Issues - Respond to hidden commands'
-
-# the workflow to execute on is comments that are newly created
-on:
-  issues:
-    types: [ opened, edited ]
-  issue_comment:
-    types: [ created ]
-
-# permissions needed for reacting to IssueOps commands on issues and PRs
-permissions:
-  contents: read
-  pull-requests: write
-  issues: write
-  checks: read
-
-jobs:
-  respond:
-    runs-on: ubuntu-latest
-    steps:
-      - run: |
-          ISSUE_BODY=$(gh issue view $NUMBER --json body)
-          if [[ $ISSUE_BODY == *".eOxNZAmyGz6CXMyf"* ]]; then
-            gh issue comment "$NUMBER" --body "$V2_ISSUE_REPLY_BODY"
-            gh issue close "$NUMBER" --reason completed
-          fi
-        env:
-          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
-          GH_REPO: ${{ github.repository }}
-          NUMBER: ${{ github.event.issue.number }}
-          V2_ISSUE_REPLY_BODY: ${{ secrets.V2_ISSUE_REPLY_BODY }}
-          LABELS: v2-layout-issue

.github/workflows/depsreview.yml

@@ -1,16 +0,0 @@
-name: 'Code - Dependency review'
-on: [ pull_request ]
-
-permissions:
-  contents: read
-
-jobs:
-  dependency-review:
-    runs-on: ubuntu-latest
-    steps:
-      - name: 'Checkout repository'
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-      - name: 'Dependency review'
-        uses: actions/dependency-review-action@v4

.github/workflows/label-actions.yml

@@ -1,21 +0,0 @@
-name: 'Issues - Reply to specific labels'
-
-on:
-  issues:
-    types: [ labeled, unlabeled ]
-  pull_request_target:
-    types: [ labeled, unlabeled ]
-  discussion:
-    types: [ labeled, unlabeled ]
-
-permissions:
-  contents: read
-  issues: write
-  pull-requests: write
-  discussions: write
-
-jobs:
-  action:
-    runs-on: ubuntu-latest
-    steps:
-      - uses: dessant/label-actions@v4

.github/workflows/laravel.yml

@@ -0,0 +1,146 @@
+name: Firefly III
+
+on:
+  push:
+    branches-ignore:
+      - '**'
+
+jobs:
+  prepare:
+
+    runs-on: ubuntu-latest
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Copy .env
+        run: test -f .env || cp .ci/.env.ci .env
+      - name: Prepare dependencies
+        run: |
+          set -euxo pipefail
+          export PATH=$PATH:$HOME/.composer/vendor/bin/
+          composer global require hirak/prestissimo --no-plugins --no-scripts
+          composer install --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist --no-suggest
+
+          touch ./storage/database/database.sqlite
+      - name: Prepare Firefly III
+        run: |
+          chmod -R 777 storage bootstrap/cache
+          php artisan migrate --seed
+          php artisan firefly-iii:upgrade-database
+      - name: Upload database
+        uses: actions/upload-artifact@v2
+        with:
+          name: database
+          path: storage/database/database.sqlite
+      - name: Upload cache
+        uses: actions/upload-artifact@v2
+        with:
+          name: cache
+          path: bootstrap/cache/
+      - name: Upload composer cache
+        uses: actions/upload-artifact@v2
+        with:
+          name: composer
+          path: ~/.composer
+
+  laravel-tests:
+
+    runs-on: ubuntu-latest
+
+    needs:
+      - prepare
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Copy .env
+        run: test -f .env || cp .ci/.env.ci .env
+      - name: Download database
+        uses: actions/download-artifact@v2
+        with:
+          name: database
+          path: storage/database/database.sqlite
+      - name: Download cache
+        uses: actions/download-artifact@v2
+        with:
+          name: cache
+          path: bootstrap/cache/
+      - name: Download vendor
+        uses: actions/download-artifact@v2
+        with:
+          name: composer
+          path: ~/.composer
+      - name: Install composer
+        run: composer install --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist --no-suggest
+
+      - name: PHPUnit tests
+        uses: php-actions/phpunit@v1
+        with:
+          config: phpunit.xml
+          memory: 512M
+
+  coding-standards:
+
+    runs-on: ubuntu-latest
+
+    needs:
+      - prepare
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Copy .env
+        run: test -f .env || cp .ci/.env.ci .env
+      - name: Download database
+        uses: actions/download-artifact@v2
+        with:
+          name: database
+          path: storage/database/database.sqlite
+      - name: Download cache
+        uses: actions/download-artifact@v2
+        with:
+          name: cache
+          path: bootstrap/cache/
+      - name: Download vendor
+        uses: actions/download-artifact@v2
+        with:
+          name: composer
+          path: ~/.composer
+      - name: install depenencies
+        run: |
+          composer global require nette/coding-standard
+          composer install --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist --no-suggest
+
+      - name: Execute code standard
+        run: /home/runner/.composer/vendor/bin/ecs check app tests --config ./.ci/firefly-iii-standard.yml
+
+  phpstan:
+
+    runs-on: ubuntu-latest
+
+    needs:
+      - prepare
+
+    steps:
+      - uses: actions/checkout@v2
+      - name: Copy .env
+        run: test -f .env || cp .ci/.env.ci .env
+      - name: Download database
+        uses: actions/download-artifact@v2
+        with:
+          name: database
+          path: storage/database/database.sqlite
+      - name: Download cache
+        uses: actions/download-artifact@v2
+        with:
+          name: cache
+          path: bootstrap/cache/
+      - name: Download vendor
+        uses: actions/download-artifact@v2
+        with:
+          name: composer
+          path: ~/.composer
+      - name: Install depenencies
+        run: |
+          composer install --no-ansi --no-interaction --no-scripts --no-progress --prefer-dist --no-suggest
+
+      - name: Execute PHPStan
+        run: vendor/bin/phpstan analyse -c .ci/phpstan.neon

.github/workflows/lock.yml

@@ -1,29 +1,19 @@
-name: 'Issues - Lock old issues'
+name: Lock old issues
 
 on:
   workflow_dispatch:
   schedule:
-    - cron: '0 2 * * *'
-
-concurrency:
-  group: lock-threads
-
-permissions:
-  issues: write
-  pull-requests: write
-  discussions: write
+    - cron: '0 0 * * *'
 
 jobs:
   lock:
-    permissions:
-      issues: write
-      pull-requests: write
-      discussions: write
     runs-on: ubuntu-latest
     steps:
-      - uses: dessant/lock-threads@v5
+      - uses: dessant/lock-threads@v2
         with:
-          issue-inactive-days: 21
-          pr-inactive-days: 21
-          discussion-inactive-days: 21
-          log-output: true
+          github-token: ${{ github.token }}
+          issue-lock-inactive-days: '90'
+          issue-lock-comment: >
+            This issue has been automatically locked since there
+            has not been any recent activity after it was closed.
+            Please open a new issue for related bugs.

.github/workflows/release.yml

@@ -1,393 +0,0 @@
-name: 'Code - Create new release'
-
-on:
-  workflow_dispatch:
-    inputs:
-      version:
-        description: 'Release "v1.2.3" or "develop" or "branch-abc"'
-        required: true
-        default: 'develop'
-      phpversion:
-        description: 'PHP version'
-        required: true
-        default: '8.4'
-  schedule:
-    - cron: '0 3 * * MON'
-
-jobs:
-  build:
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-        with:
-          fetch-depth: 0
-      - name: Switch branch
-        run: |
-          if [[ "develop" == "$version" ]]; then
-            git checkout --track origin/develop
-            git pull
-          elif [[ "$version" == branch* ]]; then
-            PULLBRANCH=${version:7}
-            echo "The branch is '$PULLBRANCH' ($version)"
-            git checkout --track origin/$PULLBRANCH
-            git pull
-          else
-            git config user.name github-actions
-            git config user.email 41898282+github-actions[bot]@users.noreply.github.com
-            git checkout --track origin/develop
-            git pull
-            git checkout main
-            git merge develop
-          fi
-        env:
-          version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }}
-      - name: Setup PHP
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: ${{ github.event.inputs.phpversion }}
-          extensions: mbstring, intl, zip, bcmath
-      - name: crowdin action
-        uses: crowdin/github-action@v2
-        with:
-          upload_sources: true
-          download_translations: true
-          push_translations: false
-          push_sources: false
-        env:
-          GITHUB_TOKEN: ${{ github.token }}
-          CROWDIN_PROJECT_NR: ${{ secrets.CROWDIN_PROJECT_NR }}
-          CROWDIN_TOKEN: ${{ secrets.CROWDIN_TOKEN }}
-      - name: Cleanup changelog
-        id: cleanup-changelog
-        uses: JC5/firefly-iii-dev@main
-        with:
-          action: 'ff3:changelog'
-          output: ''
-        env:
-          FIREFLY_III_ROOT: /github/workspace
-          GH_TOKEN: ${{ secrets.CHANGELOG_TOKEN }}
-      - name: "Create THANKS.md"
-        id: thank-you
-        uses: JC5/firefly-iii-dev@main
-        with:
-          action: 'ff3:thank-you'
-          output: ''
-        env:
-          FIREFLY_III_ROOT: /github/workspace
-          GH_TOKEN: ''
-      - name: Extract changelog
-        id: extract-changelog
-        uses: JC5/firefly-iii-dev@main
-        with:
-          action: 'ff3:extract-changelog'
-          output: 'output'
-        env:
-          FIREFLY_III_ROOT: /github/workspace
-          GH_TOKEN: ""
-      - name: Replace version
-        id: replace-version
-        uses: JC5/firefly-iii-dev@main
-        with:
-          action: 'ff3:version'
-          output: ''
-        env:
-          FIREFLY_III_ROOT: /github/workspace
-          GH_TOKEN: ""
-          FF_III_VERSION: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }}
-      - name: Generate JSON v1
-        id: json-v1
-        uses: JC5/firefly-iii-dev@main
-        with:
-          action: 'ff3:json-translations v1'
-          output: ''
-        env:
-          FIREFLY_III_ROOT: /github/workspace
-          GH_TOKEN: ''
-      - name: Generate JSON v2
-        id: json-v2
-        uses: JC5/firefly-iii-dev@main
-        with:
-          action: 'ff3:json-translations v2'
-          output: ''
-        env:
-          FIREFLY_III_ROOT: /github/workspace
-          GH_TOKEN: ''
-      - name: Code cleanup
-        id: code-cleanup
-        uses: JC5/firefly-iii-dev@main
-        with:
-          action: 'ff3:code'
-          output: ''
-        env:
-          FIREFLY_III_ROOT: /github/workspace
-          GH_TOKEN: ''
-      - name: Build JS
-        run: |
-          npm install
-          npm run prod  --workspace=v1
-          npm run build --workspace=v2
-          npm update
-      - name: Run CI
-        run: |
-          rm -rf vendor composer.lock
-          composer update --no-dev --no-scripts --no-plugins -q
-          sudo chown -R runner:docker resources/lang
-          .ci/phpcs.sh || true
-      - name: Import GPG key
-        uses: crazy-max/ghaction-import-gpg@v6
-        with:
-          gpg_private_key: ${{ secrets.GPG_PRIVATE_KEY }}
-          passphrase: ${{ secrets.PASSPHRASE }}
-      - name: Release
-        run: |
-          # do some configuration
-          sudo timedatectl set-timezone Europe/Amsterdam
-          git config user.name github-actions
-          git config user.email 41898282+github-actions[bot]@users.noreply.github.com
-          git config advice.addIgnoredFile false
-
-          # set some variables
-          releaseName=$version
-          originalName=$version
-          zipName=FireflyIII-$version.zip
-          tarName=FireflyIII-$version.tar.gz
-
-          # update composer (again)
-          composer update --no-dev --no-scripts --no-plugins
-          composer dump-autoload
-
-          # if this is a develop build, slightly different variable names.
-          if [[ "develop" == "$version" ]]; then
-            #[[ -z $(git status --untracked-files=normal --porcelain) ]] && echo "this branch is clean, no need to push..." && exit 0;
-            releaseName=$version-$(date +'%Y%m%d')
-            originalName=$releaseName
-            zipName=FireflyIII-develop.zip
-            tarName=FireflyIII-develop.tar.gz
-          fi
-
-          # if this is a branch build, also slightly different variable names.
-          if [[ "$version" == branch* ]]; then
-            #[[ -z $(git status --untracked-files=normal --porcelain) ]] && echo "this branch is clean, no need to push..." && exit 0;
-            # branch builds overrule develop
-            releaseName=$version-$(date +'%Y%m%d')
-            originalName=$releaseName
-            zipName=FireflyIII-$version.zip
-            tarName=FireflyIII-$version.tar.gz
-          fi
-
-          # in both cases, if the release or tag already exists, add ".1" until it no longer exists.
-          tagFound=true
-          tagCount=1
-          while [ "$tagFound" = true ]
-          do
-            if [ $(git tag -l "$releaseName") ]; then
-              echo "Tag $releaseName exists already."
-              releaseName="$originalName"."$tagCount"
-              echo "Tag for release is now $releaseName"
-              tagCount=$((tagCount+1))
-            else
-             echo "Tag $releaseName does not exist, can continue"
-             tagFound=false
-            fi
-          done
-          echo "Will use tag and release name $releaseName."
-
-          # add all content, except output.txt (this contains the changelog and/or the download instructions)
-          echo 'Add all and reset output.txt'
-          git add -A
-          if test -f "output.txt"; then
-            git reset output.txt
-          fi
-          git commit -m "Auto commit for release '$version' on $(date +'%Y-%m-%d')" || true
-          git push
-
-          # zip and tar everything
-          echo 'Zip and tar...'
-          zip -rq $zipName . -x "*.git*" "*.ci*" "*.github*" "*node_modules*" "*output.txt*"
-          touch $tarName
-          tar --exclude=$tarName --exclude=$zipName --exclude='./.git' --exclude='./.ci' --exclude='./.github' --exclude='./node_modules' --exclude='./output.txt' -czf $tarName .
-
-          # add sha256 sum
-          echo 'Sha sum ...'
-          sha256sum -b $zipName > $zipName.sha256
-          sha256sum -b $tarName > $tarName.sha256
-
-          # add signatures:
-          gpg --armor --detach-sign $zipName
-          gpg --armor --detach-sign $tarName
-
-          # describe the development release.
-          if [[ "develop" == "$version" ]]; then
-            echo 'Develop release.'
-            rm -f output.txt
-            touch output.txt
-            sudo chown -R runner:docker output.txt
-            echo "Weekly development release of Firefly III with the latest fixes, translations and features. Docker users can find this release under the \`develop\` tag." >> output.txt
-            echo "" >> output.txt
-            echo "This release was created on **$(date +'%Y-%m-%d')** and may contain unexpected bugs. Data loss is rare but is not impossible. The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt
-            echo "" >> output.txt
-            echo "* Please read the installation instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/installation/docker/), [Portainer](https://docs.firefly-iii.org/how-to/firefly-iii/installation/portainer/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/installation/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/installation/self-managed/)" >> output.txt
-            echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt
-            echo "" >> output.txt
-            echo ":warning: Please be careful with this pre-release, as it may not work as expected." >> output.txt
-          fi
-          # describe a branch release
-          if [[ "$version" == branch* ]]; then
-            echo 'Branch release.'
-            rm -f output.txt
-            touch output.txt
-            sudo chown -R runner:docker output.txt
-            echo "Irregular BRANCH release of Firefly III. This release contains specific features or changes. Docker users can find this release under the \`$version\` tag." >> output.txt
-            echo "" >> output.txt
-            echo "This release was created on **$(date +'%Y-%m-%d')** and may contain unexpected bugs. Data loss is rare but is not impossible. The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt
-            echo "" >> output.txt
-            echo "* Please read the installation instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/installation/docker/), [Portainer](https://docs.firefly-iii.org/how-to/firefly-iii/installation/portainer/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/installation/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/installation/self-managed/)" >> output.txt
-            echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt
-            echo "" >> output.txt
-            echo ":warning: Please be careful with this branch pre-release, as it may not work as expected." >> output.txt
-          fi
-          # describe the main release
-          if [[ "develop" != "$version" ]] && [[ "$version" != branch* ]] && [[ "$version" != *alpha* ]] && [[ "$version" != *beta* ]]; then
-            echo 'Main release.'
-            sudo chown -R runner:docker output.txt
-            echo '' >> output.txt
-            echo '### Instructions' >> output.txt
-            echo '' >> output.txt
-            echo "* Installation instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/installation/docker/), [Portainer](https://docs.firefly-iii.org/how-to/firefly-iii/installation/portainer/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/installation/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/installation/self-managed/)" >> output.txt
-            echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt
-            echo "* The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt
-
-          fi
-
-          # describe alpha release
-          if [[ "$version" == *alpha* ]]; then
-            echo 'ALPHA release.'
-            rm -f output.txt
-            touch output.txt
-            sudo chown -R runner:docker output.txt
-            echo "Very early ALPHA release of Firefly III. This release contains specific features or changes. Docker users can find this release under the \`$version\` tag." >> output.txt
-            echo '' >> output.txt
-            echo "This release was created on **$(date +'%Y-%m-%d')** and may contain unexpected bugs. Data loss is rare but is not impossible. The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt
-            echo '' >> output.txt
-            echo '### Instructions' >> output.txt
-            echo '' >> output.txt
-            echo "* Installation instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/installation/docker/), [Portainer](https://docs.firefly-iii.org/how-to/firefly-iii/installation/portainer/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/installation/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/installation/self-managed/)" >> output.txt
-            echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt
-            echo "* The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt
-
-          fi
-
-          # describe beta release
-          if [[ "$version" == *beta* ]]; then
-            echo 'BETA release.'
-            rm -f output.txt
-            touch output.txt
-            sudo chown -R runner:docker output.txt
-            echo "Very early BETA release of Firefly III. This release contains specific features or changes. Docker users can find this release under the \`$version\` tag." >> output.txt
-            echo '' >> output.txt
-            echo "This release was created on **$(date +'%Y-%m-%d')** and may contain unexpected bugs. Data loss is rare but is not impossible. The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt
-            echo '' >> output.txt
-            echo '### Instructions' >> output.txt
-            echo '' >> output.txt
-            echo "* Installation instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/installation/docker/), [Portainer](https://docs.firefly-iii.org/how-to/firefly-iii/installation/portainer/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/installation/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/installation/self-managed/)" >> output.txt
-            echo "* Or read the upgrade instructions for [Docker](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/docker/), [Kubernetes](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/kubernetes/) or [self-managed servers](https://docs.firefly-iii.org/how-to/firefly-iii/upgrade/self-managed/)" >> output.txt
-            echo "* The releases are signed, and you can verify them using the [Firefly III releases PGP key](https://docs.firefly-iii.org/explanation/more-information/signatures/)." >> output.txt
-
-          fi
-
-          # create a development release:
-          if [[ "develop" == "$version" ]]; then
-            # create the release:
-            echo "Create develop release."
-            git tag -a $releaseName -m "Development release '$version' on $(date +'%Y-%m-%d')"
-
-            git push origin $releaseName
-            gh release create $releaseName -p --verify-tag \
-              -t "Development release for $(date +'%Y-%m-%d')" \
-              --latest=false \
-              -F output.txt
-          fi
-
-          # create a branch release:
-          if [[ "$version" == branch* ]]; then
-
-            # create the release:
-            echo "Create branch release."
-            git tag -a $releaseName -m "Branch release '$version' on $(date +'%Y-%m-%d')"
-
-            git push origin $releaseName
-            gh release create $releaseName -p --verify-tag \
-              -t "Branch release for $(date +'%Y-%m-%d')" \
-              --latest=false \
-              -F output.txt
-          fi
-
-          # create a development (nightly) release:
-          if [[ "develop" == "$version" ]] || [[ "$version" == branch* ]]; then
-            # add zip file to release.
-            gh release upload $releaseName $zipName
-            gh release upload $releaseName $tarName
-
-            # add sha256 sum to release
-            gh release upload $releaseName $zipName.sha256
-            gh release upload $releaseName $tarName.sha256
-
-            # add signatures to release
-            gh release upload $releaseName $zipName.asc
-            gh release upload $releaseName $tarName.asc
-
-            # get current HEAD and add as file to the release
-            HEAD=$(git rev-parse HEAD)
-            echo $HEAD > HEAD.txt
-            gh release upload $releaseName HEAD.txt
-          else
-            echo 'MAIN (real) release'
-            git tag -a $releaseName -m "Here be changelog"
-            git push origin $releaseName
-
-            # do not tag as latest when alpha or beta.
-            if [[ "$version" == *alpha* ]] || [[ "$version" == *beta* ]]; then
-              echo 'Mark alpha or beta as NOT the latest.'
-              gh release create $releaseName -F output.txt -t "$releaseName" --verify-tag --latest=false
-            fi
-
-            # tag as latest when NOT alpha or beta.
-            if [[ "$version" != *alpha* ]] && [[ "$version" != *beta* ]]; then
-              echo 'Mark prod as the latest.'
-              gh release create $releaseName -F output.txt -t "$releaseName" --verify-tag
-            fi
-
-            # add archive files to release
-            gh release upload $releaseName $zipName
-            gh release upload $releaseName $tarName
-
-            # add sha256 sums to release
-            gh release upload $releaseName $zipName.sha256
-            gh release upload $releaseName $tarName.sha256
-
-            # add signatures to release
-            gh release upload $releaseName $zipName.asc
-            gh release upload $releaseName $tarName.asc
-
-            # get current HEAD and add as file to the release
-            HEAD=$(git rev-parse HEAD)
-            echo $HEAD > HEAD.txt
-            gh release upload $releaseName HEAD.txt
-
-            # remove all temporary files
-            rm -f output.txt
-            rm -f HEAD.txt
-            rm -f $zipName
-            rm -f $zipName.sha256
-            rm -f $tarName
-            rm -f $tarName.sha256
-
-            # merge main back into develop
-            git checkout develop
-            git merge main
-            git push
-          fi
-        env:
-          GH_TOKEN: ${{ github.token }}
-          version: ${{ github.event_name == 'schedule' && 'develop' || github.event.inputs.version }}

.github/workflows/sonarcloud.yml

@@ -1,69 +0,0 @@
-name: 'Code - Run Sonarcloud'
-on:
-  pull_request:
-  workflow_dispatch:
-  push:
-    branches:
-      - main
-      - develop
-env:
-  DB_CONNECTION: sqlite
-  APP_KEY: TestTestTestTestTestTestTestTest
-jobs:
-  sonarcloud:
-    name: SonarCloud
-    runs-on: ubuntu-latest
-    steps:
-      - name: Checkout
-        uses: actions/checkout@v4
-      - name: Setup PHP with Xdebug
-        uses: shivammathur/setup-php@v2
-        with:
-          php-version: '8.4'
-          coverage: xdebug
-          extensions: >-
-            bcmath
-            curl
-            fileinfo
-            iconv
-            intl
-            json
-            sqlite3
-            mbstring
-            openssl
-            pdo
-            session
-            simplexml
-            sodium
-            tokenizer
-            xml
-            xmlwriter
-
-      - name: Copy standard configuration
-        run: cp .env.testing .env
-
-      - name: Install Composer dependencies
-        run: composer install --prefer-dist --no-interaction --no-progress --no-scripts
-
-      - name: "Create database file"
-        run: |
-          touch storage/database/database.sqlite
-          wget -q https://github.com/firefly-iii/test-fixtures/raw/refs/heads/main/test-database.sqlite -O storage/database/database.sqlite
-
-      - name: "Upgrades the database to the latest version"
-        run: php artisan firefly-iii:upgrade-database
-
-      - name: "Integrity Database Report"
-        run: php artisan firefly-iii:report-integrity
-
-      - name: "Run tests with coverage"
-        run: composer coverage
-
-      - name: Fix code coverage paths
-        run: sed -i 's@'$GITHUB_WORKSPACE'@/github/workspace/@g' coverage.xml
-
-      - name: SonarCloud Scan
-        uses: SonarSource/sonarcloud-github-action@master
-        env:
-          GITHUB_TOKEN: ${{ secrets.GH_ACTIONS_PERSONAL_ACCESS_TOKEN }}
-          SONAR_TOKEN: ${{ secrets.SONAR_TOKEN }}

.github/workflows/stale.yml

@@ -1,40 +1,23 @@
-name: "Issues - Mark and close stale issues"
+name: "Close stale issues"
 on:
   schedule:
-    - cron: "0 4 * * *"
-  workflow_dispatch:
-
-permissions:
-  contents: read
+    - cron: "30 1 * * *"
 
 jobs:
   stale:
-    permissions:
-      issues: write  # for actions/stale to close stale issues
-      pull-requests: write  # for actions/stale to close stale PRs
-      actions: write
     runs-on: ubuntu-latest
     steps:
-      - uses: actions/stale@v9
+      - uses: actions/stale@v3
         with:
           repo-token: ${{ secrets.GITHUB_TOKEN }}
-          stale-issue-message: |
-            Hi there!
-
-            This is an automatic reply. `Share and enjoy`
-
-            This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
-
-            Thank you for your contributions.
-          stale-pr-message: |
-            Hi there!
-
-            This is an automatic reply. `Share and enjoy`
-
-            This PR has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs.
-
-            Thank you for your contributions.
+          stale-issue-message: >
+            This issue has been automatically marked as stale because it has not had
+            recent activity. It will be closed if no further activity occurs. Thank you
+            for your contributions.
+          stale-pr-message: >
+            This issue has been automatically marked as stale because it has not had
+            recent activity. It will be closed if no further activity occurs. Thank you
+            for your contributions.
           days-before-stale: 14
           days-before-close: 7
-          exempt-all-milestones: true
-          exempt-issue-labels: 'triage'
+          exempt-issue-labels: 'enhancement,feature,bug,announcement'

.gitignore

@@ -1,20 +1,18 @@
 /node_modules
+/frontend/node_modules
+/frontend/fonts
+/frontend/images
+/public/hot
+/public/storage
 /storage/*.key
 /vendor
-public/hot
+/.vagrant
+Homestead.json
+Homestead.yaml
 npm-debug.log
 yarn-error.log
 .env
-/.ci/php-cs-fixer/vendor
-coverage.xml
-
-# ignore generated files.
-public/build
-
-# ignore v1 build files
-resources/assets/v1/node_modules
-resources/assets/v1/build
-
-# ignore v2 build files
-resources/assets/v2/node_modules
-resources/assets/v2/build
+public/google*.html
+report.html
+composer.phar
+app.js.map

.htaccess

@@ -8,5 +8,7 @@
 # To hide directory listing
 Options All -Indexes
 
-# To prevent access any file
-Deny from all
+# To prevent access to .env and other files
+<Files .*>
+    Deny from all
+</Files>

.scrutinizer.yml

@@ -0,0 +1,58 @@
+--- 
+build: 
+  nodes: 
+    analysis: 
+      project_setup: 
+        override: true
+      tests: 
+        override: 
+          - php-scrutinizer-run
+checks: 
+  javascript: true
+  php: 
+    align_assignments: true
+    avoid_fixme_comments: true
+    avoid_multiple_statements_on_same_line: true
+    avoid_perl_style_comments: true
+    avoid_todo_comments: true
+    duplication: false
+    encourage_single_quotes: true
+    newline_at_end_of_file: true
+    no_goto: true
+    no_long_variable_names: 
+      maximum: "20"
+    no_short_method_names: 
+      minimum: "3"
+    no_short_variable_names: 
+      minimum: "3"
+    optional_parameters_at_the_end: true
+    parameter_doc_comments: true
+    remove_extra_empty_lines: true
+    return_doc_comment_if_not_inferrable: true
+    return_doc_comments: true
+    uppercase_constants: true
+    use_self_instead_of_fqcn: true
+coding_style: 
+  php: 
+    spaces: 
+      around_operators: 
+        concatenation: true
+      other: 
+        after_type_cast: false
+filter: 
+  excluded_paths: 
+    - database/migrations/*
+    - bootstrap/*
+    - config/*
+    - docker/*
+    - public/js/lib/*
+    - public/lib/adminlte/js/*
+    - public/lib/bootstrap/js/*
+    - resources/*
+    - routes/*
+    - storage/*
+  paths: 
+    - app/*
+    - public/js/ff/*
+tools: 
+  external_code_coverage: false

.travis.yml

@@ -0,0 +1,20 @@
+language: php
+php:
+- '7.4'
+dist: xenial
+os: linux
+cache:
+  directories:
+  - "/home/travis/.config"
+  - "/home/travis/build/firefly-iii/firefly-iii/vendor"
+
+branches:
+  only:
+  - develop
+
+before_script:
+- phpenv config-rm xdebug.ini || return 0
+
+script:
+- "./.ci/phpstan.sh"
+- "./.ci/phpunit.sh"

THANKS.md

@@ -1,202 +0,0 @@
-# Thank you! :tada: :heart: :tada:
-
-Over time, many people have contributed to Firefly III. Their efforts are not always visible, but always remembered and appreciated.
-Please find below all the people who contributed to the Firefly III code. Their names are mentioned in the year of their first contribution.
-
-## 2024
-- Sobuno
-- TasneemTantawy
-- Antônio Franco
-- yparitcher
-- Jhon Pedroza
-- mzhubail
-- tasnim
-- withbest
-- Steve Wasiura
-- imlonghao
-- Rahman Yusuf
-- Michael Thomas
-- WardenJakx
-- kuilin
-- Stevie Robinson
-- luzpaz
-- Lemuel Roberto Bonifácio
-- maureenferreira
-
-## 2023
-- tieu1991
-- Maxco10
-- zqye
-- Mateus Pereira
-- josephbadow
-- Christian Desktop
-- Edgars
-- Hannah K
-- noxonad
-- Kaijia Feng
-- Marc Ordinas i Llopis
-- Kuba Turek
-- Julien Stébenne
-
-## 2022
-- Johannes Zellner
-- Janne Heß
-- charlesteets
-- Nathan PERIER
-- Jan Willhaus
-- canoine
-- Rick Cuddy
-- James
-- Hugo Meyronneinc
-- naveen
-- neilnaveen
-- naveensrinivasan
-- Federico Micelli
-- George Hahn
-
-## 2021
-- StillLoading
-- Igor Rzegocki
-- Lorenzo Breda
-- Hosh
-- Flightkick
-- alex6480
-- VREEdom
-- Hamza FADIL
-- Kasper Læssø Sørensen
-- Alex
-- Jeroen De Meerleer
-- Ruben van Erk
-- Fabian Zimmermann
-- Mirko Berger
-- KaihatsuOnline
-- MihataBG
-
-## 2020
-- Hannes Körber
-- Julien Cassagne
-- bu4ak
-- Viktor Yakovlev
-- Oliver Kaufmann
-- Arvind Chembarpu
-- GrayStrider
-- psychowood
-- Hosh Sadiq
-- emansih
-- Aniruddha Maru
-- johnny
-- sephrat
-- bpatath
-- Florian Dupret
-- Maxim Kurbatov
-- Lucas Guima
-- Sandro
-- Ruben Verhoef
-- Daniel Idzerda
-- Calum Smith
-- Agraphie
-- Tomer Shvueli
-- Tomer S
-
-## 2019
-- Pascal Jungblut
-- Justyn Shull
-- Timendum
-- Nicolas Lœuillet
-- Dominic Guhl
-- Melroy van den Berg
-- Henning Stein
-- Jan Klepek
-- Jonathan
-- Geoffrey “Frogeye” Preud'homme
-- Michael Fix
-- Juraj Mlich
-- Eddybrando Vásquez
-- hulloanson
-- Will Rouesnel
-- lastlink
-- Mr. Funk
-- Simon Taddiken
-- Joris
-- Bastiaan Nijkamp
-
-## 2018
-- a1ex4
-- Daniel Quah
-- Marco Lourenço
-- Dennis Enderink
-- Luca Bognolo
-- Mike Conway
-- Ben
-- Mathieu Post
-- George Hertz
-- HamuZ HamuZ
-- David Meiseles
-- Erik Gelderblom
-- Luca Vallerini
-- Clemens Wijnekus
-- Jacob Weisz
-- Mateusz Gozdek
-- anmol26s
-- Kevin Hellemun
-- Shashank M Chakravarthy
-- Nico Schreiner
-- Paul Sohier
-- Brenden Conte
-- Ben Yanke
-- Andrew Prokhorenkov
-- devlearner
-- Kelvin
-- J'informatique
-
-## 2017
-- Victor Mosin
-- Justin
-- Hugo van Duijn
-- Lukas Winkler
-- Marcin Szymanski
-- Jens Kat
-- koziolek
-- jleeong
-- Simon Hanna
-- richard & xeli.eu
-- Sergey Besedin
-- Welbert Serra
-- Joris de Vries
-- Patrick Kostjens
-- Enrico Lamperti
-- Christian Musa
-- Enno Lohmeier
-
-## 2016
-- Sander
-- Toon Schoenmakers
-- Telyn
-- Sander Kleykens
-- Tom van der Werf
-- Matthew Peck
-- Sander Mulders
-- Bonno Nachtegaal-Karels
-- Niek Haarman
-- Edwin
-- Thijs Alkemade
-- zjean
-- Graham Miller
-- Robert Horlings
-- leander091
-
-## 2015
-- Antonio Spinelli
-- Colin O'Dell
-- RonaldvanMeer
-- Richard Ebbers
-- Balazs Varkonyi
-- Niek van der Kooy
-- Ilya Kil
-
-## 2014
-- Stewart Malik
-- Graham Campbell
-
-
-Thank you for all your support!

app.json

@@ -0,0 +1,65 @@
+{
+  "name": "Firefly III",
+  "description": "A free and open source personal finances manager",
+  "repository": "https://github.com/firefly-iii/firefly-iii",
+  "website": "https://firefly-iii.org/",
+  "logo": "https://raw.githubusercontent.com/firefly-iii/firefly-iii/main/public/mstile-150x150.png",
+  "keywords": [
+    "finance",
+    "finances",
+    "manager",
+    "management",
+    "euro",
+    "dollar",
+    "laravel",
+    "money",
+    "currency",
+    "financials",
+    "financial",
+    "budgets",
+    "administration",
+    "tool",
+    "tooling",
+    "help",
+    "helper",
+    "assistant",
+    "planning",
+    "organizing",
+    "bills",
+    "personal finance",
+    "budgets",
+    "budgeting",
+    "budgeting tool",
+    "budgeting application",
+    "transactions",
+    "self hosted",
+    "self-hosted",
+    "transfers",
+    "management"
+  ],
+  "addons": [
+    {
+      "plan": "heroku-postgresql",
+      "options": {
+        "version": "12"
+      }
+    }
+  ],
+  "scripts": {
+    "postdeploy": "php artisan migrate:refresh --seed;php artisan firefly:instructions install"
+  },
+  "buildpacks": [
+    {
+      "url": "heroku/php"
+    },
+    {
+      "url": "https://github.com/heroku/heroku-buildpack-locale"
+    }
+  ],
+  "env": {
+    "APP_KEY": {
+      "description": "This key is used to create app cookies en secure attachments.",
+      "value": "base64:If1gJN4pyycXTq+WS5TjneDympKuu+8SKvTl6RZnhJg="
+    }
+  }
+}

app/Api/V1/Controllers/Autocomplete/AccountController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * AccountController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -26,11 +25,9 @@ namespace FireflyIII\Api\V1\Controllers\Autocomplete;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Autocomplete\AutocompleteRequest;
-use FireflyIII\Enums\AccountTypeEnum;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\Account;
+use FireflyIII\Models\AccountType;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Support\Facades\Steam;
 use FireflyIII\Support\Http\Api\AccountFilter;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
@@ -41,10 +38,7 @@ use Illuminate\Http\JsonResponse;
 class AccountController extends Controller
 {
     use AccountFilter;
-    // this array only exists to test if the constructor will use it properly.
-    protected array $accepts = ['application/json', 'application/vnd.api+json'];
 
-    /** @var array<int, string> */
     private array                      $balanceTypes;
     private AccountRepositoryInterface $repository;
 
@@ -64,67 +58,59 @@ class AccountController extends Controller
                 return $next($request);
             }
         );
-        $this->balanceTypes = [AccountTypeEnum::ASSET->value, AccountTypeEnum::LOAN->value, AccountTypeEnum::DEBT->value, AccountTypeEnum::MORTGAGE->value];
+        $this->balanceTypes = [AccountType::ASSET, AccountType::LOAN, AccountType::DEBT, AccountType::MORTGAGE,];
     }
 
     /**
-     * Documentation for this endpoint:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getAccountsAC
+     * @param AutocompleteRequest $request
      *
-     * @throws FireflyException
-     * @throws FireflyException
+     * @return JsonResponse
      */
     public function accounts(AutocompleteRequest $request): JsonResponse
     {
-        $data   = $request->getData();
-        $types  = $data['types'];
-        $query  = $data['query'];
-        $date   = $data['date'] ?? today(config('app.timezone'));
-        $return = [];
-        $result = $this->repository->searchAccount((string) $query, $types, $this->parameters->get('limit'));
+        $data  = $request->getData();
+        $types = $data['types'];
+        $query = $data['query'];
+        $date  = $data['date'] ?? today(config('app.timezone'));
+
+        $return          = [];
+        $result          = $this->repository->searchAccount((string)$query, $types, $data['limit']);
+        $defaultCurrency = app('amount')->getDefaultCurrency();
 
         /** @var Account $account */
         foreach ($result as $account) {
             $nameWithBalance = $account->name;
-            $currency        = $this->repository->getAccountCurrency($account) ?? $this->nativeCurrency;
-            $useCurrency     = $currency;
+            $currency        = $this->repository->getAccountCurrency($account) ?? $defaultCurrency;
+
             if (in_array($account->accountType->type, $this->balanceTypes, true)) {
-                $balance         = Steam::finalAccountBalance($account, $date);
-                $key             = $this->convertToNative && $currency->id !== $this->nativeCurrency->id ? 'native_balance' : 'balance';
-                $useCurrency     = $this->convertToNative && $currency->id !== $this->nativeCurrency->id ? $this->nativeCurrency : $currency;
-                $amount          = $balance[$key] ?? '0';
-                $nameWithBalance = sprintf(
-                    '%s (%s)',
-                    $account->name,
-                    app('amount')->formatAnything($useCurrency, $amount, false)
-                );
+                $balance         = app('steam')->balance($account, $date);
+                $nameWithBalance = sprintf('%s (%s)', $account->name, app('amount')->formatAnything($currency, $balance, false));
             }
 
-            $return[]        = [
-                'id'                      => (string) $account->id,
+            $return[] = [
+                'id'                      => (string)$account->id,
                 'name'                    => $account->name,
                 'name_with_balance'       => $nameWithBalance,
                 'type'                    => $account->accountType->type,
-                'currency_id'             => (string) $useCurrency->id,
-                'currency_name'           => $useCurrency->name,
-                'currency_code'           => $useCurrency->code,
-                'currency_symbol'         => $useCurrency->symbol,
-                'currency_decimal_places' => $useCurrency->decimal_places,
+                'currency_id'             => $currency->id,
+                'currency_name'           => $currency->name,
+                'currency_code'           => $currency->code,
+                'currency_symbol'         => $currency->symbol,
+                'currency_decimal_places' => $currency->decimal_places,
             ];
         }
 
         // custom order.
+        $order = [AccountType::ASSET, AccountType::REVENUE, AccountType::EXPENSE];
         usort(
-            $return,
-            static function (array $left, array $right) {
-                $order = [AccountTypeEnum::ASSET->value, AccountTypeEnum::REVENUE->value, AccountTypeEnum::EXPENSE->value];
-                $posA  = (int) array_search($left['type'], $order, true);
-                $posB  = (int) array_search($right['type'], $order, true);
+            $return, function ($a, $b) use ($order) {
+            $pos_a = array_search($a['type'], $order);
+            $pos_b = array_search($b['type'], $order);
 
-                return $posA - $posB;
-            }
+            return $pos_a - $pos_b;
+        }
         );
 
-        return response()->api($return);
+        return response()->json($return);
     }
 }

app/Api/V1/Controllers/Autocomplete/BillController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * BillController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -57,23 +56,24 @@ class BillController extends Controller
     }
 
     /**
-     * Documentation for this endpoint is at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getBillsAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function bills(AutocompleteRequest $request): JsonResponse
     {
         $data     = $request->getData();
-        $result   = $this->repository->searchBill($data['query'], $this->parameters->get('limit'));
+        $result   = $this->repository->searchBill($data['query'], $data['limit']);
         $filtered = $result->map(
             static function (Bill $item) {
                 return [
-                    'id'     => (string) $item->id,
-                    'name'   => $item->name,
-                    'active' => $item->active,
+                    'id'   => (string)$item->id,
+                    'name' => $item->name,
                 ];
             }
         );
 
-        return response()->api($filtered->toArray());
+        return response()->json($filtered->toArray());
     }
+
 }

app/Api/V1/Controllers/Autocomplete/BudgetController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * BudgetController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -57,22 +56,23 @@ class BudgetController extends Controller
     }
 
     /**
-     * Documentation for this endpoint is at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getBudgetsAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function budgets(AutocompleteRequest $request): JsonResponse
     {
         $data     = $request->getData();
-        $result   = $this->repository->searchBudget($data['query'], $this->parameters->get('limit'));
+        $result   = $this->repository->searchBudget($data['query'], $data['limit']);
         $filtered = $result->map(
             static function (Budget $item) {
                 return [
-                    'id'   => (string) $item->id,
+                    'id'   => (string)$item->id,
                     'name' => $item->name,
                 ];
             }
         );
 
-        return response()->api($filtered->toArray());
+        return response()->json($filtered);
     }
 }

app/Api/V1/Controllers/Autocomplete/CategoryController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * CategoryController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -57,22 +56,23 @@ class CategoryController extends Controller
     }
 
     /**
-     * Documentation for this endpoint is at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getCategoriesAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function categories(AutocompleteRequest $request): JsonResponse
     {
         $data     = $request->getData();
-        $result   = $this->repository->searchCategory($data['query'], $this->parameters->get('limit'));
+        $result   = $this->repository->searchCategory($data['query'], $data['limit']);
         $filtered = $result->map(
             static function (Category $item) {
                 return [
-                    'id'   => (string) $item->id,
+                    'id'   => (string)$item->id,
                     'name' => $item->name,
                 ];
             }
         );
 
-        return response()->api($filtered->toArray());
+        return response()->json($filtered);
     }
 }

app/Api/V1/Controllers/Autocomplete/CurrencyController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * CurrencyController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -27,7 +26,7 @@ namespace FireflyIII\Api\V1\Controllers\Autocomplete;
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Autocomplete\AutocompleteRequest;
 use FireflyIII\Models\TransactionCurrency;
-use FireflyIII\Repositories\UserGroups\Currency\CurrencyRepositoryInterface;
+use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
 
@@ -57,19 +56,20 @@ class CurrencyController extends Controller
     }
 
     /**
-     * Documentation for this endpoint is at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getCurrenciesAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function currencies(AutocompleteRequest $request): JsonResponse
     {
         $data       = $request->getData();
-        $collection = $this->repository->searchCurrency($data['query'], $this->parameters->get('limit'));
+        $collection = $this->repository->searchCurrency($data['query'], $data['limit']);
         $result     = [];
 
         /** @var TransactionCurrency $currency */
         foreach ($collection as $currency) {
             $result[] = [
-                'id'             => (string) $currency->id,
+                'id'             => (string)$currency->id,
                 'name'           => $currency->name,
                 'code'           => $currency->code,
                 'symbol'         => $currency->symbol,
@@ -77,25 +77,24 @@ class CurrencyController extends Controller
             ];
         }
 
-        return response()->api($result);
+        return response()->json($result);
     }
 
     /**
-     * Documentation for this endpoint is at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getCurrenciesCodeAC
+     * @param AutocompleteRequest $request
      *
-     * @deprecated
+     * @return JsonResponse
      */
     public function currenciesWithCode(AutocompleteRequest $request): JsonResponse
     {
         $data       = $request->getData();
-        $collection = $this->repository->searchCurrency($data['query'], $this->parameters->get('limit'));
+        $collection = $this->repository->searchCurrency($data['query'], $data['limit']);
         $result     = [];
 
         /** @var TransactionCurrency $currency */
         foreach ($collection as $currency) {
             $result[] = [
-                'id'             => (string) $currency->id,
+                'id'             => (string)$currency->id,
                 'name'           => sprintf('%s (%s)', $currency->name, $currency->code),
                 'code'           => $currency->code,
                 'symbol'         => $currency->symbol,
@@ -103,6 +102,6 @@ class CurrencyController extends Controller
             ];
         }
 
-        return response()->api($result);
+        return response()->json($result);
     }
 }

app/Api/V1/Controllers/Autocomplete/ObjectGroupController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * ObjectGroupController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -57,24 +56,26 @@ class ObjectGroupController extends Controller
     }
 
     /**
-     * Documentation for this endpoint is at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getObjectGroupsAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function objectGroups(AutocompleteRequest $request): JsonResponse
     {
         $data   = $request->getData();
         $return = [];
-        $result = $this->repository->search($data['query'], $this->parameters->get('limit'));
+        $result = $this->repository->search($data['query'], $data['limit']);
 
         /** @var ObjectGroup $objectGroup */
         foreach ($result as $objectGroup) {
             $return[] = [
-                'id'    => (string) $objectGroup->id,
+                'id'    => (string)$objectGroup->id,
                 'name'  => $objectGroup->title,
                 'title' => $objectGroup->title,
             ];
         }
 
-        return response()->api($return);
+        return response()->json($return);
     }
+
 }

app/Api/V1/Controllers/Autocomplete/PiggyBankController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * PiggyBankController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -37,7 +36,7 @@ use Illuminate\Http\JsonResponse;
  */
 class PiggyBankController extends Controller
 {
-    private AccountRepositoryInterface   $accountRepository;
+    private AccountRepositoryInterface $accountRepository;
     private PiggyBankRepositoryInterface $piggyRepository;
 
     /**
@@ -61,69 +60,63 @@ class PiggyBankController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getPiggiesAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function piggyBanks(AutocompleteRequest $request): JsonResponse
     {
-        $data     = $request->getData();
-        $piggies  = $this->piggyRepository->searchPiggyBank($data['query'], $this->parameters->get('limit'));
-        $response = [];
+        $data            = $request->getData();
+        $piggies         = $this->piggyRepository->searchPiggyBank($data['query'], $data['limit']);
+        $defaultCurrency = app('amount')->getDefaultCurrency();
+        $response        = [];
 
         /** @var PiggyBank $piggy */
         foreach ($piggies as $piggy) {
-            $currency    = $piggy->transactionCurrency;
-            $objectGroup = $piggy->objectGroups()->first();
-            $response[]  = [
-                'id'                      => (string) $piggy->id,
+            $currency   = $this->accountRepository->getAccountCurrency($piggy->account) ?? $defaultCurrency;
+            $response[] = [
+                'id'                      => (string)$piggy->id,
                 'name'                    => $piggy->name,
-                'currency_id'             => (string) $currency->id,
+                'currency_id'             => $currency->id,
                 'currency_name'           => $currency->name,
                 'currency_code'           => $currency->code,
-                'currency_symbol'         => $currency->symbol,
                 'currency_decimal_places' => $currency->decimal_places,
-                'object_group_id'         => null === $objectGroup ? null : (string) $objectGroup->id,
-                'object_group_title'      => $objectGroup?->title,
             ];
         }
 
-        return response()->api($response);
+        return response()->json($response);
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getPiggiesBalanceAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function piggyBanksWithBalance(AutocompleteRequest $request): JsonResponse
     {
-        $data     = $request->getData();
-        $piggies  = $this->piggyRepository->searchPiggyBank($data['query'], $this->parameters->get('limit'));
-        $response = [];
-
+        $data            = $request->getData();
+        $piggies         = $this->piggyRepository->searchPiggyBank($data['query'], $data['limit']);
+        $defaultCurrency = app('amount')->getDefaultCurrency();
+        $response        = [];
         /** @var PiggyBank $piggy */
         foreach ($piggies as $piggy) {
-            $currency      = $piggy->transactionCurrency;
-            $currentAmount = $this->piggyRepository->getCurrentAmount($piggy);
-            $objectGroup   = $piggy->objectGroups()->first();
+            $currency      = $this->accountRepository->getAccountCurrency($piggy->account) ?? $defaultCurrency;
+            $currentAmount = $this->piggyRepository->getRepetition($piggy)->currentamount ?? '0';
             $response[]    = [
-                'id'                      => (string) $piggy->id,
+                'id'                      => (string)$piggy->id,
                 'name'                    => $piggy->name,
                 'name_with_balance'       => sprintf(
-                    '%s (%s / %s)',
-                    $piggy->name,
-                    app('amount')->formatAnything($currency, $currentAmount, false),
-                    app('amount')->formatAnything($currency, $piggy->target_amount, false),
+                    '%s (%s / %s)', $piggy->name, app('amount')->formatAnything($currency, $currentAmount, false),
+                    app('amount')->formatAnything($currency, $piggy->targetamount, false),
                 ),
-                'currency_id'             => (string) $currency->id,
+                'currency_id'             => $currency->id,
                 'currency_name'           => $currency->name,
                 'currency_code'           => $currency->code,
-                'currency_symbol'         => $currency->symbol,
                 'currency_decimal_places' => $currency->decimal_places,
-                'object_group_id'         => null === $objectGroup ? null : (string) $objectGroup->id,
-                'object_group_title'      => $objectGroup?->title,
             ];
         }
 
-        return response()->api($response);
+        return response()->json($response);
     }
+
 }

app/Api/V1/Controllers/Autocomplete/RecurrenceController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * RecurrenceController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -26,7 +25,7 @@ namespace FireflyIII\Api\V1\Controllers\Autocomplete;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Autocomplete\AutocompleteRequest;
-use FireflyIII\Models\Recurrence;
+use FireflyIII\Models\Rule;
 use FireflyIII\Repositories\Recurring\RecurringRepositoryInterface;
 use Illuminate\Http\JsonResponse;
 
@@ -46,7 +45,6 @@ class RecurrenceController extends Controller
         $this->middleware(
             function ($request, $next) {
                 $this->repository = app(RecurringRepositoryInterface::class);
-
                 $this->repository->setUser(auth()->user());
 
                 return $next($request);
@@ -55,24 +53,26 @@ class RecurrenceController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getRecurringAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function recurring(AutocompleteRequest $request): JsonResponse
     {
-        $data        = $request->getData();
-        $recurrences = $this->repository->searchRecurrence($data['query'], $this->parameters->get('limit'));
-        $response    = [];
+        $data     = $request->getData();
+        $rules    = $this->repository->searchRecurrence($data['query'], $data['limit']);
+        $response = [];
 
-        /** @var Recurrence $recurrence */
-        foreach ($recurrences as $recurrence) {
+        /** @var Rule $rule */
+        foreach ($rules as $rule) {
             $response[] = [
-                'id'          => (string) $recurrence->id,
-                'name'        => $recurrence->title,
-                'description' => $recurrence->description,
+                'id'          => (string)$rule->id,
+                'name'        => $rule->title,
+                'description' => $rule->description,
             ];
         }
 
-        return response()->api($response);
+        return response()->json($response);
     }
+
 }

app/Api/V1/Controllers/Autocomplete/RuleController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * RuleController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -54,24 +53,26 @@ class RuleController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getRulesAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function rules(AutocompleteRequest $request): JsonResponse
     {
         $data     = $request->getData();
-        $rules    = $this->repository->searchRule($data['query'], $this->parameters->get('limit'));
+        $rules    = $this->repository->searchRule($data['query'], $data['limit']);
         $response = [];
 
         /** @var Rule $rule */
         foreach ($rules as $rule) {
             $response[] = [
-                'id'          => (string) $rule->id,
+                'id'          => (string)$rule->id,
                 'name'        => $rule->title,
                 'description' => $rule->description,
             ];
         }
 
-        return response()->api($response);
+        return response()->json($response);
     }
+
 }

app/Api/V1/Controllers/Autocomplete/RuleGroupController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * RuleGroupController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -54,24 +53,25 @@ class RuleGroupController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getRuleGroupsAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function ruleGroups(AutocompleteRequest $request): JsonResponse
     {
         $data     = $request->getData();
-        $groups   = $this->repository->searchRuleGroup($data['query'], $this->parameters->get('limit'));
+        $groups   = $this->repository->searchRuleGroup($data['query'], $data['limit']);
         $response = [];
 
         /** @var RuleGroup $group */
         foreach ($groups as $group) {
             $response[] = [
-                'id'          => (string) $group->id,
+                'id'          => (string)$group->id,
                 'name'        => $group->title,
                 'description' => $group->description,
             ];
         }
 
-        return response()->api($response);
+        return response()->json($response);
     }
 }

app/Api/V1/Controllers/Autocomplete/TagController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * TagController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -57,24 +56,25 @@ class TagController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getTagAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function tags(AutocompleteRequest $request): JsonResponse
     {
-        $data   = $request->getData();
-        $result = $this->repository->searchTags($data['query'], $this->parameters->get('limit'));
-        $array  = [];
+        $data = $request->getData();
 
+        $result = $this->repository->searchTags($data['query'], $data['limit']);
+        $array  = [];
         /** @var Tag $tag */
         foreach ($result as $tag) {
             $array[] = [
-                'id'   => (string) $tag->id,
+                'id'   => (string)$tag->id,
                 'name' => $tag->tag,
                 'tag'  => $tag->tag,
             ];
         }
 
-        return response()->api($array);
+        return response()->json($array);
     }
 }

app/Api/V1/Controllers/Autocomplete/TransactionController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * TransactionController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -62,13 +61,14 @@ class TransactionController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getTransactionsAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function transactions(AutocompleteRequest $request): JsonResponse
     {
-        $data     = $request->getData();
-        $result   = $this->repository->searchJournalDescriptions($data['query'], $this->parameters->get('limit'));
+        $data   = $request->getData();
+        $result = $this->repository->searchJournalDescriptions($data['query'], $data['limit']);
 
         // limit and unique
         $filtered = $result->unique('description');
@@ -77,27 +77,28 @@ class TransactionController extends Controller
         /** @var TransactionJournal $journal */
         foreach ($filtered as $journal) {
             $array[] = [
-                'id'                   => (string) $journal->id,
-                'transaction_group_id' => (string) $journal->transaction_group_id,
+                'id'                   => (string)$journal->id,
+                'transaction_group_id' => (string)$journal->transaction_group_id,
                 'name'                 => $journal->description,
                 'description'          => $journal->description,
             ];
         }
 
-        return response()->api($array);
+        return response()->json($array);
     }
 
     /**
-     * This endpoint is documented at:
-     * * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getTransactionsIDAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
      */
     public function transactionsWithID(AutocompleteRequest $request): JsonResponse
     {
         $data   = $request->getData();
-        $result = new Collection();
+        $result = new Collection;
         if (is_numeric($data['query'])) {
             // search for group, not journal.
-            $firstResult = $this->groupRepository->find((int) $data['query']);
+            $firstResult = $this->groupRepository->find((int)$data['query']);
             if (null !== $firstResult) {
                 // group may contain multiple journals, each a result:
                 foreach ($firstResult->transactionJournals as $journal) {
@@ -106,22 +107,22 @@ class TransactionController extends Controller
             }
         }
         if (!is_numeric($data['query'])) {
-            $result = $this->repository->searchJournalDescriptions($data['query'], $this->parameters->get('limit'));
+            $result = $this->repository->searchJournalDescriptions($data['query'], $data['limit']);
         }
 
         // limit and unique
-        $array  = [];
+        $array = [];
 
         /** @var TransactionJournal $journal */
         foreach ($result as $journal) {
             $array[] = [
-                'id'                   => (string) $journal->id,
-                'transaction_group_id' => (string) $journal->transaction_group_id,
+                'id'                   => (string)$journal->id,
+                'transaction_group_id' => (string)$journal->transaction_group_id,
                 'name'                 => sprintf('#%d: %s', $journal->transaction_group_id, $journal->description),
                 'description'          => sprintf('#%d: %s', $journal->transaction_group_id, $journal->description),
             ];
         }
 
-        return response()->api($array);
+        return response()->json($array);
     }
 }

app/Api/V1/Controllers/Autocomplete/TransactionTypeController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * TransactionTypeController.php
  * Copyright (c) 2020 james@firefly-iii.org
@@ -53,25 +52,27 @@ class TransactionTypeController extends Controller
     }
 
     /**
-     * This endpoint is documented at
-     * * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/autocomplete/getTransactionTypesAC
+     * @param AutocompleteRequest $request
+     *
+     * @return JsonResponse
+     * @codeCoverageIgnore
      */
     public function transactionTypes(AutocompleteRequest $request): JsonResponse
     {
         $data  = $request->getData();
-        $types = $this->repository->searchTypes($data['query'], $this->parameters->get('limit'));
+        $types = $this->repository->searchTypes($data['query'], $data['limit']);
         $array = [];
 
         /** @var TransactionType $type */
         foreach ($types as $type) {
             // different key for consistency.
             $array[] = [
-                'id'   => (string) $type->id,
+                'id'   => (string)$type->id,
                 'name' => $type->type,
                 'type' => $type->type,
             ];
         }
 
-        return response()->api($array);
+        return response()->json($array);
     }
 }

app/Api/V1/Controllers/Chart/AccountController.php

@@ -27,11 +27,10 @@ namespace FireflyIII\Api\V1\Controllers\Chart;
 use Carbon\Carbon;
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Data\DateRequest;
-use FireflyIII\Enums\AccountTypeEnum;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\Account;
-use FireflyIII\Models\Preference;
+use FireflyIII\Models\AccountType;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
+use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Support\Http\Api\ApiSupport;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
@@ -43,10 +42,13 @@ class AccountController extends Controller
 {
     use ApiSupport;
 
-    private AccountRepositoryInterface $repository;
+    private CurrencyRepositoryInterface $currencyRepository;
+    private AccountRepositoryInterface  $repository;
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -58,50 +60,51 @@ class AccountController extends Controller
                 $this->repository = app(AccountRepositoryInterface::class);
                 $this->repository->setUser($user);
 
+                $this->currencyRepository = app(CurrencyRepositoryInterface::class);
+                $this->currencyRepository->setUser($user);
+
                 return $next($request);
             }
         );
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/charts/getChartAccountOverview
+     * @param DateRequest $request
      *
-     * @throws FireflyException
+     * @return JsonResponse
      */
     public function overview(DateRequest $request): JsonResponse
     {
         // parameters for chart:
-        $dates      = $request->getAll();
-
+        $dates = $request->getAll();
         /** @var Carbon $start */
-        $start      = $dates['start'];
-
+        $start = $dates['start'];
         /** @var Carbon $end */
-        $end        = $dates['end'];
+        $end = $dates['end'];
 
         // user's preferences
-        $defaultSet = $this->repository->getAccountsByType([AccountTypeEnum::ASSET->value])->pluck('id')->toArray();
+        $defaultSet = $this->repository->getAccountsByType([AccountType::ASSET])->pluck('id')->toArray();
+        $frontPage  = app('preferences')->get('frontPageAccounts', $defaultSet);
+        $default    = app('amount')->getDefaultCurrency();
 
-        /** @var Preference $frontpage */
-        $frontpage  = app('preferences')->get('frontpageAccounts', $defaultSet);
-
-        if (!(is_array($frontpage->data) && count($frontpage->data) > 0)) {
-            $frontpage->data = $defaultSet;
-            $frontpage->save();
+        if (0 === count($frontPage->data)) {
+            $frontPage->data = $defaultSet;
+            $frontPage->save();
         }
 
-        // get accounts:
-        $accounts   = $this->repository->getAccountsById($frontpage->data);
-        $chartData  = [];
 
+        // get accounts:
+        $accounts  = $this->repository->getAccountsById($frontPage->data);
+        $chartData = [];
         /** @var Account $account */
         foreach ($accounts as $account) {
-            $currency     = $this->repository->getAccountCurrency($account) ?? $this->nativeCurrency;
-            $field        = $this->convertToNative && $currency->id !== $this->nativeCurrency->id ? 'native_balance' : 'balance';
-            $currentSet   = [
+            $currency = $this->repository->getAccountCurrency($account);
+            if (null === $currency) {
+                $currency = $default; 
+            }
+            $currentSet = [
                 'label'                   => $account->name,
-                'currency_id'             => (string) $currency->id,
+                'currency_id'             => (string)$currency->id,
                 'currency_code'           => $currency->code,
                 'currency_symbol'         => $currency->symbol,
                 'currency_decimal_places' => $currency->decimal_places,
@@ -111,19 +114,19 @@ class AccountController extends Controller
                 'yAxisID'                 => 0, // 0, 1, 2
                 'entries'                 => [],
             ];
-            // TODO this code is also present in the V2 chart account controller so this method is due to be deprecated.
+            /** @var Carbon $currentStart */
             $currentStart = clone $start;
-            $range        = app('steam')->finalAccountBalanceInRange($account, $start, clone $end, $this->convertToNative);
-            $previous     = array_values($range)[0][$field];
+            $range        = app('steam')->balanceInRange($account, $start, clone $end);
+            $previous     = round((float)array_values($range)[0], 12);
             while ($currentStart <= $end) {
-                $format                        = $currentStart->format('Y-m-d');
-                $label                         = $currentStart->toAtomString();
-                $balance                       = array_key_exists($format, $range) ? $range[$format][$field] : $previous;
-                $previous                      = $balance;
+                $format   = $currentStart->format('Y-m-d');
+                $label    = $currentStart->toAtomString();
+                $balance  = array_key_exists($format, $range) ? round((float)$range[$format], 12) : $previous;
+                $previous = $balance;
                 $currentStart->addDay();
                 $currentSet['entries'][$label] = $balance;
             }
-            $chartData[]  = $currentSet;
+            $chartData[] = $currentSet;
         }
 
         return response()->json($chartData);

app/Api/V1/Controllers/Controller.php

@@ -25,50 +25,27 @@ declare(strict_types=1);
 namespace FireflyIII\Api\V1\Controllers;
 
 use Carbon\Carbon;
-use Carbon\Exceptions\InvalidFormatException;
-use FireflyIII\Exceptions\BadHttpHeaderException;
-use FireflyIII\Models\Preference;
-use FireflyIII\Models\TransactionCurrency;
-use FireflyIII\Support\Facades\Amount;
-use FireflyIII\Support\Facades\Steam;
-use FireflyIII\Transformers\V2\AbstractTransformer;
-use FireflyIII\User;
-use Illuminate\Database\Eloquent\Model;
+use Carbon\Exceptions\InvalidDateException;
 use Illuminate\Foundation\Auth\Access\AuthorizesRequests;
 use Illuminate\Foundation\Bus\DispatchesJobs;
 use Illuminate\Foundation\Validation\ValidatesRequests;
-use Illuminate\Pagination\LengthAwarePaginator;
 use Illuminate\Routing\Controller as BaseController;
-use Illuminate\Support\Collection;
 use League\Fractal\Manager;
-use League\Fractal\Pagination\IlluminatePaginatorAdapter;
-use League\Fractal\Resource\Collection as FractalCollection;
-use League\Fractal\Resource\Item;
 use League\Fractal\Serializer\JsonApiSerializer;
-use Symfony\Component\HttpFoundation\Exception\BadRequestException;
+use Log;
 use Symfony\Component\HttpFoundation\ParameterBag;
 
 /**
  * Class Controller.
  *
- * @SuppressWarnings("PHPMD.CouplingBetweenObjects")
- * @SuppressWarnings("PHPMD.NumberOfChildren")
+ * @codeCoverageIgnore
  */
 abstract class Controller extends BaseController
 {
-    use AuthorizesRequests;
-    use DispatchesJobs;
-    use ValidatesRequests;
+    use AuthorizesRequests, DispatchesJobs, ValidatesRequests;
 
-    protected const string CONTENT_TYPE      = 'application/vnd.api+json';
-    protected const string JSON_CONTENT_TYPE = 'application/json';
-
-    /** @var array<int, string> */
-    protected array        $allowedSort;
+    protected const CONTENT_TYPE = 'application/vnd.api+json';
     protected ParameterBag $parameters;
-    protected bool        $convertToNative   = false;
-    protected array $accepts                 = ['application/json', 'application/vnd.api+json'];
-    protected TransactionCurrency $nativeCurrency;
 
     /**
      * Controller constructor.
@@ -76,70 +53,45 @@ abstract class Controller extends BaseController
     public function __construct()
     {
         // get global parameters
-        $this->allowedSort = config('firefly.allowed_sort_parameters');
+        $this->parameters = $this->getParameters();
         $this->middleware(
             function ($request, $next) {
-                $this->parameters = $this->getParameters();
                 if (auth()->check()) {
-                    $language              = Steam::getLanguage();
-                    $this->convertToNative = Amount::convertToNative();
-                    $this->nativeCurrency  = Amount::getNativeCurrency();
+                    $language = app('steam')->getLanguage();
                     app()->setLocale($language);
                 }
 
-
-                // filter down what this endpoint accepts.
-                if (!$request->accepts($this->accepts)) {
-                    throw new BadHttpHeaderException(sprintf('Sorry, Accept header "%s" is not something this endpoint can provide.', $request->header('Accept')));
-                }
-
-
                 return $next($request);
             }
         );
+
     }
 
     /**
-     * Method to grab all parameters from the URL.
+     * Method to grab all parameters from the URI.
+     *
+     * @return ParameterBag
      */
     private function getParameters(): ParameterBag
     {
-        $bag      = new ParameterBag();
-        $page     = (int) request()->get('page');
-        if ($page < 1) {
+        $bag  = new ParameterBag;
+        $page = (int)request()->get('page');
+        if (0 === $page) {
             $page = 1;
         }
-        if ($page > 2 ** 16) {
-            $page = 2 ** 16;
-        }
         $bag->set('page', $page);
 
         // some date fields:
-        $dates    = ['start', 'end', 'date'];
+        $dates = ['start', 'end', 'date'];
         foreach ($dates as $field) {
-            $date = null;
-
-            try {
-                $date = request()->query->get($field);
-            } catch (BadRequestException $e) {
-                app('log')->error(sprintf('Request field "%s" contains a non-scalar value. Value set to NULL.', $field));
-                app('log')->error($e->getMessage());
-                app('log')->error($e->getTraceAsString());
-                $value = null;
-            }
+            $date = request()->query->get($field);
             $obj  = null;
             if (null !== $date) {
                 try {
-                    $obj = Carbon::parse((string) $date);
-                } catch (InvalidFormatException $e) {
+                    $obj = Carbon::parse($date);
+                } catch (InvalidDateException $e) {
                     // don't care
-                    app('log')->warning(
-                        sprintf(
-                            'Ignored invalid date "%s" in API controller parameter check: %s',
-                            substr((string) $date, 0, 20),
-                            $e->getMessage()
-                        )
-                    );
+                    Log::error(sprintf('Invalid date exception in API controller: %s', $e->getMessage()));
                 }
             }
             $bag->set($field, $obj);
@@ -148,76 +100,20 @@ abstract class Controller extends BaseController
         // integer fields:
         $integers = ['limit'];
         foreach ($integers as $integer) {
-            try {
-                $value = request()->query->get($integer);
-            } catch (BadRequestException $e) {
-                app('log')->error(sprintf('Request field "%s" contains a non-scalar value. Value set to NULL.', $integer));
-                app('log')->error($e->getMessage());
-                app('log')->error($e->getTraceAsString());
-                $value = null;
-            }
+            $value = request()->query->get($integer);
             if (null !== $value) {
-                $value = (int) $value;
-                if ($value < 1) {
-                    $value = 1;
-                }
-                if ($value > 2 ** 16) {
-                    $value = 2 ** 16;
-                }
-
-                $bag->set($integer, $value);
-            }
-            if (null === $value
-                && 'limit' === $integer // @phpstan-ignore-line
-                && auth()->check()) {
-                // set default for user:
-                /** @var User $user */
-                $user     = auth()->user();
-
-                /** @var Preference $pageSize */
-                $pageSize = (int) app('preferences')->getForUser($user, 'listPageSize', 50)->data;
-                $bag->set($integer, $pageSize);
+                $bag->set($integer, (int)$value);
             }
         }
 
-        // sort fields:
-        return $this->getSortParameters($bag);
-    }
-
-    private function getSortParameters(ParameterBag $bag): ParameterBag
-    {
-        $sortParameters = [];
-
-        try {
-            $param = (string) request()->query->get('sort');
-        } catch (BadRequestException $e) {
-            app('log')->error('Request field "sort" contains a non-scalar value. Value set to NULL.');
-            app('log')->error($e->getMessage());
-            app('log')->error($e->getTraceAsString());
-            $param = '';
-        }
-        if ('' === $param) {
-            return $bag;
-        }
-        $parts          = explode(',', $param);
-        foreach ($parts as $part) {
-            $part      = trim($part);
-            $direction = 'asc';
-            if ('-' === $part[0]) {
-                $part      = substr($part, 1);
-                $direction = 'desc';
-            }
-            if (in_array($part, $this->allowedSort, true)) {
-                $sortParameters[] = [$part, $direction];
-            }
-        }
-        $bag->set('sort', $sortParameters);
-
         return $bag;
+
     }
 
     /**
-     * Method to help build URL's.
+     * Method to help build URI's.
+     *
+     * @return string
      */
     final protected function buildParams(): string
     {
@@ -229,63 +125,24 @@ abstract class Controller extends BaseController
             }
             if ($value instanceof Carbon) {
                 $params[$key] = $value->format('Y-m-d');
-
                 continue;
             }
             $params[$key] = $value;
         }
 
-        return $return.http_build_query($params);
+        return $return . http_build_query($params);
     }
 
+    /**
+     * @return Manager
+     */
     final protected function getManager(): Manager
     {
         // create some objects:
-        $manager = new Manager();
-        $baseUrl = request()->getSchemeAndHttpHost().'/api/v1';
+        $manager = new Manager;
+        $baseUrl = request()->getSchemeAndHttpHost() . '/api/v1';
         $manager->setSerializer(new JsonApiSerializer($baseUrl));
 
         return $manager;
     }
-
-    final protected function jsonApiList(string $key, LengthAwarePaginator $paginator, AbstractTransformer $transformer): array
-    {
-        $manager  = new Manager();
-        $baseUrl  = sprintf('%s/api/v1/', request()->getSchemeAndHttpHost());
-
-        // TODO add stuff to path?
-
-        $manager->setSerializer(new JsonApiSerializer($baseUrl));
-
-        $objects  = $paginator->getCollection();
-
-        // the transformer, at this point, needs to collect information that ALL items in the collection
-        // require, like meta-data and stuff like that, and save it for later.
-        $objects  = $transformer->collectMetaData($objects);
-        $paginator->setCollection($objects);
-
-        $resource = new FractalCollection($objects, $transformer, $key);
-        $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
-
-        return $manager->createData($resource)->toArray();
-    }
-
-    /**
-     * Returns a JSON API object and returns it.
-     *
-     * @param array<int, mixed>|Model $object
-     */
-    final protected function jsonApiObject(string $key, array|Model $object, AbstractTransformer $transformer): array
-    {
-        // create some objects:
-        $manager  = new Manager();
-        $baseUrl  = sprintf('%s/api/v1', request()->getSchemeAndHttpHost());
-        $manager->setSerializer(new JsonApiSerializer($baseUrl));
-
-        $transformer->collectMetaData(new Collection([$object]));
-
-        $resource = new Item($object, $transformer, $key);
-
-        return $manager->createData($resource)->toArray();
-    }
 }

app/Api/V1/Controllers/Data/Bulk/AccountController.php

@@ -0,0 +1,52 @@
+<?php
+declare(strict_types=1);
+
+namespace FireflyIII\Api\V1\Controllers\Data\Bulk;
+
+
+use FireflyIII\Api\V1\Controllers\Controller;
+use FireflyIII\Api\V1\Requests\Data\Bulk\MoveTransactionsRequest;
+use FireflyIII\Repositories\Account\AccountRepositoryInterface;
+use FireflyIII\Services\Internal\Destroy\AccountDestroyService;
+use Illuminate\Http\JsonResponse;
+
+/**
+ * Class AccountController
+ */
+class AccountController extends Controller
+{
+    private AccountRepositoryInterface $repository;
+
+    public function __construct()
+    {
+        parent::__construct();
+        $this->middleware(
+            function ($request, $next) {
+                $this->repository = app(AccountRepositoryInterface::class);
+                $this->repository->setUser(auth()->user());
+
+                return $next($request);
+            }
+        );
+    }
+
+    /**
+     * @param MoveTransactionsRequest $request
+     *
+     * @return JsonResponse
+     */
+    public function moveTransactions(MoveTransactionsRequest $request): JsonResponse
+    {
+        $accountIds  = $request->getAll();
+        $original    = $this->repository->findNull($accountIds['original_account']);
+        $destination = $this->repository->findNull($accountIds['destination_account']);
+
+        /** @var AccountDestroyService $service */
+        $service = app(AccountDestroyService::class);
+        $service->moveTransactions($original, $destination);
+
+        return response()->json([], 204);
+
+    }
+
+}

app/Api/V1/Controllers/Data/Bulk/TransactionController.php

@@ -1,91 +0,0 @@
-<?php
-
-/*
- * TransactionController.php
- * Copyright (c) 2021 james@firefly-iii.org
- *
- * This file is part of Firefly III (https://github.com/firefly-iii).
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-declare(strict_types=1);
-
-namespace FireflyIII\Api\V1\Controllers\Data\Bulk;
-
-use FireflyIII\Api\V1\Controllers\Controller;
-use FireflyIII\Api\V1\Requests\Data\Bulk\TransactionRequest;
-use FireflyIII\Repositories\Account\AccountRepositoryInterface;
-use FireflyIII\Services\Internal\Destroy\AccountDestroyService;
-use Illuminate\Http\JsonResponse;
-
-/**
- * Class TransactionController
- *
- * Endpoint to update transactions by submitting
- * (optional) a "where" clause and an "update"
- * clause.
- *
- * Because this is a security nightmare waiting to happen validation
- * is pretty strict.
- */
-class TransactionController extends Controller
-{
-    private AccountRepositoryInterface $repository;
-
-    public function __construct()
-    {
-        parent::__construct();
-        $this->middleware(
-            function ($request, $next) {
-                $this->repository = app(AccountRepositoryInterface::class);
-                $this->repository->setUser(auth()->user());
-
-                return $next($request);
-            }
-        );
-    }
-
-    /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/bulkUpdateTransactions
-     */
-    public function update(TransactionRequest $request): JsonResponse
-    {
-        $query  = $request->getAll();
-        $params = $query['query'];
-
-        // this deserves better code, but for now a loop of basic if-statements
-        // to respond to what is in the $query.
-        // this is OK because only one thing can be in the query at the moment.
-        if ($this->isUpdateTransactionAccount($params)) {
-            $original    = $this->repository->find((int) $params['where']['account_id']);
-            $destination = $this->repository->find((int) $params['update']['account_id']);
-
-            /** @var AccountDestroyService $service */
-            $service     = app(AccountDestroyService::class);
-            $service->moveTransactions($original, $destination);
-        }
-
-        return response()->json([], 204);
-    }
-
-    /**
-     * @param array<string, array<string, string>> $params
-     */
-    private function isUpdateTransactionAccount(array $params): bool
-    {
-        return array_key_exists('account_id', $params['where']) && array_key_exists('account_id', $params['update']);
-    }
-}

app/Api/V1/Controllers/Data/DestroyController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * DestroyController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -26,11 +25,11 @@ namespace FireflyIII\Api\V1\Controllers\Data;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Data\DestroyRequest;
-use FireflyIII\Enums\AccountTypeEnum;
-use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\Account;
+use FireflyIII\Models\AccountType;
 use FireflyIII\Models\TransactionJournal;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Repositories\Bill\BillRepositoryInterface;
 use FireflyIII\Repositories\Budget\AvailableBudgetRepositoryInterface;
@@ -46,66 +45,135 @@ use FireflyIII\Repositories\Tag\TagRepositoryInterface;
 use FireflyIII\Services\Internal\Destroy\AccountDestroyService;
 use FireflyIII\Services\Internal\Destroy\JournalDestroyService;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Support\Facades\Log;
 
 /**
  * Class DestroyController
  */
 class DestroyController extends Controller
 {
-    private bool $unused;
-
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/destroyData
+     * @param DestroyRequest $request
      *
+     * @return JsonResponse
      * @throws FireflyException
      */
     public function destroy(DestroyRequest $request): JsonResponse
     {
-        $objects         = $request->getObjects();
-        $this->unused    = $request->boolean('unused', false);
+        $objects = $request->getObjects();
 
-        $allExceptAssets = [AccountTypeEnum::BENEFICIARY->value, AccountTypeEnum::CASH->value, AccountTypeEnum::CREDITCARD->value, AccountTypeEnum::DEFAULT->value, AccountTypeEnum::EXPENSE->value, AccountTypeEnum::IMPORT->value, AccountTypeEnum::INITIAL_BALANCE->value, AccountTypeEnum::LIABILITY_CREDIT->value, AccountTypeEnum::RECONCILIATION->value, AccountTypeEnum::REVENUE->value];
-        $all             = [AccountTypeEnum::ASSET->value, AccountTypeEnum::BENEFICIARY->value, AccountTypeEnum::CASH->value, AccountTypeEnum::CREDITCARD->value, AccountTypeEnum::DEBT->value, AccountTypeEnum::DEFAULT->value, AccountTypeEnum::EXPENSE->value, AccountTypeEnum::IMPORT->value, AccountTypeEnum::INITIAL_BALANCE->value, AccountTypeEnum::LIABILITY_CREDIT->value, AccountTypeEnum::LOAN->value, AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::RECONCILIATION->value];
-        $liabilities     = [AccountTypeEnum::DEBT->value, AccountTypeEnum::LOAN->value, AccountTypeEnum::MORTGAGE->value, AccountTypeEnum::CREDITCARD->value];
-        $transactions    = [TransactionTypeEnum::WITHDRAWAL->value, TransactionTypeEnum::DEPOSIT->value, TransactionTypeEnum::TRANSFER->value, TransactionTypeEnum::RECONCILIATION->value];
-
-        match ($objects) {
-            'budgets'                => $this->destroyBudgets(),
-            'bills'                  => $this->destroyBills(),
-            'piggy_banks'            => $this->destroyPiggyBanks(),
-            'rules'                  => $this->destroyRules(),
-            'recurring'              => $this->destroyRecurringTransactions(),
-            'categories'             => $this->destroyCategories(),
-            'tags'                   => $this->destroyTags(),
-            'object_groups'          => $this->destroyObjectGroups(),
-            'not_assets_liabilities' => $this->destroyAccounts($allExceptAssets),
-            'accounts'               => $this->destroyAccounts($all),
-            'asset_accounts'         => $this->destroyAccounts([AccountTypeEnum::ASSET->value, AccountTypeEnum::DEFAULT->value]),
-            'expense_accounts'       => $this->destroyAccounts([AccountTypeEnum::BENEFICIARY->value, AccountTypeEnum::EXPENSE->value]),
-            'revenue_accounts'       => $this->destroyAccounts([AccountTypeEnum::REVENUE->value]),
-            'liabilities'            => $this->destroyAccounts($liabilities),
-            'transactions'           => $this->destroyTransactions($transactions),
-            'withdrawals'            => $this->destroyTransactions([TransactionTypeEnum::WITHDRAWAL->value]),
-            'deposits'               => $this->destroyTransactions([TransactionTypeEnum::DEPOSIT->value]),
-            'transfers'              => $this->destroyTransactions([TransactionTypeEnum::TRANSFER->value]),
-            default                  => throw new FireflyException(sprintf('200033: This endpoint can\'t handle object "%s"', $objects)),
-        };
-
-        app('preferences')->mark();
+        switch ($objects) {
+            default:
+                throw new FireflyException(sprintf('This endpoint can\'t handle object "%s"', $objects));
+            case 'budgets':
+                $this->destroyBudgets();
+                break;
+            case 'bills':
+                $this->destroyBills();
+                break;
+            case 'piggy_banks':
+                $this->destroyPiggyBanks();
+                break;
+            case 'rules':
+                $this->destroyRules();
+                break;
+            case 'recurring':
+                $this->destroyRecurringTransactions();
+                break;
+            case 'categories':
+                $this->destroyCategories();
+                break;
+            case 'tags':
+                $this->destroyTags();
+                break;
+            case 'object_groups':
+                $this->destroyObjectGroups();
+                break;
+            case 'accounts':
+                $this->destroyAccounts(
+                    [
+                        AccountType::ASSET, AccountType::DEFAULT,
+                        AccountType::BENEFICIARY, AccountType::EXPENSE,
+                        AccountType::REVENUE, AccountType::INITIAL_BALANCE,
+                        AccountType::DEBT, AccountType::LOAN, AccountType::MORTGAGE, AccountType::CREDITCARD,
+                    ]
+                );
+                break;
+            case 'asset_accounts':
+                $this->destroyAccounts(
+                    [
+                        AccountType::ASSET, AccountType::DEFAULT,
+                    ]
+                );
+                break;
+            case 'expense_accounts':
+                $this->destroyAccounts(
+                    [
+                        AccountType::BENEFICIARY, AccountType::EXPENSE,
+                    ]
+                );
+                break;
+            case 'revenue_accounts':
+                $this->destroyAccounts(
+                    [
+                        AccountType::REVENUE,
+                    ]
+                );
+                break;
+            case 'liabilities':
+                $this->destroyAccounts(
+                    [
+                        AccountType::DEBT, AccountType::LOAN, AccountType::MORTGAGE, AccountType::CREDITCARD,
+                    ]
+                );
+                break;
+            case 'transactions':
+                $this->destroyTransactions(
+                    [
+                        TransactionType::WITHDRAWAL,
+                        TransactionType::DEPOSIT,
+                        TransactionType::TRANSFER,
+                        TransactionType::RECONCILIATION,
+                        TransactionType::OPENING_BALANCE,
+                    ]
+                );
+                break;
+            case 'withdrawals':
+                $this->destroyTransactions(
+                    [
+                        TransactionType::WITHDRAWAL,
+                    ]
+                );
+                break;
+            case 'deposits':
+                $this->destroyTransactions(
+                    [
+                        TransactionType::DEPOSIT,
+                    ]
+                );
+                break;
+            case 'transfers':
+                $this->destroyTransactions(
+                    [
+                        TransactionType::TRANSFER,
+                    ]
+                );
+                break;
+        }
 
         return response()->json([], 204);
     }
 
+    /**
+     *
+     */
     private function destroyBudgets(): void
     {
         /** @var AvailableBudgetRepositoryInterface $abRepository */
-        $abRepository     = app(AvailableBudgetRepositoryInterface::class);
+        $abRepository = app(AvailableBudgetRepositoryInterface::class);
         $abRepository->destroyAll();
 
         /** @var BudgetLimitRepositoryInterface $blRepository */
-        $blRepository     = app(BudgetLimitRepositoryInterface::class);
+        $blRepository = app(BudgetLimitRepositoryInterface::class);
         $blRepository->destroyAll();
 
         /** @var BudgetRepositoryInterface $budgetRepository */
@@ -113,6 +181,9 @@ class DestroyController extends Controller
         $budgetRepository->destroyAll();
     }
 
+    /**
+     *
+     */
     private function destroyBills(): void
     {
         /** @var BillRepositoryInterface $repository */
@@ -120,6 +191,9 @@ class DestroyController extends Controller
         $repository->destroyAll();
     }
 
+    /**
+     *
+     */
     private function destroyPiggyBanks(): void
     {
         /** @var PiggyBankRepositoryInterface $repository */
@@ -127,6 +201,9 @@ class DestroyController extends Controller
         $repository->destroyAll();
     }
 
+    /**
+     *
+     */
     private function destroyRules(): void
     {
         /** @var RuleGroupRepositoryInterface $repository */
@@ -134,6 +211,9 @@ class DestroyController extends Controller
         $repository->destroyAll();
     }
 
+    /**
+     *
+     */
     private function destroyRecurringTransactions(): void
     {
         /** @var RecurringRepositoryInterface $repository */
@@ -141,6 +221,9 @@ class DestroyController extends Controller
         $repository->destroyAll();
     }
 
+    /**
+     *
+     */
     private function destroyCategories(): void
     {
         /** @var CategoryRepositoryInterface $categoryRepos */
@@ -148,6 +231,9 @@ class DestroyController extends Controller
         $categoryRepos->destroyAll();
     }
 
+    /**
+     *
+     */
     private function destroyTags(): void
     {
         /** @var TagRepositoryInterface $tagRepository */
@@ -163,7 +249,7 @@ class DestroyController extends Controller
     }
 
     /**
-     * @param array<int, string> $types
+     * @param array $types
      */
     private function destroyAccounts(array $types): void
     {
@@ -171,27 +257,14 @@ class DestroyController extends Controller
         $repository = app(AccountRepositoryInterface::class);
         $collection = $repository->getAccountsByType($types);
         $service    = app(AccountDestroyService::class);
-
         /** @var Account $account */
         foreach ($collection as $account) {
-            $count = $account->transactions()->count();
-            if (true === $this->unused && 0 === $count) {
-                app('log')->info(sprintf('Deleted unused account #%d "%s"', $account->id, $account->name));
-                Log::channel('audit')->info(sprintf('Deleted unused account #%d "%s"', $account->id, $account->name));
-                $service->destroy($account, null);
-
-                continue;
-            }
-            if (false === $this->unused) {
-                app('log')->info(sprintf('Deleting account #%d "%s"', $account->id, $account->name));
-                Log::channel('audit')->warning(sprintf('Deleted account #%d "%s"', $account->id, $account->name));
-                $service->destroy($account, null);
-            }
+            $service->destroy($account, null);
         }
     }
 
     /**
-     * @param array<int, string> $types
+     * @param array $types
      */
     private function destroyTransactions(array $types): void
     {
@@ -199,10 +272,10 @@ class DestroyController extends Controller
         $repository = app(JournalRepositoryInterface::class);
         $journals   = $repository->findByType($types);
         $service    = app(JournalDestroyService::class);
-
         /** @var TransactionJournal $journal */
         foreach ($journals as $journal) {
             $service->destroy($journal);
         }
     }
+
 }

app/Api/V1/Controllers/Data/Export/ExportController.php

@@ -1,7 +1,7 @@
 <?php
-
+declare(strict_types=1);
 /*
- * ExportController.php
+ * AccountController.php
  * Copyright (c) 2021 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
@@ -20,15 +20,13 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-declare(strict_types=1);
-
 namespace FireflyIII\Api\V1\Controllers\Data\Export;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Data\Export\ExportRequest;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Support\Export\ExportDataGenerator;
 use Illuminate\Http\Response as LaravelResponse;
+use League\Csv\CannotInsertRecord;
 
 /**
  * Class ExportController
@@ -54,22 +52,24 @@ class ExportController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportAccounts
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
-     *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function accounts(ExportRequest $request): LaravelResponse
     {
         $this->exporter->setExportAccounts(true);
 
         return $this->returnExport('accounts');
+
     }
 
     /**
-     * @throws FireflyException
+     * @param string $key
+     *
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     private function returnExport(string $key): LaravelResponse
     {
@@ -82,25 +82,22 @@ class ExportController extends Controller
         $response
             ->header('Content-Description', 'File Transfer')
             ->header('Content-Type', 'application/octet-stream')
-            ->header('Content-Disposition', 'attachment; filename='.$fileName)
+            ->header('Content-Disposition', 'attachment; filename=' . $fileName)
             ->header('Content-Transfer-Encoding', 'binary')
             ->header('Connection', 'Keep-Alive')
             ->header('Expires', '0')
             ->header('Cache-Control', 'must-revalidate, post-check=0, pre-check=0')
             ->header('Pragma', 'public')
-            ->header('Content-Length', (string) strlen($data[$key]))
-        ;
+            ->header('Content-Length', (string)strlen($data[$key]));
 
         return $response;
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportBills
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
-     *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function bills(ExportRequest $request): LaravelResponse
     {
@@ -110,12 +107,10 @@ class ExportController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportBudgets
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
-     *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function budgets(ExportRequest $request): LaravelResponse
     {
@@ -125,12 +120,10 @@ class ExportController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportCategories
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
-     *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function categories(ExportRequest $request): LaravelResponse
     {
@@ -140,12 +133,10 @@ class ExportController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportPiggies
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
-     *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function piggyBanks(ExportRequest $request): LaravelResponse
     {
@@ -155,12 +146,10 @@ class ExportController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportRecurring
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
-     *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function recurring(ExportRequest $request): LaravelResponse
     {
@@ -170,12 +159,10 @@ class ExportController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportRules
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
-     *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function rules(ExportRequest $request): LaravelResponse
     {
@@ -185,12 +172,10 @@ class ExportController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportTags
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
-     *
-     * @SuppressWarnings("PHPMD.UnusedFormalParameter")
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function tags(ExportRequest $request): LaravelResponse
     {
@@ -200,10 +185,10 @@ class ExportController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/exportTransactions
+     * @param ExportRequest $request
      *
-     * @throws FireflyException
+     * @return LaravelResponse
+     * @throws CannotInsertRecord
      */
     public function transactions(ExportRequest $request): LaravelResponse
     {
@@ -215,4 +200,5 @@ class ExportController extends Controller
 
         return $this->returnExport('transactions');
     }
+
 }

app/Api/V1/Controllers/Data/PurgeController.php

@@ -1,104 +0,0 @@
-<?php
-
-/*
- * PurgeController.php
- * Copyright (c) 2022 james@firefly-iii.org
- *
- * This file is part of Firefly III (https://github.com/firefly-iii).
- *
- * This program is free software: you can redistribute it and/or modify
- * it under the terms of the GNU Affero General Public License as
- * published by the Free Software Foundation, either version 3 of the
- * License, or (at your option) any later version.
- *
- * This program is distributed in the hope that it will be useful,
- * but WITHOUT ANY WARRANTY; without even the implied warranty of
- * MERCHANTABILITY or FITNESS FOR A PARTICULAR PURPOSE.  See the
- * GNU Affero General Public License for more details.
- *
- * You should have received a copy of the GNU Affero General Public License
- * along with this program.  If not, see <https://www.gnu.org/licenses/>.
- */
-
-declare(strict_types=1);
-
-namespace FireflyIII\Api\V1\Controllers\Data;
-
-use FireflyIII\Api\V1\Controllers\Controller;
-use FireflyIII\Models\Account;
-use FireflyIII\Models\Bill;
-use FireflyIII\Models\Budget;
-use FireflyIII\Models\Category;
-use FireflyIII\Models\Recurrence;
-use FireflyIII\Models\Rule;
-use FireflyIII\Models\RuleGroup;
-use FireflyIII\Models\Tag;
-use FireflyIII\Models\TransactionGroup;
-use FireflyIII\Models\TransactionJournal;
-use FireflyIII\Repositories\PiggyBank\PiggyBankRepositoryInterface;
-use FireflyIII\User;
-use Illuminate\Http\JsonResponse;
-
-/**
- * Class PurgeController
- */
-class PurgeController extends Controller
-{
-    /**
-     * TODO cleanup and use repositories.
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/data/purgeData
-     */
-    public function purge(): JsonResponse
-    {
-        /** @var User $user */
-        $user       = auth()->user();
-
-        // some manual code, too lazy to call all repositories.
-
-        // budgets:
-        Budget::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // bills
-        Bill::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // piggies
-        $repository = app(PiggyBankRepositoryInterface::class);
-        $repository->setUser($user);
-        $repository->purgeAll();
-        //        $set  = PiggyBank::leftJoin('accounts', 'accounts.id', 'piggy_banks.account_id')
-        //            ->where('accounts.user_id', $user->id)->onlyTrashed()->get(['piggy_banks.*'])
-        //        ;
-        //
-        //        /** @var PiggyBank $piggy */
-        //        foreach ($set as $piggy) {
-        //            $piggy->forceDelete();
-        //        }
-
-        // rule group
-        RuleGroup::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // rules
-        Rule::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // recurring transactions
-        Recurrence::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // categories
-        Category::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // tags
-        Tag::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // accounts
-        Account::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // transaction groups
-        TransactionGroup::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        // transaction journals
-        TransactionJournal::whereUserId($user->id)->onlyTrashed()->forceDelete();
-
-        return response()->json([], 204);
-    }
-}

app/Api/V1/Controllers/Insight/Expense/AccountController.php

@@ -28,34 +28,42 @@ use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Repositories\Account\OperationsRepositoryInterface;
+use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Support\Http\Api\ApiSupport;
 use Illuminate\Http\JsonResponse;
 
 /**
+ *
  * Class AccountController
  *
  * Shows expense information grouped or limited by date.
- * I.e. all expenses grouped by account + currency.
+ * Ie. all expenses grouped by account + currency.
  */
 class AccountController extends Controller
 {
     use ApiSupport;
 
+    private CurrencyRepositoryInterface   $currencyRepository;
     private OperationsRepositoryInterface $opsRepository;
     private AccountRepositoryInterface    $repository;
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
         parent::__construct();
         $this->middleware(
             function ($request, $next) {
-                $user                = auth()->user();
-                $this->repository    = app(AccountRepositoryInterface::class);
+                $user             = auth()->user();
+                $this->repository = app(AccountRepositoryInterface::class);
                 $this->repository->setUser($user);
 
+                $this->currencyRepository = app(CurrencyRepositoryInterface::class);
+                $this->currencyRepository->setUser($user);
+
                 $this->opsRepository = app(OperationsRepositoryInterface::class);
                 $this->opsRepository->setUser($user);
 
@@ -65,8 +73,9 @@ class AccountController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseAsset
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function asset(GenericRequest $request): JsonResponse
     {
@@ -79,11 +88,11 @@ class AccountController extends Controller
         /** @var array $expense */
         foreach ($expenses as $expense) {
             $result[] = [
-                'id'               => (string) $expense['id'],
+                'id'               => (string)$expense['id'],
                 'name'             => $expense['name'],
                 'difference'       => $expense['sum'],
-                'difference_float' => (float) $expense['sum'], // intentional float
-                'currency_id'      => (string) $expense['currency_id'],
+                'difference_float' => (float)$expense['sum'],
+                'currency_id'      => (string)$expense['currency_id'],
                 'currency_code'    => $expense['currency_code'],
             ];
         }
@@ -92,8 +101,9 @@ class AccountController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseExpense
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function expense(GenericRequest $request): JsonResponse
     {
@@ -107,15 +117,16 @@ class AccountController extends Controller
         /** @var array $expense */
         foreach ($expenses as $expense) {
             $result[] = [
-                'id'               => (string) $expense['id'],
+                'id'               => (string)$expense['id'],
                 'name'             => $expense['name'],
                 'difference'       => $expense['sum'],
-                'difference_float' => (float) $expense['sum'], // intentional float
-                'currency_id'      => (string) $expense['currency_id'],
+                'difference_float' => (float)$expense['sum'],
+                'currency_id'      => (string)$expense['currency_id'],
                 'currency_code'    => $expense['currency_code'],
             ];
         }
 
         return response()->json($result);
     }
+
 }

app/Api/V1/Controllers/Insight/Expense/BillController.php

@@ -1,7 +1,7 @@
 <?php
-
+declare(strict_types=1);
 /*
- * BillController.php
+ * PeriodController.php
  * Copyright (c) 2021 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
@@ -20,18 +20,14 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-declare(strict_types=1);
-
 namespace FireflyIII\Api\V1\Controllers\Insight\Expense;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
-use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\Repositories\Bill\BillRepositoryInterface;
-use FireflyIII\Support\Facades\Amount;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Support\Facades\Log;
 
 /**
  * Class BillController
@@ -58,20 +54,19 @@ class BillController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseBill
-     *
      * Expenses per bill, possibly filtered by bill and account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function bill(GenericRequest $request): JsonResponse
     {
-        $accounts        = $request->getAssetAccounts();
-        $bills           = $request->getBills();
-        $start           = $request->getStart();
-        $end             = $request->getEnd();
-        $convertToNative = Amount::convertToNative();
-        $default         = Amount::getNativeCurrency();
-        $response        = [];
+        $accounts = $request->getAssetAccounts();
+        $bills    = $request->getBills();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // get all bills:
         if (0 === $bills->count()) {
@@ -79,42 +74,39 @@ class BillController extends Controller
         }
 
         // collect all expenses in this period (regardless of type) by the given bills and accounts.
-        $collector       = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::WITHDRAWAL->value])->setRange($start, $end)->setSourceAccounts($accounts);
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::WITHDRAWAL])->setRange($start, $end)->setSourceAccounts($accounts);
         $collector->setBills($bills);
 
-        $genericSet      = $collector->getExtractedJournals();
+        $genericSet = $collector->getExtractedJournals();
         foreach ($genericSet as $journal) {
-            $billId       = (int) $journal['bill_id'];
-            $currencyId   = (int) $journal['currency_id'];
-            $currencyCode = $journal['currency_code'];
-            $field        = 'amount';
-
-            // use the native amount if the user wants to convert to native currency
-            if ($convertToNative && $currencyId !== $default->id) {
-                $currencyId   = $default->id;
-                $currencyCode = $default->code;
-                $field        = 'native_amount';
-            }
-            // use foreign amount when the foreign currency IS the default currency.
-            if ($convertToNative && $journal['currency_id'] !== $default->id && $default->id === $journal['foreign_currency_id']) {
-                $field = 'foreign_amount';
-            }
-            Log::debug(sprintf('Journal #%d in bill #%d will use %s (%s %s)', $journal['transaction_group_id'], $billId, $field, $currencyCode, $journal[$field] ?? '0'));
-
-            $key          = sprintf('%d-%d', $billId, $currencyId);
+            $billId            = (int)$journal['bill_id'];
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
+            $key               = sprintf('%d-%d', $billId, $currencyId);
+            $foreignKey        = sprintf('%d-%d', $billId, $foreignCurrencyId);
 
             if (0 !== $currencyId) {
-                $response[$key] ??= [
-                    'id'               => (string) $billId,
-                    'name'             => $journal['bill_name'],
-                    'difference'       => '0',
-                    'difference_float' => 0,
-                    'currency_id'      => (string) $currencyId,
-                    'currency_code'    => $currencyCode,
-                ];
-                $response[$key]['difference']       = bcadd($response[$key]['difference'], (string) ($journal[$field] ?? '0'));
-                $response[$key]['difference_float'] = (float) $response[$key]['difference']; // intentional float
+                $response[$key]                     = $response[$key] ?? [
+                        'id'               => (string)$billId,
+                        'name'             => $journal['bill_name'],
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$currencyId,
+                        'currency_code'    => $journal['currency_code'],
+                    ];
+                $response[$key]['difference']       = bcadd($response[$key]['difference'], $journal['amount']);
+                $response[$key]['difference_float'] = (float)$response[$key]['difference'];
+            }
+            if (0 !== $foreignCurrencyId) {
+                $response[$foreignKey]                     = $response[$foreignKey] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$foreignCurrencyId,
+                        'currency_code'    => $journal['foreign_currency_code'],
+                    ];
+                $response[$foreignKey]['difference']       = bcadd($response[$foreignKey]['difference'], $journal['foreign_amount']);
+                $response[$foreignKey]['difference_float'] = (float)$response[$foreignKey]['difference'];
             }
         }
 
@@ -122,56 +114,53 @@ class BillController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseNoBill
-     *
      * Expenses for no bill filtered by account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function noBill(GenericRequest $request): JsonResponse
     {
-        $accounts        = $request->getAssetAccounts();
-        $start           = $request->getStart();
-        $end             = $request->getEnd();
-        $convertToNative = Amount::convertToNative();
-        $default         = Amount::getNativeCurrency();
-        $response        = [];
+        $accounts = $request->getAssetAccounts();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // collect all expenses in this period (regardless of type) by the given bills and accounts.
-        $collector       = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::WITHDRAWAL->value])->setRange($start, $end)->setSourceAccounts($accounts);
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::WITHDRAWAL])->setRange($start, $end)->setSourceAccounts($accounts);
         $collector->withoutBill();
 
-        $genericSet      = $collector->getExtractedJournals();
+        $genericSet = $collector->getExtractedJournals();
 
         foreach ($genericSet as $journal) {
-            $currencyId   = (int) $journal['currency_id'];
-            $currencyCode = $journal['currency_code'];
-            $field        = 'amount';
-
-            // use the native amount if the user wants to convert to native currency
-            if ($convertToNative && $currencyId !== $default->id) {
-                $currencyId   = $default->id;
-                $currencyCode = $default->code;
-                $field        = 'native_amount';
-            }
-            // use foreign amount when the foreign currency IS the default currency.
-            if ($convertToNative && $journal['currency_id'] !== $default->id && $default->id === $journal['foreign_currency_id']) {
-                $field = 'foreign_amount';
-            }
-            Log::debug(sprintf('Journal #%d will use %s (%s %s)', $journal['transaction_group_id'], $field, $currencyCode, $journal[$field] ?? '0'));
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
             if (0 !== $currencyId) {
-                $response[$currencyId] ??= [
-                    'difference'       => '0',
-                    'difference_float' => 0,
-                    'currency_id'      => (string) $currencyId,
-                    'currency_code'    => $currencyCode,
-                ];
-                $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], (string) ($journal[$field] ?? '0'));
-                $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference']; // intentional float
+                $response[$currencyId]                     = $response[$currencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$currencyId,
+                        'currency_code'    => $journal['currency_code'],
+                    ];
+                $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], $journal['amount']);
+                $response[$currencyId]['difference_float'] = (float)$response[$currencyId]['difference'];
+            }
+            if (0 !== $foreignCurrencyId) {
+                $response[$foreignCurrencyId]                     = $response[$foreignCurrencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$foreignCurrencyId,
+                        'currency_code'    => $journal['foreign_currency_code'],
+                    ];
+                $response[$foreignCurrencyId]['difference']       = bcadd($response[$foreignCurrencyId]['difference'], $journal['foreign_amount']);
+                $response[$foreignCurrencyId]['difference_float'] = (float)$response[$foreignCurrencyId]['difference'];
             }
         }
 
         return response()->json(array_values($response));
     }
+
 }

app/Api/V1/Controllers/Insight/Expense/BudgetController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * BudgetController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -44,6 +43,8 @@ class BudgetController extends Controller
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -64,8 +65,9 @@ class BudgetController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseBudget
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function budget(GenericRequest $request): JsonResponse
     {
@@ -77,19 +79,17 @@ class BudgetController extends Controller
         if (0 === $budgets->count()) {
             $budgets = $this->repository->getActiveBudgets();
         }
-
         /** @var Budget $budget */
         foreach ($budgets as $budget) {
-            $expenses = $this->opsRepository->sumExpenses($start, $end, $assetAccounts, new Collection([$budget]));
-
+            $expenses = $this->opsRepository->sumExpenses($start, $end, $assetAccounts, new Collection([$budget]), null);
             /** @var array $expense */
             foreach ($expenses as $expense) {
                 $result[] = [
-                    'id'               => (string) $budget->id,
+                    'id'               => (string)$budget->id,
                     'name'             => $budget->name,
                     'difference'       => $expense['sum'],
-                    'difference_float' => (float) $expense['sum'], // intentional float
-                    'currency_id'      => (string) $expense['currency_id'],
+                    'difference_float' => (float)$expense['sum'],
+                    'currency_id'      => (string)$expense['currency_id'],
                     'currency_code'    => $expense['currency_code'],
                 ];
             }
@@ -99,8 +99,9 @@ class BudgetController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseNoBudget
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function noBudget(GenericRequest $request): JsonResponse
     {
@@ -108,18 +109,19 @@ class BudgetController extends Controller
         $end           = $request->getEnd();
         $assetAccounts = $request->getAssetAccounts();
         $result        = [];
-        $expenses      = $this->noRepository->sumExpenses($start, $end, $assetAccounts);
-
+        $expenses      = $this->noRepository->sumExpenses($start, $end, $assetAccounts, null);
         /** @var array $expense */
         foreach ($expenses as $expense) {
             $result[] = [
                 'difference'       => $expense['sum'],
-                'difference_float' => (float) $expense['sum'], // intentional float
-                'currency_id'      => (string) $expense['currency_id'],
+                'difference_float' => (float)$expense['sum'],
+                'currency_id'      => (string)$expense['currency_id'],
                 'currency_code'    => $expense['currency_code'],
             ];
         }
 
         return response()->json($result);
+
     }
+
 }

app/Api/V1/Controllers/Insight/Expense/CategoryController.php

@@ -44,6 +44,8 @@ class CategoryController extends Controller
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -64,8 +66,9 @@ class CategoryController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightTransferCategory
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function category(GenericRequest $request): JsonResponse
     {
@@ -77,19 +80,17 @@ class CategoryController extends Controller
         if (0 === $categories->count()) {
             $categories = $this->repository->getCategories();
         }
-
         /** @var Category $category */
         foreach ($categories as $category) {
             $expenses = $this->opsRepository->sumExpenses($start, $end, $assetAccounts, new Collection([$category]));
-
             /** @var array $expense */
             foreach ($expenses as $expense) {
                 $result[] = [
-                    'id'               => (string) $category->id,
+                    'id'               => (string)$category->id,
                     'name'             => $category->name,
                     'difference'       => $expense['sum'],
-                    'difference_float' => (float) $expense['sum'], // intentional float
-                    'currency_id'      => (string) $expense['currency_id'],
+                    'difference_float' => (float)$expense['sum'],
+                    'currency_id'      => (string)$expense['currency_id'],
                     'currency_code'    => $expense['currency_code'],
                 ];
             }
@@ -99,8 +100,9 @@ class CategoryController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightTransferNoCategory
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function noCategory(GenericRequest $request): JsonResponse
     {
@@ -109,17 +111,17 @@ class CategoryController extends Controller
         $assetAccounts = $request->getAssetAccounts();
         $result        = [];
         $expenses      = $this->noRepository->sumExpenses($start, $end, $assetAccounts);
-
         /** @var array $expense */
         foreach ($expenses as $expense) {
             $result[] = [
                 'difference'       => $expense['sum'],
-                'difference_float' => (float) $expense['sum'], // intentional float
-                'currency_id'      => (string) $expense['currency_id'],
+                'difference_float' => (float)$expense['sum'],
+                'currency_id'      => (string)$expense['currency_id'],
                 'currency_code'    => $expense['currency_code'],
             ];
         }
 
         return response()->json($result);
+
     }
 }

app/Api/V1/Controllers/Insight/Expense/PeriodController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * PeriodController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -26,68 +25,59 @@ namespace FireflyIII\Api\V1\Controllers\Insight\Expense;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
-use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
-use FireflyIII\Support\Facades\Amount;
+use FireflyIII\Models\TransactionType;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Support\Facades\Log;
 
 /**
  * Class PeriodController
  */
 class PeriodController extends Controller
 {
+
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseTotal
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function total(GenericRequest $request): JsonResponse
     {
-        $accounts        = $request->getAssetAccounts();
-        $start           = $request->getStart();
-        $end             = $request->getEnd();
-        $response        = [];
-        $convertToNative = Amount::convertToNative();
-        $default         = Amount::getNativeCurrency();
+        $accounts = $request->getAssetAccounts();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // collect all expenses in this period (regardless of type)
-        $collector       = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::WITHDRAWAL->value])->setRange($start, $end)->setSourceAccounts($accounts);
-        $genericSet      = $collector->getExtractedJournals();
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::WITHDRAWAL])->setRange($start, $end)->setSourceAccounts($accounts);
+        $genericSet = $collector->getExtractedJournals();
         foreach ($genericSet as $journal) {
-            // same code as many other sumExpense methods. I think this needs some kind of generic method.
-            $amount                                    = '0';
-            $currencyId                                = (int) $journal['currency_id'];
-            $currencyCode                              = $journal['currency_code'];
-            if ($convertToNative) {
-                $amount = Amount::getAmountFromJournal($journal);
-                if ($default->id !== (int) $journal['currency_id'] && $default->id !== (int) $journal['foreign_currency_id']) {
-                    $currencyId   = $default->id;
-                    $currencyCode = $default->code;
-                }
-                if ($default->id !== (int) $journal['currency_id'] && $default->id === (int) $journal['foreign_currency_id']) {
-                    $currencyId   = $journal['foreign_currency_id'];
-                    $currencyCode = $journal['foreign_currency_code'];
-                }
-                Log::debug(sprintf('[a] Add amount %s %s', $currencyCode, $amount));
-            }
-            if (!$convertToNative) {
-                // ignore the amount in foreign currency.
-                Log::debug(sprintf('[b] Add amount %s %s', $currencyCode, $journal['amount']));
-                $amount = $journal['amount'];
-            }
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
-
-            $response[$currencyId] ??= [
-                'difference'       => '0',
-                'difference_float' => 0,
-                'currency_id'      => (string) $currencyId,
-                'currency_code'    => $currencyCode,
-            ];
-            $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], $amount);
-            $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference']; // intentional float
+            if (0 !== $currencyId) {
+                $response[$currencyId]                     = $response[$currencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$currencyId,
+                        'currency_code'    => $journal['currency_code'],
+                    ];
+                $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], $journal['amount']);
+                $response[$currencyId]['difference_float'] = (float)$response[$currencyId]['difference'];
+            }
+            if (0 !== $foreignCurrencyId) {
+                $response[$foreignCurrencyId]                     = $response[$foreignCurrencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$foreignCurrencyId,
+                        'currency_code'    => $journal['foreign_currency_code'],
+                    ];
+                $response[$foreignCurrencyId]['difference']       = bcadd($response[$foreignCurrencyId]['difference'], $journal['foreign_amount']);
+                $response[$foreignCurrencyId]['difference_float'] = (float)$response[$foreignCurrencyId]['difference'];
+            }
         }
 
         return response()->json(array_values($response));
     }
+
 }

app/Api/V1/Controllers/Insight/Expense/TagController.php

@@ -1,7 +1,7 @@
 <?php
-
+declare(strict_types=1);
 /*
- * TagController.php
+ * PeriodController.php
  * Copyright (c) 2021 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
@@ -20,18 +20,14 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-declare(strict_types=1);
-
 namespace FireflyIII\Api\V1\Controllers\Insight\Expense;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
-use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\Repositories\Tag\TagRepositoryInterface;
-use FireflyIII\Support\Facades\Amount;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Support\Facades\Log;
 
 /**
  * Class TagController
@@ -57,76 +53,69 @@ class TagController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseNoTag
-     *
      * Expenses for no tag filtered by account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function noTag(GenericRequest $request): JsonResponse
     {
-        $accounts        = $request->getAssetAccounts();
-        $start           = $request->getStart();
-        $end             = $request->getEnd();
-        $response        = [];
-        $convertToNative = Amount::convertToNative();
-        $default         = Amount::getNativeCurrency();
+        $accounts = $request->getAssetAccounts();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // collect all expenses in this period (regardless of type) by the given bills and accounts.
-        $collector       = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::WITHDRAWAL->value])->setRange($start, $end)->setSourceAccounts($accounts);
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::WITHDRAWAL])->setRange($start, $end)->setSourceAccounts($accounts);
         $collector->withoutTags();
 
-        $genericSet      = $collector->getExtractedJournals();
+        $genericSet = $collector->getExtractedJournals();
 
         foreach ($genericSet as $journal) {
-            // same code as many other sumExpense methods. I think this needs some kind of generic method.
-            $amount                                    = '0';
-            $currencyId                                = (int) $journal['currency_id'];
-            $currencyCode                              = $journal['currency_code'];
-            if ($convertToNative) {
-                $amount = Amount::getAmountFromJournal($journal);
-                if ($default->id !== (int) $journal['currency_id'] && $default->id !== (int) $journal['foreign_currency_id']) {
-                    $currencyId   = $default->id;
-                    $currencyCode = $default->code;
-                }
-                if ($default->id !== (int) $journal['currency_id'] && $default->id === (int) $journal['foreign_currency_id']) {
-                    $currencyId   = $journal['foreign_currency_id'];
-                    $currencyCode = $journal['foreign_currency_code'];
-                }
-                Log::debug(sprintf('[a] Add amount %s %s', $currencyCode, $amount));
-            }
-            if (!$convertToNative) {
-                // ignore the amount in foreign currency.
-                Log::debug(sprintf('[b] Add amount %s %s', $currencyCode, $journal['amount']));
-                $amount = $journal['amount'];
-            }
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
-            $response[$currencyId] ??= [
-                'difference'       => '0',
-                'difference_float' => 0,
-                'currency_id'      => (string) $currencyId,
-                'currency_code'    => $currencyCode,
-            ];
-            $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], $amount);
-            $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference']; // float but on purpose.
+            if (0 !== $currencyId) {
+                $response[$currencyId]                     = $response[$currencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$currencyId,
+                        'currency_code'    => $journal['currency_code'],
+                    ];
+                $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], $journal['amount']);
+                $response[$currencyId]['difference_float'] = (float)$response[$currencyId]['difference'];
+            }
+            if (0 !== $foreignCurrencyId) {
+                $response[$foreignCurrencyId]                     = $response[$foreignCurrencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$foreignCurrencyId,
+                        'currency_code'    => $journal['foreign_currency_code'],
+                    ];
+                $response[$foreignCurrencyId]['difference']       = bcadd($response[$foreignCurrencyId]['difference'], $journal['foreign_amount']);
+                $response[$foreignCurrencyId]['difference_float'] = (float)$response[$foreignCurrencyId]['difference'];
+            }
         }
 
         return response()->json(array_values($response));
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightExpenseTag
-     *
      * Expenses per tag, possibly filtered by tag and account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function tag(GenericRequest $request): JsonResponse
     {
-        $accounts   = $request->getAssetAccounts();
-        $tags       = $request->getTags();
-        $start      = $request->getStart();
-        $end        = $request->getEnd();
-        $response   = [];
+        $accounts = $request->getAssetAccounts();
+        $tags     = $request->getTags();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // get all tags:
         if (0 === $tags->count()) {
@@ -134,15 +123,14 @@ class TagController extends Controller
         }
 
         // collect all expenses in this period (regardless of type) by the given bills and accounts.
-        $collector  = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::WITHDRAWAL->value])->setRange($start, $end)->setSourceAccounts($accounts);
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::WITHDRAWAL])->setRange($start, $end)->setSourceAccounts($accounts);
         $collector->setTags($tags);
         $genericSet = $collector->getExtractedJournals();
-
         /** @var array $journal */
         foreach ($genericSet as $journal) {
-            $currencyId        = (int) $journal['currency_id'];
-            $foreignCurrencyId = (int) $journal['foreign_currency_id'];
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
             /** @var array $tag */
             foreach ($journal['tags'] as $tag) {
@@ -152,32 +140,33 @@ class TagController extends Controller
 
                 // on currency ID
                 if (0 !== $currencyId) {
-                    $response[$key] ??= [
-                        'id'               => (string) $tagId,
-                        'name'             => $tag['name'],
-                        'difference'       => '0',
-                        'difference_float' => 0,
-                        'currency_id'      => (string) $currencyId,
-                        'currency_code'    => $journal['currency_code'],
-                    ];
+                    $response[$key]                     = $response[$key] ?? [
+                            'id'               => (string)$tagId,
+                            'name'             => $tag['name'],
+                            'difference'       => '0',
+                            'difference_float' => 0,
+                            'currency_id'      => (string)$currencyId,
+                            'currency_code'    => $journal['currency_code'],
+                        ];
                     $response[$key]['difference']       = bcadd($response[$key]['difference'], $journal['amount']);
-                    $response[$key]['difference_float'] = (float) $response[$key]['difference']; // float but on purpose.
+                    $response[$key]['difference_float'] = (float)$response[$key]['difference'];
                 }
 
                 // on foreign ID
                 if (0 !== $foreignCurrencyId) {
                     $response[$foreignKey]                     = $journal[$foreignKey] ?? [
-                        'difference'       => '0',
-                        'difference_float' => 0,
-                        'currency_id'      => (string) $foreignCurrencyId,
-                        'currency_code'    => $journal['foreign_currency_code'],
-                    ];
+                            'difference'       => '0',
+                            'difference_float' => 0,
+                            'currency_id'      => (string)$foreignCurrencyId,
+                            'currency_code'    => $journal['foreign_currency_code'],
+                        ];
                     $response[$foreignKey]['difference']       = bcadd($response[$foreignKey]['difference'], $journal['foreign_amount']);
-                    $response[$foreignKey]['difference_float'] = (float) $response[$foreignKey]['difference']; // float but on purpose.
+                    $response[$foreignKey]['difference_float'] = (float)$response[$foreignKey]['difference'];
                 }
             }
         }
 
         return response()->json(array_values($response));
     }
+
 }

app/Api/V1/Controllers/Insight/Income/AccountController.php

@@ -28,34 +28,43 @@ use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Repositories\Account\OperationsRepositoryInterface;
+use FireflyIII\Repositories\Currency\CurrencyRepositoryInterface;
 use FireflyIII\Support\Http\Api\ApiSupport;
 use Illuminate\Http\JsonResponse;
 
 /**
+ *
  * Class AccountController
  *
  * Shows income information grouped or limited by date.
- * I.e. all income grouped by account + currency.
+ * Ie. all income grouped by account + currency.
+ * TODO same code as Expense/AccountController.
  */
 class AccountController extends Controller
 {
     use ApiSupport;
 
+    private CurrencyRepositoryInterface   $currencyRepository;
     private OperationsRepositoryInterface $opsRepository;
     private AccountRepositoryInterface    $repository;
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
         parent::__construct();
         $this->middleware(
             function ($request, $next) {
-                $user                = auth()->user();
-                $this->repository    = app(AccountRepositoryInterface::class);
+                $user             = auth()->user();
+                $this->repository = app(AccountRepositoryInterface::class);
                 $this->repository->setUser($user);
 
+                $this->currencyRepository = app(CurrencyRepositoryInterface::class);
+                $this->currencyRepository->setUser($user);
+
                 $this->opsRepository = app(OperationsRepositoryInterface::class);
                 $this->opsRepository->setUser($user);
 
@@ -65,26 +74,27 @@ class AccountController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightIncomeAsset
+     * TODO same code as Expense/AccountController.
+     * TODO does not actually include the name of the expense account.
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function asset(GenericRequest $request): JsonResponse
     {
         $start         = $request->getStart();
         $end           = $request->getEnd();
         $assetAccounts = $request->getAssetAccounts();
-
         $income        = $this->opsRepository->sumIncomeByDestination($start, $end, $assetAccounts);
         $result        = [];
-
         /** @var array $entry */
         foreach ($income as $entry) {
             $result[] = [
-                'id'               => (string) $entry['id'],
+                'id'               => (string)$entry['id'],
                 'name'             => $entry['name'],
                 'difference'       => $entry['sum'],
-                'difference_float' => (float) $entry['sum'], // float but on purpose.
-                'currency_id'      => (string) $entry['currency_id'],
+                'difference_float' => (float)$entry['sum'],
+                'currency_id'      => (string)$entry['currency_id'],
                 'currency_code'    => $entry['currency_code'],
             ];
         }
@@ -93,8 +103,11 @@ class AccountController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightIncomeRevenue
+     * TODO does not actually include the name of the expense account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function revenue(GenericRequest $request): JsonResponse
     {
@@ -108,15 +121,16 @@ class AccountController extends Controller
         /** @var array $entry */
         foreach ($income as $entry) {
             $result[] = [
-                'id'               => (string) $entry['id'],
+                'id'               => (string)$entry['id'],
                 'name'             => $entry['name'],
                 'difference'       => $entry['sum'],
-                'difference_float' => (float) $entry['sum'], // float but on purpose.
-                'currency_id'      => (string) $entry['currency_id'],
+                'difference_float' => (float)$entry['sum'],
+                'currency_id'      => (string)$entry['currency_id'],
                 'currency_code'    => $entry['currency_code'],
             ];
         }
 
         return response()->json($result);
     }
+
 }

app/Api/V1/Controllers/Insight/Income/CategoryController.php

@@ -35,6 +35,7 @@ use Illuminate\Support\Collection;
 
 /**
  * Class CategoryController
+ * TODO same as opposing category controller
  */
 class CategoryController extends Controller
 {
@@ -44,6 +45,8 @@ class CategoryController extends Controller
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -64,8 +67,9 @@ class CategoryController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightIncomeCategory
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function category(GenericRequest $request): JsonResponse
     {
@@ -77,19 +81,17 @@ class CategoryController extends Controller
         if (0 === $categories->count()) {
             $categories = $this->repository->getCategories();
         }
-
         /** @var Category $category */
         foreach ($categories as $category) {
             $expenses = $this->opsRepository->sumIncome($start, $end, $assetAccounts, new Collection([$category]));
-
             /** @var array $expense */
             foreach ($expenses as $expense) {
                 $result[] = [
-                    'id'               => (string) $category->id,
+                    'id'               => (string)$category->id,
                     'name'             => $category->name,
                     'difference'       => $expense['sum'],
-                    'difference_float' => (float) $expense['sum'], // float but on purpose.
-                    'currency_id'      => (string) $expense['currency_id'],
+                    'difference_float' => (float)$expense['sum'],
+                    'currency_id'      => (string)$expense['currency_id'],
                     'currency_code'    => $expense['currency_code'],
                 ];
             }
@@ -99,8 +101,9 @@ class CategoryController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightIncomeNoCategory
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function noCategory(GenericRequest $request): JsonResponse
     {
@@ -109,17 +112,17 @@ class CategoryController extends Controller
         $assetAccounts = $request->getAssetAccounts();
         $result        = [];
         $expenses      = $this->noRepository->sumIncome($start, $end, $assetAccounts);
-
         /** @var array $expense */
         foreach ($expenses as $expense) {
             $result[] = [
                 'difference'       => $expense['sum'],
-                'difference_float' => (float) $expense['sum'], // float but on purpose.
-                'currency_id'      => (string) $expense['currency_id'],
+                'difference_float' => (float)$expense['sum'],
+                'currency_id'      => (string)$expense['currency_id'],
                 'currency_code'    => $expense['currency_code'],
             ];
         }
 
         return response()->json($result);
+
     }
 }

app/Api/V1/Controllers/Insight/Income/PeriodController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * PeriodController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -26,9 +25,8 @@ namespace FireflyIII\Api\V1\Controllers\Insight\Income;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
-use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
-use FireflyIII\Support\Facades\Amount;
+use FireflyIII\Models\TransactionType;
 use Illuminate\Http\JsonResponse;
 
 /**
@@ -36,49 +34,52 @@ use Illuminate\Http\JsonResponse;
  */
 class PeriodController extends Controller
 {
+
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightIncomeTotal
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function total(GenericRequest $request): JsonResponse
     {
-        $accounts        = $request->getAssetAccounts();
-        $start           = $request->getStart();
-        $end             = $request->getEnd();
-        $response        = [];
-        $convertToNative = Amount::convertToNative();
-        $default         = Amount::getNativeCurrency();
+        $accounts = $request->getAssetAccounts();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // collect all expenses in this period (regardless of type)
-        $collector       = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::DEPOSIT->value])->setRange($start, $end)->setDestinationAccounts($accounts);
-        $genericSet      = $collector->getExtractedJournals();
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::DEPOSIT])->setRange($start, $end)->setDestinationAccounts($accounts);
+        $genericSet = $collector->getExtractedJournals();
         foreach ($genericSet as $journal) {
-            // currency
-            $currencyId                                = $journal['currency_id'];
-            $currencyCode                              = $journal['currency_code'];
-            $field                                     = $convertToNative && $currencyId !== $default->id ? 'native_amount' : 'amount';
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
-            // perhaps use default currency instead?
-            if ($convertToNative && $journal['currency_id'] !== $default->id) {
-                $currencyId   = $default->id;
-                $currencyCode = $default->code;
+            if (0 !== $currencyId) {
+                $response[$currencyId]                     = $response[$currencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$currencyId,
+                        'currency_code'    => $journal['currency_code'],
+                    ];
+                $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal['amount']));
+                $response[$currencyId]['difference_float'] = (float)$response[$currencyId]['difference'];
             }
-            // use foreign amount when the foreign currency IS the default currency.
-            if ($convertToNative && $journal['currency_id'] !== $default->id && $default->id === $journal['foreign_currency_id']) {
-                $field = 'foreign_amount';
+            if (0 !== $foreignCurrencyId) {
+                $response[$foreignCurrencyId]                     = $response[$foreignCurrencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$foreignCurrencyId,
+                        'currency_code'    => $journal['foreign_currency_code'],
+                    ];
+                $response[$foreignCurrencyId]['difference']       = bcadd(
+                    $response[$foreignCurrencyId]['difference'], app('steam')->positive($journal['foreign_amount'])
+                );
+                $response[$foreignCurrencyId]['difference_float'] = (float)$response[$foreignCurrencyId]['difference'];
             }
-
-            $response[$currencyId] ??= [
-                'difference'       => '0',
-                'difference_float' => 0,
-                'currency_id'      => (string) $currencyId,
-                'currency_code'    => $currencyCode,
-            ];
-            $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal[$field]));
-            $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference']; // float but on purpose.
         }
 
         return response()->json(array_values($response));
     }
+
 }

app/Api/V1/Controllers/Insight/Income/TagController.php

@@ -1,7 +1,7 @@
 <?php
-
+declare(strict_types=1);
 /*
- * TagController.php
+ * PeriodController.php
  * Copyright (c) 2021 james@firefly-iii.org
  *
  * This file is part of Firefly III (https://github.com/firefly-iii).
@@ -20,16 +20,13 @@
  * along with this program.  If not, see <https://www.gnu.org/licenses/>.
  */
 
-declare(strict_types=1);
-
 namespace FireflyIII\Api\V1\Controllers\Insight\Income;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
-use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\Repositories\Tag\TagRepositoryInterface;
-use FireflyIII\Support\Facades\Amount;
 use Illuminate\Http\JsonResponse;
 
 /**
@@ -57,70 +54,71 @@ class TagController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightIncomeTag
-     *
      * Expenses for no tag filtered by account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function noTag(GenericRequest $request): JsonResponse
     {
-        $accounts        = $request->getAssetAccounts();
-        $start           = $request->getStart();
-        $end             = $request->getEnd();
-        $response        = [];
-        $convertToNative = Amount::convertToNative();
-        $default         = Amount::getNativeCurrency();
+        $accounts = $request->getAssetAccounts();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // collect all expenses in this period (regardless of type) by the given bills and accounts.
-        $collector       = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::DEPOSIT->value])->setRange($start, $end)->setDestinationAccounts($accounts);
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::DEPOSIT])->setRange($start, $end)->setDestinationAccounts($accounts);
         $collector->withoutTags();
 
-        $genericSet      = $collector->getExtractedJournals();
+        $genericSet = $collector->getExtractedJournals();
 
         foreach ($genericSet as $journal) {
-            // currency
-            $currencyId                                = $journal['currency_id'];
-            $currencyCode                              = $journal['currency_code'];
-            $field                                     = $convertToNative && $currencyId !== $default->id ? 'native_amount' : 'amount';
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
-            // perhaps use default currency instead?
-            if ($convertToNative && $journal['currency_id'] !== $default->id) {
-                $currencyId   = $default->id;
-                $currencyCode = $default->code;
+            if (0 !== $currencyId) {
+                $response[$currencyId]                     = $response[$currencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$currencyId,
+                        'currency_code'    => $journal['currency_code'],
+                    ];
+                $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal['amount']));
+                $response[$currencyId]['difference_float'] = (float)$response[$currencyId]['difference'];
             }
-            // use foreign amount when the foreign currency IS the default currency.
-            if ($convertToNative && $journal['currency_id'] !== $default->id && $default->id === $journal['foreign_currency_id']) {
-                $field = 'foreign_amount';
+            if (0 !== $foreignCurrencyId) {
+                $response[$foreignCurrencyId]                     = $response[$foreignCurrencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$foreignCurrencyId,
+                        'currency_code'    => $journal['foreign_currency_code'],
+                    ];
+                $response[$foreignCurrencyId]['difference']       = bcadd(
+                    $response[$foreignCurrencyId]['difference'], app('steam')->positive($journal['foreign_amount'])
+                );
+                $response[$foreignCurrencyId]['difference_float'] = (float)$response[$foreignCurrencyId]['difference'];
             }
-
-            $response[$currencyId] ??= [
-                'difference'       => '0',
-                'difference_float' => 0,
-                'currency_id'      => (string) $currencyId,
-                'currency_code'    => $currencyCode,
-            ];
-            $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal[$field]));
-            $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference'];
-
         }
 
         return response()->json(array_values($response));
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightIncomeNoTag
-     *
      * Expenses per tag, possibly filtered by tag and account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function tag(GenericRequest $request): JsonResponse
     {
-        $accounts   = $request->getAssetAccounts();
-        $tags       = $request->getTags();
-        $start      = $request->getStart();
-        $end        = $request->getEnd();
-        $response   = [];
+        $accounts = $request->getAssetAccounts();
+        $tags     = $request->getTags();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // get all tags:
         if (0 === $tags->count()) {
@@ -128,15 +126,14 @@ class TagController extends Controller
         }
 
         // collect all expenses in this period (regardless of type) by the given bills and accounts.
-        $collector  = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::DEPOSIT->value])->setRange($start, $end)->setDestinationAccounts($accounts);
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::DEPOSIT])->setRange($start, $end)->setDestinationAccounts($accounts);
         $collector->setTags($tags);
         $genericSet = $collector->getExtractedJournals();
-
         /** @var array $journal */
         foreach ($genericSet as $journal) {
-            $currencyId        = (int) $journal['currency_id'];
-            $foreignCurrencyId = (int) $journal['foreign_currency_id'];
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
             /** @var array $tag */
             foreach ($journal['tags'] as $tag) {
@@ -146,35 +143,35 @@ class TagController extends Controller
 
                 // on currency ID
                 if (0 !== $currencyId) {
-                    $response[$key] ??= [
-                        'id'               => (string) $tagId,
-                        'name'             => $tag['name'],
-                        'difference'       => '0',
-                        'difference_float' => 0,
-                        'currency_id'      => (string) $currencyId,
-                        'currency_code'    => $journal['currency_code'],
-                    ];
+                    $response[$key]                     = $response[$key] ?? [
+                            'id'               => (string)$tagId,
+                            'name'             => $tag['name'],
+                            'difference'       => '0',
+                            'difference_float' => 0,
+                            'currency_id'      => (string)$currencyId,
+                            'currency_code'    => $journal['currency_code'],
+                        ];
                     $response[$key]['difference']       = bcadd($response[$key]['difference'], app('steam')->positive($journal['amount']));
-                    $response[$key]['difference_float'] = (float) $response[$key]['difference'];
+                    $response[$key]['difference_float'] = (float)$response[$key]['difference'];
                 }
 
                 // on foreign ID
                 if (0 !== $foreignCurrencyId) {
                     $response[$foreignKey]                     = $journal[$foreignKey] ?? [
-                        'difference'       => '0',
-                        'difference_float' => 0,
-                        'currency_id'      => (string) $foreignCurrencyId,
-                        'currency_code'    => $journal['foreign_currency_code'],
-                    ];
+                            'difference'       => '0',
+                            'difference_float' => 0,
+                            'currency_id'      => (string)$foreignCurrencyId,
+                            'currency_code'    => $journal['foreign_currency_code'],
+                        ];
                     $response[$foreignKey]['difference']       = bcadd(
-                        $response[$foreignKey]['difference'],
-                        app('steam')->positive($journal['foreign_amount'])
+                        $response[$foreignKey]['difference'], app('steam')->positive($journal['foreign_amount'])
                     );
-                    $response[$foreignKey]['difference_float'] = (float) $response[$foreignKey]['difference'];
+                    $response[$foreignKey]['difference_float'] = (float)$response[$foreignKey]['difference'];
                 }
             }
         }
 
         return response()->json(array_values($response));
     }
+
 }

app/Api/V1/Controllers/Insight/Transfer/AccountController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * AccountController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -41,6 +40,8 @@ class AccountController extends Controller
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -57,8 +58,12 @@ class AccountController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightTransfers
+     * TODO same code as Expense/AccountController.
+     * TODO does not actually include the name of the expense account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function asset(GenericRequest $request): JsonResponse
     {
@@ -66,7 +71,6 @@ class AccountController extends Controller
         $end           = $request->getEnd();
         $assetAccounts = $request->getAssetAccounts();
         $transfers     = $this->opsRepository->sumTransfers($start, $end, $assetAccounts);
-
         return response()->json($transfers);
     }
 }

app/Api/V1/Controllers/Insight/Transfer/CategoryController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * CategoryController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -44,6 +43,8 @@ class CategoryController extends Controller
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -64,8 +65,9 @@ class CategoryController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightTransferCategory
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function category(GenericRequest $request): JsonResponse
     {
@@ -77,19 +79,17 @@ class CategoryController extends Controller
         if (0 === $categories->count()) {
             $categories = $this->repository->getCategories();
         }
-
         /** @var Category $category */
         foreach ($categories as $category) {
             $expenses = $this->opsRepository->sumTransfers($start, $end, $assetAccounts, new Collection([$category]));
-
             /** @var array $expense */
             foreach ($expenses as $expense) {
                 $result[] = [
-                    'id'               => (string) $category->id,
+                    'id'               => (string)$category->id,
                     'name'             => $category->name,
                     'difference'       => $expense['sum'],
-                    'difference_float' => (float) $expense['sum'],
-                    'currency_id'      => (string) $expense['currency_id'],
+                    'difference_float' => (float)$expense['sum'],
+                    'currency_id'      => (string)$expense['currency_id'],
                     'currency_code'    => $expense['currency_code'],
                 ];
             }
@@ -99,8 +99,9 @@ class CategoryController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightTransferNoCategory
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function noCategory(GenericRequest $request): JsonResponse
     {
@@ -109,17 +110,17 @@ class CategoryController extends Controller
         $assetAccounts = $request->getAssetAccounts();
         $result        = [];
         $expenses      = $this->noRepository->sumTransfers($start, $end, $assetAccounts);
-
         /** @var array $expense */
         foreach ($expenses as $expense) {
             $result[] = [
                 'difference'       => $expense['sum'],
-                'difference_float' => (float) $expense['sum'],
-                'currency_id'      => (string) $expense['currency_id'],
+                'difference_float' => (float)$expense['sum'],
+                'currency_id'      => (string)$expense['currency_id'],
                 'currency_code'    => $expense['currency_code'],
             ];
         }
 
         return response()->json($result);
+
     }
 }

app/Api/V1/Controllers/Insight/Transfer/PeriodController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * PeriodController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -26,9 +25,8 @@ namespace FireflyIII\Api\V1\Controllers\Insight\Transfer;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
-use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
-use FireflyIII\Support\Facades\Amount;
+use FireflyIII\Models\TransactionType;
 use Illuminate\Http\JsonResponse;
 
 /**
@@ -36,50 +34,52 @@ use Illuminate\Http\JsonResponse;
  */
 class PeriodController extends Controller
 {
+
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightTransferTotal
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function total(GenericRequest $request): JsonResponse
     {
-        $accounts        = $request->getAssetAccounts();
-        $start           = $request->getStart();
-        $end             = $request->getEnd();
-        $response        = [];
-        $convertToNative = Amount::convertToNative();
-        $default         = Amount::getNativeCurrency();
+        $accounts = $request->getAssetAccounts();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // collect all expenses in this period (regardless of type)
-        $collector       = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::TRANSFER->value])->setRange($start, $end)->setDestinationAccounts($accounts);
-        $genericSet      = $collector->getExtractedJournals();
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::TRANSFER])->setRange($start, $end)->setDestinationAccounts($accounts);
+        $genericSet = $collector->getExtractedJournals();
         foreach ($genericSet as $journal) {
-            // currency
-            $currencyId                                = $journal['currency_id'];
-            $currencyCode                              = $journal['currency_code'];
-            $field                                     = $convertToNative && $currencyId !== $default->id ? 'native_amount' : 'amount';
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
-            // perhaps use default currency instead?
-            if ($convertToNative && $journal['currency_id'] !== $default->id) {
-                $currencyId   = $default->id;
-                $currencyCode = $default->code;
+            if (0 !== $currencyId) {
+                $response[$currencyId]                     = $response[$currencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$currencyId,
+                        'currency_code'    => $journal['currency_code'],
+                    ];
+                $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal['amount']));
+                $response[$currencyId]['difference_float'] = (float)$response[$currencyId]['difference'];
             }
-            // use foreign amount when the foreign currency IS the default currency.
-            if ($convertToNative && $journal['currency_id'] !== $default->id && $default->id === $journal['foreign_currency_id']) {
-                $field = 'foreign_amount';
+            if (0 !== $foreignCurrencyId) {
+                $response[$foreignCurrencyId]                     = $response[$foreignCurrencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$foreignCurrencyId,
+                        'currency_code'    => $journal['foreign_currency_code'],
+                    ];
+                $response[$foreignCurrencyId]['difference']       = bcadd(
+                    $response[$foreignCurrencyId]['difference'], app('steam')->positive($journal['foreign_amount'])
+                );
+                $response[$foreignCurrencyId]['difference_float'] = (float)$response[$foreignCurrencyId]['difference'];
             }
-
-            $response[$currencyId] ??= [
-                'difference'       => '0',
-                'difference_float' => 0,
-                'currency_id'      => (string) $currencyId,
-                'currency_code'    => $currencyCode,
-            ];
-            $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal[$field]));
-            $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference'];
-
         }
 
         return response()->json(array_values($response));
     }
+
 }

app/Api/V1/Controllers/Insight/Transfer/TagController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * TagController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -26,10 +25,9 @@ namespace FireflyIII\Api\V1\Controllers\Insight\Transfer;
 
 use FireflyIII\Api\V1\Controllers\Controller;
 use FireflyIII\Api\V1\Requests\Insight\GenericRequest;
-use FireflyIII\Enums\TransactionTypeEnum;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
+use FireflyIII\Models\TransactionType;
 use FireflyIII\Repositories\Tag\TagRepositoryInterface;
-use FireflyIII\Support\Facades\Amount;
 use Illuminate\Http\JsonResponse;
 
 /**
@@ -41,6 +39,7 @@ class TagController extends Controller
 
     /**
      * TagController constructor.
+     * TODO lots of copying and pasting here.
      */
     public function __construct()
     {
@@ -57,69 +56,71 @@ class TagController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightTransferNoTag
+     * Expenses for no tag filtered by account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function noTag(GenericRequest $request): JsonResponse
     {
-        $accounts        = $request->getAssetAccounts();
-        $start           = $request->getStart();
-        $end             = $request->getEnd();
-        $response        = [];
-        $convertToNative = Amount::convertToNative();
-        $default         = Amount::getNativeCurrency();
-
+        $accounts = $request->getAssetAccounts();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // collect all expenses in this period (regardless of type) by the given bills and accounts.
-        $collector       = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::TRANSFER->value])->setRange($start, $end)->setDestinationAccounts($accounts);
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::TRANSFER])->setRange($start, $end)->setDestinationAccounts($accounts);
         $collector->withoutTags();
 
-        $genericSet      = $collector->getExtractedJournals();
+        $genericSet = $collector->getExtractedJournals();
 
         foreach ($genericSet as $journal) {
-            // currency
-            $currencyId                                = $journal['currency_id'];
-            $currencyCode                              = $journal['currency_code'];
-            $field                                     = $convertToNative && $currencyId !== $default->id ? 'native_amount' : 'amount';
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
-            // perhaps use default currency instead?
-            if ($convertToNative && $journal['currency_id'] !== $default->id) {
-                $currencyId   = $default->id;
-                $currencyCode = $default->code;
+            if (0 !== $currencyId) {
+                $response[$currencyId]                     = $response[$currencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$currencyId,
+                        'currency_code'    => $journal['currency_code'],
+                    ];
+                $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal['amount']));
+                $response[$currencyId]['difference_float'] = (float)$response[$currencyId]['difference'];
             }
-            // use foreign amount when the foreign currency IS the default currency.
-            if ($convertToNative && $journal['currency_id'] !== $default->id && $default->id === $journal['foreign_currency_id']) {
-                $field = 'foreign_amount';
+            if (0 !== $foreignCurrencyId) {
+                $response[$foreignCurrencyId]                     = $response[$foreignCurrencyId] ?? [
+                        'difference'       => '0',
+                        'difference_float' => 0,
+                        'currency_id'      => (string)$foreignCurrencyId,
+                        'currency_code'    => $journal['foreign_currency_code'],
+                    ];
+                $response[$foreignCurrencyId]['difference']       = bcadd(
+                    $response[$foreignCurrencyId]['difference'], app('steam')->positive($journal['foreign_amount'])
+                );
+                $response[$foreignCurrencyId]['difference_float'] = (float)$response[$foreignCurrencyId]['difference'];
             }
-
-            $response[$currencyId] ??= [
-                'difference'       => '0',
-                'difference_float' => 0,
-                'currency_id'      => (string) $currencyId,
-                'currency_code'    => $currencyCode,
-            ];
-            $response[$currencyId]['difference']       = bcadd($response[$currencyId]['difference'], app('steam')->positive($journal[$field]));
-            $response[$currencyId]['difference_float'] = (float) $response[$currencyId]['difference'];
-
         }
 
         return response()->json(array_values($response));
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/insight/insightTransferTag
-     *
      * Transfers per tag, possibly filtered by tag and account.
+     *
+     * @param GenericRequest $request
+     *
+     * @return JsonResponse
      */
     public function tag(GenericRequest $request): JsonResponse
     {
-        $accounts   = $request->getAssetAccounts();
-        $tags       = $request->getTags();
-        $start      = $request->getStart();
-        $end        = $request->getEnd();
-        $response   = [];
+        $accounts = $request->getAssetAccounts();
+        $tags     = $request->getTags();
+        $start    = $request->getStart();
+        $end      = $request->getEnd();
+        $response = [];
 
         // get all tags:
         if (0 === $tags->count()) {
@@ -127,15 +128,14 @@ class TagController extends Controller
         }
 
         // collect all expenses in this period (regardless of type) by the given bills and accounts.
-        $collector  = app(GroupCollectorInterface::class);
-        $collector->setTypes([TransactionTypeEnum::TRANSFER->value])->setRange($start, $end)->setDestinationAccounts($accounts);
+        $collector = app(GroupCollectorInterface::class);
+        $collector->setTypes([TransactionType::TRANSFER])->setRange($start, $end)->setDestinationAccounts($accounts);
         $collector->setTags($tags);
         $genericSet = $collector->getExtractedJournals();
-
         /** @var array $journal */
         foreach ($genericSet as $journal) {
-            $currencyId        = (int) $journal['currency_id'];
-            $foreignCurrencyId = (int) $journal['foreign_currency_id'];
+            $currencyId        = (int)$journal['currency_id'];
+            $foreignCurrencyId = (int)$journal['foreign_currency_id'];
 
             /** @var array $tag */
             foreach ($journal['tags'] as $tag) {
@@ -145,31 +145,30 @@ class TagController extends Controller
 
                 // on currency ID
                 if (0 !== $currencyId) {
-                    $response[$key] ??= [
-                        'id'               => (string) $tagId,
-                        'name'             => $tag['name'],
-                        'difference'       => '0',
-                        'difference_float' => 0,
-                        'currency_id'      => (string) $currencyId,
-                        'currency_code'    => $journal['currency_code'],
-                    ];
+                    $response[$key]                     = $response[$key] ?? [
+                            'id'               => (string)$tagId,
+                            'name'             => $tag['name'],
+                            'difference'       => '0',
+                            'difference_float' => 0,
+                            'currency_id'      => (string)$currencyId,
+                            'currency_code'    => $journal['currency_code'],
+                        ];
                     $response[$key]['difference']       = bcadd($response[$key]['difference'], app('steam')->positive($journal['amount']));
-                    $response[$key]['difference_float'] = (float) $response[$key]['difference'];
+                    $response[$key]['difference_float'] = (float)$response[$key]['difference'];
                 }
 
                 // on foreign ID
                 if (0 !== $foreignCurrencyId) {
                     $response[$foreignKey]                     = $journal[$foreignKey] ?? [
-                        'difference'       => '0',
-                        'difference_float' => 0,
-                        'currency_id'      => (string) $foreignCurrencyId,
-                        'currency_code'    => $journal['foreign_currency_code'],
-                    ];
+                            'difference'       => '0',
+                            'difference_float' => 0,
+                            'currency_id'      => (string)$foreignCurrencyId,
+                            'currency_code'    => $journal['foreign_currency_code'],
+                        ];
                     $response[$foreignKey]['difference']       = bcadd(
-                        $response[$foreignKey]['difference'],
-                        app('steam')->positive($journal['foreign_amount'])
+                        $response[$foreignKey]['difference'], app('steam')->positive($journal['foreign_amount'])
                     );
-                    $response[$foreignKey]['difference_float'] = (float) $response[$foreignKey]['difference']; // intentional float
+                    $response[$foreignKey]['difference_float'] = (float)$response[$foreignKey]['difference'];
                 }
             }
         }

app/Api/V1/Controllers/Models/Account/DestroyController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * AccountController.php
  * Copyright (c) 2019 james@firefly-iii.org
@@ -34,12 +33,14 @@ use Illuminate\Http\JsonResponse;
  */
 class DestroyController extends Controller
 {
-    public const string RESOURCE_KEY = 'accounts';
+    public const RESOURCE_KEY = 'accounts';
 
     private AccountRepositoryInterface $repository;
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -55,15 +56,16 @@ class DestroyController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/accounts/deleteAccount
-     *
      * Remove the specified resource from storage.
+     *
+     * @param Account $account
+     *
+     * @codeCoverageIgnore
+     * @return JsonResponse
      */
     public function destroy(Account $account): JsonResponse
     {
         $this->repository->destroy($account, null);
-        app('preferences')->mark();
 
         return response()->json([], 204);
     }

app/Api/V1/Controllers/Models/Account/ListController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * AccountController.php
  * Copyright (c) 2019 james@firefly-iii.org
@@ -25,7 +24,6 @@ declare(strict_types=1);
 namespace FireflyIII\Api\V1\Controllers\Models\Account;
 
 use FireflyIII\Api\V1\Controllers\Controller;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Helpers\Collector\GroupCollectorInterface;
 use FireflyIII\Models\Account;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
@@ -48,12 +46,14 @@ class ListController extends Controller
 {
     use TransactionFilter;
 
-    public const string RESOURCE_KEY = 'accounts';
+    public const RESOURCE_KEY = 'accounts';
 
     private AccountRepositoryInterface $repository;
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -69,109 +69,115 @@ class ListController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/accounts/listAttachmentByAccount
+     * @param Account $account
      *
-     * @throws FireflyException
+     * @return JsonResponse
+     * @codeCoverageIgnore
      */
     public function attachments(Account $account): JsonResponse
     {
-        $manager     = $this->getManager();
-        $pageSize    = $this->parameters->get('limit');
-        $collection  = $this->repository->getAttachments($account);
+        $manager    = $this->getManager();
+        $pageSize   = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $collection = $this->repository->getAttachments($account);
 
         $count       = $collection->count();
         $attachments = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
 
         // make paginator:
-        $paginator   = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
-        $paginator->setPath(route('api.v1.accounts.attachments', [$account->id]).$this->buildParams());
+        $paginator = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.accounts.attachments', [$account->id]) . $this->buildParams());
 
         /** @var AttachmentTransformer $transformer */
         $transformer = app(AttachmentTransformer::class);
         $transformer->setParameters($this->parameters);
 
-        $resource    = new FractalCollection($attachments, $transformer, 'attachments');
+        $resource = new FractalCollection($attachments, $transformer, 'attachments');
         $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/accounts/listPiggyBankByAccount
+     * List all piggies.
      *
-     * @throws FireflyException
+     * @param Account $account
+     *
+     * @return JsonResponse
+     * @codeCoverageIgnore
      */
     public function piggyBanks(Account $account): JsonResponse
     {
         // create some objects:
-        $manager     = $this->getManager();
+        $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize    = $this->parameters->get('limit');
+        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
-        // get list of piggy banks. Count it and split it.
-        $collection  = $this->repository->getPiggyBanks($account);
-        $count       = $collection->count();
-        $piggyBanks  = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
+        // get list of budgets. Count it and split it.
+        $collection = $this->repository->getPiggyBanks($account);
+        $count      = $collection->count();
+        $piggyBanks = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
 
         // make paginator:
-        $paginator   = new LengthAwarePaginator($piggyBanks, $count, $pageSize, $this->parameters->get('page'));
-        $paginator->setPath(route('api.v1.accounts.piggy-banks', [$account->id]).$this->buildParams());
+        $paginator = new LengthAwarePaginator($piggyBanks, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.accounts.piggy_banks', [$account->id]) . $this->buildParams());
 
         /** @var PiggyBankTransformer $transformer */
         $transformer = app(PiggyBankTransformer::class);
         $transformer->setParameters($this->parameters);
 
-        $resource    = new FractalCollection($piggyBanks, $transformer, 'piggy_banks');
+        $resource = new FractalCollection($piggyBanks, $transformer, 'piggy_banks');
         $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
+
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/accounts/listTransactionByAccount
-     *
      * Show all transaction groups related to the account.
      *
-     * @throws FireflyException
+     * @codeCoverageIgnore
+     *
+     * @param Request $request
+     * @param Account $account
+     *
+     * @return JsonResponse
      */
     public function transactions(Request $request, Account $account): JsonResponse
     {
-        $pageSize    = $this->parameters->get('limit');
-        $type        = $request->get('type') ?? 'default';
+        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
+        $type     = $request->get('type') ?? 'default';
         $this->parameters->set('type', $type);
-        $types       = $this->mapTransactionTypes($this->parameters->get('type'));
-        $manager     = $this->getManager();
 
+        // user can overrule page size with limit parameter.
+        $limit = $this->parameters->get('limit');
+        if (null !== $limit && $limit > 0) {
+            $pageSize = $limit;
+        }
+        $types   = $this->mapTransactionTypes($this->parameters->get('type'));
+        $manager = $this->getManager();
         /** @var User $admin */
-        $admin       = auth()->user();
+        $admin = auth()->user();
 
         // use new group collector:
         /** @var GroupCollectorInterface $collector */
-        $collector   = app(GroupCollectorInterface::class);
+        $collector = app(GroupCollectorInterface::class);
         $collector->setUser($admin)->setAccounts(new Collection([$account]))
-            ->withAPIInformation()->setLimit($pageSize)->setPage($this->parameters->get('page'))->setTypes($types)
-        ;
+                  ->withAPIInformation()->setLimit($pageSize)->setPage($this->parameters->get('page'))->setTypes($types);
 
-        if (null !== $this->parameters->get('start')) {
-            $collector->setStart($this->parameters->get('start'));
-        }
-        if (null !== $this->parameters->get('end')) {
-            $collector->setEnd($this->parameters->get('end'));
+        if (null !== $this->parameters->get('start') && null !== $this->parameters->get('end')) {
+            $collector->setRange($this->parameters->get('start'), $this->parameters->get('end'));
         }
 
-        $paginator   = $collector->getPaginatedGroups();
-        $paginator->setPath(route('api.v1.accounts.transactions', [$account->id]).$this->buildParams());
-        $groups      = $paginator->getCollection();
+        $paginator = $collector->getPaginatedGroups();
+        $paginator->setPath(route('api.v1.accounts.transactions', [$account->id]) . $this->buildParams());
+        $groups = $paginator->getCollection();
 
         /** @var TransactionGroupTransformer $transformer */
         $transformer = app(TransactionGroupTransformer::class);
         $transformer->setParameters($this->parameters);
 
-        $resource    = new FractalCollection($groups, $transformer, 'transactions');
+        $resource = new FractalCollection($groups, $transformer, 'transactions');
         $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);

app/Api/V1/Controllers/Models/Account/ShowController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * ShowController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -25,7 +24,6 @@ declare(strict_types=1);
 namespace FireflyIII\Api\V1\Controllers\Models\Account;
 
 use FireflyIII\Api\V1\Controllers\Controller;
-use FireflyIII\Exceptions\FireflyException;
 use FireflyIII\Models\Account;
 use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Support\Http\Api\AccountFilter;
@@ -44,12 +42,14 @@ class ShowController extends Controller
 {
     use AccountFilter;
 
-    public const string RESOURCE_KEY = 'accounts';
+    public const RESOURCE_KEY = 'accounts';
 
     private AccountRepositoryInterface $repository;
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -65,64 +65,63 @@ class ShowController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/accounts/listAccount
-     *
      * Display a listing of the resource.
      *
-     * @throws FireflyException
+     * @param Request $request
+     *
+     * @codeCoverageIgnore
+     * @return JsonResponse
      */
     public function index(Request $request): JsonResponse
     {
-        $manager     = $this->getManager();
-        $type        = $request->get('type') ?? 'all';
+        $manager = $this->getManager();
+        $type    = $request->get('type') ?? 'all';
         $this->parameters->set('type', $type);
 
         // types to get, page size:
-        $types       = $this->mapAccountTypes($this->parameters->get('type'));
-        $pageSize    = $this->parameters->get('limit');
+        $types    = $this->mapAccountTypes($this->parameters->get('type'));
+        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of accounts. Count it and split it.
         $this->repository->resetAccountOrder();
-        $collection  = $this->repository->getAccountsByType($types, $this->parameters->get('sort') ?? []);
-        $count       = $collection->count();
-
-        // continue sort:
-
-        $accounts    = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
+        $collection = $this->repository->getAccountsByType($types);
+        $count      = $collection->count();
+        $accounts   = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
 
         // make paginator:
-        $paginator   = new LengthAwarePaginator($accounts, $count, $pageSize, $this->parameters->get('page'));
-        $paginator->setPath(route('api.v1.accounts.index').$this->buildParams());
+        $paginator = new LengthAwarePaginator($accounts, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.accounts.index') . $this->buildParams());
 
         /** @var AccountTransformer $transformer */
         $transformer = app(AccountTransformer::class);
         $transformer->setParameters($this->parameters);
 
-        $resource    = new FractalCollection($accounts, $transformer, self::RESOURCE_KEY);
+        $resource = new FractalCollection($accounts, $transformer, self::RESOURCE_KEY);
         $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/accounts/getAccount
-     *
      * Show single instance.
+     *
+     * @param Account $account
+     *
+     * @return JsonResponse
      */
     public function show(Account $account): JsonResponse
     {
         // get list of accounts. Count it and split it.
         $this->repository->resetAccountOrder();
         $account->refresh();
-        $manager     = $this->getManager();
+        $manager = $this->getManager();
 
         /** @var AccountTransformer $transformer */
         $transformer = app(AccountTransformer::class);
         $transformer->setParameters($this->parameters);
-        $resource    = new Item($account, $transformer, self::RESOURCE_KEY);
+        $resource = new Item($account, $transformer, self::RESOURCE_KEY);
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
     }
+
 }

app/Api/V1/Controllers/Models/Account/StoreController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * AccountController.php
  * Copyright (c) 2019 james@firefly-iii.org
@@ -36,12 +35,14 @@ use League\Fractal\Resource\Item;
  */
 class StoreController extends Controller
 {
-    public const string RESOURCE_KEY = 'accounts';
+    public const RESOURCE_KEY = 'accounts';
 
     private AccountRepositoryInterface $repository;
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -57,24 +58,26 @@ class StoreController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/accounts/storeAccount
-     *
      * Store a new instance.
+     *
+     * @param StoreRequest $request
+     *
+     * @return JsonResponse
      */
     public function store(StoreRequest $request): JsonResponse
     {
-        $data        = $request->getAllAccountData();
+        $data = $request->getAllAccountData();
         $this->repository->resetAccountOrder();
-        $account     = $this->repository->store($data);
-        $manager     = $this->getManager();
+        $account = $this->repository->store($data);
+        $manager = $this->getManager();
 
         /** @var AccountTransformer $transformer */
         $transformer = app(AccountTransformer::class);
         $transformer->setParameters($this->parameters);
 
-        $resource    = new Item($account, $transformer, self::RESOURCE_KEY);
+        $resource = new Item($account, $transformer, self::RESOURCE_KEY);
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
     }
+
 }

app/Api/V1/Controllers/Models/Account/UpdateController.php

@@ -1,5 +1,4 @@
 <?php
-
 /**
  * AccountController.php
  * Copyright (c) 2019 james@firefly-iii.org
@@ -31,18 +30,21 @@ use FireflyIII\Repositories\Account\AccountRepositoryInterface;
 use FireflyIII\Transformers\AccountTransformer;
 use Illuminate\Http\JsonResponse;
 use League\Fractal\Resource\Item;
+use Log;
 
 /**
  * Class UpdateController
  */
 class UpdateController extends Controller
 {
-    public const string RESOURCE_KEY = 'accounts';
+    public const RESOURCE_KEY = 'accounts';
 
     private AccountRepositoryInterface $repository;
 
     /**
      * AccountController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -58,25 +60,26 @@ class UpdateController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/accounts/updateAccount
-     *
      * Update account.
+     *
+     * @param UpdateRequest $request
+     * @param Account       $account
+     *
+     * @return JsonResponse
      */
     public function update(UpdateRequest $request, Account $account): JsonResponse
     {
-        app('log')->debug(sprintf('Now in %s', __METHOD__));
+        Log::debug(sprintf('Now in %s', __METHOD__));
         $data         = $request->getUpdateData();
-        $data['type'] = config('firefly.shortNamesByFullName.'.$account->accountType->type);
+        $data['type'] = config('firefly.shortNamesByFullName.' . $account->accountType->type);
         $account      = $this->repository->update($account, $data);
         $manager      = $this->getManager();
         $account->refresh();
-        app('preferences')->mark();
 
         /** @var AccountTransformer $transformer */
-        $transformer  = app(AccountTransformer::class);
+        $transformer = app(AccountTransformer::class);
         $transformer->setParameters($this->parameters);
-        $resource     = new Item($account, $transformer, self::RESOURCE_KEY);
+        $resource = new Item($account, $transformer, self::RESOURCE_KEY);
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
     }

app/Api/V1/Controllers/Models/Attachment/DestroyController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * DestroyController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -30,8 +29,6 @@ use FireflyIII\Models\Attachment;
 use FireflyIII\Repositories\Attachment\AttachmentRepositoryInterface;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
-use Illuminate\Support\Facades\Log;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 /**
  * Class DestroyController
@@ -42,6 +39,8 @@ class DestroyController extends Controller
 
     /**
      * DestroyController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -60,21 +59,17 @@ class DestroyController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/attachments/deleteAttachment
-     *
      * Remove the specified resource from storage.
+     *
+     * @codeCoverageIgnore
+     *
+     * @param Attachment $attachment
+     *
+     * @return JsonResponse
      */
     public function destroy(Attachment $attachment): JsonResponse
     {
-        if (true === auth()->user()->hasRole('demo')) {
-            Log::channel('audit')->warning(sprintf('Demo user tries to access attachment API in %s', __METHOD__));
-
-            throw new NotFoundHttpException();
-        }
-
         $this->repository->destroy($attachment);
-        app('preferences')->mark();
 
         return response()->json([], 204);
     }

app/Api/V1/Controllers/Models/Attachment/ShowController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * ShowController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -34,11 +33,9 @@ use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Response as LaravelResponse;
 use Illuminate\Pagination\LengthAwarePaginator;
-use Illuminate\Support\Facades\Log;
 use League\Fractal\Pagination\IlluminatePaginatorAdapter;
 use League\Fractal\Resource\Collection as FractalCollection;
 use League\Fractal\Resource\Item;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
 
 /**
  * Class ShowController
@@ -49,6 +46,8 @@ class ShowController extends Controller
 
     /**
      * ShowController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -67,20 +66,16 @@ class ShowController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/attachments/downloadAttachment
-     *
      * Download an attachment.
      *
-     * @throws FireflyException
+     * @param Attachment $attachment
+     *
+     * @codeCoverageIgnore
+     * @return LaravelResponse
+     * @throws   FireflyException
      */
     public function download(Attachment $attachment): LaravelResponse
     {
-        if (true === auth()->user()->hasRole('demo')) {
-            Log::channel('audit')->warning(sprintf('Demo user tries to access attachment API in %s', __METHOD__));
-
-            throw new NotFoundHttpException();
-        }
         if (false === $attachment->uploaded) {
             throw new FireflyException('200000: File has not been uploaded (yet).');
         }
@@ -88,52 +83,42 @@ class ShowController extends Controller
             throw new FireflyException('200000: File has not been uploaded (yet).');
         }
         if ($this->repository->exists($attachment)) {
-            $content  = $this->repository->getContent($attachment);
+            $content = $this->repository->getContent($attachment);
             if ('' === $content) {
                 throw new FireflyException('200002: File is empty (zero bytes).');
             }
-            $quoted   = sprintf('"%s"', addcslashes(basename($attachment->filename), '"\\'));
+            $quoted = sprintf('"%s"', addcslashes(basename($attachment->filename), '"\\'));
 
             /** @var LaravelResponse $response */
             $response = response($content);
             $response
                 ->header('Content-Description', 'File Transfer')
                 ->header('Content-Type', 'application/octet-stream')
-                ->header('Content-Disposition', 'attachment; filename='.$quoted)
+                ->header('Content-Disposition', 'attachment; filename=' . $quoted)
                 ->header('Content-Transfer-Encoding', 'binary')
                 ->header('Connection', 'Keep-Alive')
                 ->header('Expires', '0')
                 ->header('Cache-Control', 'must-revalidate, post-check=0, pre-check=0')
                 ->header('Pragma', 'public')
-                ->header('Content-Length', (string) strlen($content))
-            ;
+                ->header('Content-Length', (string)strlen($content));
 
             return $response;
         }
-
         throw new FireflyException('200003: File does not exist.');
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/attachments/listAttachment
-     *
      * Display a listing of the resource.
      *
-     * @throws FireflyException
+     * @return JsonResponse
+     * @codeCoverageIgnore
      */
     public function index(): JsonResponse
     {
-        if (true === auth()->user()->hasRole('demo')) {
-            Log::channel('audit')->warning(sprintf('Demo user tries to access attachment API in %s', __METHOD__));
-
-            throw new NotFoundHttpException();
-        }
-
-        $manager     = $this->getManager();
+        $manager = $this->getManager();
 
         // types to get, page size:
-        $pageSize    = $this->parameters->get('limit');
+        $pageSize = (int)app('preferences')->getForUser(auth()->user(), 'listPageSize', 50)->data;
 
         // get list of attachments. Count it and split it.
         $collection  = $this->repository->get();
@@ -141,39 +126,34 @@ class ShowController extends Controller
         $attachments = $collection->slice(($this->parameters->get('page') - 1) * $pageSize, $pageSize);
 
         // make paginator:
-        $paginator   = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
-        $paginator->setPath(route('api.v1.attachments.index').$this->buildParams());
+        $paginator = new LengthAwarePaginator($attachments, $count, $pageSize, $this->parameters->get('page'));
+        $paginator->setPath(route('api.v1.attachments.index') . $this->buildParams());
 
         /** @var AttachmentTransformer $transformer */
         $transformer = app(AttachmentTransformer::class);
         $transformer->setParameters($this->parameters);
 
-        $resource    = new FractalCollection($attachments, $transformer, 'attachments');
+        $resource = new FractalCollection($attachments, $transformer, 'attachments');
         $resource->setPaginator(new IlluminatePaginatorAdapter($paginator));
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/attachments/getAttachment
-     *
      * Display the specified resource.
+     *
+     * @param Attachment $attachment
+     *
+     * @return JsonResponse
      */
     public function show(Attachment $attachment): JsonResponse
     {
-        if (true === auth()->user()->hasRole('demo')) {
-            Log::channel('audit')->warning(sprintf('Demo user tries to access attachment API in %s', __METHOD__));
-
-            throw new NotFoundHttpException();
-        }
-        $manager     = $this->getManager();
-
+        $manager = $this->getManager();
         /** @var AttachmentTransformer $transformer */
         $transformer = app(AttachmentTransformer::class);
         $transformer->setParameters($this->parameters);
 
-        $resource    = new Item($attachment, $transformer, 'attachments');
+        $resource = new Item($attachment, $transformer, 'attachments');
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
     }

app/Api/V1/Controllers/Models/Attachment/StoreController.php

@@ -1,5 +1,4 @@
 <?php
-
 /*
  * StoreController.php
  * Copyright (c) 2021 james@firefly-iii.org
@@ -35,9 +34,8 @@ use FireflyIII\Transformers\AttachmentTransformer;
 use FireflyIII\User;
 use Illuminate\Http\JsonResponse;
 use Illuminate\Http\Request;
-use Illuminate\Support\Facades\Log;
 use League\Fractal\Resource\Item;
-use Symfony\Component\HttpKernel\Exception\NotFoundHttpException;
+use Log;
 
 /**
  * Class StoreController
@@ -48,6 +46,8 @@ class StoreController extends Controller
 
     /**
      * StoreController constructor.
+     *
+     * @codeCoverageIgnore
      */
     public function __construct()
     {
@@ -66,59 +66,50 @@ class StoreController extends Controller
     }
 
     /**
-     * This endpoint is documented at:
-     * https://api-docs.firefly-iii.org/?urls.primaryName=2.0.0%20(v1)#/attachments/uploadAttachment
-     *
      * Store a newly created resource in storage.
      *
+     * @param StoreRequest $request
+     *
+     * @return JsonResponse
      * @throws FireflyException
      */
     public function store(StoreRequest $request): JsonResponse
     {
-        if (true === auth()->user()->hasRole('demo')) {
-            Log::channel('audit')->warning(sprintf('Demo user tries to access attachment API in %s', __METHOD__));
-
-            throw new NotFoundHttpException();
-        }
-        app('log')->debug(sprintf('Now in %s', __METHOD__));
-        $data        = $request->getAll();
-        $attachment  = $this->repository->store($data);
-        $manager     = $this->getManager();
+        Log::debug(sprintf('Now in %s', __METHOD__));
+        $data       = $request->getAll();
+        $attachment = $this->repository->store($data);
+        $manager    = $this->getManager();
 
         /** @var AttachmentTransformer $transformer */
         $transformer = app(AttachmentTransformer::class);
         $transformer->setParameters($this->parameters);
 
-        $resource    = new Item($attachment, $transformer, 'attachments');
+        $resource = new Item($attachment, $transformer, 'attachments');
 
         return response()->json($manager->createData($resource)->toArray())->header('Content-Type', self::CONTENT_TYPE);
     }
 
     /**
      * Upload an attachment.
+     *
+     * @codeCoverageIgnore
+     *
+     * @param Request    $request
+     * @param Attachment $attachment
+     *
+     * @return JsonResponse
      */
     public function upload(Request $request, Attachment $attachment): JsonResponse
     {
-        if (true === auth()->user()->hasRole('demo')) {
-            Log::channel('audit')->warning(sprintf('Demo user tries to access attachment API in %s', __METHOD__));
-
-            throw new NotFoundHttpException();
-        }
-
         /** @var AttachmentHelperInterface $helper */
         $helper = app(AttachmentHelperInterface::class);
         $body   = $request->getContent();
         if ('' === $body) {
-            app('log')->error('Body of attachment is empty.');
-
-            return response()->json([], 422);
-        }
-        $result = $helper->saveAttachmentFromApi($attachment, $body);
-        if (false === $result) {
-            app('log')->error('Could not save attachment from API.');
+            Log::error('Body of attachment is empty.');
 
             return response()->json([], 422);
         }
+        $helper->saveAttachmentFromApi($attachment, $body);
 
         return response()->json([], 204);
     }