Commit Graph

24603 Commits

Author SHA1 Message Date
Travis Cross 03cdc495f0 Fix quoting issue in debian/rules
This amends commit f93c3f70bf
2013-05-31 20:40:10 +00:00
Travis Cross a95e9004fc Set compiled-in storage_dir and certs_dir defaults for Debian 2013-05-31 20:40:10 +00:00
Travis Cross c7524f9ea7 Fix debian lang-* recommends on sounds-*
Thanks to Richard Neese for pointing out the erroneous results.
2013-05-31 20:40:10 +00:00
Nathan Neulinger 2e66012e96 Change to correct prompt on outgoing call, eliminate UNDEFINED! message 2013-05-31 15:10:44 -05:00
Nathan Neulinger d39086892f Allow skinny speed dials to work when already off-hook 2013-05-31 15:10:44 -05:00
Nathan Neulinger 123d0865fb FS-5431: --resolve fix socket creation loop for mod_skinny to avoid segfault 2013-05-31 15:10:43 -05:00
Nathan Neulinger 32bddaa6cd FS-5429: --resolve add minimal idivert support for skinny 2013-05-31 15:10:43 -05:00
Nathan Neulinger 582e3699f6 FS-5379: --resolve fix skinny phone codec agreement issues due to incorrect hardwired ptime, update field names for future coding to be more descriptive 2013-05-31 15:10:43 -05:00
Nathan Neulinger da5c2a6aef FS-5225: --resolve add ability to dial by pressing line button 2013-05-31 15:10:43 -05:00
Nathan Neulinger c33eb7412b FS-5267: --resolve avoid null deref if sessions missing 2013-05-31 15:10:43 -05:00
Mathieu Parent ab7635e9bc Add IPs to mod_skinny recv/send event messages
FS-5268 --resolve
thanks to Nathan Neulinger
2013-05-31 15:10:43 -05:00
Mathieu Parent 4a981b336a Don't pretend we support skinny-wait timeout (See #FS 477) 2013-05-31 15:10:42 -05:00
Mathieu Parent b36ad82da7 Don't create a new session when pressing speeddial
Fixes #FS-5259 (Thanks to Nathan Neulinger for the patch)
2013-05-31 15:10:42 -05:00
Brian West 83c6f4250b add kirk wireless servers to safe as they do not do rport 2013-05-31 11:56:53 -05:00
Steve Underwood 4d08e07237 Fixed a weakness in error UDPTL lost packet recovery. Hopefully this addresses
FS5202.
2013-05-31 09:04:46 -05:00
Brian West b90dee2461 Swap this 2013-05-31 09:16:50 -05:00
Travis Cross e1a773406d Unsigned values are never less than zero 2013-05-29 03:02:21 +00:00
Travis Cross 1637a08206 Avoid using psession uninitialized in mod_fsk 2013-05-29 03:00:13 +00:00
Travis Cross 04b8de0619 Avoid using memory after we free it
Without setting errmsg to NULL here, we'll try to print this freed
value again below if another error doesn't intercede.
2013-05-29 02:52:23 +00:00
Travis Cross 5e7485ff20 Avoid dereferencing potential null value 2013-05-29 02:52:13 +00:00
Travis Cross 9ce4be3daa Remove assignment without effect 2013-05-29 02:52:05 +00:00
Travis Cross ca9d806042 Avoid dereferencing potential null value 2013-05-29 02:51:57 +00:00
Travis Cross 83e33bb399 Handle potential malloc failure better 2013-05-29 02:51:51 +00:00
Travis Cross 58e48416be Add missing text editor local variable blocks 2013-05-29 02:50:03 +00:00
Travis Cross 00769c458f Fix unlikely memory leak in ESL 2013-05-29 02:48:59 +00:00
Travis Cross 800fe2a970 Remove assignment without effect in fs_cli 2013-05-29 02:48:50 +00:00
Travis Cross 987f76d379 Avoid dangling reference at end of fs_cli
Not that it really matters since we're returning to the OS momentarily
at that point anyway.
2013-05-29 02:48:33 +00:00
Travis Cross de3727fe06 Add common include paths for jni.h and jni_md.h 2013-05-29 02:48:28 +00:00
Jeff Lenk 73257d7ca2 FS-5479 --resolve 2013-05-29 02:48:23 +00:00
Jeff Lenk 1926a54bd0 fix unused parameter warning on windows 2013-05-29 02:48:17 +00:00
Travis Cross 50a02efd27 Fix variable type in mod_nibblebill 2013-05-29 02:48:11 +00:00
Travis Cross e964215868 Work around error in pocketsphinx-0.7
fsg_search.c:263:2: error: non-void function 'fsg_search_reinit' should return a value [-Wreturn-type]
2013-05-29 02:48:01 +00:00
Travis Cross d5d9e45632 Remove self-assignment without any effect
clang:

  error: explicitly assigning a variable of type 'uint16_t' (aka 'unsigned short') to itself [-Werror,-Wself-assign]
2013-05-29 02:47:41 +00:00
Travis Cross e60877cde6 Add missing newline at end of mod_say_fa.c 2013-05-29 02:47:08 +00:00
Mariusz Czułada cd549aa44a FS-5157 patch accepted 2013-05-29 00:22:19 +02:00
Brian West 2cac71675f log auto adjust ip and port separate so it doesn't get clobbered on hold/update events 2013-05-28 16:26:05 -05:00
Anthony Minessale 4d5ea55924 FS-5480 --resolve 2013-05-28 08:18:00 -05:00
Travis Cross acc8eb5cb6 Remove unused variable in mod_rtmp
Unused variables break the build with recent versions of gcc and
clang.
2013-05-26 05:29:21 +00:00
Travis Cross aea5cdd989 Add commit note about shell escaping
Disregard the supplemental commit text on
commit a744b202fd.

switch_util_quote_shell_arg() is fine.
2013-05-26 05:28:51 +00:00
Travis Cross a744b202fd Quote arguments to shell when sending email
Note that the function switch_util_quote_shell_arg is implemented
incorrectly for unix shells, so this is still not safe until that
function is fixed.

Reported-by: Nathan Neulinger <nneul@mst.edu>

FS-5450 --resolve
2013-05-26 01:41:02 +00:00
Travis Cross ff85c6cfdf Fix memory leaks in mod_tts_commandline
We were using both switch_util_quote_shell_arg and
switch_string_replace without freeing the results even though both
functions malloc.
2013-05-26 01:08:10 +00:00
Travis Cross 103d97e208 Leave room for switch_escape_string to add a terminating null
Thanks-to: Nathan Neulinger <nneul@mst.edu>

FS-5448 --resolve
2013-05-25 23:29:48 +00:00
Travis Cross 2870bb9200 Fix comment spelling
Thanks-to: Mariusz Czułada <manieq.net@gmail.com>
2013-05-25 21:47:08 +00:00
Travis Cross ed276a10d2 Fix memory corruption in mod_erlang_event
Thanks-to: Alexandre Snarskii <snar@snar.spb.ru>

FS-5465 --resolve
2013-05-25 21:46:58 +00:00
Travis Cross 4b2dd0a8d9 Don't setup ZRTP without a session and channel
FS-5472 --resolve
2013-05-25 21:46:11 +00:00
Travis Cross f07e58d30f Handle a failure of strerror_r
This fixes the build on gcc-4.7.3.  The build was breaking with:

  error: ignoring return value of 'strerror_r', declared with attribute warn_unused_result [-Werror=unused-result]
2013-05-25 21:44:16 +00:00
William King 6c4ec9d954 Fix a possible deadlock scenario in the impossible scenario from the last patch. 2013-05-25 11:07:30 -07:00
William King a6d24d8eac Redundant code. The if/else block makes more sense than the equivalent in two separate if's. 2013-05-25 07:46:47 -07:00
William King 782480c48b Better to not pass tmp_socket to setsockopt if there was an error here creating the socket. 2013-05-25 07:36:43 -07:00
William King 479a06bda6 It's been missing a break there for ~4 years and instead using the 8k max_ms values(the ptime_div value is the same). 2013-05-25 07:16:51 -07:00