Chris Rienzo
41b993755c
CID: 1211941 mod_rayo - unlikely dereference of NULL pointer
2014-05-08 12:16:13 -04:00
Chris Rienzo
b1337495fb
CID: 1211943 mod_rayo - removed dead code when changing output speed
2014-05-08 12:16:02 -04:00
Chris Rienzo
5b06a86c43
CID: 1211944 mod_rayo - remove set of unused pointer
2014-05-08 12:15:49 -04:00
Chris Rienzo
ab9971c7ac
CID: 1211946 mod_rayo - dead code after switch statement
2014-05-08 12:15:38 -04:00
Chris Rienzo
2d8f61d245
CID: 1211947 mod_rayo - allocated array with unsigned char * element size instead of unsigned char
2014-05-08 12:15:25 -04:00
Chris Rienzo
2c74771c2f
CID: 1211951 mod_rayo - fix unlikely dereference of null pointer
2014-05-08 12:15:17 -04:00
Chris Rienzo
2363269821
mod_rayo: fix compiler error to nlsml.c from attempted coverity fix
2014-05-08 11:11:14 -04:00
William King
8b3e039c71
CID: 1211948 fix memory leak of decoded iks message in function parse_plain_auth_message in mod_rayo
2014-05-08 09:52:20 -04:00
William King
e19bafe894
CID: 1211950 fix memory leak of iksparser in function nlsml_parse in mod_rayo
2014-05-08 09:52:10 -04:00
Anthony Minessale
88216387e0
FS-6506 --resolve Technically when you are not using groups you do not add a <users> tag inside <domain> you just put several <user> tags in <domain> This patch will consume an extraneous <users> tag and move on making it work either way.
2014-05-07 00:06:11 +05:00
Michael Jerris
6eca0f8444
add quickie targets for fr sounds
2014-05-05 19:23:25 -04:00
Anthony Minessale
9274b30b77
sofia is treating all notify sending as if they were natted rather than when nat is detected. This causes issues on some polycoms that use strange ports in their contact for getting notifies that do not match the port the calls come from
2014-05-06 04:10:29 +05:00
Anthony Minessale
9bf0e8c517
FS-6503 --resolve remove unused code
2014-05-02 01:28:44 +05:00
Michael Jerris
28efa9e6a2
FS-6500: try to do the bounds checking properly using element of the enum
2014-05-02 00:00:46 +05:00
William King
944ef52a1e
Correction to commit 0ba59aa6c2d252886eb4889c5d37fe114e07b4f4 using the correct variable in tel uri param parsing for mod_sofia
2014-04-29 15:23:36 -07:00
Anthony Minessale
83ecf84e06
FS-4779 FS-6467 the behaviour from 4479 is now masked behind the param 3pcc-reinvite-bridged-on-ack FS-6467 please test master
2014-04-28 22:10:33 +05:00
Anthony Minessale
28babdea4e
FS-6491 --resolve
...
This seems to be a paradox when running a perl script from a session then executing perl again on the same session from a different thread.
I fixed it by converting any execution of perl in the execute_on_* family of operators to only run background mode which is to store the command in the session stack to be executed only by the session thread instead of on the spot by the outide thread. changing the execute_on_answer to perl::/path/to/script.pl would also eliminate the crash in code that has not been updated with this patch.
This is just a limitation of embedded perl we have to live with.
2014-04-28 21:20:02 +05:00
William King
838c2174e5
Expanding on 052638186b2784c4142089008adf4289d40c80bc to support boolean tel url params in mod_sofia
2014-04-25 13:50:35 -07:00
Michael Jerris
65026d3448
FS-6485: --resolve fix -lz include order issue breaking ubuntu 14.04 build
2014-04-24 08:11:31 -04:00
Chris Rienzo
b36f6f1ec6
mod_soundtouch: commit 34d5b6e8657e28298470c09a614fc586b8bac761 broke CentOS build
2014-04-22 16:24:00 -04:00
Anthony Minessale
51dd2eb93b
FS-6477 --resolve
...
Conflicts:
src/mod/applications/mod_conference/mod_conference.c
2014-04-22 23:53:44 +05:00
Chris Rienzo
24d2762efa
mod_rayo: preserve old caller ID behavior if display name is not given
2014-04-22 13:29:43 -04:00
Chris Rienzo
0df68285d0
mod_rayo: relax recent caller ID restrictions a bit
2014-04-22 08:50:25 -04:00
Travis Cross
8a20da75ef
Refactor out extraneous call to gettime
...
We were calling switch_epoch_time_now() twice for no good reason.
2014-04-19 04:09:26 +00:00
Travis Cross
34d5b6e865
Edit out gcc-ism from soundtouch lib
...
This allows building mod_soundtouch in clang as clang doesn't support
gcc's -fcheck-new.
2014-04-19 04:08:36 +00:00
Travis Cross
cac3edcb90
Remove ancient FS-2746 patch from tree
2014-04-19 04:06:27 +00:00
Travis Cross
d5cdc1be00
Remove completely obsolete patches from tree
...
These haven't been touched in years; they can't possibly still be
applicable.
2014-04-19 04:05:19 +00:00
Travis Cross
7e060ff77f
Remove stray executable bits
2014-04-19 04:02:42 +00:00
Travis Cross
e4948316e0
Add uuid_ring_ready API command
...
We already had uuid_answer and uuid_pre_answer, so we might as well
add uuid_ring_ready.
2014-04-19 04:02:41 +00:00
Travis Cross
b013a494b5
Fix typo in comment
2014-04-19 03:01:31 +00:00
Travis Cross
8e9fd1fb83
Avoid leaking memory on mod_cdr_sqlite unload
2014-04-19 02:56:23 +00:00
Travis Cross
a455a8694c
Avoid leaking memory on mod_voicemail unload
2014-04-19 02:56:15 +00:00
Travis Cross
bb41207cc7
Avoid leaking memory on mod_hash unload
2014-04-19 02:56:02 +00:00
Travis Cross
1fa1df2512
Avoid leaking memory on unload of mod_dptools
...
Automated leak detectors find leaked memory on shutdown. Cleaning up
after ourselves on shutdown eliminates noise from these reports.
2014-04-19 02:55:50 +00:00
Travis Cross
021c98fa74
Hide warning about sometimes initialized variable
...
The rc variable here was always initialized but the compiler couldn't
see that because of the lack of an unconditional else clause.
2014-04-19 02:51:29 +00:00
Travis Cross
220d8ff873
Correct display of last write timestamp
...
On start DTMF packets we were showing the last write timestamp as a
signed value when it's an unsigned value, which could result in it
appearing incongruous with later packets where the value was displayed
correctly.
2014-04-19 01:53:00 +00:00
Travis Cross
480f6c2092
Move loop exit conditionals
...
The net effect here is the code looks more "regular" and reads more
linearly.
2014-04-19 01:49:26 +00:00
Travis Cross
f122a5ae87
Avoid considering more phrase actions after break
...
Previously we would continue considering phrase actions even after
receiving a break action; we would only break on the next input
clause. It appears the intent here was to break before the next
action.
2014-04-19 01:49:26 +00:00
Travis Cross
b2d153f97c
Improve comment
2014-04-19 01:49:25 +00:00
Travis Cross
beca9eff9d
Consolidate two conditionals
...
If we get SWITCH_STATUS_BREAK then we didn't get
SWITCH_STATUS_SUCCESS.
2014-04-19 01:49:25 +00:00
Travis Cross
6f279e52b0
Remove variable assignment without effect
...
We're breaking out of the loop here anyway, so setting done to true is
useless.
2014-04-19 01:49:25 +00:00
Travis Cross
90930d2958
Fix memory leak in phrase macro playback
...
We were leaking memory when break_on_match was set or when we received
back SWITCH_STATUS_BREAK from a callee as we were failing to free
field_expanded_alloc.
2014-04-19 01:49:25 +00:00
Travis Cross
bd2b63da27
Remove tautological conditional
...
If pattern is null we're setting it to a non-null value, so this
branch will always be taken.
Use `git diff -w` or `git log -p -w` to see what's going on in this
commit.
2014-04-19 01:49:24 +00:00
Travis Cross
e9c8afc5ec
Fix memory leak on memory error
...
In the event of a memory error, we were trying to free a null pointer
while leaking the allocation for field_expanded_alloc.
2014-04-19 01:49:24 +00:00
Travis Cross
6e8a053464
Move variables down into loop where they're used
...
These variables aren't used outside of this for loop, so they should
be declared within it.
2014-04-19 01:49:24 +00:00
Seven Du
586f0d2e17
fix compiler warning
2014-04-17 14:59:09 +08:00
Anthony Minessale
370230e323
update
2014-04-17 04:33:21 +05:00
Anthony Minessale
41fa2c9c6a
FS-6462 --resolve
...
I found a problem here but it may not completely match your expectations.
I reviewed the RFC 4028 and checked against the code and I discovered we should not be putting a Min-SE in any response at all besides a 422:
section 5:
The Min-SE header field MUST NOT be used in responses except for
those with a 422 response code. It indicates the minimum value of
the session interval that the server is willing to accept.
I corrected this problem and implemented the 422 response so if you request a value lower than the minimum specified for the profile.
If the value is equal or higher to the minimum, it will be reflected in the Session-Expires header in the response and no Min-SE will be present.
2014-04-17 04:32:44 +05:00
Anthony Minessale
264fd6ffcc
FS-5997 regression from commit 70accd9f272472ac2081283f1927d901b409acb6 this caused some attended transfers to calls with multiple targets to get the abondoned channels to be stuck on write lock
2014-04-17 02:42:08 +05:00
Chris Rienzo
56e5a9ce8e
FS-6407 --resolve mod_rayo: support SIP URI caller ID w/ display name
2014-04-15 14:28:11 -04:00
