The implementation clears the context / state data from memory when it
is finished with it. Prior to this commit, however, it was actually
only clearing the first 4 bytes on x86 or 8 bytes on x86_64.
clang warns:
warning: argument to 'sizeof' in 'memset' call is the same
expression as the destination; did you mean to dereference it?
[-Wsizeof-pointer-memaccess]
On some compilers this fixes the build.
gcc reports:
error: format not a string literal and no format arguments
clang reports:
error: format string is not a string literal (potentially insecure) [-Werror,-Wformat-security]
Debian nightlies created with debian/util.sh now have the version set
in the same format as Makefile.am produces. Unlike Makefile.am,
however, we show the orig packaging date rather than the date of the
latest commit, as the latter could legitimately regress and we need
this to always increment.
When we're terminating ZRTP to an IVR or to a leg which is not
ZRTP-capable, there's no way for us to make an intelligent decision
about whether this flag should be set. For a client to consider the
SAS as verified, however, both sides need to set this flag. By always
setting this flag on our side, we leave the decision completely in the
hands of the client where we hope there is a careful human.
Signed-off-by: Travis Cross <tc@traviscross.com>
I don't see this command being used anywhere. Since I don't like to touch core files unless absolutely necessary I'm reverting these two changes. I've emailed the author, Tamas, for an explanation. The other patches for FS-3432 (merged in now) appear to work fine without this commit.
This reverts commit fbcb862265.
sed: 1: "/#define *SWITCH_VERSIO ...": bad flag in substitute command: '}'
Reported-by: scruz in #freeswitch @ irc.freenode.net
Signed-off-by: Stefan Knoblich <s.knoblich@axsentis.de>
This amends commit f8be71ac6d.
This still should resolve FS-4303.
What's going on here is that we need a portable way to access
strftime. date(1posix) doesn't provide enough. And without perl, I
can't think of a better way to get to it than just using C. So the
logic for generating the extended revision has been moved into a small
self-contained and hopefully portable C program.
Anthony Minessale
Travis Cross
Jeff Lenk
dschreiber
Brian West
Mathieu Rene
Giovanni Maruzzelli
Michael Jerris
Stefan Knoblich
Daniel Swarbrick