William King
|
79e3de3e55
|
full_contact must be freed by sofia. There isn't a chance of this having blown anything up, but Coverity is right that this should be initialized with NULL to be safe against future refactors.
|
2013-05-18 19:13:44 -07:00 |
|
William King
|
c80d768004
|
My bad. some how a make didn't catch this issue after a cleanup refactor. In this instance buf is being treated as an 8 byte number, not a pointer.
|
2013-05-18 17:46:50 -07:00 |
|
William King
|
f3393ef362
|
Coverity reported an Uninitialized pointer read. Upon further digging it appears that there is a code path where incoming packets can come in out of order, so this section of code tries to see if it can find the missed packets. As per FS-5202 there is a case where under heavy load the packet exists, and has most of the packet parsed, but still has a NULL pointer for the packet buffer. These two lines would at least help detect the edge case.
|
2013-05-18 17:35:07 -07:00 |
|
William King
|
bd4ea84242
|
Edge case for when you are subscribing to presence on a valet parking lot. In which case there would be a small leak.
|
2013-05-18 17:07:31 -07:00 |
|
William King
|
97286e10cd
|
Possible leak if someone were to try and add extra headers to a channel that had either an inbound info on that session or the session were to be deflected. I don't see a way that these extra headers could be added outside of a C module subscribing to the session states, but just to make sure I'm adding these so that just like other extra header locations it's cleaned up.
|
2013-05-18 17:01:27 -07:00 |
|
William King
|
14f48a6a7a
|
Alice meet rabit hole. There is a leak here on every invite that comes back from a status 180 when the other side is not FS, but you have presence enabled. Thanks to Coverity scan for location this condition. This 'might' not have been leaking if sofia was automatically freeing this when the sofia object was destroyed, but all other locations where sip_header_as_string where called they were all followed by a su_free, so I assume not.
|
2013-05-18 16:36:41 -07:00 |
|
William King
|
d61d395e8d
|
If the mod_sofia global presense hash is null, then make sure to free the matches variable before going to done.
|
2013-05-18 16:06:15 -07:00 |
|
William King
|
dac6ce1b45
|
FS-5443: --resolve leaked because the JS api's copy and return new malloc'd pointers.
|
2013-05-18 15:47:51 -07:00 |
|
William King
|
9ce6ce082f
|
When message events were added, the debug field name was overlooked. This would have only been hit when debug level was above 'DEBUG1' and at that point it would have incorrectly chosen debug display names.
|
2013-05-18 15:11:14 -07:00 |
|
William King
|
4fc1369a1b
|
Minor typo. User is being passed into this fuction as a long pointer, not a long.
|
2013-05-18 14:30:43 -07:00 |
|
William King
|
49303fdabc
|
read() does not NULL terminate statbuf, but strstr expects statbuf to be null terminated.
|
2013-05-18 14:27:00 -07:00 |
|
William King
|
48f423db40
|
This was writing a null one space to the right, outside of the malloc'd buffer. On further review this uses apr_vsnprintf which always returns null terminated.
|
2013-05-18 13:39:12 -07:00 |
Jeff Lenk
|
dec5a592ca
|
FS-5434 --resolve
|
2013-05-17 21:44:13 -05:00 |
Anthony Minessale
|
bf688a87aa
|
fix silence_stream size bug
|
2013-05-17 16:12:13 -05:00 |
|
William King
|
fc42d93ddf
|
FS-5441: --resolve
|
2013-05-17 12:40:04 -07:00 |
|
Anthony Minessale
|
c8ef74055a
|
FS-5430 --resolve
|
2013-05-15 09:27:44 -05:00 |
|
Anthony Minessale
|
3fe3a0091c
|
FS-5418 --resolve
|
2013-05-15 08:09:07 -05:00 |
|
Anthony Minessale
|
88003520bb
|
FS-5208 --resolve
|
2013-05-15 07:37:12 -05:00 |
|
Anthony Minessale
|
793008a215
|
FS-5011 try to fill gaps
|
2013-05-14 11:23:21 -05:00 |
|
Anthony Minessale
|
d3c5713649
|
FS-5325 force rebuild
|
2013-05-14 07:44:48 -05:00 |
|
Anthony Minessale
|
ec7d8a0118
|
FS-5416 --resolve just missing the part that registers it
|
2013-05-14 07:38:20 -05:00 |
|
Anthony Minessale
|
fcb699c8b7
|
FS-5407 --resolve
|
2013-05-13 14:21:25 -05:00 |
|
Anthony Minessale
|
e8ecb64666
|
FS-5410 --resolve
|
2013-05-13 13:15:54 -05:00 |
|
Jeff Lenk
|
b52994ed5d
|
FS-5325 windows compile
(cherry picked from commit d466316ace)
|
2013-05-10 17:34:06 -05:00 |
Raymond Chandler
|
d125147dd8
|
add context
|
2013-05-10 16:32:22 -04:00 |
|
Anthony Minessale
|
b8b6756a44
|
FS-5325
|
2013-05-10 12:55:46 -05:00 |
|
Anthony Minessale
|
d6c2b9a2fb
|
FS-5085 the last change helped weed out the real bug which is this commit
|
2013-05-10 10:45:07 -05:00 |
|
Anthony Minessale
|
e5754ab3ee
|
FS-5403 --resolve
|
2013-05-10 09:59:19 -05:00 |
|
Anthony Minessale
|
e44c278c68
|
move log message to avoid logging null
|
2013-05-09 14:35:19 -05:00 |
|
Anthony Minessale
|
3fc8f7888a
|
FS-5399 --resolve
|
2013-05-09 14:09:23 -05:00 |
|
Anthony Minessale
|
4f8faf9b78
|
FS-5325 i'll put the nonblocking in but I still think this is a problem with openssl, a short read is not there every single time you connect, When the lib is in full blocking mode it should be handling the complicated actions internally. As complicated as socket programming is, async ssl is even worse because it requires you to do your own buffering and attemps to read may fail waiting for you to write or vice-versa which should have been handled for us in the lib. non-interruptable syscalls are getting pretty outdated and not enabling it is much less complex than making every socket app on earth be non-blocking
|
2013-05-09 12:56:59 -05:00 |
|
Anthony Minessale
|
3847ae028a
|
FS-5360 --resolve fields are exec-on-max-failures exec-on-max-timeouts pin, needs testing
|
2013-05-09 12:29:04 -05:00 |
|
Anthony Minessale
|
a08965601c
|
FS-5390 --resolve
|
2013-05-09 10:30:00 -05:00 |
|
Anthony Minessale
|
646b34a2a2
|
FS-5398
|
2013-05-09 10:10:06 -05:00 |
|
William King
|
569da261aa
|
FS-5395: False alarm on a reported valgrind memory leak. The io_private is alloc'd from a memory pool which valgrind sucks at tracking. No need to free this, because it'll get cleared when the memory pool on the rsession is destroyed.
|
2013-05-08 18:45:55 -07:00 |
|
William King
|
924e24a0de
|
FS-5395: --resolve Resolve another mod_rtmp crash where oh specific hangup scenarios there would be a free of variable that wasn't ever malloced
|
2013-05-08 16:53:15 -07:00 |
|
Anthony Minessale
|
2e19cbcc61
|
FS-5085 I discovered that the bowout is happening from both legs at once, we only need to check this condition on the A side of the loopback bridge
|
2013-05-08 13:17:45 -05:00 |
Brian West
|
7c8c758586
|
Undo previous change
|
2013-05-08 14:40:48 -05:00 |
|
Raymond Chandler
|
3c132c91b3
|
FS-5288 --resolve
|
2013-05-08 13:58:43 -04:00 |
|
Raymond Chandler
|
5f0d33338e
|
FS-5327 --resolve
|
2013-05-08 13:58:17 -04:00 |
|
Anthony Minessale
|
900b0c1747
|
FS-5371 --resolve typo
|
2013-05-08 09:19:05 -05:00 |
|
William King
|
f4bde33dab
|
Revert "fixed stuck mod_rtmp session when the call is killed from fs side, such as using uuid_kill"
This reverts commit d8edc031fa.
Conflicts:
src/mod/endpoints/mod_rtmp/mod_rtmp.c
|
2013-05-07 16:08:15 -07:00 |
|
Anthony Minessale
|
2b950b9599
|
FS-5168 --resolve
|
2013-05-07 14:10:03 -05:00 |
|
Anthony Minessale
|
d6cd34143b
|
FS-5325
|
2013-05-07 11:30:53 -05:00 |
|
Anthony Minessale
|
bf3f26b0f8
|
FS-5383 --resolve
|
2013-05-07 08:31:48 -05:00 |
Ken Rice
|
7c88f35451
|
1.2.9 rev bump
|
2013-05-06 18:30:47 -05:00 |
|
Ken Rice
|
c7567d418e
|
fix mod_spandsp on systems with libjbig
|
2013-05-06 18:27:20 -05:00 |
Michael Jerris
|
99fd7a87ff
|
fix auto in will not use the last slot
|
2013-05-06 11:45:30 -04:00 |
|
Anthony Minessale
|
65f0d16dee
|
FS-5371 --resolve
|
2013-05-03 13:38:44 -05:00 |
|
Anthony Minessale
|
749afaa7a3
|
FS-5365 --resolve
|
2013-05-03 13:13:44 -05:00 |