Commit Graph

26704 Commits

Author SHA1 Message Date
Michael Jerris 7da28a2481 FS-353: look for ldns pkg-config for homebrew, you will need to update your homebrew ldns package if you installed it prior to this commit, they just fixed the pkg-config file being installed 2014-05-02 13:26:43 -04:00
Brian West 367f4f399b FS-6500: use correct type in ftdm callback 2014-05-02 11:19:52 -05:00
Brian West ca88a0451d FS-6500: handle conversion from switch to ftdm cause type which almost match each other 2014-05-02 11:19:52 -05:00
Brian West cbcf54b65d FS-6500: fix return value type for outgoing_channel function 2014-05-02 11:19:52 -05:00
Steve Underwood 28a9a40e37 Various little cleanups, many of them from a clang static analysis 2014-05-02 23:32:33 +08:00
Natanael Copa 317f4b1442 Fix building with musl libc
POSIX says poll.h and signal.h should not be prefixed with sys/ (ie
poll.h instead of sys/poll.h)

limits.h also defines a TZNAME_MAX so we change name of the define for
spandsp.
2014-05-02 11:20:36 -04:00
Michael Jerris 13b411529f FS-6500: freebsd does not support the inline backtrace solution 2014-05-02 11:14:39 -04:00
Travis Cross ba84e1d8f9 Remove dead assignment in libscgi 2014-05-02 03:58:48 +00:00
Travis Cross 2b1ae831d1 Remove some dead assignments in ESL 2014-05-02 03:57:07 +00:00
Travis Cross fc40e4ab79 Avoid leaking data_buf in mod_conference
When we couldn't acquire the rwlock on the conference we were leaking
a buffer we just allocated.  On a 48k/10ms conference we would leak
960 bytes per attempt.
2014-05-02 03:48:10 +00:00
Moises Silva 64c678f17a freetdm: ftdm_gsm: Fix a few compilation warnings 2014-05-01 20:28:23 -04:00
Moises Silva 99c022b1dd FS-6500: freetdm: Add more enum compliance by defining proper enum values for FTDM_END and FTDM_ANY special state values 2014-05-01 20:24:03 -04:00
Michael Jerris db1a2de186 don't null check what we know won't be null 2014-05-01 19:00:24 -04:00
Michael Jerris 2e3558c43e don't need to double check for null 2014-05-01 18:50:26 -04:00
Travis Cross a3e1b7df49 Protect cross-compiling from polluted PKG_CONFIG_PATH 2014-05-01 22:23:59 +00:00
Michael Jerris 582fa1a664 fix typo 2014-05-01 18:22:57 -04:00
Travis Cross cd650f6055 Use system ldns library
This library is used only by mod_enum and is available on most
platforms.  The version in our tree has many code quality problems
that are generating noise when doing static analysis.  Suffice it to
say we want rid of it as our responsibility.

FS-353
2014-05-01 22:01:59 +00:00
Travis Cross c1f884cd33 Remove old ldns patch from FS-3110 2014-05-01 22:01:59 +00:00
Raymond Chandler 33460064ac CID: 1210739 2014-05-01 17:34:54 -04:00
Raymond Chandler a4e0929ef0 CID: 1210596 2014-05-01 17:28:54 -04:00
Raymond Chandler 17f79bc2c3 CID: 1210770 2014-05-01 16:36:58 -04:00
Anthony Minessale 7f18b80e60 FS-6503 --resolve remove unused code 2014-05-02 01:28:12 +05:00
Brian West c462ed6ae1 FS-6499 --resolve 2014-05-01 15:21:57 -05:00
Brian West d06b137abd FS-6498 --resolve 2014-05-01 15:20:28 -05:00
Michael Jerris d2c2f174e7 FS-6500: try to do the bounds checking properly using element of the enum 2014-05-01 14:32:23 -04:00
Michael Jerris 906467b360 fix log message on sending tport ping over ws to log error in failure cases 2014-05-01 14:20:27 -04:00
Michael Jerris 64f1098b8c remove dead assignment 2014-05-01 14:17:06 -04:00
Michael Jerris b0fd845786 remove dead assignment 2014-05-01 14:04:56 -04:00
Michael Jerris d4ba268f29 remove dead assignment 2014-05-01 13:52:12 -04:00
Michael Jerris cfd8d28bc8 silence clang unused function warnings and get rid of some unused functions 2014-05-01 09:03:19 -04:00
Michael Jerris fc25bbc23c remove unused function 2014-05-01 08:32:23 -04:00
Michael Jerris b55ba90def fix 2 potential use after free errors 2014-05-01 08:30:52 -04:00
Travis Cross 4ec5e5af47 Refactor if blocks
Since the first branch doesn't need to do anything, we invert it and
pull a sub-branch out a level into the main conditional.
2014-04-30 23:23:06 +00:00
Travis Cross ae3cf0a1a9 Remove dead assignment
...now this code needs refactoring.
2014-04-30 23:22:13 +00:00
Travis Cross 2ae823fb9f Drop dead assignments
We goto done at the end of these blocks.
2014-04-30 23:03:06 +00:00
Raymond Chandler e4d807108c CID: 1210646 2014-04-30 18:47:02 -04:00
Travis Cross fd4364cd43 Drop dead assignment 2014-04-30 22:43:33 +00:00
Travis Cross 946db55b34 Drop dead assignments 2014-04-30 22:42:08 +00:00
Raymond Chandler 3abcee7142 unused 2014-04-30 18:36:44 -04:00
Travis Cross f38ccbfb51 Remove dead assignment, but why...
This assignment isn't doing anything, so it safe to remove it, but
there remains the question of whether there could have been some
actually necessary intention behind this line.
2014-04-30 22:33:24 +00:00
Travis Cross 0f6e364e61 Drop dead assignment 2014-04-30 22:33:24 +00:00
Travis Cross b9b5b0d827 Avoid dead assignment of return value of execv
execv(3) only returns on error, and will always return -1 in that
case.
2014-04-30 22:33:24 +00:00
William King 5f3e98beb4 Fix a use after free in a 'theoretical' case in switch_cache_db_persistant_execute_trans_full where the pre_trans_execute statement fails, but SQLSetAutoCommitAttr succeeds 2014-04-30 14:37:17 -07:00
Michael Jerris 6add88b43f check return value for es_say_general_count 2014-04-30 16:43:35 -04:00
Michael Jerris ef18915ca5 make sure old_pid_buffer is null terminated 2014-04-30 16:36:14 -04:00
Michael Jerris a1a397420e fix leaked body in error case 2014-04-30 16:10:08 -04:00
Michael Jerris 23b3e172d5 don't leak file handle if fd = 0 2014-04-30 15:56:36 -04:00
Michael Jerris 6f16e0d3da don't leak if first realloc fails but second one succeeds 2014-04-30 15:53:26 -04:00
Michael Jerris 068ad205b7 split this into 2 functions so its clear if this function allocates or not 2014-04-30 15:48:23 -04:00
Steve Underwood b205313f4f More fixes from Coverity scans 2014-05-01 02:56:53 +08:00