64fc3f7934
Changed the function parameter name in the function definition to
...
match the updated parameter name in the function declaration. #doxygen
2014-07-03 14:19:33 -07:00
aef569172b
Removed a useless called to abs.
...
Clang 3.5 reported the following error: error: taking the absolute
value of unsigned type 'unsigned int' has no effect
[-Werror,-Wabsolute-value]
Subtracting unsigned variables will never be negative and will either
be the small expected value or will wrap to a very big value. This
code is trying to determine if the difference between these timestamps
is greater than 16000.
The variables last_write_ts and this_ts deal with timestamps. In the
normal case this_ts will be a larger timestamp than
last_write_ts. This change will maintain the intended behavior of
reseting the video if the difference is larger than
16000 and in the abnormal case this value would wrap and still exceed
the 16000.
2014-07-03 13:17:12 -07:00
24e5c13283
Removed an autological-pointer-compare from src/switch_utils.c.
...
Building with Clang 3.5 gave the following warning: error: comparison
of array 'iface_out.sin6_addr.__in6_u.__u6_addr8' equal to a null
pointer is always false [-Werror,-Wtautological-pointer-compare]
This is a problem because as it is written the check will never be
true. A pointer to a structure within a structure will never be null. The
intention was either to null check the pointer or to check if the IP
address itself was not zero.
From context in the code this appeared to be a pointer null check so I
removed it.
2014-07-03 12:12:22 -07:00
831d5892b9
preserve timer name for recovery
2014-07-03 23:50:14 +05:00
89f7196a6e
Fixed trucation of value warning.
...
There was a parameter mismatch between abs(), which expects an int,
and atol() which returns a long. Since max_drift is defined as an int,
there is no need to pars q as a long rather than an int.
2014-07-03 10:53:19 -07:00
64763398fa
Merge pull request #4 in FS/freeswitch from ~KATHLEEN.KING/freeswitch-fork:doxygen-switch_regex.h-2 to master
...
* commit '35755d37d5dd47c2f8470ca9a294b55f124ee1e7':
Fixed parameter name of variable in switch_regex_match_partial. #doxygen
2014-07-03 12:03:04 -05:00
8732abef40
test commit hooks, whitespace change only
2014-07-03 08:50:04 -05:00
4a51650b16
reswig
2014-07-03 08:09:18 -05:00
f47ecb25a1
Changed the variable name for clarity.
2014-07-02 20:10:31 -07:00
35755d37d5
Fixed parameter name of variable in
...
switch_regex_match_partial. #doxygen
2014-07-02 17:46:55 -07:00
39200cd13b
increase memory for buffers to hold new decoded stereo codecs
2014-07-03 02:55:21 +05:00
99f15662e2
fix jb endless loop of missing packets
2014-07-03 02:16:32 +05:00
9e0d1d6841
only count unmuted channels in positioning
2014-07-02 22:57:29 +05:00
9807a92a70
vs2010 reswig
2014-07-02 12:46:26 -05:00
f0d16d0d18
expand positioning api usage
2014-07-02 04:49:16 +05:00
1518240bab
FS-6637 try this instead
2014-07-01 23:59:40 +05:00
0f017814dd
FS-6637 nevermind, this is already in the code
2014-07-01 23:53:45 +05:00
5d70df9b1c
FS-6637 try this patch
2014-07-01 22:32:02 +05:00
2423fc7d0f
FS-6540 This should proxy all refers now, the param has changed to proxy-refer
2014-06-30 12:53:22 -05:00
7f9348dbc3
fix volume adjustments in stereo conference
2014-06-30 23:39:42 +05:00
41a7d1cf31
some refactoring to make new stereo stuff more stable
2014-06-30 23:00:45 +05:00
591ea9e9ca
tweaks
2014-06-30 04:39:46 +05:00
0bb7f1659f
check for member channel
2014-06-30 01:59:21 +05:00
c1f1f8b98e
Check for too many SRTP errors before warning
...
We're checking whether we've hit the warning threshold before checking
whether we should just end the call. This causes an off-by-one error
where we take one SRTP error more than intended.
This commit reverses the order of the tests.
2014-06-29 20:49:46 +00:00
0ac78cacc3
add openal code to mod_conference
2014-06-30 01:23:08 +05:00
1a56298c53
add 44.1khz codec defs
2014-06-30 01:23:07 +05:00
7741f403f1
Handle SRTP_READ_ERROR in mod_rayo
2014-06-28 06:42:57 +00:00
f31641f4bf
Allow more SRTP errors before killing call
...
In a carrier interop we saw the call get killed for SRTP failures
during a reinvite. We're wondering if the SRTP errors may have been
transitory and if it may have recovered after a few more packets.
It's debatable whether we should kill calls at all for SRTP auth
failures; semantically the right thing to do when a MAC fails is to
ignore the packet completely. So raising this limit to 100 packets
shouldn't do any harm. With this change we still warn at 10 errors
and every 10 errors thereafter.
2014-06-28 03:57:20 +00:00
7406be6927
Relay cause of hangup on SRTP failure
...
We hangup the channel after receiving 10 SRTP packets in a row with a
bad auth tag or that are replayed. Prior to this commit we were
indicating a normal clearing. When doing interop and looking first at
packet traces, this made freeswitch's behavior look surprising. With
this commit we'll indicate more loudly what's happening.
2014-06-28 01:18:50 +00:00
52892b312a
Fix misspelled function
...
switch_rtp_set_invalid_handler has been misspelled as
switch_rtp_set_invald_handler going all the way back to the
beginning. So while it's possible that someone somewhere could be
relying on this misspelling, I think it's more likely that no one has
used it much and that's why it wasn't spotted. We don't even use it
ourselves anywhere anymore.
Introduced in commit: 828e03715f
2014-06-28 00:32:41 +00:00
fc247a223f
Add editor footer to core files missing it
2014-06-27 23:55:27 +00:00
52fb53cba4
Allow reincarnation from mod_sofia's shutdown-on-fail
...
mod_sofia's parameter shutdown-on-fail now accepts the value
"reincarnate-now". This will cause the switch to exit immediately
with a non-zero exit code so that the supervisor can recover the
switch. For this to work you have to pass in -reincarnate or
-reincarnate-reexec to freeswitch.
2014-06-27 22:18:39 +00:00
80ed14ab3e
Ensure mod_sofia params can be unset or reset
...
This is the result of auditing each mod_sofia profile parameter to
ensure that it can be unset or reset after being set. One use-case
for this being done correctly is so a later parameter in a
configuration file can reliably override an earlier one, which is
useful for setups with layered include files.
2014-06-26 09:04:56 +00:00
75feed68fc
Avoid leaking memory on sofia profile reload
...
We were leaking the string values of apply-candidate-acl parameters.
2014-06-26 08:39:55 +00:00
63351a1061
Terminate format_cdr json files with newline
...
In UNIX, text files by definition end with a newline.
2014-06-25 23:30:54 +00:00
d5fa28417e
Allow setting format of log filename in format_cdr
...
This commit allows you to set a `log-file` string parameter in a
format_cdr profile. This string is a template that may (and should!)
contain variables. This template will be expanded and used as the
file name of the CDR to be written. This parameter should contain
only the template for the file name itself; the path is relative to
the `log-dir`.
2014-06-25 23:22:34 +00:00
f7b4ec617a
Allow SIP UPDATE messages without display updates
...
Previously if send-display-update was set to false we would also
remove UPDATE from our Allow: headers. This is unnecessary. The
UPDATE message is useful in SIP transactions even if we're not sending
display updates.
With this commit, we add a new boolean profile flag, allow-update. If
set to true we'll send Allow: UPDATE. If set to false, we will not.
If there is a conflict with another setting that requires UPDATE
support, the allow-update parameter will win and a warning will be
printed.
ref: RFC 3311
2014-06-25 20:43:29 +00:00
ba784f2548
skip update on member channels with no json
2014-06-25 13:40:50 -05:00
b9a51bbf91
FS-6632 Trying to actually use opus in stereo broke pretending to use it in stereo
2014-06-25 21:19:07 +05:00
062b7c6e3d
duh, the code to parse the codec params from the config file wasn't there
2014-06-25 21:19:07 +05:00
c71f89a39b
FS-6627
2014-06-24 15:42:07 -05:00
1a58f05891
FS-6621
2014-06-24 14:13:10 -05:00
6540068faa
fix compiler warning
2014-06-24 09:10:34 +08:00
25c0f7d00c
FS-6440 regression from this patch on single CPU or VM machines causes startup race
2014-06-23 23:55:52 +05:00
b21f34bffc
Clarify error message.
2014-06-21 19:16:50 +00:00
058ef6923b
FS-6617 fix compile error
2014-06-21 11:04:53 -05:00
011e069652
fix recording in stereo conferences
2014-06-20 23:53:22 +05:00
8f47f403fd
FS-6612: Don't use rport in tcp or tls
2014-06-20 10:23:05 -05:00
ffa09cd1e7
various verto cleanups and fix a race in double event delivery thread creation
2014-06-20 19:21:56 +05:00
faeb00368e
verto bug fixing in codec negotiation and some stereo codec stuff
2014-06-20 01:41:28 +05:00
f7c6c90749
fix null strcmp
2014-06-19 23:37:39 +05:00
d886cc12fa
mod_skinny: profile digit timeout is integer not string
2014-06-18 17:11:19 -05:00
65e190ce26
mod_skinny: add easy access to set blocking/non-blocking mode for skinny socket on a per-profile basis
2014-06-18 17:06:54 -05:00
8dabf51945
mod_skinny: socket timeout should be set in all cases, not just for blocking
2014-06-18 16:41:38 -05:00
06b87b83c5
mod_skinny: no warning if there is a matching entry, but no version listed
2014-06-18 12:06:27 -05:00
296c489143
mod_skinny: add stub for media resource notification message sent by VG224
2014-06-18 11:54:49 -05:00
840f7e69dd
mod_skinny: always return a response to version message, since that's what CCM does
2014-06-18 11:44:25 -05:00
4eabd3ab95
mod_skinny: handle additional escaping in log messages to reduce screen/console issues
2014-06-18 10:19:42 -05:00
e279ae8203
FS-6605 add support for automatic dialing when off-hook/ringdown --resolve
2014-06-18 08:40:28 -05:00
723ea00855
FS-6607 add further not from wiki page about IPv6 support
2014-06-17 19:53:45 -05:00
1e249d61c3
FS-6607 add notice of IPv6 support for mod_skinny
2014-06-17 19:36:55 -05:00
412abaddde
no one seems to be okay with actually installing perl modules because it might require the permissions to acutally do so, instead, let the users figure out how to install them themselves so they can figure out how to have permissions and where they acutally go by themselves with no direction from us
2014-06-17 20:19:22 -04:00
b077217d44
FS-6337
2014-06-18 01:19:14 +05:00
3c08104874
remove unused code
2014-06-18 01:17:35 +05:00
d5856a4197
FS-477 fix inappropriate firing of timeout after call proceeds --resolve
2014-06-17 14:56:21 -05:00
c76c132692
FS-6604: needs DESTDIR
2014-06-17 11:53:10 -05:00
6e05bfba13
FS-6604: install to archlib not sitelibexp
2014-06-17 11:19:02 -05:00
82dbc5d2b9
FS-6604: install to archlib not sitelibexp
2014-06-17 10:35:17 -05:00
3c7c167581
mod_rayo: improved idle detection- call is idle only if no active components and not joined
2014-06-16 14:39:17 -04:00
10719e58c8
work around macro definition of fileno breaking our c++ code
2014-06-16 11:14:42 -05:00
23259812ac
FS-6593 --resolve this isn't used, I've tested.
2014-06-16 10:42:58 -05:00
13e02278a1
Use portable version of strerror_r()
...
FS-6596 --resolve
2014-06-16 13:45:39 +00:00
9e600ec938
FS-6591 --resolve If you are still using spidermonkey you should migrate to v8
2014-06-13 22:49:01 -05:00
dc2f5cc491
vs2010 reswig
2014-06-13 22:41:37 -05:00
c0e7e7b88c
add reset function to clear some state data in the rtp session
2014-06-14 07:05:00 +05:00
280e816a90
FS-6590 --resolve
2014-06-14 04:56:55 +05:00
9108a08a47
fix build
2014-06-13 23:15:41 +05:00
633dfe2a56
FS-6535 mod_rayo: close recognizer when input component is complete
2014-06-13 12:34:19 -04:00
1511fe3ee8
mod_rayo: rework component inheritance- component now inherits parent call/mixer mutex and parent reference counting moved to base class
2014-06-13 12:16:26 -04:00
730d2f88ba
mod_rayo: rename reference counting functions to something more sensible
2014-06-13 11:33:33 -04:00
9aa5102142
FS-6535 mod_rayo: compile error
2014-06-13 10:08:49 -04:00
4c54f45f4a
FS-6535 mod_rayo: allow unimrcp recognizer w/ profile specified
2014-06-13 10:05:53 -04:00
950de7fc5c
reswig
2014-06-13 07:49:34 -05:00
c375e336bc
add debugging
2014-06-13 06:06:14 -04:00
41cea5c751
remove debug
2014-06-13 05:01:37 -04:00
4e5ecdf995
only run plc on mono channels
2014-06-13 03:02:12 -04:00
33541dcfd9
add logging
2014-06-13 03:02:09 -04:00
4ffbf23ffa
stereo refactoring
2014-06-13 01:49:16 -04:00
56ef59e9ad
vs2010 reswig and fix mod_rss for recent stereo changes
2014-06-12 22:48:21 -05:00
c82ac3afbf
FS-6535 mod_rayo: fix double lock on speech detection failure
2014-06-12 23:24:35 -04:00
bb6869b7ab
FS-6535 --resolve mod_rayo: allow multiple grammars (including dtmf) when using unimrcp
2014-06-12 22:56:34 -04:00
0f62c4cd62
FS-6440 --resolve
2014-06-13 05:46:40 +05:00
ed7264b6d3
doh
2014-06-13 05:28:14 +05:00
7642d846a9
some more channels updates
2014-06-13 05:13:43 +05:00
579a051867
add channels param the the silence generator function
2014-06-13 04:49:44 +05:00
ab5278c02f
stereo: fix mod_flite, mod_ssml, mod_unimrcp compile errors
2014-06-12 17:41:52 -04:00
97cc089826
fix compile errs
2014-06-12 13:12:39 -04:00
928a989de1
first pass of stereo support
2014-06-12 22:06:33 +05:00
b333714906
fix coverity warnings
2014-06-11 17:11:47 -05:00
bfaf20c2f3
fix install
2014-06-11 15:20:38 -05:00
1ffb1ee0d0
WIP
2014-06-11 12:48:46 -05:00
12da85ef61
Check for execv(3) errors when reincarnating
...
When -reincarnate-reexec is given we run execv to restart FS. If
argv[0] isn't a full pathname then execv is going to fail. While not
common for a FS system started by init, this is a common occurrence
when FS is started from the shell.
Now if execv fails, we'll try execvp. If that fails too then we'll
fall back on the normal reincarnation behavior.
Previously what would happen in that case is god would descend from
the heavens and become mortal. Leaving heaven absent, all hope for
reincarnation was lost.
(That is, we'd simply return from reincarnate_protect and the
supervisor process would become the new instance of FS, so the trick
would only work once.)
2014-06-10 23:52:36 +00:00
03202e3017
Add fsctl command to summon reincarnation
...
If you start freeswitch with -reincarnate or -reincarnate-reexec, FS
will restart automatically in the event of an unexpected exit.
Currently, you can cause FS to immediately call exit(0) with `fsctl
shutdown now`, or you can have it call abort() with `fsctl crash`.
Which are both nice, but if you have reincarnation engaged, you really
might want FS to call exit([non-zero]) so the great supervisor
immediately breathes life back into your system.
This is now available via `fsctl shutdown reincarnate now`.
2014-06-10 22:39:27 +00:00
148c21c6b2
FS-477 mod_skinny fix leaked lock
2014-06-09 12:34:52 -05:00
2974734479
FS-477 mod_skinny: re-add ability to set digit timeout in patterns, update example configs
2014-06-09 12:29:47 -05:00
8b6fd66f34
FS-477 default to 10 seconds to avoid noticeable impact on current users until variable timeout support re-added
2014-06-09 10:56:52 -05:00
31a181a4b5
mod_skinny: implement digit timeout for dialing
...
For numbers with variable length, there should be a timeout to wait for
further digits before routing the number. This has been prepared with
the skinny-wait target, which waited forever. This patch implements the
digit timeout which routes the call after the timeout has elapsed. The
timeout can be configured in the mod_skinny XML settings
("digit-timeout") and defaults to 2 seconds.
This implementation has been requested and sponsored by Blackned GmbH.
Signed-off-by: Simon Wunderlich <sw@simonwunderlich.de>
Signed-off-by: Nathan Neulinger <nneul@neulinger.org>
2014-06-09 10:55:36 -05:00
49ee6781a5
FS-6540 please test
2014-06-05 23:49:50 +05:00
37a194d956
FS-6555: move -w to the right place so it silences the warnings in generated code instead of using gnu makeisms that didn't actually fix the problem
2014-06-04 20:43:38 +05:00
3ab1044d6e
FS-6562 --resolve
2014-06-03 15:16:45 -04:00
6722e3dfea
fix regression from regression
2014-06-02 19:25:04 -05:00
f358c35b67
remove debug line
2014-06-02 19:21:02 -05:00
a7b9329a08
FS-6446 regression fixed
2014-06-02 19:09:48 -05:00
0eda5cb80f
suppress audio flaw tally when coming off hold
2014-06-02 19:09:10 -05:00
956da6d689
Modify sofia profile to attempt to bind to the interface up to 3 tries with a 5 second wait between attempts.
...
Add new profile params bind-attempts and bind-attempt-interval to modify default behavior.
--NEEDSDOCS
2014-06-02 22:47:26 +05:00
ead290870a
fix compiler warning for implicit convertion
2014-06-01 08:09:49 +08:00
495db48f5a
make device state code more accurate
2014-05-31 00:30:59 +05:00
79a888de2c
Revert addition of PERL_GCC_PEDANTIC to CFLAGS
...
Brian and I decided to handle this by just stripping -ansi -pedantic
from the mod_perl build instead.
Revert "Since we can't tell if the system perl was built with
pedantic, we have a problem because we default debug enabled which
uses AX_CFLAGS_WARN_ALL_ANSI, For the GNU CC compiler it will be
-Wall (and -ansi -pedantic) The result is added to the shellvar being
CFLAGS by default. Which then gets included for building mod_perl,
Either way I think this is the correct corse of action to overcome
these new builds of mod_perl."
This reverts commit cb94340e26
2014-05-30 15:40:46 +00:00
750e2bae36
Build mod_perl without pedantic flags even when debugging
...
This means we don't have to set PERL_GCC_PEDANTIC which removes
assertions that are helpful for debugging.
2014-05-30 15:37:14 +00:00
cb94340e26
Since we can't tell if the system perl was built with pedantic, we have a problem because we default debug enabled which uses AX_CFLAGS_WARN_ALL_ANSI, For the GNU CC compiler it will be -Wall (and -ansi -pedantic) The result is added to the shellvar being CFLAGS by default. Which then gets included for building mod_perl, Either way I think this is the correct corse of action to overcome these new builds of mod_perl.
2014-05-29 21:13:07 -05:00
6092524f17
CID:1174726 Dereference before null check, CID:1214199 Dereference null return value; refactor channel_outgoing_channel to have failure conditions first to reduce indenting level
2014-05-29 21:59:26 +00:00
0d7b1ff42a
chrome now requires longer ice password
2014-05-29 15:46:31 -04:00
b53a6c2b2e
Remove unused assignment
...
If we don't find it, we create a new one, and if we do find it, we
don't use it.
2014-05-29 16:01:09 +00:00
2b0c9a1482
FS-6560 --resolve
2014-05-29 08:37:21 -07:00
609982cf2f
Remove redundant check for null
...
We're asserting now, and we would have already blown up from
dereferencing earlier.
2014-05-29 14:25:49 +00:00
6663692ff7
Assert on implied failure to malloc
...
switch_event_expand_headers should only return null on a malloc
failure, so we might as well just assert here.
2014-05-29 14:24:48 +00:00
e66d24622a
Fix potential dereference of null pointer
...
The node could conceivably disappear before we grab the globals mutex
and we'd get back a null pointer.
2014-05-29 14:11:33 +00:00
17137d089d
Add missing parenthesis pair
...
This would have briefly prevented setting outbound_per_cycle from the
mod_fifo config file.
2014-05-29 13:21:22 +00:00
84fe7b0794
Remove tautological condition check
...
We already decided to goto end if node is null, so it cannot be null
here.
2014-05-29 13:15:44 +00:00
bf59d57dab
Add missing parenthesis pair
...
This would have briefly caused the importance value in the fifo config
file to be ignored.
2014-05-29 13:10:23 +00:00
50dfce2845
FS-6513 --resolve This function was assuming the app was being run with execute_on_media so it did not properly check for established media. Now it will use the scheduler method automatically when this state is detected.
2014-05-29 01:14:28 +05:00
a976badec7
Document the length limit of fifo_outbound_uuid
...
Ask me sometime how I was "reminded" of this.
2014-05-28 17:04:46 +00:00
5138f4d5a7
add new stub module mod_rtc dummy signaling-free media engine endpoint
2014-05-28 07:31:24 +05:00
00b25baa42
mod_fifo: Explain session message unbridge constant
2014-05-28 01:32:11 +00:00
144fea57b2
mod_fifo: Add missing has_outbound to docstring
2014-05-28 01:32:11 +00:00
42e9615900
mod_fifo: Add missing tab completions
2014-05-28 01:32:10 +00:00
06805452d8
mod_fifo: Cleanup documentation formatting
2014-05-28 01:32:10 +00:00
431d7d97c7
mod_fifo: Document effect of fifo strategy and importance
2014-05-28 01:32:10 +00:00
96012ffb3a
mod_fifo: Document the enterprise strategy
2014-05-28 01:32:10 +00:00
e2596b3f30
mod_fifo: Document the ringall strategy
2014-05-28 01:32:09 +00:00
1b5a1c1e1d
mod_fifo: Document find_consumers()
2014-05-28 01:32:09 +00:00
0c25c3deb9
mod_fifo: Document node_thread_run()
2014-05-28 01:32:09 +00:00
80ccaf3450
mod_fifo: Remove duplicate check in ringall strategy
...
We already checked the number of usable rows, and nothing has changed.
2014-05-28 01:32:08 +00:00
343aee2dd8
mod_fifo: Comment manual call tracking session handler
2014-05-28 01:32:08 +00:00
48acd9fe66
mod_fifo: Note source of unexplained constant
2014-05-28 01:32:08 +00:00
a24b0b739f
mod_fifo: Avoid getting time twice
...
We were simply discarding unused the first time we retrieved here.
2014-05-28 01:32:07 +00:00
64144d73a3
mod_fifo: Refactor to avoid a memory allocation
2014-05-28 01:32:07 +00:00
011882c8dd
mod_fifo: Cleanup line spacing
2014-05-28 01:32:07 +00:00
a5f982fd1c
mod_fifo: Replace duplicate code with node_caller_count()
2014-05-28 01:32:06 +00:00
597a5c1208
mod_fifo: Remove empty declaration
2014-05-28 01:32:06 +00:00
edecd151a5
mod_fifo: Document the read_frame_callbacks
2014-05-28 01:32:06 +00:00
42ebfbfc59
mod_fifo: Document the fifo_queue_t structure
2014-05-28 01:32:06 +00:00
5f4ed9c123
mod_fifo: Document fifo_chime_data::list
2014-05-28 01:32:05 +00:00
2c7c15261d
mod_fifo: Document caller DTMF handler
2014-05-28 01:32:05 +00:00
3e6199eace
mod_fifo: Remove reimplementation of strchr()
2014-05-28 01:32:05 +00:00
27b3ddcc9f
mod_fifo: Document the consumer DTMF callback
2014-05-28 01:32:04 +00:00
7920630c8f
mod_fifo: Refactor DTMF exit key matching
2014-05-28 01:32:04 +00:00
c34ad2c0ec
mod_fifo: Avoid getting a var when we won't use it
2014-05-28 01:32:04 +00:00
077579b131
mod_fifo: Document fifo_queue_popfly()
2014-05-28 01:32:03 +00:00
b914c2374d
mod_fifo: Document fifo_queue_pop_nameval()
2014-05-28 01:32:03 +00:00
1eaf4b50ca
mod_fifo: Document remove parameter of fifo_queue_pop()
2014-05-28 01:32:03 +00:00
e241477860
mod_fifo: Tighten up some whitespace
2014-05-28 01:32:03 +00:00
e677da5870
mod_fifo: Refactor in create_node()
2014-05-28 01:32:02 +00:00
628b6c19ab
mod_fifo: Remove dead code
...
We were making a copy of the fifo name and stripping any domain name,
but then not using the value.
2014-05-28 01:32:02 +00:00
6105e9783c
mod_fifo: Refactor load_config()
...
Reduce number of local variables where possible; consolidate lines.
2014-05-28 01:32:02 +00:00
353c3b19fa
mod_fifo: Document fifo_node::outbound_name
2014-05-28 01:32:01 +00:00
17070e9dac
mod_fifo: Improve strategy thread function names
2014-05-28 01:32:01 +00:00
1f7589d6fa
mod_fifo: Refactor
2014-05-28 01:32:01 +00:00
0526e00457
mod_fifo: Replace global var with local static
...
This marker value is only used in one place.
2014-05-28 01:32:01 +00:00
2068b284cc
mod_fifo: Fix memory leak of xml structure
...
If getting the DB handle failed during the load or reload of the
configuration, we would leak the XML structure we just allocated for
the configuration.
2014-05-28 01:32:00 +00:00
c6e90e0111
mod_fifo: Refactor out config file reading
2014-05-28 01:32:00 +00:00
a3a62d2481
mod_fifo: Convert macro to fn and improve name
2014-05-28 01:32:00 +00:00
06d94d2c17
mod_fifo: Move straggling vars to global struct
2014-05-28 01:31:59 +00:00
31ae5b4655
mod_fifo: Cleanup whitespace
2014-05-28 01:31:59 +00:00
f80e869fe0
mod_fifo: Cleanup whitespace in load_config()
2014-05-28 01:31:59 +00:00
a15058406e
mod_fifo: Cleanup config parsing
2014-05-28 01:31:58 +00:00
20f35e4591
mod_fifo: Improve function names
2014-05-28 01:31:58 +00:00
84d6b2e351
mod_fifo: Consolidate code
2014-05-28 01:31:58 +00:00
8ccd13bd9a
mod_fifo: Document load_config()
2014-05-28 01:31:58 +00:00
83f69a41e8
Add in-code documentation for mod_fifo
...
The goal here is to describe theory. We want to illuminate what the
code is trying to do and what the core concepts are.
2014-05-28 01:31:57 +00:00
7c2b4381cf
FS-6446 --resolve
2014-05-27 20:40:00 +05:00
48483452d2
mod_rayo: remove code that is no longer needed
2014-05-27 10:22:18 -04:00
ed2351e048
mod_rayo: http_put of received fax was broken
2014-05-27 09:15:22 -04:00
333aff8a05
Document that switch_core_alloc returns zeroed memory
2014-05-27 11:24:09 +00:00
1fe6fb6d46
Use CPPFLAGS for mod_java includes
2014-05-24 09:14:21 +00:00
e8ba8ed5a5
Avoid useless NAT log message
...
If FS is not behind NAT, then every call generates at least three
INFO-level log messages:
[INFO] switch_nat.c:589 NAT port mapping disabled
This is useless noise. The message is only interesting if you do have
NAT enabled but mapping disabled, which might indicate a configuration
issue.
With this change, we just skip the entire nat_add_mapping function if
the NAT system isn't initialized or we're not behind NAT.
2014-05-24 08:57:03 +00:00
054c645818
Show initial channel values with `show channels`
...
Store some initial details about the channel separately so we can
preserve them across e.g. transfers and display them with show
channels.
With this commit, we store the original caller ID (name and number)
and IP address, and the call destination, dialplan, and context.
FS-4296 --resolve
Thanks-to: Mariusz Czułada <manieq.net@gmail.com>
2014-05-24 08:42:54 +00:00
0274991732
Revert commit that breaks build on gcc-4.8
...
Revert "FS-4296 --resolve initial calling/called nums in 'show channels'"
This reverts commit b08138d058
2014-05-24 07:18:48 +00:00
b5816d3477
mod_graylog2: native GELF logging
2014-05-23 16:53:42 -04:00
b08138d058
FS-4296 --resolve initial calling/called nums in 'show channels'
...
Store initial caller and destination numbers in 'channels' table,
so `show channels` can display it.
Patch provided by Mariusz Czułada <manieq.net@gmail.com>
2014-05-23 15:03:47 -05:00
042b162bc4
back off locking contention on sql queues when they are nearly full to allow the system to recover from an attack
2014-05-23 23:13:38 +05:00
af4380d938
fix linker on mod_cepstral to work in newer environments
2014-05-23 21:11:25 +05:00
ed6dd184f7
FS-6482 Commit 7e15c938e2 broke MWI for device having no transport parameters (plain UDP connection)
2014-05-23 08:42:16 -04:00
c768e4b6e6
CID:1215198 don't set variables that are not used, and clean up the bail out usage condition to be more sane
2014-05-22 14:52:56 +00:00
dcf633b1dd
Revert workaround of gcc-4.6.3-14+rpi1 ARM bug
...
The correct fix is to use gcc-4.7 or newer. If the compiler borked
this, one should trust nothing else it produces.
Revert "FS-6524,FS-6494: the compiler for rpi seems to be strangely
mis-optimizing this if/else block. Yes, its already set to this value,
but without the else block, it 'magically' hits the if blocks above,
unless you sleep, print a log, or add the else"
This reverts commit 1ca1d63795
2014-05-22 01:03:24 +00:00
11f373d4f2
CID: 1215198 Fix an assignment so that the variable only handles malloc'd data.
2014-05-21 16:28:03 -07:00
bedf8327b6
FS-6418 FS-6427 add profile param NDLB-proxy-never-patch-reinvites to solve both issues
2014-05-21 03:31:50 +05:00
1ca1d63795
FS-6524,FS-6494: the compiler for rpi seems to be strangely mis-optimizing this if/else block. Yes, its already set to this value, but without the else block, it 'magically' hits the if blocks above, unless you sleep, print a log, or add the else
2014-05-20 16:20:36 -05:00
b3555b91e9
FS-6539 fix typo
2014-05-20 16:20:36 -05:00
e6e0deba54
Fix erlang deadlock
...
Release session R/W Lock
2014-05-20 10:13:38 +02:00
bf84e9d414
missed file from a94f0a3fa6
2014-05-20 04:42:23 +05:00
55f8f556fa
add heartbeat_fire_on_set variable to fire heartbeat instantly when its first enabled (legacy behavior)
2014-05-20 04:07:47 +05:00
a94f0a3fa6
compute timeout based on fake sample count not real life one
2014-05-20 04:02:03 +05:00
ea78f4d0e8
Fix race in erlang process spawning
...
We received the reply and signaled the condition
earlier then started to wait for it
2014-05-19 14:47:39 +02:00
34807208c6
Chinese say now say "one" before "ten" for numbers >99
2014-05-17 14:28:58 +08:00
e4888349e1
Prevent opus lib from re-configuring on every make
...
We were using the libopus directory itself rather than a file within
it as a makefile target. This is a bad idea as make will see the
target as updated whenever files are created in or removed from the
directory. Since running configure creates and removes files, the
target will always appear dirty.
The effect was that when mod_opus was enabled in FS make would always
cause libopus to be reconfigured.
We'll target instead the configure file in libopus as that's the first
thing we need anyway.
2014-05-17 00:03:26 +00:00
c19aa584cc
CID: 1214222
...
sofia_glue_get_url_from_contact to strdup the value so before
overwriting the value signal to sofia that we have finished with the
raw header.
2014-05-16 17:01:03 -07:00
388e119e55
CID: 1214221,1214222
...
sip_header_as_string returns new memory alloc'd on the nua_handle's memory pool. This memory would not be freed until
the handle was destroyed. Since there is no usage of the call-info header after it is added to the event as a header value,
we should make sure to both su_free the sofia returned string, but also more cleanly create the event header value to reduce a strdup.
2014-05-16 16:35:49 -07:00
dc83348b71
Fix build for 31b8b55d0b
2014-05-16 15:36:25 -07:00
29e2263442
CID:1210789 Make return value of a function available from the another calling function. Also add a small status check.
2014-05-16 17:18:17 -04:00
b58bbd18b0
CID:1214233 Pointer to local outside scope
2014-05-16 21:08:53 +00:00
8fa7398760
CID:1025868 Simplified a function arguments never called.
2014-05-16 17:03:59 -04:00
e1f8e199f0
CID:1087632 Resource leak
2014-05-16 21:01:13 +00:00
31b8b55d0b
CID:1214216 Resource leak
2014-05-16 20:46:00 +00:00
386000d877
CID:1024418 Unintentional integer overflow
2014-05-16 20:07:58 +00:00
4238339176
CID:1023970 Unused pointer value
2014-05-16 19:53:23 +00:00
6a8002db79
CID:1024582 Logically dead code
2014-05-16 19:27:25 +00:00
21a5d166c6
CID:1024581 Logically dead code
2014-05-16 19:22:37 +00:00
c1f7887039
CID:1024580 Logically dead code, x will always be > 1
2014-05-16 19:19:31 +00:00
73c1e09269
CID:1024579 Logically dead code
2014-05-16 19:09:18 +00:00
3666029ff0
add auth-subscriptions flag. sofia ua can now optionally challenge subscrition requests
2014-05-16 19:05:35 +00:00
9b1ebff8de
CID:1024270 Dereference before null check
2014-05-16 18:54:50 +00:00
7d5434f57c
CID: 1214223-1214230 If sent an invalid registration authentication header with multiple params of the same name, then only use the first of the params instead of leaking memory
2014-05-16 11:50:18 -07:00
54fc2f5e39
CID:1023975 Unused pointer value
2014-05-16 18:49:23 +00:00
a67389ad5c
CID:1025879 Logically dead code
2014-05-16 18:20:25 +00:00
ecde431730
CID:1025850 Dereference before null check
2014-05-16 18:15:34 +00:00
b10c865c25
CID:1025849 Dereference before null check
2014-05-16 18:12:28 +00:00
a997331577
CID:1214125 https://scan6.coverity.com:8443/docs/en/cov_checker_ref.html#static_checker_BUFFER_SIZE
2014-05-16 13:30:27 -04:00
269db09015
don't leak on xferext ivr event, CID:1214232 Resource leak
2014-05-16 14:50:18 +00:00
65d9cf62c9
CID:1214237 String not null terminated
2014-05-16 14:41:42 +00:00
455ed10e40
CID:1214130 Buffer not null terminated
2014-05-16 14:37:43 +00:00
ebc0a99f1c
CID:1024250 Dereference before null check. CID:1024251 Dereference before null check, we don't need tto check these, as they are already used above in all cases
2014-05-15 18:34:25 +00:00
4653d78154
CID:1087387 Unused pointer value
2014-05-15 18:30:03 +00:00
44401e842a
CID:1023936 Unused pointer value
2014-05-15 17:00:32 +00:00
b7b14209eb
CID 1214210: mod_ssml - resource leak when parsing SSML
2014-05-15 11:31:04 -04:00
d055f5b6df
CID 1214263: mod_ssml - remove unused pointer value
2014-05-15 11:12:06 -04:00
d8d58fde63
CID:1214141 Buffer not null terminated
2014-05-15 14:26:29 +00:00
1b0bdaf85e
CID:1214212 Resource leak in voicemail_list
2014-05-15 14:11:39 +00:00
4e888a282c
CID:1214196 Dereference null return value, if we hit this condition, something very bad has happened, we should never have the private not set if we get to the hangup hook, log error instead of crashing
2014-05-15 14:09:38 +00:00
d2884ac5a6
CID:1214211 Resource leak
2014-05-15 13:58:08 +00:00
0469db0305
CID:1214200 Dereference null return value
2014-05-15 13:47:24 +00:00
92c6f3abc5
CID:1214192 Dereference after null check, don't crash when no file name passed on file open
2014-05-15 13:37:26 +00:00
179e07c649
CID:1214219 Resource leak
2014-05-15 13:30:39 +00:00
07b6bba68b
CID:1214209 Resource leak, don't leak event populated by switch_channel_get_variables
2014-05-15 13:22:51 +00:00
452d7a3793
CID:1214163 Unchecked return value, check return value of switch_ivr_play_file and bail out if it fails
2014-05-15 13:18:58 +00:00
7c72e94a67
CID:1214158 Buffer not null terminated
2014-05-15 12:42:49 +00:00
68825ff4f1
CID:1214220 Resource leak
2014-05-15 12:41:09 +00:00
619b31e1e8
CID:1214140 Buffer not null terminated, make sure hostname is always null terminated
2014-05-15 12:38:41 +00:00
16805187ec
CID:1214256 Unused pointer value
2014-05-15 12:36:36 +00:00
128601316f
CID:1214255 Unused pointer value
2014-05-15 12:34:50 +00:00
Kathleen King
Anthony Minessale
Mike Jerris
Ken Rice
Brian West
Jeff Lenk
Travis Cross
Seven Du
Eliot Gable
Nathan Neulinger
Chris Rienzo
Chris Rienzo
Simon Wunderlich
William King
Marc Olivier Chouinard
root
Tamas Cseke
Steve Underwood
Russell Treleaven